From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB5A8C73C68 for ; Wed, 10 Jul 2019 04:12:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C39BC2083D for ; Wed, 10 Jul 2019 04:12:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bWsVGu9Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726147AbfGJEMS (ORCPT ); Wed, 10 Jul 2019 00:12:18 -0400 Received: from mail-vs1-f66.google.com ([209.85.217.66]:40734 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725844AbfGJEMR (ORCPT ); Wed, 10 Jul 2019 00:12:17 -0400 Received: by mail-vs1-f66.google.com with SMTP id a186so609314vsd.7 for ; Tue, 09 Jul 2019 21:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jsT84thXZgrjljKWPHUjY7JeFgImc9+U4hEoxyiTJcc=; b=bWsVGu9ZtrSBJl4JbELamsoGGvbUEuoJyLkzEdD/lBLkOe2SuDywqNJvjhLcdkFQIV uQzhsHZfClHSSErFS8YngoK5icUK/zOzfk2MyJE77f/EpBtLGiDl5OLXwZaYMg1H4xvi 8bZw2KyzNEgXQhxeZxd3j43hSpSd9KAK3Vxwk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jsT84thXZgrjljKWPHUjY7JeFgImc9+U4hEoxyiTJcc=; b=aeR7bQK3FEjN2e6Fq+hDYG6OmhNs1mdddQHylXjwB2uXZXdRFIZDmcD5gpq4zS1IXe eHumGXfHxDXMtqttSFWuxUmq764MJbi0C1LeekwuSkk9mm5p+XVKOHIph8gXdPyOn0G/ KIvUwTuOi1AC8akXKVgf65OtDFZjxkIEA/1wLg4qgfPzsn2PW3DATao5Hx9XUQYUSe9D w13Q0vGE+50J194wC7wn6QYQFxBD0s6vyeAnb4bckoBqhcBj+WSDtNxDkbcAbwvah8du z2vPy/cNztiHd0LTgR3L2YCWVFOcsndQM8fvT0XF2snbwNfo2ZPCvlIVfhk8LaYN8a0/ l1zQ== X-Gm-Message-State: APjAAAXlxSDAJVK+dgg3Bz0vK3uaCfDVfd9rRz8LprXz7iYDk1Gep/eh qcYMhJsdLXHcmeNWLdT1ixDHA6JmsGwSEzEOIoznPA== X-Google-Smtp-Source: APXvYqwRDoiekjMfVg1dAkd95CbZGZ3jhAzyHEQ1N/LeXKKIJksHQNLAm0BnKpQtXYeH+ZnDwbVN+JmCCFjQkCNhqMc= X-Received: by 2002:a67:f7cd:: with SMTP id a13mr14190782vsp.163.1562731935844; Tue, 09 Jul 2019 21:12:15 -0700 (PDT) MIME-Version: 1.0 References: <20190603043251.226549-1-cychiang@chromium.org> <20190603043251.226549-6-cychiang@chromium.org> <20190709200121.GA19118@bogus> In-Reply-To: <20190709200121.GA19118@bogus> From: Cheng-yi Chiang Date: Wed, 10 Jul 2019 12:11:48 +0800 Message-ID: Subject: Re: [PATCH 5/7] ASoC: rockchip: rockchip-max98090: Add node for HDMI To: Rob Herring Cc: linux-kernel , Hans Verkuil , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Philipp Zabel , Mark Brown , Liam Girdwood , Takashi Iwai , Jaroslav Kysela , Russell King , Andrzej Hajda , Laurent Pinchart , David Airlie , Daniel Vetter , Heiko Stuebner , Doug Anderson , Dylan Reid , tzungbi@chromium.org, linux-media@vger.kernel.org, "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 10, 2019 at 4:01 AM Rob Herring wrote: > > On Mon, Jun 03, 2019 at 12:32:49PM +0800, Cheng-Yi Chiang wrote: > > Let user specify HDMI node so machine driver can use it to let codec > > driver register callback on correct hdmi-notifier. > > > > Signed-off-by: Cheng-Yi Chiang > > --- > > Documentation/devicetree/bindings/sound/rockchip-max98090.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > index a805aa99ad75..dae57c14864e 100644 > > --- a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > +++ b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > @@ -7,6 +7,7 @@ Required properties: > > connected to the CODEC > > - rockchip,audio-codec: The phandle of the MAX98090 audio codec > > - rockchip,headset-codec: The phandle of Ext chip for jack detection > > +- rockchip,hdmi: The phandle of HDMI node for HDMI jack detection > > > > Example: > > > > @@ -16,4 +17,5 @@ sound { > > rockchip,i2s-controller = <&i2s>; > > rockchip,audio-codec = <&max98090>; > > rockchip,headset-codec = <&headsetcodec>; > > + rockchip,hdmi= <&hdmi>; > > space ^ > > With that, > > Acked-by: Rob Herring > Hi Rob, Thank you for the review. But I have changed the approach in v2 so there is no need for machine driver to expose this property. Thanks! > > }; > > -- > > 2.22.0.rc1.257.g3120a18244-goog > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cheng-yi Chiang Subject: Re: [PATCH 5/7] ASoC: rockchip: rockchip-max98090: Add node for HDMI Date: Wed, 10 Jul 2019 12:11:48 +0800 Message-ID: References: <20190603043251.226549-1-cychiang@chromium.org> <20190603043251.226549-6-cychiang@chromium.org> <20190709200121.GA19118@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190709200121.GA19118@bogus> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: linux-kernel , Hans Verkuil , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Philipp Zabel , Mark Brown , Liam Girdwood , Takashi Iwai , Jaroslav Kysela , Russell King , Andrzej Hajda , Laurent Pinchart , David Airlie , Daniel Vetter , Heiko Stuebner , Doug Anderson , Dylan Reid , tzungbi@chromium.org, linux-media@vger.kernel.org, moderated list:SOUND - SOC LAYER / List-Id: devicetree@vger.kernel.org On Wed, Jul 10, 2019 at 4:01 AM Rob Herring wrote: > > On Mon, Jun 03, 2019 at 12:32:49PM +0800, Cheng-Yi Chiang wrote: > > Let user specify HDMI node so machine driver can use it to let codec > > driver register callback on correct hdmi-notifier. > > > > Signed-off-by: Cheng-Yi Chiang > > --- > > Documentation/devicetree/bindings/sound/rockchip-max98090.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > index a805aa99ad75..dae57c14864e 100644 > > --- a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > +++ b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > @@ -7,6 +7,7 @@ Required properties: > > connected to the CODEC > > - rockchip,audio-codec: The phandle of the MAX98090 audio codec > > - rockchip,headset-codec: The phandle of Ext chip for jack detection > > +- rockchip,hdmi: The phandle of HDMI node for HDMI jack detection > > > > Example: > > > > @@ -16,4 +17,5 @@ sound { > > rockchip,i2s-controller = <&i2s>; > > rockchip,audio-codec = <&max98090>; > > rockchip,headset-codec = <&headsetcodec>; > > + rockchip,hdmi= <&hdmi>; > > space ^ > > With that, > > Acked-by: Rob Herring > Hi Rob, Thank you for the review. But I have changed the approach in v2 so there is no need for machine driver to expose this property. Thanks! > > }; > > -- > > 2.22.0.rc1.257.g3120a18244-goog > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47979C73C69 for ; Wed, 10 Jul 2019 04:12:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1086F20645 for ; Wed, 10 Jul 2019 04:12:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VCDHSCVW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bWsVGu9Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1086F20645 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QPMSjl209Rv58p3oAYdQPqqeTRDb/fwa2Kr31EMBnU8=; b=VCDHSCVWINQJaG ifDBtCDadLHlG3uNJlOaDB5RswufD+vJeI6gGRM1Zb5fUw/XJUKpXTMcUDbyXQIQI+4se3RuOR8Ql 6InDDNS903ivPv4AjhFXySMXt24sRJ06sIXxeF0IIRdAD6tpaoCZPPYu/BVhrW6RI2r6Z0TZRKpQx ULtbz8aTdRnQeK6ecjK/e/8nZSu38XrVvM58WVKS23AcSIkOMDSzRihLf7BWzfnFWFO2HA/4H8dv3 jhbuWKeZPOZZ6oCRPk1b0n4WO/e0p0X0bncfzZ0gI6+Bwue3/wERvZu7Qi0Uf8cwiAjQp9kw9NGno n0K3wjANVGUfCstfQRGQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hl3xt-0008C6-Il; Wed, 10 Jul 2019 04:12:21 +0000 Received: from mail-vs1-xe43.google.com ([2607:f8b0:4864:20::e43]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hl3xp-0008Ak-VJ for linux-arm-kernel@lists.infradead.org; Wed, 10 Jul 2019 04:12:19 +0000 Received: by mail-vs1-xe43.google.com with SMTP id u124so629768vsu.2 for ; Tue, 09 Jul 2019 21:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jsT84thXZgrjljKWPHUjY7JeFgImc9+U4hEoxyiTJcc=; b=bWsVGu9ZtrSBJl4JbELamsoGGvbUEuoJyLkzEdD/lBLkOe2SuDywqNJvjhLcdkFQIV uQzhsHZfClHSSErFS8YngoK5icUK/zOzfk2MyJE77f/EpBtLGiDl5OLXwZaYMg1H4xvi 8bZw2KyzNEgXQhxeZxd3j43hSpSd9KAK3Vxwk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jsT84thXZgrjljKWPHUjY7JeFgImc9+U4hEoxyiTJcc=; b=NQw13t4+GZ1IZ6+5i6hvciOU7C52Wad9GcpwQth1Ib5LhwNtqYEgOoFYk2Y2R5Su1m VRaI1e1RA20lhz6chyAOIkiz89hb/kE1Lvx//QcCWEatq5YRhDLT7qZq/PERe1owBLeW gp4q2iCktKvQ+TovnVsVtUUr8o/DH5+cUJP/IwlfSQ+F+38QQ3LWeyCpp/jtAEIcreBO IIQ/A0LD1l2GOaKRmfWZb6Th6aij+QNiWoSA2Nm1LvVN5lFP/KLaX9ATPU976/gIBiSZ d02yFDbWYqLnQAdH2VRtc4YL9ZSfQO1ORCAIPvlHJMBhecyi+juGgbfUkWRP2+pZOLdr lRIQ== X-Gm-Message-State: APjAAAWAzrk+96pIJOjG9RsbVuMYh9tc5MiMTfkUtIjCFfcz+T8uTTxX MS4/CroEE3Ql3Ssn+rfrXj+sgMdSy3A9YzWZ9502WA== X-Google-Smtp-Source: APXvYqwRDoiekjMfVg1dAkd95CbZGZ3jhAzyHEQ1N/LeXKKIJksHQNLAm0BnKpQtXYeH+ZnDwbVN+JmCCFjQkCNhqMc= X-Received: by 2002:a67:f7cd:: with SMTP id a13mr14190782vsp.163.1562731935844; Tue, 09 Jul 2019 21:12:15 -0700 (PDT) MIME-Version: 1.0 References: <20190603043251.226549-1-cychiang@chromium.org> <20190603043251.226549-6-cychiang@chromium.org> <20190709200121.GA19118@bogus> In-Reply-To: <20190709200121.GA19118@bogus> From: Cheng-yi Chiang Date: Wed, 10 Jul 2019 12:11:48 +0800 Message-ID: Subject: Re: [PATCH 5/7] ASoC: rockchip: rockchip-max98090: Add node for HDMI To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190709_211218_036255_069CD6D9 X-CRM114-Status: GOOD ( 17.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Heiko Stuebner , Liam Girdwood , David Airlie , dri-devel@lists.freedesktop.org, Takashi Iwai , Hans Verkuil , Andrzej Hajda , Laurent Pinchart , linux-rockchip@lists.infradead.org, Dylan Reid , linux-media@vger.kernel.org, devicetree@vger.kernel.org, tzungbi@chromium.org, Philipp Zabel , Bartlomiej Zolnierkiewicz , Russell King , Mark Brown , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Doug Anderson , linux-kernel , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 10, 2019 at 4:01 AM Rob Herring wrote: > > On Mon, Jun 03, 2019 at 12:32:49PM +0800, Cheng-Yi Chiang wrote: > > Let user specify HDMI node so machine driver can use it to let codec > > driver register callback on correct hdmi-notifier. > > > > Signed-off-by: Cheng-Yi Chiang > > --- > > Documentation/devicetree/bindings/sound/rockchip-max98090.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > index a805aa99ad75..dae57c14864e 100644 > > --- a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > +++ b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > @@ -7,6 +7,7 @@ Required properties: > > connected to the CODEC > > - rockchip,audio-codec: The phandle of the MAX98090 audio codec > > - rockchip,headset-codec: The phandle of Ext chip for jack detection > > +- rockchip,hdmi: The phandle of HDMI node for HDMI jack detection > > > > Example: > > > > @@ -16,4 +17,5 @@ sound { > > rockchip,i2s-controller = <&i2s>; > > rockchip,audio-codec = <&max98090>; > > rockchip,headset-codec = <&headsetcodec>; > > + rockchip,hdmi= <&hdmi>; > > space ^ > > With that, > > Acked-by: Rob Herring > Hi Rob, Thank you for the review. But I have changed the approach in v2 so there is no need for machine driver to expose this property. Thanks! > > }; > > -- > > 2.22.0.rc1.257.g3120a18244-goog > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel