From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753439AbeADWGF (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Thu, 4 Jan 2018 17:06:05 -0500
Received: from mail-it0-f65.google.com ([209.85.214.65]:42944 "EHLO
        mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752344AbeADWGE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 4 Jan 2018 17:06:04 -0500
X-Google-Smtp-Source: ACJfBovmJztYfAqYKCWT7MnnQYqvl+8Fx3S/ONBnh0gHctWmxKHhP6Jq1Ts2TAaVSFiMUn6i0xK7FqaE35z+p20PrrQ=
MIME-Version: 1.0
In-Reply-To: <20180104143710.8961-11-dwmw@amazon.co.uk>
References: <1515058213.12987.89.camel@amazon.co.uk> <20180104143710.8961-1-dwmw@amazon.co.uk>
 <20180104143710.8961-11-dwmw@amazon.co.uk>
From: Justin Forbes <jmforbes@linuxtx.org>
Date: Thu, 4 Jan 2018 16:06:02 -0600
Message-ID: <CAFxkdAou+kYvHhB52RTpJnMJ3jCbco5vzKv0HZe==XtDAOhEZA@mail.gmail.com>
Subject: Re: [PATCH v3 11/13] retpoline/taint: Taint kernel for missing
 retpoline in compiler
To: David Woodhouse <dwmw@amazon.co.uk>
Cc: Andi Kleen <ak@linux.intel.com>, Paul Turner <pjt@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linux-foundation.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Kees Cook <keescook@google.com>,
        Rik van Riel <riel@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Jiri Kosina <jikos@kernel.org>,
        Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Thu, Jan 4, 2018 at 8:37 AM, David Woodhouse <dwmw@amazon.co.uk> wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> When the kernel or a module hasn't been compiled with a retpoline
> aware compiler, print a warning and set a taint flag.
>
> For modules it is checked at compile time, however it cannot
> check assembler or other non compiled objects used in the module link.
>
> Due to lack of better letter it uses taint option 'Z'
>

Is taint really the right thing to do here? Why not just do pr_info?