All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bamvor Zhang Jian <bamvor.zhangjian@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>,
	Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kernel <kernel@savoirfairelinux.com>,
	Bamvor Zhang Jian <bamvor.zhangjian@linaro.org>
Subject: Re: [PATCH] gpiolib: fix chip order in gpio list
Date: Thu, 14 Jan 2016 15:09:23 +0800	[thread overview]
Message-ID: <CAFy1USTQLpnV4ZtOf0dC+hk5j4M7WbU7Cis=PxLWuu8sqO4FEA@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdZb1wWy-19y9BX9T0xeKUfmC2ym-sd4JEoLqhqVeb6GFw@mail.gmail.com>

On 01/13/2016 06:11 PM, Linus Walleij wrote:
> On Thu, Jan 7, 2016 at 10:46 PM, Julien Grossholtz
> <julien.grossholtz@savoirfairelinux.com> wrote:
>
>> In some situations the gpio_list order is not correct.
>> As a consequence gpiochip_find_base returns the same
>> base number twice. This happens when a first ship is added
>> with manual base number, then other ships are added using
>> automatic base number.
>>
>> To prevent this behaviour, this patch add the new ship after
s/ship/chip
>> the last element of the gpio list.
>>
>> Signed-off-by: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>
>
> Patch looks correct to me so applied.
>
> Bamvor: please comment if you see some problems.
Nope, it could pass all the testcases I wrote.

Regards

Bamvor
>
> Yours,
> Linus Walleij
>

      reply	other threads:[~2016-01-14  7:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 21:46 [PATCH] gpiolib: fix chip order in gpio list Julien Grossholtz
2016-01-13 10:11 ` Linus Walleij
2016-01-14  7:09   ` Bamvor Zhang Jian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFy1USTQLpnV4ZtOf0dC+hk5j4M7WbU7Cis=PxLWuu8sqO4FEA@mail.gmail.com' \
    --to=bamvor.zhangjian@linaro.org \
    --cc=gnurou@gmail.com \
    --cc=julien.grossholtz@savoirfairelinux.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.