All of lore.kernel.org
 help / color / mirror / Atom feed
From: Calvin Wan <calvinwan@google.com>
To: phillip.wood@dunelm.org.uk
Cc: git@vger.kernel.org, emilyshaffer@google.com, avarab@gmail.com,
	phillip.wood123@gmail.com, myriamanis@google.com
Subject: Re: [PATCH v4 4/5] diff-lib: refactor match_stat_with_submodule
Date: Wed, 30 Nov 2022 11:08:09 -0800	[thread overview]
Message-ID: <CAFySSZBC5HbGQxtpsEL8_kxbogx0JX10DvMXJb9uotyQpg46Cw@mail.gmail.com> (raw)
In-Reply-To: <19f91fea-a2a9-7dc6-d940-cc10f384fe76@dunelm.org.uk>

> Thanks for splitting this change out. I have to say I find the original
> quite a bit easier to read. If you're worried about the code added in
> the next commit being too indented perhaps you could move the body of
> the if statement into a separate function.

Then we're just swapping if statement depth for function call depth, which
seems even worse. I think the confusion comes from adding the "ret:" part
which is currently unnecessary so I can get rid of that this patch.

Thanks

  reply	other threads:[~2022-11-30 19:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <https://lore.kernel.org/git/20221020232532.1128326-1-calvinwan@google.com/>
2022-11-08 18:41 ` [PATCH v4 0/5] submodule: parallelize diff Calvin Wan
2022-11-23 17:49   ` Glen Choo
2023-01-15  9:31   ` Junio C Hamano
2023-01-17 19:31     ` Calvin Wan
2022-11-08 18:41 ` [PATCH v4 1/5] run-command: add duplicate_output_fn to run_processes_parallel_opts Calvin Wan
2022-11-28 20:45   ` Jonathan Tan
2022-11-30 18:46     ` Calvin Wan
2022-11-29  5:11   ` Elijah Newren
2022-11-30 18:47     ` Calvin Wan
2022-11-29 23:29   ` Glen Choo
2022-11-30  9:53     ` Ævar Arnfjörð Bjarmason
2022-11-30 10:26       ` Phillip Wood
2022-11-30 19:02         ` Calvin Wan
2022-11-30 10:28       ` Phillip Wood
2022-11-30 10:57         ` Ævar Arnfjörð Bjarmason
2022-11-08 18:41 ` [PATCH v4 2/5] submodule: strbuf variable rename Calvin Wan
2022-11-08 18:41 ` [PATCH v4 3/5] submodule: move status parsing into function Calvin Wan
2022-11-08 18:41 ` [PATCH v4 4/5] diff-lib: refactor match_stat_with_submodule Calvin Wan
2022-11-30 14:36   ` Phillip Wood
2022-11-30 19:08     ` Calvin Wan [this message]
2022-11-08 18:42 ` [PATCH v4 5/5] diff-lib: parallelize run_diff_files for submodules Calvin Wan
2022-11-28 21:01   ` Jonathan Tan
2022-11-29 22:29     ` Glen Choo
2022-11-30 18:11       ` Calvin Wan
2022-11-29  5:13   ` Elijah Newren
2022-11-30 18:04     ` Calvin Wan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFySSZBC5HbGQxtpsEL8_kxbogx0JX10DvMXJb9uotyQpg46Cw@mail.gmail.com \
    --to=calvinwan@google.com \
    --cc=avarab@gmail.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=myriamanis@google.com \
    --cc=phillip.wood123@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.