From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:60113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsCaD-0001OL-8Y for qemu-devel@nongnu.org; Fri, 08 Feb 2019 15:17:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gsCaB-0000aw-QQ for qemu-devel@nongnu.org; Fri, 08 Feb 2019 15:17:08 -0500 Received: from mail-vk1-xa44.google.com ([2607:f8b0:4864:20::a44]:43674) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gsCa9-0007AN-KQ for qemu-devel@nongnu.org; Fri, 08 Feb 2019 15:17:07 -0500 Received: by mail-vk1-xa44.google.com with SMTP id o130so1110806vke.10 for ; Fri, 08 Feb 2019 12:12:46 -0800 (PST) MIME-Version: 1.0 References: <20190130025708.12811-1-jimw@sifive.com> In-Reply-To: From: Jim Wilson Date: Fri, 8 Feb 2019 11:08:55 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH 5/5 v3] RISC-V: Add hooks to use the gdb xml files. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: "qemu-devel@nongnu.org Developers" , "open list:RISC-V" On Fri, Feb 8, 2019 at 10:17 AM Alistair Francis wrote: > Can we just write a wrapper function then that sets and unsets the variable? > Something like this: > > riscv_csrrw_debug(...) { > #if !defined(CONFIG_USER_ONLY) > env->debugger = true; > #endif > result = riscv_csrrw(env, ...); > #if !defined(CONFIG_USER_ONLY) > env->debugger = false; > #endif > } Yes, that would work. Do you want me to resubmit a fixed part 5 patch? Jim From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gsD4v-0007ae-UN for mharc-qemu-riscv@gnu.org; Fri, 08 Feb 2019 15:48:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsD4s-0007Yq-I6 for qemu-riscv@nongnu.org; Fri, 08 Feb 2019 15:48:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gsD4o-0001lY-Ro for qemu-riscv@nongnu.org; Fri, 08 Feb 2019 15:48:50 -0500 Received: from mail-vk1-xa42.google.com ([2607:f8b0:4864:20::a42]:40302) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gsD4h-0001Vc-4C for qemu-riscv@nongnu.org; Fri, 08 Feb 2019 15:48:41 -0500 Received: by mail-vk1-xa42.google.com with SMTP id v70so1132852vkv.7 for ; Fri, 08 Feb 2019 12:48:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UxT29kiCIm1XmjA/YgdDSyKpiF0SGaIWn8dKGExb6pE=; b=U/R3U4+n5t7qYjtyC4z8MgcDyRWexz3D9Oxavsnfm1Mq7Bdi1gR/NFsWXeFppuGdOx 5DENVtKe2e4LqR7xwcSqAA2MzcvU6G1hRpyVesA+XnRJSNh5L4PblDix32ZxHu+tu28x qsKZl70Bkl6xYlGryFP3duAzn+9IhKcpg2nmBUe/09bBr/yR7VAjpZOh6PbhEN27v+Cj Nwt4lsHrTFW/GAA2HPAHBu3i1gcK4/fYdBQWQl3iIjxYd2Qko92hnvgf0sy+sa1M2p65 H2JI42eNqjmCmtP7meiX0WNEEGcx2vi48nva7P/fCqiah4cggH348tWSGUkUCDdBoS/1 3zWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UxT29kiCIm1XmjA/YgdDSyKpiF0SGaIWn8dKGExb6pE=; b=GGeUEP+uU7Q3e2HO6lNV6NmriB8scU2j0yA6tt+p1mG1n6iolV0qLxXWuO+cDOa4+r nzEOYTBvByEVEVt0TC3bEgQ5pq/AxZLX0NgGfefFY/84IEiheblZlvfhfUk+bmAl4Eho 8rSkDzN3Li3ObzxJkDgMmmNRsKrouz3i7rAhpePOPFCPO+51wE0bKU7XHSz3YRFqvAQr 3B7KuTbnPhpF01dYGjP2ZA1YYOePgvTDoRdYHNxQ2llReILqlYRXTd9e4KP78w2hedE/ 5lnAhtAiXlqKSWFPzwwNMMpP1LI8fNV/uBQ03mDFyELogIyQxjrPH9g8noHVEg/G6NH6 PlUA== X-Gm-Message-State: AHQUAuZpxBuSE10xZMV3E9iajXPFgq1cGsmN9ibt/tkeT4ZOzVQZXGmt iwI0iExwTQnppZChBt/TRfj8q/o8Nan+6nnwrFwP+9l0 X-Google-Smtp-Source: AHgI3IZKhiTcHRp9iyCbetEIvwMeELFTTGfvWmr994mFf7q+e6Yr6lyBSrkAx2dHGW+TldkvS6VikG/CRkvx+sU0Jz4= X-Received: by 2002:a1f:1408:: with SMTP id 8mr8146371vku.36.1549652946051; Fri, 08 Feb 2019 11:09:06 -0800 (PST) MIME-Version: 1.0 References: <20190130025708.12811-1-jimw@sifive.com> In-Reply-To: From: Jim Wilson Date: Fri, 8 Feb 2019 11:08:55 -0800 Message-ID: To: Alistair Francis Cc: "qemu-devel@nongnu.org Developers" , "open list:RISC-V" Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::a42 Subject: Re: [Qemu-riscv] [Qemu-devel] [PATCH 5/5 v3] RISC-V: Add hooks to use the gdb xml files. X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Feb 2019 20:48:52 -0000 On Fri, Feb 8, 2019 at 10:17 AM Alistair Francis wrote: > Can we just write a wrapper function then that sets and unsets the variable? > Something like this: > > riscv_csrrw_debug(...) { > #if !defined(CONFIG_USER_ONLY) > env->debugger = true; > #endif > result = riscv_csrrw(env, ...); > #if !defined(CONFIG_USER_ONLY) > env->debugger = false; > #endif > } Yes, that would work. Do you want me to resubmit a fixed part 5 patch? Jim