All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chas Williams <3chas3@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, mark.rutland@arm.com,
	natechancellor@gmail.com, Chas Williams <chas3@att.com>
Subject: Re: [PATCH] Fixes: Commit 2aa6d036b716 ("mm: numa: avoid waiting on freed migrated pages")
Date: Wed, 5 Sep 2018 13:46:47 -0400	[thread overview]
Message-ID: <CAG2-Gkkt9p8bhjDfssPLoKAhUU1v3XGHMTFoYfoPfeCKE24yYA@mail.gmail.com> (raw)
In-Reply-To: <20180905150243.GB21619@kroah.com>

On Wed, Sep 5, 2018 at 11:03 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Sep 05, 2018 at 10:43:17AM -0400, Chas Williams wrote:
> > From: Chas Williams <chas3@att.com>
> >
> > Commit 2aa6d036b716 ("mm: numa: avoid waiting on freed migrated pages")
> > was an incomplete backport of the upstream commit.  It is necessary to
> > always reset page_nid before attempting any early exit.
> >
> > The original commit conflicted due to lack of commit 82b0f8c39a38
> > ("mm: join struct fault_env and vm_fault") in 4.9 so it wasn't a clean
> > application, and the change must have just gotten lost in the noise.
> >
> > Signed-off-by: Chas Williams <chas3@att.com>
> > ---
> >  mm/huge_memory.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Much better, thanks!
>
> But can you cc: the people involved in that first patch to get their
> ack?
>
> Also, what about 4.4.y and 3.18.y which had the original commit
> backported as well?  Do they also need this fix?

Yes, both are broken.

> thanks,
>
> greg k-h

  reply	other threads:[~2018-09-05 22:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05  8:58 [PATCH v4.9.y] Fixes: Commit 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages") Chas Williams
2018-09-05  9:05 ` Greg KH
2018-09-05  9:18   ` Nathan Chancellor
     [not found]     ` <CAG2-Gkn69EFYV2XwBraSt2nPwxRh2i+vV-XRfzxsZH2_7cORhg@mail.gmail.com>
2018-09-05  9:32       ` Greg Kroah-Hartman
2018-09-05  9:41         ` Chas Williams
2018-09-05 10:07           ` Greg Kroah-Hartman
2018-09-05 14:43 ` [PATCH] Fixes: Commit 2aa6d036b716 " Chas Williams
2018-09-05 15:02   ` Greg KH
2018-09-05 17:46     ` Chas Williams [this message]
2018-09-06 15:09 ` [PATCH][4.9.y] " Chas Williams
2018-09-06 15:10 ` [PATCH][v3.18.y] Fixes: Commit 86af955d02bb " Chas Williams
2018-09-06 15:11 ` [PATCH][v4.4.y] Fixes: Commit cdbf92675fad " Chas Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAG2-Gkkt9p8bhjDfssPLoKAhUU1v3XGHMTFoYfoPfeCKE24yYA@mail.gmail.com \
    --to=3chas3@gmail.com \
    --cc=chas3@att.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=mark.rutland@arm.com \
    --cc=natechancellor@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.