From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chas Williams <3chas3@gmail.com> Subject: Re: [PATCH v3] net/bonding: fix slave add for mode 4 Date: Thu, 31 May 2018 20:05:17 -0400 Message-ID: References: <1525867586-23328-1-git-send-email-radu.nicolau@intel.com> <1527783047-18201-1-git-send-email-radu.nicolau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: dev@dpdk.org, Declan Doherty , Ferruh Yigit To: Radu Nicolau Return-path: Received: from mail-it0-f65.google.com (mail-it0-f65.google.com [209.85.214.65]) by dpdk.org (Postfix) with ESMTP id 6992F4C93 for ; Fri, 1 Jun 2018 02:05:18 +0200 (CEST) Received: by mail-it0-f65.google.com with SMTP id c3-v6so30268705itj.4 for ; Thu, 31 May 2018 17:05:18 -0700 (PDT) In-Reply-To: <1527783047-18201-1-git-send-email-radu.nicolau@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It's not clear to me that the issue here is the bonding slave add. You can only add started PMDs. When a PMD dev start is complete, the PMD should have a valid link state and the link properties should be valid. A few of the PMDs are very good about this, particularly the ones with LSC interrupts. Those drivers often wait for the first link interrupt before setting their link status. So there is a race where the link state isn't well defined. And lastly, why do we care what the link state is when adding a slave? If the link state changes to down, do we remove the slave? If the link speed of the slave changes, do we remove the slave? So this test doesn't make much sense. For mode 4, you should be able to add a slave, but if the link state doesn't match what has been negotiated, then the slave should fail to activate. On Thu, May 31, 2018 at 12:10 PM, Radu Nicolau wrote: > > Add a call to rte_eth_link_get_nowait on every slave to update > the internal link status struct. Otherwise slave add will fail > for mode 4 if the ports are all stopped but only one of them checked. > > Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions") > Bugzilla ID: 52 > > Signed-off-by: Radu Nicolau > --- > v3: updated commit msg > v2: add fix and Bugzilla references > > drivers/net/bonding/rte_eth_bond_api.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c > index d558df8..cad08b9 100644 > --- a/drivers/net/bonding/rte_eth_bond_api.c > +++ b/drivers/net/bonding/rte_eth_bond_api.c > @@ -296,6 +296,8 @@ __eth_bond_slave_add_lock_free(uint16_t bonded_port_id, uint16_t slave_port_id) > return -1; > } > > + rte_eth_link_get_nowait(slave_port_id, &link_props); > + > slave_add(internals, slave_eth_dev); > > /* We need to store slaves reta_size to be able to synchronize RETA for all > -- > 2.7.5 >