On Wed, Jul 13, 2011 at 06:05, Davidlohr Bueso wrote: > I don't think we should always rely on having the kernel headers, that's > why the fallback is provided. [snip] > I think with this patch we address the issue without removing our > fallback. Hi Dave et.al. The preprocessor directive bellow is problematic. I don't see where, or how, it might get satisfied so I am afraid the 'fall back' is always in use regardless whether an user has kernel headers or not. #ifdef KERNEL_INCLUDES_ARE_CLEAN To fix that I modified the patch to use autoconf to check whether each necessary header is present, and use them if possible. Notice that Dave that I wrote your name to Reviewed-by patch line so it would be nice to hear that you're OK with the change. See the attachment, or pull from my repository. The following changes since commit bfa8d39b5826b928deb6d84aee3a4a1d6557364c: build-sys: fix spaces versus tabs conflict (2011-07-11 15:12:06 +0200) are available in the git repository at: https://github.com/kerolasa/lelux-utiliteetit minix Sami Kerola (1): minix: v3 super-block does not have s_state field configure.ac | 5 ++ disk-utils/minix.h | 129 ++++++++++++++++++++++++++++------------------ disk-utils/mkfs.minix.c | 2 - 3 files changed, 83 insertions(+), 53 deletions(-) --    Sami Kerola    http://www.iki.fi/kerolasa/