From: Sami Kerola <kerolasa@iki.fi>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH 03/13] libfdisk: collapse indentation [oclint]
Date: Thu, 21 Jul 2016 21:20:01 +0100 [thread overview]
Message-ID: <CAG27Bk2dCmtE0PL52Br=j6YvZO3wpTRU09mQrB7wUc7k-edaOA@mail.gmail.com> (raw)
In-Reply-To: <20160719084836.pgjmo4v45zme4rys@ws.net.home>
On 19 July 2016 at 09:48, Karel Zak <kzak@redhat.com> wrote:
> On Sun, Jul 17, 2016 at 02:00:05PM +0100, Sami Kerola wrote:
>> - for (j = 0; j < i; j++)
>> - if (lens[j]) {
>
>> + for (j = 0; j < i && lens[j]; j++)
>
>
> I don't think the result is the same logic.
Oh I see. The patch is dropped from the my oclint branch, that is
rebased on top change 10e8d7a.
--
Sami Kerola
http://www.iki.fi/kerolasa/
next prev parent reply other threads:[~2016-07-21 20:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-17 13:00 [PATCH 00/13] pull: OCLint static code analysis changes Sami Kerola
2016-07-17 13:00 ` [PATCH 01/13] misc: simplify if clauses [oclint] Sami Kerola
2016-07-17 13:00 ` [PATCH 02/13] switch_root: simplify code and reduce indentation [oclint] Sami Kerola
2016-07-17 13:00 ` [PATCH 03/13] libfdisk: collapse " Sami Kerola
2016-07-19 8:48 ` Karel Zak
2016-07-21 20:20 ` Sami Kerola [this message]
2016-07-17 13:00 ` [PATCH 04/13] lslogins: simplify if clause and move definition and comments [oclint] Sami Kerola
2016-07-17 13:00 ` [PATCH 05/13] libblkid: simplify if clause [oclint] Sami Kerola
2016-07-17 13:00 ` [PATCH 06/13] logger: " Sami Kerola
2016-07-17 13:00 ` [PATCH 07/13] syspriv: flip inverted logic [oclint] Sami Kerola
2016-07-17 13:00 ` [PATCH 08/13] libmount, look: remove dead code [oclint] Sami Kerola
2016-07-17 13:00 ` [PATCH 09/13] dmesg: drop core at impossible case in read_buffer() [oclint] Sami Kerola
2016-07-17 13:00 ` [PATCH 10/13] misc: fix declarations shadowing variables in the global scope [oclint] Sami Kerola
2016-07-17 13:00 ` [PATCH 11/13] setterm: " Sami Kerola
2016-07-17 13:00 ` [PATCH 12/13] agetty: move unreachable code to pre-processor #else segment [oclint] Sami Kerola
2016-07-17 13:00 ` [PATCH 13/13] libblkid: fix debugging macro [oclint] Sami Kerola
2016-08-02 13:44 ` [PATCH 00/13] pull: OCLint static code analysis changes Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG27Bk2dCmtE0PL52Br=j6YvZO3wpTRU09mQrB7wUc7k-edaOA@mail.gmail.com' \
--to=kerolasa@iki.fi \
--cc=kerolasa@gmail.com \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.