From: Sami Kerola <kerolasa@iki.fi>
To: util-linux <util-linux@vger.kernel.org>
Cc: Sami Kerola <kerolasa@iki.fi>
Subject: Re: [PATCH 00/12] pull: mostly swap command clarifications
Date: Tue, 29 Apr 2014 22:05:19 +0100 [thread overview]
Message-ID: <CAG27Bk2oYs=yEcyxHz8b0xPeMXyLbbbvgX4E4=E93Rv8EpqDxQ@mail.gmail.com> (raw)
In-Reply-To: <1398629138-31718-1-git-send-email-kerolasa@iki.fi>
On 27 April 2014 21:05, Sami Kerola <kerolasa@iki.fi> wrote:
> are available in the git repository at:
>
> git://github.com/kerolasa/lelux-utiliteetit.git 2014wk16
[snip]
> include/xalloc: ensure arithmetics overflow cannot happen
> dmesg: move get_boot_time() to lib/timeutils
> last: fix is_phantom() detection
> include/c.h: add macro to print definitions as string
> mkswap, swaplabel: move version number to header
> mkswap: remove legacy swap structure
> include/swapheader.h: ensure type sizes
> swapon: swaps with legacy version label are not supported
> swapon, swapheader, mkswap: move swap signature to header
> libsmartcols: remove ununsed assignment
> lib/timeutils: fix memory leak
> lib/pager: use names when referring to standard file descriptors
Good evening,
I got rid of the xalloc change, with intention to send some sort of
xrecalloc() later. The 'swapon: swaps with legacy version label are
not supported' patch now uses SWAP_SIGNATURE_SZ instead of magic
number & Bernhard is added as reviewer. Karel, I am not sure if I got
the libsmartcols check right so please ensure the logic is correct.
Corrected versions of the patches are available from my github remote
branch that is using the same name as previous time I sent these. IMHO
the changes are pretty small, so resubmission is not (yet) necessary.
If there's more feedback that might change.
--
Sami Kerola
http://www.iki.fi/kerolasa/
next prev parent reply other threads:[~2014-04-29 21:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 20:05 [PATCH 00/12] pull: mostly swap command clarifications Sami Kerola
2014-04-27 20:05 ` [PATCH 01/12] include/xalloc: ensure arithmetics overflow cannot happen Sami Kerola
2014-04-27 20:45 ` Bernhard Voelker
2014-04-28 6:52 ` Karel Zak
2014-04-28 8:42 ` Sami Kerola
2014-04-27 20:05 ` [PATCH 02/12] dmesg: move get_boot_time() to lib/timeutils Sami Kerola
2014-05-06 10:00 ` Ruediger Meier
2014-05-06 11:20 ` Karel Zak
2014-05-06 13:42 ` Ruediger Meier
2014-05-06 14:40 ` Karel Zak
2014-05-06 16:03 ` Ruediger Meier
2014-05-07 9:52 ` Karel Zak
2014-05-07 14:04 ` Ruediger Meier
2014-04-27 20:05 ` [PATCH 03/12] last: fix is_phantom() detection Sami Kerola
2014-04-27 20:05 ` [PATCH 04/12] include/c.h: add macro to print definitions as string Sami Kerola
2014-04-27 20:05 ` [PATCH 05/12] mkswap, swaplabel: move version number to header Sami Kerola
2014-04-27 20:05 ` [PATCH 06/12] mkswap: remove legacy swap structure Sami Kerola
2014-04-27 20:05 ` [PATCH 07/12] include/swapheader.h: ensure type sizes Sami Kerola
2014-04-27 20:05 ` [PATCH 08/12] swapon: swaps with legacy version label are not supported Sami Kerola
2014-04-28 8:37 ` Benno Schulenberg
2014-04-28 8:44 ` Sami Kerola
2014-04-28 9:00 ` Karel Zak
2014-04-27 20:05 ` [PATCH 09/12] swapon, swapheader, mkswap: move swap signature to header Sami Kerola
2014-04-27 20:05 ` [PATCH 10/12] libsmartcols: remove ununsed assignment Sami Kerola
2014-04-28 9:02 ` Karel Zak
2014-04-27 20:05 ` [PATCH 11/12] lib/timeutils: fix memory leak Sami Kerola
2014-04-27 20:05 ` [PATCH 12/12] lib/pager: use names when referring to standard file descriptors Sami Kerola
2014-04-29 21:05 ` Sami Kerola [this message]
2014-04-29 21:46 ` [PATCH 00/12] pull: mostly swap command clarifications Bernhard Voelker
2014-05-06 8:36 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG27Bk2oYs=yEcyxHz8b0xPeMXyLbbbvgX4E4=E93Rv8EpqDxQ@mail.gmail.com' \
--to=kerolasa@iki.fi \
--cc=kerolasa@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.