From: Chunyan Zhang <zhang.chunyan@linaro.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Grygorii Strashko <grygorii.Strashko@ti.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Subject: Re: [BACKPORT 4.4.y] PM / sleep: prohibit devices probing during suspend/hibernation
Date: Mon, 10 Jun 2019 10:33:51 +0800 [thread overview]
Message-ID: <CAG2=9p_6Rk4oUu0hWKdzHNxRg=Hsboz=vYwsmfagmuCHzEKMOg@mail.gmail.com> (raw)
In-Reply-To: <20190606010857.GF29739@sasha-vm>
On Thu, 6 Jun 2019 at 09:08, Sasha Levin <sashal@kernel.org> wrote:
>
> On Wed, Jun 05, 2019 at 07:14:12PM +0800, Chunyan Zhang wrote:
> >From: "Strashko, Grygorii" <grygorii.strashko@ti.com>
> >
> >[ Upstream commit 013c074f8642d8e815ad670601f8e27155a74b57 ]
> >
> >It is unsafe [1] if probing of devices will happen during suspend or
> >hibernation and system behavior will be unpredictable in this case.
> >So, let's prohibit device's probing in dpm_prepare() and defer their
> >probing instead. The normal behavior will be restored in
> >dpm_complete().
> >
> >This patch introduces new DD core APIs:
> > device_block_probing()
> > It will disable probing of devices and defer their probes instead.
> > device_unblock_probing()
> > It will restore normal behavior and trigger re-probing of deferred
> > devices.
> >
> >[1] https://lkml.org/lkml/2015/9/11/554
> >
> >Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> >Acked-by: Pavel Machek <pavel@ucw.cz>
> >Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
>
> This patch had to be fixed a few times (see 015bb5e134 and 9a2a5a638f8),
> we can't just take it as is.
>
> It might be just simpler to move to a newer kernel at this point.
Thanks for the information and suggestion!
Chunyan
>
> --
> Thanks,
> Sasha
prev parent reply other threads:[~2019-06-10 2:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 11:14 [BACKPORT 4.4.y] PM / sleep: prohibit devices probing during suspend/hibernation Chunyan Zhang
2019-06-06 1:08 ` Sasha Levin
2019-06-10 2:33 ` Chunyan Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG2=9p_6Rk4oUu0hWKdzHNxRg=Hsboz=vYwsmfagmuCHzEKMOg@mail.gmail.com' \
--to=zhang.chunyan@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.Strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.