From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753899AbaHUHMK (ORCPT ); Thu, 21 Aug 2014 03:12:10 -0400 Received: from mail-qg0-f44.google.com ([209.85.192.44]:47138 "EHLO mail-qg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753773AbaHUHMH (ORCPT ); Thu, 21 Aug 2014 03:12:07 -0400 MIME-Version: 1.0 In-Reply-To: <53F4B663.90400@ti.com> References: <1407944075-8093-1-git-send-email-gabriel.fernandez@linaro.org> <1407944075-8093-3-git-send-email-gabriel.fernandez@linaro.org> <53F4B663.90400@ti.com> Date: Thu, 21 Aug 2014 09:12:06 +0200 Message-ID: Subject: Re: [PATCH 2/5] phy: miphy28lp: Add MiPHY28lp header file for DT x Driver defines From: Gabriel Fernandez To: Kishon Vijay Abraham I Cc: Gabriel FERNANDEZ , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Russell King , Grant Likely , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@stlinux.com" , alexandre torgue Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kishon, Okay, good. BR Gabriel On 20 August 2014 16:53, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 13 August 2014 09:04 PM, Gabriel FERNANDEZ wrote: >> This provides the shared header file which will be reference from both >> the MiPHY28lp driver and its associated Device Tree node(s). >> >> Signed-off-by: alexandre torgue >> Signed-off-by: Gabriel Fernandez >> --- >> include/dt-bindings/phy/phy-miphy28lp.h | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> create mode 100644 include/dt-bindings/phy/phy-miphy28lp.h >> >> diff --git a/include/dt-bindings/phy/phy-miphy28lp.h b/include/dt-bindings/phy/phy-miphy28lp.h >> new file mode 100644 >> index 0000000..7cf9bce >> --- /dev/null >> +++ b/include/dt-bindings/phy/phy-miphy28lp.h >> @@ -0,0 +1,12 @@ >> +/* >> + * This header provides constants for the phy framework >> + * based on the STMicroelectronics miph28lp. >> + */ >> +#ifndef _DT_BINDINGS_PHY_MIPHY28LP >> +#define _DT_BINDINGS_PHY_MIPHY28LP >> + >> +#define MIPHY_TYPE_SATA 1 >> +#define MIPHY_TYPE_PCIE 2 >> +#define MIPHY_TYPE_USB 3 > > I think we should create a common file for phy so that all user's need not > create a separate copy of the same thing. > > Thanks > Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabriel Fernandez Subject: Re: [PATCH 2/5] phy: miphy28lp: Add MiPHY28lp header file for DT x Driver defines Date: Thu, 21 Aug 2014 09:12:06 +0200 Message-ID: References: <1407944075-8093-1-git-send-email-gabriel.fernandez@linaro.org> <1407944075-8093-3-git-send-email-gabriel.fernandez@linaro.org> <53F4B663.90400@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <53F4B663.90400-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kishon Vijay Abraham I Cc: Gabriel FERNANDEZ , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Russell King , Grant Likely , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org" , alexandre torgue List-Id: devicetree@vger.kernel.org Hi Kishon, Okay, good. BR Gabriel On 20 August 2014 16:53, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 13 August 2014 09:04 PM, Gabriel FERNANDEZ wrote: >> This provides the shared header file which will be reference from both >> the MiPHY28lp driver and its associated Device Tree node(s). >> >> Signed-off-by: alexandre torgue >> Signed-off-by: Gabriel Fernandez >> --- >> include/dt-bindings/phy/phy-miphy28lp.h | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> create mode 100644 include/dt-bindings/phy/phy-miphy28lp.h >> >> diff --git a/include/dt-bindings/phy/phy-miphy28lp.h b/include/dt-bindings/phy/phy-miphy28lp.h >> new file mode 100644 >> index 0000000..7cf9bce >> --- /dev/null >> +++ b/include/dt-bindings/phy/phy-miphy28lp.h >> @@ -0,0 +1,12 @@ >> +/* >> + * This header provides constants for the phy framework >> + * based on the STMicroelectronics miph28lp. >> + */ >> +#ifndef _DT_BINDINGS_PHY_MIPHY28LP >> +#define _DT_BINDINGS_PHY_MIPHY28LP >> + >> +#define MIPHY_TYPE_SATA 1 >> +#define MIPHY_TYPE_PCIE 2 >> +#define MIPHY_TYPE_USB 3 > > I think we should create a common file for phy so that all user's need not > create a separate copy of the same thing. > > Thanks > Kishon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: gabriel.fernandez@linaro.org (Gabriel Fernandez) Date: Thu, 21 Aug 2014 09:12:06 +0200 Subject: [PATCH 2/5] phy: miphy28lp: Add MiPHY28lp header file for DT x Driver defines In-Reply-To: <53F4B663.90400@ti.com> References: <1407944075-8093-1-git-send-email-gabriel.fernandez@linaro.org> <1407944075-8093-3-git-send-email-gabriel.fernandez@linaro.org> <53F4B663.90400@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Kishon, Okay, good. BR Gabriel On 20 August 2014 16:53, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 13 August 2014 09:04 PM, Gabriel FERNANDEZ wrote: >> This provides the shared header file which will be reference from both >> the MiPHY28lp driver and its associated Device Tree node(s). >> >> Signed-off-by: alexandre torgue >> Signed-off-by: Gabriel Fernandez >> --- >> include/dt-bindings/phy/phy-miphy28lp.h | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> create mode 100644 include/dt-bindings/phy/phy-miphy28lp.h >> >> diff --git a/include/dt-bindings/phy/phy-miphy28lp.h b/include/dt-bindings/phy/phy-miphy28lp.h >> new file mode 100644 >> index 0000000..7cf9bce >> --- /dev/null >> +++ b/include/dt-bindings/phy/phy-miphy28lp.h >> @@ -0,0 +1,12 @@ >> +/* >> + * This header provides constants for the phy framework >> + * based on the STMicroelectronics miph28lp. >> + */ >> +#ifndef _DT_BINDINGS_PHY_MIPHY28LP >> +#define _DT_BINDINGS_PHY_MIPHY28LP >> + >> +#define MIPHY_TYPE_SATA 1 >> +#define MIPHY_TYPE_PCIE 2 >> +#define MIPHY_TYPE_USB 3 > > I think we should create a common file for phy so that all user's need not > create a separate copy of the same thing. > > Thanks > Kishon