From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753140AbbCaJLu (ORCPT ); Tue, 31 Mar 2015 05:11:50 -0400 Received: from mail-ob0-f178.google.com ([209.85.214.178]:35240 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752838AbbCaJLp (ORCPT ); Tue, 31 Mar 2015 05:11:45 -0400 MIME-Version: 1.0 In-Reply-To: <1426674930.2649.50.camel@tiscali.nl> References: <1426515635-9466-1-git-send-email-gabriel.fernandez@linaro.org> <1426515635-9466-4-git-send-email-gabriel.fernandez@linaro.org> <1426518695.26437.55.camel@x220> <55093C12.7070004@st.com> <1426674930.2649.50.camel@tiscali.nl> Date: Tue, 31 Mar 2015 11:11:44 +0200 Message-ID: Subject: Re: [PATCH v2 3/5] PCI: st: Provide support for the sti PCIe controller From: Gabriel Fernandez To: Bjorn Helgaas Cc: Fabrice Gasnier , Gabriel FERNANDEZ , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Russell King , Mohit Kumar , Jingoo Han , Lucas Stach , Kishon Vijay Abraham I , Andrew Morton , "David S. Miller" , Greg KH , Mauro Carvalho Chehab , Joe Perches , Tejun Heo , Arnd Bergmann , Viresh Kumar , Thierry Reding , Phil Edworthy , Minghuan Lian , Tanmay Inamdar , Muralidharan Karicheri , Sachin Kamat , Andrew Lunn , Liviu Dudau , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@stlinux.com" , "linux-pci@vger.kernel.org" , Lee Jones , Paul Bolle Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, pci-st.c driver could be modular with modification of pcie-designware core driver. But as Fabrice said it should be another patchset. What do you prefer ? drop all the module related macros as mentioned by Paul ? or keep macros like other vendors do ? Thanks Gabriel On 18 March 2015 at 11:35, Paul Bolle wrote: > Hi Fabrice, > > Fabrice Gasnier schreef op wo 18-03-2015 om 09:49 [+0100]: >> On 03/16/2015 04:11 PM, Paul Bolle wrote: >> >> +config PCI_ST >> >> + bool "ST PCIe controller" >> > You add a bool Kconfig symbol. A week or two ago I saw some patches fly >> > by that - I think - allowed PCIe controllers to be built modular. >> >> Thanks for your review. >> >> Are you talking about "PCI: Export symbols of PCI functions" patch, that >> is part of a series >> named "pci: iproc: Add Broadcom iProc PCIe support" ? > > Yes, that is the series I was thinking about. (I made you search lkml, > and that was a bit rude. But you found the patch anyhow.) > >> This controller doesn't look like to be based on pcie-designware core >> driver. >> Other vendors that are using "pcie-designware" core driver are also make >> it bool. >> The current core driver doesn't support module loading/unloading as I >> see it. >> If this is required, I also think this should be part of another patchset. >> >> What do you think ? > > I wouldn't know whether your driver might work as a loadable module, but > other people reading this surely will. But if it can't work as a module > you should drop all the module related macros etc. I spotted. Because > then they serve no purpose. > > > Paul Bolle > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabriel Fernandez Subject: Re: [PATCH v2 3/5] PCI: st: Provide support for the sti PCIe controller Date: Tue, 31 Mar 2015 11:11:44 +0200 Message-ID: References: <1426515635-9466-1-git-send-email-gabriel.fernandez@linaro.org> <1426515635-9466-4-git-send-email-gabriel.fernandez@linaro.org> <1426518695.26437.55.camel@x220> <55093C12.7070004@st.com> <1426674930.2649.50.camel@tiscali.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1426674930.2649.50.camel@tiscali.nl> Sender: linux-pci-owner@vger.kernel.org To: Bjorn Helgaas Cc: Fabrice Gasnier , Gabriel FERNANDEZ , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Russell King , Mohit Kumar , Jingoo Han , Lucas Stach , Kishon Vijay Abraham I , Andrew Morton , "David S. Miller" , Greg KH , Mauro Carvalho Chehab , Joe Perches , Tejun Heo , Arnd Bergmann , Viresh Kumar List-Id: devicetree@vger.kernel.org Hi Bjorn, pci-st.c driver could be modular with modification of pcie-designware core driver. But as Fabrice said it should be another patchset. What do you prefer ? drop all the module related macros as mentioned by Paul ? or keep macros like other vendors do ? Thanks Gabriel On 18 March 2015 at 11:35, Paul Bolle wrote: > Hi Fabrice, > > Fabrice Gasnier schreef op wo 18-03-2015 om 09:49 [+0100]: >> On 03/16/2015 04:11 PM, Paul Bolle wrote: >> >> +config PCI_ST >> >> + bool "ST PCIe controller" >> > You add a bool Kconfig symbol. A week or two ago I saw some patches fly >> > by that - I think - allowed PCIe controllers to be built modular. >> >> Thanks for your review. >> >> Are you talking about "PCI: Export symbols of PCI functions" patch, that >> is part of a series >> named "pci: iproc: Add Broadcom iProc PCIe support" ? > > Yes, that is the series I was thinking about. (I made you search lkml, > and that was a bit rude. But you found the patch anyhow.) > >> This controller doesn't look like to be based on pcie-designware core >> driver. >> Other vendors that are using "pcie-designware" core driver are also make >> it bool. >> The current core driver doesn't support module loading/unloading as I >> see it. >> If this is required, I also think this should be part of another patchset. >> >> What do you think ? > > I wouldn't know whether your driver might work as a loadable module, but > other people reading this surely will. But if it can't work as a module > you should drop all the module related macros etc. I spotted. Because > then they serve no purpose. > > > Paul Bolle > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f179.google.com ([209.85.214.179]:35240 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379AbbCaJLp (ORCPT ); Tue, 31 Mar 2015 05:11:45 -0400 Received: by obcjt1 with SMTP id jt1so17027447obc.2 for ; Tue, 31 Mar 2015 02:11:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1426674930.2649.50.camel@tiscali.nl> References: <1426515635-9466-1-git-send-email-gabriel.fernandez@linaro.org> <1426515635-9466-4-git-send-email-gabriel.fernandez@linaro.org> <1426518695.26437.55.camel@x220> <55093C12.7070004@st.com> <1426674930.2649.50.camel@tiscali.nl> Date: Tue, 31 Mar 2015 11:11:44 +0200 Message-ID: Subject: Re: [PATCH v2 3/5] PCI: st: Provide support for the sti PCIe controller From: Gabriel Fernandez To: Bjorn Helgaas Cc: Fabrice Gasnier , Gabriel FERNANDEZ , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Russell King , Mohit Kumar , Jingoo Han , Lucas Stach , Kishon Vijay Abraham I , Andrew Morton , "David S. Miller" , Greg KH , Mauro Carvalho Chehab , Joe Perches , Tejun Heo , Arnd Bergmann , Viresh Kumar , Thierry Reding , Phil Edworthy , Minghuan Lian , Tanmay Inamdar , Muralidharan Karicheri , Sachin Kamat , Andrew Lunn , Liviu Dudau , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@stlinux.com" , "linux-pci@vger.kernel.org" , Lee Jones , Paul Bolle Content-Type: text/plain; charset=UTF-8 Sender: linux-pci-owner@vger.kernel.org List-ID: Hi Bjorn, pci-st.c driver could be modular with modification of pcie-designware core driver. But as Fabrice said it should be another patchset. What do you prefer ? drop all the module related macros as mentioned by Paul ? or keep macros like other vendors do ? Thanks Gabriel On 18 March 2015 at 11:35, Paul Bolle wrote: > Hi Fabrice, > > Fabrice Gasnier schreef op wo 18-03-2015 om 09:49 [+0100]: >> On 03/16/2015 04:11 PM, Paul Bolle wrote: >> >> +config PCI_ST >> >> + bool "ST PCIe controller" >> > You add a bool Kconfig symbol. A week or two ago I saw some patches fly >> > by that - I think - allowed PCIe controllers to be built modular. >> >> Thanks for your review. >> >> Are you talking about "PCI: Export symbols of PCI functions" patch, that >> is part of a series >> named "pci: iproc: Add Broadcom iProc PCIe support" ? > > Yes, that is the series I was thinking about. (I made you search lkml, > and that was a bit rude. But you found the patch anyhow.) > >> This controller doesn't look like to be based on pcie-designware core >> driver. >> Other vendors that are using "pcie-designware" core driver are also make >> it bool. >> The current core driver doesn't support module loading/unloading as I >> see it. >> If this is required, I also think this should be part of another patchset. >> >> What do you think ? > > I wouldn't know whether your driver might work as a loadable module, but > other people reading this surely will. But if it can't work as a module > you should drop all the module related macros etc. I spotted. Because > then they serve no purpose. > > > Paul Bolle > From mboxrd@z Thu Jan 1 00:00:00 1970 From: gabriel.fernandez@linaro.org (Gabriel Fernandez) Date: Tue, 31 Mar 2015 11:11:44 +0200 Subject: [PATCH v2 3/5] PCI: st: Provide support for the sti PCIe controller In-Reply-To: <1426674930.2649.50.camel@tiscali.nl> References: <1426515635-9466-1-git-send-email-gabriel.fernandez@linaro.org> <1426515635-9466-4-git-send-email-gabriel.fernandez@linaro.org> <1426518695.26437.55.camel@x220> <55093C12.7070004@st.com> <1426674930.2649.50.camel@tiscali.nl> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Bjorn, pci-st.c driver could be modular with modification of pcie-designware core driver. But as Fabrice said it should be another patchset. What do you prefer ? drop all the module related macros as mentioned by Paul ? or keep macros like other vendors do ? Thanks Gabriel On 18 March 2015 at 11:35, Paul Bolle wrote: > Hi Fabrice, > > Fabrice Gasnier schreef op wo 18-03-2015 om 09:49 [+0100]: >> On 03/16/2015 04:11 PM, Paul Bolle wrote: >> >> +config PCI_ST >> >> + bool "ST PCIe controller" >> > You add a bool Kconfig symbol. A week or two ago I saw some patches fly >> > by that - I think - allowed PCIe controllers to be built modular. >> >> Thanks for your review. >> >> Are you talking about "PCI: Export symbols of PCI functions" patch, that >> is part of a series >> named "pci: iproc: Add Broadcom iProc PCIe support" ? > > Yes, that is the series I was thinking about. (I made you search lkml, > and that was a bit rude. But you found the patch anyhow.) > >> This controller doesn't look like to be based on pcie-designware core >> driver. >> Other vendors that are using "pcie-designware" core driver are also make >> it bool. >> The current core driver doesn't support module loading/unloading as I >> see it. >> If this is required, I also think this should be part of another patchset. >> >> What do you think ? > > I wouldn't know whether your driver might work as a loadable module, but > other people reading this surely will. But if it can't work as a module > you should drop all the module related macros etc. I spotted. Because > then they serve no purpose. > > > Paul Bolle >