All of lore.kernel.org
 help / color / mirror / Atom feed
From: peng yu <yupeng0921@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH net-next] remove TWKilled counter
Date: Thu, 17 Jan 2019 12:26:07 -0800	[thread overview]
Message-ID: <CAG3TDc09u51TH2_szt_oamd8PtzA6rsrKDG0jqoR7xAkhzfsPg@mail.gmail.com> (raw)
In-Reply-To: <CAM_iQpXJr0p-scxr5GwOKrKHnZunP3pJP0YObSnCsfLPeMC44w@mail.gmail.com>

On Thu, Jan 17, 2019 at 10:07 AM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>
> On Thu, Jan 17, 2019 at 3:43 AM yupeng <yupeng0921@gmail.com> wrote:
> > diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h
> > index 86dc24a96c90..fb0a17337bf2 100644
> > --- a/include/uapi/linux/snmp.h
> > +++ b/include/uapi/linux/snmp.h
> > @@ -178,7 +178,6 @@ enum
> >         LINUX_MIB_ARPFILTER,                    /* ArpFilter */
> >         LINUX_MIB_TIMEWAITED,                   /* TimeWaited */
> >         LINUX_MIB_TIMEWAITRECYCLED,             /* TimeWaitRecycled */
> > -       LINUX_MIB_TIMEWAITKILLED,               /* TimeWaitKilled */
> >         LINUX_MIB_PAWSACTIVEREJECTED,           /* PAWSActiveRejected */
> >         LINUX_MIB_PAWSESTABREJECTED,            /* PAWSEstabRejected */
> >         LINUX_MIB_DELAYEDACKS,                  /* DelayedACKs */
>
> This is no way to go, it is breaking user-space.
>
> You should at least keep this definition even if this counter is unused.

From the snmp.h commit history, I didn't aware that we should keep the
user-space compatibility. For example, the commit 713bafea9292 removed
LINUX_MIB_TCPFACKREORDER, and the commit 4f693b55c3d2 inserted
LINUX_MIB_TCPBACKLOGCOALESCE to the middle of the linux mib
definitions enum. I think these commits would break the user-space
compatibility too. Did they use any method to avoid breaking the
user-space compatibility? Or if I misunderstand anything, please let
me know.

Thanks a lot.

  reply	other threads:[~2019-01-17 20:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17  8:18 [PATCH net-next] remove TWKilled counter yupeng
2019-01-17 18:07 ` Cong Wang
2019-01-17 20:26   ` peng yu [this message]
2019-01-21 23:14     ` peng yu
2019-01-23  6:58       ` Cong Wang
2019-01-28  7:35         ` peng yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAG3TDc09u51TH2_szt_oamd8PtzA6rsrKDG0jqoR7xAkhzfsPg@mail.gmail.com \
    --to=yupeng0921@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.