From: Robert Foss <robert.foss@linaro.org>
To: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
mchehab@kernel.org, hverkuil@xs4all.nl, jonathan@marek.ca,
andrey.konovalov@linaro.org, todor.too@gmail.com,
agross@kernel.org, bjorn.andersson@linaro.org, jgrahsl@snap.com,
hfink@snap.com, vladimir.zapolskiy@linaro.org,
dmitry.baryshkov@linaro.org
Subject: Re: [PATCH v2 6/8] media: camss: Set unused regulators to the empty set
Date: Mon, 10 Jan 2022 16:18:51 +0100 [thread overview]
Message-ID: <CAG3jFys62DcODLpQH9rOE3fCvMTqKsy4gZFP6nvvA-i3bT=tiA@mail.gmail.com> (raw)
In-Reply-To: <20220109024910.2041763-7-bryan.odonoghue@linaro.org>
On Sun, 9 Jan 2022 at 03:47, Bryan O'Donoghue
<bryan.odonoghue@linaro.org> wrote:
>
> If a CAMSS block has no regulator set the regulator array to the empty set
> as opposed to setting the first element of the array to NULL.
>
> Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> drivers/media/platform/qcom/camss/camss.c | 60 +++++++++++------------
> 1 file changed, 30 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 419c48c4f1d52..dcb37a739c95b 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -34,7 +34,7 @@
> static const struct resources csiphy_res_8x16[] = {
> /* CSIPHY0 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "top_ahb", "ispif_ahb", "ahb", "csiphy0_timer" },
> .clock_rate = { { 0 },
> { 0 },
> @@ -46,7 +46,7 @@ static const struct resources csiphy_res_8x16[] = {
>
> /* CSIPHY1 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "top_ahb", "ispif_ahb", "ahb", "csiphy1_timer" },
> .clock_rate = { { 0 },
> { 0 },
> @@ -107,7 +107,7 @@ static const struct resources_ispif ispif_res_8x16 = {
> static const struct resources vfe_res_8x16[] = {
> /* VFE0 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "top_ahb", "vfe0", "csi_vfe0",
> "vfe_ahb", "vfe_axi", "ahb" },
> .clock_rate = { { 0 },
> @@ -129,7 +129,7 @@ static const struct resources vfe_res_8x16[] = {
> static const struct resources csiphy_res_8x96[] = {
> /* CSIPHY0 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "top_ahb", "ispif_ahb", "ahb", "csiphy0_timer" },
> .clock_rate = { { 0 },
> { 0 },
> @@ -141,7 +141,7 @@ static const struct resources csiphy_res_8x96[] = {
>
> /* CSIPHY1 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "top_ahb", "ispif_ahb", "ahb", "csiphy1_timer" },
> .clock_rate = { { 0 },
> { 0 },
> @@ -153,7 +153,7 @@ static const struct resources csiphy_res_8x96[] = {
>
> /* CSIPHY2 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "top_ahb", "ispif_ahb", "ahb", "csiphy2_timer" },
> .clock_rate = { { 0 },
> { 0 },
> @@ -249,7 +249,7 @@ static const struct resources_ispif ispif_res_8x96 = {
> static const struct resources vfe_res_8x96[] = {
> /* VFE0 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "top_ahb", "ahb", "vfe0", "csi_vfe0", "vfe_ahb",
> "vfe0_ahb", "vfe_axi", "vfe0_stream"},
> .clock_rate = { { 0 },
> @@ -267,7 +267,7 @@ static const struct resources vfe_res_8x96[] = {
>
> /* VFE1 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "top_ahb", "ahb", "vfe1", "csi_vfe1", "vfe_ahb",
> "vfe1_ahb", "vfe_axi", "vfe1_stream"},
> .clock_rate = { { 0 },
> @@ -287,7 +287,7 @@ static const struct resources vfe_res_8x96[] = {
> static const struct resources csiphy_res_660[] = {
> /* CSIPHY0 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "top_ahb", "ispif_ahb", "ahb", "csiphy0_timer",
> "csi0_phy", "csiphy_ahb2crif" },
> .clock_rate = { { 0 },
> @@ -301,7 +301,7 @@ static const struct resources csiphy_res_660[] = {
>
> /* CSIPHY1 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "top_ahb", "ispif_ahb", "ahb", "csiphy1_timer",
> "csi1_phy", "csiphy_ahb2crif" },
> .clock_rate = { { 0 },
> @@ -315,7 +315,7 @@ static const struct resources csiphy_res_660[] = {
>
> /* CSIPHY2 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "top_ahb", "ispif_ahb", "ahb", "csiphy2_timer",
> "csi2_phy", "csiphy_ahb2crif" },
> .clock_rate = { { 0 },
> @@ -425,7 +425,7 @@ static const struct resources_ispif ispif_res_660 = {
> static const struct resources vfe_res_660[] = {
> /* VFE0 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "throttle_axi", "top_ahb", "ahb", "vfe0",
> "csi_vfe0", "vfe_ahb", "vfe0_ahb", "vfe_axi",
> "vfe0_stream"},
> @@ -446,7 +446,7 @@ static const struct resources vfe_res_660[] = {
>
> /* VFE1 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "throttle_axi", "top_ahb", "ahb", "vfe1",
> "csi_vfe1", "vfe_ahb", "vfe1_ahb", "vfe_axi",
> "vfe1_stream"},
> @@ -469,7 +469,7 @@ static const struct resources vfe_res_660[] = {
> static const struct resources csiphy_res_845[] = {
> /* CSIPHY0 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "camnoc_axi", "soc_ahb", "slow_ahb_src",
> "cpas_ahb", "cphy_rx_src", "csiphy0",
> "csiphy0_timer_src", "csiphy0_timer" },
> @@ -487,7 +487,7 @@ static const struct resources csiphy_res_845[] = {
>
> /* CSIPHY1 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "camnoc_axi", "soc_ahb", "slow_ahb_src",
> "cpas_ahb", "cphy_rx_src", "csiphy1",
> "csiphy1_timer_src", "csiphy1_timer" },
> @@ -505,7 +505,7 @@ static const struct resources csiphy_res_845[] = {
>
> /* CSIPHY2 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "camnoc_axi", "soc_ahb", "slow_ahb_src",
> "cpas_ahb", "cphy_rx_src", "csiphy2",
> "csiphy2_timer_src", "csiphy2_timer" },
> @@ -523,7 +523,7 @@ static const struct resources csiphy_res_845[] = {
>
> /* CSIPHY3 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "camnoc_axi", "soc_ahb", "slow_ahb_src",
> "cpas_ahb", "cphy_rx_src", "csiphy3",
> "csiphy3_timer_src", "csiphy3_timer" },
> @@ -605,7 +605,7 @@ static const struct resources csid_res_845[] = {
> static const struct resources vfe_res_845[] = {
> /* VFE0 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "camnoc_axi", "cpas_ahb", "slow_ahb_src",
> "soc_ahb", "vfe0", "vfe0_axi",
> "vfe0_src", "csi0",
> @@ -625,7 +625,7 @@ static const struct resources vfe_res_845[] = {
>
> /* VFE1 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "camnoc_axi", "cpas_ahb", "slow_ahb_src",
> "soc_ahb", "vfe1", "vfe1_axi",
> "vfe1_src", "csi1",
> @@ -645,7 +645,7 @@ static const struct resources vfe_res_845[] = {
>
> /* VFE-lite */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "camnoc_axi", "cpas_ahb", "slow_ahb_src",
> "soc_ahb", "vfe_lite",
> "vfe_lite_src", "csi2",
> @@ -666,7 +666,7 @@ static const struct resources vfe_res_845[] = {
> static const struct resources csiphy_res_8250[] = {
> /* CSIPHY0 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "csiphy0", "csiphy0_timer" },
> .clock_rate = { { 400000000 },
> { 300000000 } },
> @@ -675,7 +675,7 @@ static const struct resources csiphy_res_8250[] = {
> },
> /* CSIPHY1 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "csiphy1", "csiphy1_timer" },
> .clock_rate = { { 400000000 },
> { 300000000 } },
> @@ -684,7 +684,7 @@ static const struct resources csiphy_res_8250[] = {
> },
> /* CSIPHY2 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "csiphy2", "csiphy2_timer" },
> .clock_rate = { { 400000000 },
> { 300000000 } },
> @@ -693,7 +693,7 @@ static const struct resources csiphy_res_8250[] = {
> },
> /* CSIPHY3 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "csiphy3", "csiphy3_timer" },
> .clock_rate = { { 400000000 },
> { 300000000 } },
> @@ -702,7 +702,7 @@ static const struct resources csiphy_res_8250[] = {
> },
> /* CSIPHY4 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "csiphy4", "csiphy4_timer" },
> .clock_rate = { { 400000000 },
> { 300000000 } },
> @@ -711,7 +711,7 @@ static const struct resources csiphy_res_8250[] = {
> },
> /* CSIPHY5 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "csiphy5", "csiphy5_timer" },
> .clock_rate = { { 400000000 },
> { 300000000 } },
> @@ -772,7 +772,7 @@ static const struct resources csid_res_8250[] = {
> static const struct resources vfe_res_8250[] = {
> /* VFE0 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "camnoc_axi_src", "slow_ahb_src", "cpas_ahb",
> "camnoc_axi", "vfe0_ahb", "vfe0_areg", "vfe0",
> "vfe0_axi", "cam_hf_axi" },
> @@ -790,7 +790,7 @@ static const struct resources vfe_res_8250[] = {
> },
> /* VFE1 */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "camnoc_axi_src", "slow_ahb_src", "cpas_ahb",
> "camnoc_axi", "vfe1_ahb", "vfe1_areg", "vfe1",
> "vfe1_axi", "cam_hf_axi" },
> @@ -808,7 +808,7 @@ static const struct resources vfe_res_8250[] = {
> },
> /* VFE2 (lite) */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "camnoc_axi_src", "slow_ahb_src", "cpas_ahb",
> "camnoc_axi", "vfe_lite_ahb", "vfe_lite_axi",
> "vfe_lite", "cam_hf_axi" },
> @@ -825,7 +825,7 @@ static const struct resources vfe_res_8250[] = {
> },
> /* VFE3 (lite) */
> {
> - .regulators = { NULL },
> + .regulators = {},
> .clock = { "camnoc_axi_src", "slow_ahb_src", "cpas_ahb",
> "camnoc_axi", "vfe_lite_ahb", "vfe_lite_axi",
> "vfe_lite", "cam_hf_axi" },
> --
Thanks for the cleanup!
Reviewed-by: Robert Foss <robert.foss@linaro.org>
next prev parent reply other threads:[~2022-01-10 15:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 2:49 [PATCH v2 0/8] camss: Fixup multiple VDDA regulator support Bryan O'Donoghue
2022-01-09 2:49 ` [PATCH v2 1/8] media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845 Bryan O'Donoghue
2022-01-10 12:27 ` Robert Foss
2022-01-09 2:49 ` [PATCH v2 2/8] media: dt-bindings: media: camss: Add vdda supply declarations sm8250 Bryan O'Donoghue
2022-01-10 12:29 ` Robert Foss
2022-01-09 2:49 ` [PATCH v2 3/8] arm64: dts: qcom: sdm845: Rename camss vdda-supply to vdda-phy-supply Bryan O'Donoghue
2022-01-10 12:30 ` Robert Foss
2022-01-09 2:49 ` [PATCH v2 4/8] arm64: dts: qcom: sdm845: Add camss vdda-pll-supply Bryan O'Donoghue
2022-01-10 14:45 ` Robert Foss
2022-01-09 2:49 ` [PATCH v2 5/8] media: camss: Add regulator_bulk support Bryan O'Donoghue
2022-01-10 15:17 ` Robert Foss
2022-01-11 11:20 ` Bryan O'Donoghue
[not found] ` <CAG3jFyuVxjUtBgCyNyREsZPP8jucSOvE1uYevavkPQduGSHKWQ@mail.gmail.com>
2022-01-11 11:40 ` Bryan O'Donoghue
2022-01-09 2:49 ` [PATCH v2 6/8] media: camss: Set unused regulators to the empty set Bryan O'Donoghue
2022-01-10 15:18 ` Robert Foss [this message]
2022-01-09 2:49 ` [PATCH v2 7/8] media: camss: Point sdm845 at the correct vdda regulators Bryan O'Donoghue
2022-01-10 15:19 ` Robert Foss
2022-01-09 2:49 ` [PATCH v2 8/8] media: camss: Point sm8250 " Bryan O'Donoghue
2022-01-10 15:20 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG3jFys62DcODLpQH9rOE3fCvMTqKsy4gZFP6nvvA-i3bT=tiA@mail.gmail.com' \
--to=robert.foss@linaro.org \
--cc=agross@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=hfink@snap.com \
--cc=hverkuil@xs4all.nl \
--cc=jgrahsl@snap.com \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.