From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAAEEC433ED for ; Fri, 9 Apr 2021 09:09:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C031C610F9 for ; Fri, 9 Apr 2021 09:09:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232846AbhDIJKA (ORCPT ); Fri, 9 Apr 2021 05:10:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232849AbhDIJJ6 (ORCPT ); Fri, 9 Apr 2021 05:09:58 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E654C061760 for ; Fri, 9 Apr 2021 02:09:45 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id i190so3802577pfc.12 for ; Fri, 09 Apr 2021 02:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iusrLEQTcxgLuvY/s0WkjYKt6ZUUkpVNI9Zo6gJ/N30=; b=O68a/KcucQSDWDD8wQ8Bj7qwbYXGgI5K8GIfKDi/vzuxYUsWXolfybaD7vIepwgiL8 isBDlJDctz40NQAXetLu9AqpAZDNRd9I1Tzp/9Sngtwbkd9Ed91rAA/aDDhqTZdx6sdL dhz2eLVHMxVH7wexEeN2HD2ibws2yZUvywaOFf9Jv9hRVRVR/WUUJmQuLw4KDmnI7Wu2 3spjaG0TCsWaZghBZz4NYwqkvDZCyI8LBK9luQytEEyCjWzC+PawPdF2J3utBQC4ERpV g2rMl0UIHEgUjqBE67Yg2tWoGeeTlqH2Yg1MaPTPw7djDZp2OntPrPSVknFQEt6lWitw vvCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iusrLEQTcxgLuvY/s0WkjYKt6ZUUkpVNI9Zo6gJ/N30=; b=ElvemIDUJRV4iPht/FWVxxLxqDJWU5OKMozEhWAdReIeBDrCWZjG6MEzLJHw/VXwax pdz5PwVGXMn2cy71ObExaeoW6S5FwKKgoSrba8WiYKXmtPKFzgFL1Jjsw2FnpM2rtcMs +3dzybxQNAt2u7Jr9jXY8fYaNY7QDcTjHIFP3Y7dEYlBiC1bt0zYjFLH4aMMLpbFDEKs maVEsZE95MrXyZcv8ef9nBP6cKK+4MydI0OHUFVlrkpmZ/KVFJpYP1ujGXr9qs0ATWkG rfNzZLO1F1O3vzduNIcq7lRFjr/9IoMRFPi5DN7sW6oPmSXV77OCFG23qT4Igf78UQR0 y5MQ== X-Gm-Message-State: AOAM531i90WxXCkm9/4DyuxfUr3pMF4ghImARFVVOubrEwqHrqIMnC2X mLpj/XS+AAIF6mu/ah2uDyzGsC1qkU7iMcqnAq1O0A4swvQ= X-Google-Smtp-Source: ABdhPJySq0thaQ409aIwg7KoCsn0wQzLlCiRV4ucUUW/t4VGrL8F7fn5WoPqBBSm85sIMioSg2m+itTcl+faCguh75A= X-Received: by 2002:aa7:98c9:0:b029:242:18fc:562d with SMTP id e9-20020aa798c90000b029024218fc562dmr11196723pfm.39.1617959385055; Fri, 09 Apr 2021 02:09:45 -0700 (PDT) MIME-Version: 1.0 References: <20210409050633.671223-1-yangyingliang@huawei.com> In-Reply-To: <20210409050633.671223-1-yangyingliang@huawei.com> From: Robert Foss Date: Fri, 9 Apr 2021 11:09:34 +0200 Message-ID: Subject: Re: [PATCH -next] media: camss: ispif: Remove redundant dev_err call in msm_ispif_subdev_init() To: Yang Yingliang Cc: linux-kernel , linux-media , MSM , Todor Tomov , Mauro Carvalho Chehab Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Yang, Thanks for the patch. On Fri, 9 Apr 2021 at 07:03, Yang Yingliang wrote: > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > drivers/media/platform/qcom/camss/camss-ispif.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c > index a30e453de162..37611c8861da 100644 > --- a/drivers/media/platform/qcom/camss/camss-ispif.c > +++ b/drivers/media/platform/qcom/camss/camss-ispif.c > @@ -1145,17 +1145,13 @@ int msm_ispif_subdev_init(struct camss *camss, > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]); > ispif->base = devm_ioremap_resource(dev, r); > - if (IS_ERR(ispif->base)) { > - dev_err(dev, "could not map memory\n"); > + if (IS_ERR(ispif->base)) > return PTR_ERR(ispif->base); > - } > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[1]); > ispif->base_clk_mux = devm_ioremap_resource(dev, r); > - if (IS_ERR(ispif->base_clk_mux)) { > - dev_err(dev, "could not map memory\n"); > + if (IS_ERR(ispif->base_clk_mux)) > return PTR_ERR(ispif->base_clk_mux); > - } > > /* Interrupt */ > Reviewed-by: Robert Foss