From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E91E3C433E0 for ; Thu, 18 Feb 2021 21:27:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E53964E3E for ; Thu, 18 Feb 2021 21:27:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229998AbhBRV1R (ORCPT ); Thu, 18 Feb 2021 16:27:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbhBRV1K (ORCPT ); Thu, 18 Feb 2021 16:27:10 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA22AC061574 for ; Thu, 18 Feb 2021 13:26:29 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id d15so1975552plh.4 for ; Thu, 18 Feb 2021 13:26:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=oNyAn/AnPC4iuqUuUhezP2WthkTdDgyXgEbVE+w3W0E=; b=cGxMdhiYysYNhlZoX6BPmJI+3SZheGtCeHQnHBF+0/TBo7gS1bITYoP1X60Y3tFDSj r82wuImZ+qkKl8czN0A8PO1NrHgxHPt0OW7Wn7MCVUJOuDlbcfo9ArNNo3K9oYfV+Yxk UL+OkQV6cCbVyr3HaAa8t32CssDIetFYKGSc4zHAVcVb1+TW/nC3j+O4xBrGIShlQKqL G7WtsgqVw2SItZXAPoGgEc5VKc8Uui1sDXyExVt3Cab4vziQ59EF1lMB2acukTOHwpfB fMvHzOS2DxWjQOz82pqEez/PasLzOP4MW7xqwB1xM+Segug0BygTQMJX1kOqHug2XSp7 xycw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=oNyAn/AnPC4iuqUuUhezP2WthkTdDgyXgEbVE+w3W0E=; b=h0IhtaSczfGd7qWFbPWNGNRS8rVzthKo60nvVKOWa/c2QUlH8CTmz1jUm17VauSqTg ZdWGRniVFa9XCKRfycK4562Q3NA2QHzL3fFMKSFyr/orHoYhBwPr+FZMqDLi65muFB8e hJbZmiA57SOGmMn9XeNyOKK6AC21M4sflIeAys1M4/+uBrHWaDAbjSjOqsEbI6zRoKAs YinRJWuulkUuCppqLvEONiGXL5Bzl+cIo/Zu79IBcxC1K09aweMAwN2oTcrLwbPs140P KKgKhn7mdMDDKqGaAkQBygl2oyNeyrvhEf8ddv5RyUFKySMr10sUxYRONvWHfrONphY9 v2Rg== X-Gm-Message-State: AOAM530UbQNfcQ5fzhAlmrXsGP925BB+b5KR8HRWXCWECqhYrFrWOswI bl2H65riuEHGLBhNDYYNseUFOpl0NqHxIJvX8+BvNQ== X-Google-Smtp-Source: ABdhPJyX9OOn/n/HGoFwwGZcEQUgk1OlP/45uBiDXmES3JzZrftKAA7oGEcHSya2SnlsnkFd8dMrk0rNqd00Q6E58No= X-Received: by 2002:a17:90a:70c1:: with SMTP id a1mr5885676pjm.19.1613683589132; Thu, 18 Feb 2021 13:26:29 -0800 (PST) MIME-Version: 1.0 References: <20210214232904.1142706-1-adrien.grassein@gmail.com> <20210214232904.1142706-3-adrien.grassein@gmail.com> In-Reply-To: From: Robert Foss Date: Thu, 18 Feb 2021 22:26:17 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge To: Adrien Grassein Cc: David Airlie , Daniel Vetter , Andrzej Hajda , Rob Herring , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Feb 2021 at 21:36, Adrien Grassein w= rote: > > Hey Robert, > > Thank you for your time and for your review. > > Le mer. 17 f=C3=A9vr. 2021 =C3=A0 18:32, Robert Foss a =C3=A9crit : > > > > Hey Adrien, > > > > Thanks for submitting this! > > > > On Mon, 15 Feb 2021 at 00:31, Adrien Grassein wrote: > > > > > > Lontium Lt8912 is a DSI to HDMI bridge. > > > > > > Signed-off-by: Adrien Grassein > > > --- > > > MAINTAINERS | 1 + > > > drivers/gpu/drm/bridge/Kconfig | 14 + > > > drivers/gpu/drm/bridge/Makefile | 1 + > > > drivers/gpu/drm/bridge/lontium-lt8912.c | 719 ++++++++++++++++++++++= ++ > > > 4 files changed, 735 insertions(+) > > > create mode 100644 drivers/gpu/drm/bridge/lontium-lt8912.c > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index f010b485aa7c..8b3d64b689c7 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -10444,6 +10444,7 @@ LONTIUM LT8912 MIPI TO HDMI BRIDGE > > > M: Adrien Grassein > > > S: Maintained > > > F: Documentation/devicetree/bindings/display/bridge/lontium,lt89= 12.yaml > > > +F: drivers/gpu/drm/bridge/lontium-lt8912.c > > > > > > LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI) > > > M: Sathya Prakash > > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/= Kconfig > > > index e4110d6ca7b3..5b36d4b86e3c 100644 > > > --- a/drivers/gpu/drm/bridge/Kconfig > > > +++ b/drivers/gpu/drm/bridge/Kconfig > > > @@ -48,6 +48,20 @@ config DRM_DISPLAY_CONNECTOR > > > on ARM-based platforms. Saying Y here when this driver is n= ot needed > > > will not cause any issue. > > > > > > +config DRM_LONTIUM_LT8912 > > > + tristate "Lontium LT8912 DSI/HDMI bridge" > > > + depends on OF > > > + select DRM_PANEL_BRIDGE > > > + select DRM_KMS_HELPER > > > + select REGMAP_I2C > > > + help > > > + Driver for Lontium LT8912 DSI to HDMI bridge > > > + chip driver. > > > + Please say Y if you have such hardware. > > > + > > > + Say M here if you want to support this hardware as a module= . > > > + The module will be named "lontium-lt8912". > > > + > > > config DRM_LONTIUM_LT9611 > > > tristate "Lontium LT9611 DSI/HDMI bridge" > > > select SND_SOC_HDMI_CODEC if SND_SOC > > > diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge= /Makefile > > > index 86e7acc76f8d..5a1b201cea1f 100644 > > > --- a/drivers/gpu/drm/bridge/Makefile > > > +++ b/drivers/gpu/drm/bridge/Makefile > > > @@ -2,6 +2,7 @@ > > > obj-$(CONFIG_DRM_CDNS_DSI) +=3D cdns-dsi.o > > > obj-$(CONFIG_DRM_CHRONTEL_CH7033) +=3D chrontel-ch7033.o > > > obj-$(CONFIG_DRM_DISPLAY_CONNECTOR) +=3D display-connector.o > > > +obj-$(CONFIG_DRM_LONTIUM_LT8912) +=3D lontium-lt8912.o > > > obj-$(CONFIG_DRM_LONTIUM_LT9611) +=3D lontium-lt9611.o > > > obj-$(CONFIG_DRM_LONTIUM_LT9611UXC) +=3D lontium-lt9611uxc.o > > > obj-$(CONFIG_DRM_LVDS_CODEC) +=3D lvds-codec.o > > > diff --git a/drivers/gpu/drm/bridge/lontium-lt8912.c b/drivers/gpu/dr= m/bridge/lontium-lt8912.c > > > new file mode 100644 > > > index 000000000000..d713d3365c3e > > > --- /dev/null > > > +++ b/drivers/gpu/drm/bridge/lontium-lt8912.c > > > @@ -0,0 +1,719 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright (c) 2018, The Linux Foundation. All rights reserved. > > > + */ > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +#include