From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03D6EC433F5 for ; Mon, 17 Jan 2022 15:42:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240583AbiAQPml (ORCPT ); Mon, 17 Jan 2022 10:42:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240590AbiAQPmk (ORCPT ); Mon, 17 Jan 2022 10:42:40 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CCF5C061574 for ; Mon, 17 Jan 2022 07:42:40 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id p37so10521493pfh.4 for ; Mon, 17 Jan 2022 07:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mBse3TDhMT3P1QzjpmTykdxb+O3mXQF8X49QrJGnK9w=; b=LZTP5w65jwgoJGxqEXUMQBhGqnjlbTs84KuPFBpRzYEx0DwsSeJeLBikEqHqkrSW9g VSpBlg/Cogu47PGexznErP70Sr0aY7rxPv5bhtOLPGVsqRDI4CQFxo1/MTfyCWUNYQew UWHrktQHee2IMNUM2nvKprXbyMXe4Dc7lflFtBpUDqWW4OCum5RU2Vk0pHf0sT1wfHM3 Usl/QhE1XVbcgXSbXL4IM9B7aEqPuZb8f+SzqBwnNiSi30/ryHWQKDvGlHZkLWhH/5XB aWjmgRDVAn8TCiUosMZQNjwfgAG8+SC0xnypzhxkf6TIGcn3v5jCcBjJ4vCGsBaOrrjt gKhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mBse3TDhMT3P1QzjpmTykdxb+O3mXQF8X49QrJGnK9w=; b=OxRCxDju38NdcgV/zIBhFtVic6JVdFB04tYV9KrifXUwD2RVc1d38ELYlPTCuCaC4i VfrcDyfzUMu1z2ncr9uIOaZvfmBS+gm9OGUWx0WWLhwEaouSsIzbbDPGku7WEWvQKyuY f5DqyRIJ2+orX9fIr5tw/IVaw/3nJLYBqANnP7Kc1L4PO6bu7P220xEpyTalauk1tLB5 ++vCziq7KmJCPOS2nz1eUglIkh9l4Y8ctzem7T5ROc3H9tfNIs8F5iRx9Y6Es4jorj19 F3keGZrsE8TN5WO/SUl++4j8nV9CuuKu5BFHhgwWnoLFPIQwsQcfj6N7dUNad++J3F8d 4PVA== X-Gm-Message-State: AOAM530Np1vorCIDtKmuFoyeX2C12N+Hxneoqv60zvh6CpkdqyusT6ln ujRX11c2IdhLDXDrUmcEGOaIW8g6XRFf0CVvsvm1eA== X-Google-Smtp-Source: ABdhPJyK+mJqd8HpVnnFKs335VNzfb1ZQwWiuJ4tIjAYkUGYjihDvc47IddIXGdc5+gkomCMF5P6xqqjbwDuvvVxMCk= X-Received: by 2002:a63:2b03:: with SMTP id r3mr19439606pgr.201.1642434159652; Mon, 17 Jan 2022 07:42:39 -0800 (PST) MIME-Version: 1.0 References: <20220117100949.9542-1-qwt9588@gamil.com> In-Reply-To: <20220117100949.9542-1-qwt9588@gamil.com> From: Robert Foss Date: Mon, 17 Jan 2022 16:42:28 +0100 Message-ID: Subject: Re: [PATCH v5] drm/bridge: anx7625: Return -EPROBE_DEFER if the dsi host was not found To: owen Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Xin Ji , Sam Ravnborg , Pi-Hsun Shih , Tzung-Bi Shih , Hsin-Yi Wang , Maxime Ripard , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Owen On Mon, 17 Jan 2022 at 11:10, owen wrote: > > From: owen > > It will connect to the mipi dsi host and find the corresponding > mipi dsi host node, but the node registered by the mipi dsi host > has not been loaded yet. of_find_mipi_dsi_host_by_node() returns -EINVAL > which causes the calling driver to fail. > > If the anx7625 driver is loaded afterwards the driver requesting > the mipi dsi host will not notice this. > > Better approach is to return -EPROBE_DEFER in such case. > Then when the anx7625 driver appears the driver requesting > the mipi dsi host will be probed again. > > Signed-off-by: owen > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 2346dbcc505f..297bbeb5aae0 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -1660,7 +1660,7 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx) > host = of_find_mipi_dsi_host_by_node(ctx->pdata.mipi_host_node); > if (!host) { > DRM_DEV_ERROR(dev, "fail to find dsi host.\n"); > - return -EINVAL; > + return -EPROBE_DEFER; > } > > dsi = devm_mipi_dsi_device_register_full(dev, host, &info); > -- > 2.31.0 > Reviewed-by: Robert Foss Applied to drm-misc-next. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2425EC433EF for ; Mon, 17 Jan 2022 15:42:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F48110E3C6; Mon, 17 Jan 2022 15:42:42 +0000 (UTC) Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5AACA10E3BC for ; Mon, 17 Jan 2022 15:42:40 +0000 (UTC) Received: by mail-pf1-x431.google.com with SMTP id a5so10515836pfo.5 for ; Mon, 17 Jan 2022 07:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mBse3TDhMT3P1QzjpmTykdxb+O3mXQF8X49QrJGnK9w=; b=LZTP5w65jwgoJGxqEXUMQBhGqnjlbTs84KuPFBpRzYEx0DwsSeJeLBikEqHqkrSW9g VSpBlg/Cogu47PGexznErP70Sr0aY7rxPv5bhtOLPGVsqRDI4CQFxo1/MTfyCWUNYQew UWHrktQHee2IMNUM2nvKprXbyMXe4Dc7lflFtBpUDqWW4OCum5RU2Vk0pHf0sT1wfHM3 Usl/QhE1XVbcgXSbXL4IM9B7aEqPuZb8f+SzqBwnNiSi30/ryHWQKDvGlHZkLWhH/5XB aWjmgRDVAn8TCiUosMZQNjwfgAG8+SC0xnypzhxkf6TIGcn3v5jCcBjJ4vCGsBaOrrjt gKhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mBse3TDhMT3P1QzjpmTykdxb+O3mXQF8X49QrJGnK9w=; b=PsNcemQxXwTx8CSNxDMYgtOoUTDNF1K1tjrH2QICA41ab+6nwQyhov5JP93zi9eQ5t VR/TyRg+S9zzav4o68Yfg4BICl7GcZLGKVvJmF+91SE79YNjXQnLtcA+3kLeL95rzYlv B1qiE3YY5171CIc5fVJWg4sJsoOEXZPKTJKXc1IiS3cgDfKNXTzUFSRhaALfzj4ANP7A 4pjL1fQZUsq0+tgo7WXIjH2oetMgXwWvOhPMvCU0/AtOZ6l8DEoyDUXFm2jAgrZV4e/k BfsGeZmzbbCZBw+cZIqL8PaIOOTxqgvfBq1ZyNpZGr71msZh5GDFiU16NdlNiqTCgq4+ A4aw== X-Gm-Message-State: AOAM532urzfCYdzGjbGuykKzbQ83/v3/G5VtBJer1Z9aG/DWD5dm1qpG tl6EWleBFHOuSa7vN4BvFecFsJj0dezpBBalZT9uFw== X-Google-Smtp-Source: ABdhPJyK+mJqd8HpVnnFKs335VNzfb1ZQwWiuJ4tIjAYkUGYjihDvc47IddIXGdc5+gkomCMF5P6xqqjbwDuvvVxMCk= X-Received: by 2002:a63:2b03:: with SMTP id r3mr19439606pgr.201.1642434159652; Mon, 17 Jan 2022 07:42:39 -0800 (PST) MIME-Version: 1.0 References: <20220117100949.9542-1-qwt9588@gamil.com> In-Reply-To: <20220117100949.9542-1-qwt9588@gamil.com> From: Robert Foss Date: Mon, 17 Jan 2022 16:42:28 +0100 Message-ID: Subject: Re: [PATCH v5] drm/bridge: anx7625: Return -EPROBE_DEFER if the dsi host was not found To: owen Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonas Karlman , David Airlie , dri-devel@lists.freedesktop.org, Neil Armstrong , linux-kernel@vger.kernel.org, Jernej Skrabec , Tzung-Bi Shih , Pi-Hsun Shih , Laurent Pinchart , Andrzej Hajda , Hsin-Yi Wang , Sam Ravnborg , Xin Ji , Maxime Ripard Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Owen On Mon, 17 Jan 2022 at 11:10, owen wrote: > > From: owen > > It will connect to the mipi dsi host and find the corresponding > mipi dsi host node, but the node registered by the mipi dsi host > has not been loaded yet. of_find_mipi_dsi_host_by_node() returns -EINVAL > which causes the calling driver to fail. > > If the anx7625 driver is loaded afterwards the driver requesting > the mipi dsi host will not notice this. > > Better approach is to return -EPROBE_DEFER in such case. > Then when the anx7625 driver appears the driver requesting > the mipi dsi host will be probed again. > > Signed-off-by: owen > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 2346dbcc505f..297bbeb5aae0 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -1660,7 +1660,7 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx) > host = of_find_mipi_dsi_host_by_node(ctx->pdata.mipi_host_node); > if (!host) { > DRM_DEV_ERROR(dev, "fail to find dsi host.\n"); > - return -EINVAL; > + return -EPROBE_DEFER; > } > > dsi = devm_mipi_dsi_device_register_full(dev, host, &info); > -- > 2.31.0 > Reviewed-by: Robert Foss Applied to drm-misc-next.