From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A812C433EF for ; Thu, 31 Mar 2022 15:32:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B227810F3D5; Thu, 31 Mar 2022 15:32:52 +0000 (UTC) Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7236B10E5BE for ; Thu, 31 Mar 2022 15:32:51 +0000 (UTC) Received: by mail-pj1-x1036.google.com with SMTP id d30so7293920pjk.0 for ; Thu, 31 Mar 2022 08:32:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X+GiopADefA1BaJrzW9es7QuBGeiI8EEqu490H7xG4c=; b=CldvduOqPPcI2vdCC7IWVnGyT3KROxQKSz/tTQsNTBqn0X2dc5oXD6D9hGSwHH1WKU G18IJmR639fAF82xy/UeQ9HpUoC1ruwfWbHdiFbxtiKc+jNuD8C5a6sSH43krUczsyq2 wm738vTZpgwtltofg2UxCiFo7MxZrZrB9SKYpMIpGBfemmvCoi0Mr8ZYGU7ahOOER4Sc 6FBixz1RUx6ZQP9izsfsVDZ2mHe/2DQSN7WmjBh2fyRbSroF7B6Q9eZdxg5oFVTkb545 f8OmYZ3+3mu8WG9psZ/DbIahVRNztesplniu44HHFmWkhgNHaFXAza9NSECMe5MK8rHJ EshQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X+GiopADefA1BaJrzW9es7QuBGeiI8EEqu490H7xG4c=; b=mhFUkW7kmOO9at3dT/jGfzABkhNgQc+P5ud9zOZJoUqZY84G/KhDckuh6g9bqyvf2u 5ZfqpupXl0tBR3qCKFBcwGPEBn9v1VF1gd6cwr49tUyzj72ecXb3vYi8MWaUOPt9WSVr pn446Qh/rY4vWrdWng9m+x9xtok0TN9ymPSdwGcs59VQcxwBbbSgOq5Da0WYhw15kyDh D+N1WN/gyq4COv3nG492axvtC4mU2+ln9AbRyhEiGZ5q9RM1SRUbY1afHUWEe/cCTqJW tVOwXyChscZC8s3IGnIVdnhK5OZKxNh5PG4wMAISqxJZ7mmd1Q+RO8E2WyKEg4z05Y4Q plZg== X-Gm-Message-State: AOAM5323IqRv0aMjScJ4WFuhMZxN5ZhFE1VVKug2EMa0+saL5QEH69+M chlDwL6V24r+EuZKGtqEF29IAPxXXK/FUud0UyVSIhRLHy0= X-Google-Smtp-Source: ABdhPJxjV8h7+CSqnsxGZEfU7wWE4l6F95HSGlanpIcE1wyRoZWfZyKED+Lefu3A3uyNeU16DDvyw2/Rc3lzl+ypKlE= X-Received: by 2002:a17:90b:3e85:b0:1c7:7eab:2649 with SMTP id rj5-20020a17090b3e8500b001c77eab2649mr6772372pjb.232.1648740771080; Thu, 31 Mar 2022 08:32:51 -0700 (PDT) MIME-Version: 1.0 References: <20220213022648.495895-1-marex@denx.de> In-Reply-To: From: Robert Foss Date: Thu, 31 Mar 2022 17:32:40 +0200 Message-ID: Subject: Re: [PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge To: Marek Vasut Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sam Ravnborg , Jagan Teki , dri-devel@lists.freedesktop.org, Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 31 Mar 2022 at 17:32, Robert Foss wrote: > > On Sun, 13 Feb 2022 at 03:27, Marek Vasut wrote: > > > > In rare cases, the bridge may not start up correctly, which usually > > leads to no display output. In case this happens, warn about it in > > the kernel log. > > > > Signed-off-by: Marek Vasut > > Cc: Jagan Teki > > Cc: Laurent Pinchart > > Cc: Linus Walleij > > Cc: Robert Foss > > Cc: Sam Ravnborg > > Cc: dri-devel@lists.freedesktop.org > > --- > > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > > index 19daaddd29a41..1d7c154ea1d79 100644 > > --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c > > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > > @@ -488,6 +488,11 @@ static void sn65dsi83_atomic_enable(struct drm_bridge *bridge, > > /* Clear all errors that got asserted during initialization. */ > > regmap_read(ctx->regmap, REG_IRQ_STAT, &pval); > > regmap_write(ctx->regmap, REG_IRQ_STAT, pval); > > + > > + usleep_range(10000, 12000); > > + regmap_read(ctx->regmap, REG_IRQ_STAT, &pval); > > + if (pval) > > + dev_err(ctx->dev, "Unexpected link status 0x%02x\n", pval); > > } > > > > static void sn65dsi83_atomic_disable(struct drm_bridge *bridge, > > -- > > 2.34.1 > > > > Reviewed-by: Robert Foss Applied to drm-misc-next.