From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3317DC433FE for ; Wed, 9 Dec 2020 10:56:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECE0F233EA for ; Wed, 9 Dec 2020 10:56:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730255AbgLIKz4 (ORCPT ); Wed, 9 Dec 2020 05:55:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730248AbgLIKz4 (ORCPT ); Wed, 9 Dec 2020 05:55:56 -0500 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 084FEC0613D6 for ; Wed, 9 Dec 2020 02:55:16 -0800 (PST) Received: by mail-pj1-x1041.google.com with SMTP id f14so666800pju.4 for ; Wed, 09 Dec 2020 02:55:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G5Q1tNH2c9CiPB2apafl9nqbMwDpY3uolU0PxNGFQB8=; b=O9WnD6NstpZXgrdiAigsFEFowQDxAJEw91fmZ1n3XytM2JrWVng1jqbZheqmayrqEV 0zVt4BM9fi1ieOOsiXzwmZdGnb4IdNgNHWoTbQT6jCsPNQ72opVaJtnc/iZQo14TXSrG VI0zYbD/IqCpq6k2qqo3JXHlTqrDNqXEtSCfhJhFhRxBO+zqX8I4TjFRPmPAHltQ2m7L mOEMnS6L/xfgqqOZkbOMhsf3LpszlWAqpzIDCaKD633h8ZU4YLmwUIpOsjlG7EgiCWcT VvQoJDMTez4YZXZYaSppoH+3JvhCQk3YJcmxaoBDzyqqu7yc4tVr+yAvkh8a2ea7XSyc JGpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G5Q1tNH2c9CiPB2apafl9nqbMwDpY3uolU0PxNGFQB8=; b=VxelajFBoXNuhWkHPF9LOUio1k2L7dAt0kSxb2CDZGcucUCqcdAfFgeRIuvIX7vPEu gXgYrguRsIFXg7LCFYnD3iWb9YxuHfFQNQy85nHOao6YVKdt37enuLiV49eICMbcwK/a Rb9hoxstmrTrEoh6UpwrWeMyUszqaviI7f0YqPYcL2QEVcSOGADJmlu15oGQCtw1GpRc dHxPNeHR1a7G78/zksKlteZBhJN5BIJL09yEo02/nvaECNHsifrG/xceX7wlON1YMOWC kQQBUp0i9p6Qm10gbjl2NYEhuQ+RQ9Wnuh9Xq6p2nl77cC7xR6M/oOO4ECFwGL4keB4z cuiw== X-Gm-Message-State: AOAM530ZUE3I/TJezg5X66JzRQEgPbEJbi9duUXaiyDFmZjyTLExM1AK a1Q0dRI6UI8HQN7tsA49T1w7VCKckjC2Sh8e0wc0hA== X-Google-Smtp-Source: ABdhPJxFPeseVjkwy63QtJO6iqkBaHXOXZ1XzbocSgDUEtOEMnhi2DUbCtaCYn+G4bUnxVVfpzhb/YdMrkxqdO5b7HI= X-Received: by 2002:a17:90a:ab0f:: with SMTP id m15mr1635305pjq.222.1607511315508; Wed, 09 Dec 2020 02:55:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Robert Foss Date: Wed, 9 Dec 2020 11:55:02 +0100 Message-ID: Subject: Re: [PATCH 1/2] media: camss: Fix signedness bug in video_enum_fmt() To: Dan Carpenter Cc: Andrey Konovalov , Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Hans Verkuil , linux-media , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hey Dan, Thank you for submitting this. Reviewed-by: Robert Foss On Wed, 9 Dec 2020 at 07:50, Dan Carpenter wrote: > > This test has a problem because we want to know if "k" is -1 or a > positive value less than "f->index". But the "f->index" variable is a > u32 so if "k == -1" then -1 gets type promoted to UINT_MAX which is > larger than "f->index". I've added an explicit test to check for -1. > > Fixes: a3d412d4b9f3 ("media: Revert "media: camss: Make use of V4L2_CAP_IO_MC"") > Signed-off-by: Dan Carpenter > --- > I could equally well have casted "k < (int)f->index" but I feel like > this is more explicit and readable. > > drivers/media/platform/qcom/camss/camss-video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-video.c b/drivers/media/platform/qcom/camss/camss-video.c > index bd9334af1c73..2fa3214775d5 100644 > --- a/drivers/media/platform/qcom/camss/camss-video.c > +++ b/drivers/media/platform/qcom/camss/camss-video.c > @@ -579,7 +579,7 @@ static int video_enum_fmt(struct file *file, void *fh, struct v4l2_fmtdesc *f) > break; > } > > - if (k < f->index) > + if (k == -1 || k < f->index) > /* > * All the unique pixel formats matching the arguments > * have been enumerated (k >= 0 and f->index > 0), or > -- > 2.29.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Foss Date: Wed, 09 Dec 2020 10:55:02 +0000 Subject: Re: [PATCH 1/2] media: camss: Fix signedness bug in video_enum_fmt() Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Andrey Konovalov , Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Hans Verkuil , linux-media , kernel-janitors@vger.kernel.org Hey Dan, Thank you for submitting this. Reviewed-by: Robert Foss On Wed, 9 Dec 2020 at 07:50, Dan Carpenter wrote: > > This test has a problem because we want to know if "k" is -1 or a > positive value less than "f->index". But the "f->index" variable is a > u32 so if "k = -1" then -1 gets type promoted to UINT_MAX which is > larger than "f->index". I've added an explicit test to check for -1. > > Fixes: a3d412d4b9f3 ("media: Revert "media: camss: Make use of V4L2_CAP_IO_MC"") > Signed-off-by: Dan Carpenter > --- > I could equally well have casted "k < (int)f->index" but I feel like > this is more explicit and readable. > > drivers/media/platform/qcom/camss/camss-video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-video.c b/drivers/media/platform/qcom/camss/camss-video.c > index bd9334af1c73..2fa3214775d5 100644 > --- a/drivers/media/platform/qcom/camss/camss-video.c > +++ b/drivers/media/platform/qcom/camss/camss-video.c > @@ -579,7 +579,7 @@ static int video_enum_fmt(struct file *file, void *fh, struct v4l2_fmtdesc *f) > break; > } > > - if (k < f->index) > + if (k = -1 || k < f->index) > /* > * All the unique pixel formats matching the arguments > * have been enumerated (k >= 0 and f->index > 0), or > -- > 2.29.2 >