From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4983C433ED for ; Tue, 6 Apr 2021 08:31:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8778C613BE for ; Tue, 6 Apr 2021 08:31:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233206AbhDFIbT (ORCPT ); Tue, 6 Apr 2021 04:31:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230337AbhDFIbS (ORCPT ); Tue, 6 Apr 2021 04:31:18 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3C7CC06174A for ; Tue, 6 Apr 2021 01:31:09 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id h8so7068918plt.7 for ; Tue, 06 Apr 2021 01:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gm4kCiogAkI78+mLUObZxBjBM0j57F/TvToNpIy9z3Y=; b=eINOdpHbzO+V37M3z/6K96WyaV4Vh4kXYW8GpHJ+hlaOK4AUS8lpl6jjGj43x434TK 1GdMHmDq+AMUdl6gkP9GOYsH194Yz7qvkvS+f8ZLBo9fhn0GzoKlzWGM9lvQwLWfAWrM jAAaDj1StPuQ0pO+oVwuM7IEuTKlPGd+vuIogf7ZeSsHBR5tpTBgOF0zKc6J+vyACJUQ cu6W4Me/6V2Y/YD7lwpM0+mXP/hWn1iDFiLnUsHJNb0Lfxw7dE7q6/IeJ/uNRv4i578o c/mFtMjtk+Sta1rjSb5ySISVwSGRcOV9+5YvNLji82zIDNhFZrfslyrQb7ps3Xu+aNmC IoPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gm4kCiogAkI78+mLUObZxBjBM0j57F/TvToNpIy9z3Y=; b=ZK5ovEIFLCm/K4BXaAF+bdCvkYCna1aN4jw110l2JMtfmhls9/rwqyftzLdo5bmi80 leB5Y6KeixvNGG/daud5OnAmGXLcUgHOXOJ8xHiBBa0M/mGYdaM0ns3jLdPGHKvAsfBK 9rfjp/+iVLjnQObHNkxayax/jUZDIG42hWPZIwP6qh1SsSrP+7zILYC/oH8KzYne+tso xlUzzEtLvAaT6nYhw+TA9WLgzJA1qwiqZbkZLsTF9Ye6LaN0SzDnzp/tTW/AQMuKsFA1 ne019zOqiqylOe4JjQKMRC+ydbGTLNyRxyXc1XHa1ttquoSnHN/Wajzds72GPH8NKb84 tChQ== X-Gm-Message-State: AOAM5338q7rtkp86TdZ618taw2Q1tWXnpfW7y1TWRJp7z3GOFV0hxHJ7 FpkKY4ZvoauAskM9AWBp+ojDh4+b3eOpsAIWh9XF43DkPTQ= X-Google-Smtp-Source: ABdhPJywC7pKeT35dxTuADanUaA07cRvZDmhJp2mf6McnAv/Ygqaj6eNJPwn2QxjYKn5mIhcB28ZShNdcIabXaJyx08= X-Received: by 2002:a17:90a:c908:: with SMTP id v8mr3356831pjt.75.1617697869378; Tue, 06 Apr 2021 01:31:09 -0700 (PDT) MIME-Version: 1.0 References: <20210402093255.2457184-1-yangyingliang@huawei.com> In-Reply-To: <20210402093255.2457184-1-yangyingliang@huawei.com> From: Robert Foss Date: Tue, 6 Apr 2021 10:30:58 +0200 Message-ID: Subject: Re: [PATCH -next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init() To: Yang Yingliang Cc: linux-kernel , MSM , linux-media Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Yang, Thanks for the fix. Reviewed-by: Robert Foss On Fri, 2 Apr 2021 at 11:29, Yang Yingliang wrote: > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > drivers/media/platform/qcom/camss/camss-csid.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c > index 463760c29294..cc11fbfdae13 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid.c > +++ b/drivers/media/platform/qcom/camss/camss-csid.c > @@ -568,10 +568,8 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid, > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]); > csid->base = devm_ioremap_resource(dev, r); > - if (IS_ERR(csid->base)) { > - dev_err(dev, "could not map memory\n"); > + if (IS_ERR(csid->base)) > return PTR_ERR(csid->base); > - } > > /* Interrupt */ > > -- > 2.25.1 >