From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8DB8C54E4B for ; Tue, 12 May 2020 08:13:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B8CB206D3 for ; Tue, 12 May 2020 08:13:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="B3m+V+H5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728977AbgELINn (ORCPT ); Tue, 12 May 2020 04:13:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725823AbgELINn (ORCPT ); Tue, 12 May 2020 04:13:43 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FB0BC061A0C for ; Tue, 12 May 2020 01:13:43 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id k110so9825616otc.2 for ; Tue, 12 May 2020 01:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+/M7ttbizVNgiq3E6e56DHlLpnfL10dXQ3P0u57oqQo=; b=B3m+V+H5gTjtrCKtwwO492HjhFTr38Y7VLdRIx8Tr0JsnUUVuJfvLNFpAjkYVRe/MU OGhuxIOgscPAJlStLNeONC5jnNM98kozL2u0pPS16qB774cjwhRApsJJSSoWukr1lnGH ndMSRfj/B/LQ6dcNI82uqbQkLohbgmAyXx7d4L3tgQ3l3nihXM9IjQ28IC8EK2tj/GD9 iHnOYCeOgJr/UT9aaWtYgPY3TJC7SJd+g13SZ9TH5FPj9pe98IZSRDzO8BHktwFWhKDd X1cRshj6SP1m+RsHrtI3l2vN5q2jx7wmf8L2tcm6zsUJnPybnwRmro6/JKHf/oSS9sVT GmXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+/M7ttbizVNgiq3E6e56DHlLpnfL10dXQ3P0u57oqQo=; b=AYNOqittPQfv0MaYL5hjBJ2ur5mNq6rmzMwVIHxy92VNPAsavO8MVJuLo84mPCQE4H yl2QN94mJQAJ5NO9XlxbO4snRdyZrKkVdatqVq6/3DTI2+EHJJMmtGkOhQIj7JC0sX+N g/fRYJ2lns0v5Tdw3z0/otpI/sqbjoc3rAWTTNC0r8JyRSrlXriedf6hx4qQ11vUBzMA j2XdA364QCVnIubilHmjgnxcwrtHtkhWALsDAWf12XQlx6w+9geu9uhR5mpUlfYQDDfH JIK2h7bnI5mlw6CjMcBKaxxTooLkt9QcOCs4+G5itZLsU6PFNzlAmf8EFuir3XRQLEsZ ffsg== X-Gm-Message-State: AGi0PuZU80RzB9hDjkzA9H9ot8X3f8KgwB4HcuAoZURg4XKiD4e4fxJS aYK4aEdzHr4+UPP3wXGspf8G/xsiTZ/I4JGBU+p9Qw== X-Google-Smtp-Source: APiQypLADIaeTtFDiDZj0oHRCnE87JDFcA3KKjn9my/GbFnCnkWw5321wESGx5JUU0FJwwNUrkgSoNw73WHvEVtCGSA= X-Received: by 2002:a9d:3462:: with SMTP id v89mr15637311otb.68.1589271222321; Tue, 12 May 2020 01:13:42 -0700 (PDT) MIME-Version: 1.0 References: <20200511110350.11565-1-robert.foss@linaro.org> <20200511110350.11565-3-robert.foss@linaro.org> <20200512002518.GX867@valkosipuli.retiisi.org.uk> In-Reply-To: <20200512002518.GX867@valkosipuli.retiisi.org.uk> From: Robert Foss Date: Tue, 12 May 2020 10:13:31 +0200 Message-ID: Subject: Re: [PATCH v8 2/3] media: ov8856: Add devicetree support To: Sakari Ailus Cc: Andy Shevchenko , Marco Felsch , Maxime Ripard , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Dongchun Zhu , Fabio Estevam , Tomasz Figa , Ben Kao Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 May 2020 at 02:26, Sakari Ailus wrote: > > Hi Robert, > > On Mon, May 11, 2020 at 01:03:49PM +0200, Robert Foss wrote: > > Add match table, enable ov8856_probe() to support > > both ACPI and DT modes. > > > > ACPI and DT modes are primarily distinguished from > > by checking for ACPI mode and by having resource like > > be NULL. > > > > Signed-off-by: Robert Foss > > Applied with this small diff --- please check with checkpatch.pl on the > next time. Thanks! Thanks Sakari, I appreciate it! > > diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c > index 1657e03d9a9d..4ca27675cc5a 100644 > --- a/drivers/media/i2c/ov8856.c > +++ b/drivers/media/i2c/ov8856.c > @@ -1226,8 +1226,7 @@ static int ov8856_get_hwcfg(struct ov8856 *ov8856, struct device *dev) > if (!fwnode) > return -ENXIO; > > - ret = fwnode_property_read_u32(fwnode, "clock-frequency", > - &xvclk_rate); > + ret = fwnode_property_read_u32(fwnode, "clock-frequency", &xvclk_rate); > if (ret) > return ret; > > @@ -1244,10 +1243,11 @@ static int ov8856_get_hwcfg(struct ov8856 *ov8856, struct device *dev) > } > > if (xvclk_rate != OV8856_XVCLK_19_2) > - dev_warn(dev, "external clock rate %d is unsupported", xvclk_rate); > + dev_warn(dev, "external clock rate %u is unsupported", > + xvclk_rate); > > ov8856->reset_gpio = devm_gpiod_get_optional(dev, "reset", > - GPIOD_OUT_LOW); > + GPIOD_OUT_LOW); > if (IS_ERR(ov8856->reset_gpio)) > return PTR_ERR(ov8856->reset_gpio); > > -- > Kind regards, > > Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF1DC54E4B for ; Tue, 12 May 2020 08:13:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D60BF2078E for ; Tue, 12 May 2020 08:13:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CuPtilTf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="B3m+V+H5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D60BF2078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uRS/LnQuIIzwite7xn7ipmqooPQ3ZE81YzkfcIJ2GCw=; b=CuPtilTf/UNcsV gVyCYTwCKhxdfubOJCD448O0DmxDFwMlfWBB9XlkLXXWYWzXaPPrkwkJSxXYk/90AOzI00CJpoTjY uW4FftZIXZHWmxY2XtABD5ihw4ubdcqFri+r+Gru34LtCjBC3IbwhUyJ4pYErN+s1JWPq/mH1Y5YU 3nagaCVOFnFDkWG7su5QGPf+t+3jbW+9zGj6CAOjVtsUQhSSnG3H+uSuPDa7XKv4mS8t5lslXXLYy 4AESGnKuuZCw4Q8DuTnIhF0OdyyuIOQhnq7c5I//0PFugeTzToh9jdQ9yEllkmm3CStIIYM7estUB oaA9zqr78UIZDVmPA0cA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYQ2t-0002E5-Hh; Tue, 12 May 2020 08:13:47 +0000 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYQ2p-0002CZ-JM for linux-arm-kernel@lists.infradead.org; Tue, 12 May 2020 08:13:45 +0000 Received: by mail-ot1-x344.google.com with SMTP id m33so9825437otc.5 for ; Tue, 12 May 2020 01:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+/M7ttbizVNgiq3E6e56DHlLpnfL10dXQ3P0u57oqQo=; b=B3m+V+H5gTjtrCKtwwO492HjhFTr38Y7VLdRIx8Tr0JsnUUVuJfvLNFpAjkYVRe/MU OGhuxIOgscPAJlStLNeONC5jnNM98kozL2u0pPS16qB774cjwhRApsJJSSoWukr1lnGH ndMSRfj/B/LQ6dcNI82uqbQkLohbgmAyXx7d4L3tgQ3l3nihXM9IjQ28IC8EK2tj/GD9 iHnOYCeOgJr/UT9aaWtYgPY3TJC7SJd+g13SZ9TH5FPj9pe98IZSRDzO8BHktwFWhKDd X1cRshj6SP1m+RsHrtI3l2vN5q2jx7wmf8L2tcm6zsUJnPybnwRmro6/JKHf/oSS9sVT GmXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+/M7ttbizVNgiq3E6e56DHlLpnfL10dXQ3P0u57oqQo=; b=iIHcgIdWHsq7ivhatvST0XDJiP1LlAMq4xFAde4fByQdnhjIm4xnYKeiGw//WHDVX4 esmYmqN/XRbWVXWHErDxlJdUhSyz9ud1XBVs9Bz1iAfoFQ/eA/rkF6qp12fopKcg15uA n7szcmeUepkQuZsvm4E2etabhpBpz6aMBH3RolKPm5VbCSsB4cRLO8K7AU696BhojzMM XuYIUv1nR2NeirawnpaCkq0zbmRl9UnKUlICGVMyw/5xvrfneAMMLcpl5xjrTIU64K7h USWsIMXbPKF3W5go+yfs8/0pSn3rFY7ozt+p+ggwbj/GLGVnsXuP9VK7ZBe7us55PB2w oUkA== X-Gm-Message-State: AGi0PuakpA/efdxZX6w70THldoHigYDeNT233yH4v5BYqsoZ7C/O+U7D mVufdZKkqyQ/qgKeK1SSo0YHkKnRDTowFiglTMeSew== X-Google-Smtp-Source: APiQypLADIaeTtFDiDZj0oHRCnE87JDFcA3KKjn9my/GbFnCnkWw5321wESGx5JUU0FJwwNUrkgSoNw73WHvEVtCGSA= X-Received: by 2002:a9d:3462:: with SMTP id v89mr15637311otb.68.1589271222321; Tue, 12 May 2020 01:13:42 -0700 (PDT) MIME-Version: 1.0 References: <20200511110350.11565-1-robert.foss@linaro.org> <20200511110350.11565-3-robert.foss@linaro.org> <20200512002518.GX867@valkosipuli.retiisi.org.uk> In-Reply-To: <20200512002518.GX867@valkosipuli.retiisi.org.uk> From: Robert Foss Date: Tue, 12 May 2020 10:13:31 +0200 Message-ID: Subject: Re: [PATCH v8 2/3] media: ov8856: Add devicetree support To: Sakari Ailus X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200512_011343_672600_91285DD1 X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tomasz Figa , Dongchun Zhu , Marco Felsch , linux-kernel , Ben Kao , Maxime Ripard , Andy Shevchenko , Fabio Estevam , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-media Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 12 May 2020 at 02:26, Sakari Ailus wrote: > > Hi Robert, > > On Mon, May 11, 2020 at 01:03:49PM +0200, Robert Foss wrote: > > Add match table, enable ov8856_probe() to support > > both ACPI and DT modes. > > > > ACPI and DT modes are primarily distinguished from > > by checking for ACPI mode and by having resource like > > be NULL. > > > > Signed-off-by: Robert Foss > > Applied with this small diff --- please check with checkpatch.pl on the > next time. Thanks! Thanks Sakari, I appreciate it! > > diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c > index 1657e03d9a9d..4ca27675cc5a 100644 > --- a/drivers/media/i2c/ov8856.c > +++ b/drivers/media/i2c/ov8856.c > @@ -1226,8 +1226,7 @@ static int ov8856_get_hwcfg(struct ov8856 *ov8856, struct device *dev) > if (!fwnode) > return -ENXIO; > > - ret = fwnode_property_read_u32(fwnode, "clock-frequency", > - &xvclk_rate); > + ret = fwnode_property_read_u32(fwnode, "clock-frequency", &xvclk_rate); > if (ret) > return ret; > > @@ -1244,10 +1243,11 @@ static int ov8856_get_hwcfg(struct ov8856 *ov8856, struct device *dev) > } > > if (xvclk_rate != OV8856_XVCLK_19_2) > - dev_warn(dev, "external clock rate %d is unsupported", xvclk_rate); > + dev_warn(dev, "external clock rate %u is unsupported", > + xvclk_rate); > > ov8856->reset_gpio = devm_gpiod_get_optional(dev, "reset", > - GPIOD_OUT_LOW); > + GPIOD_OUT_LOW); > if (IS_ERR(ov8856->reset_gpio)) > return PTR_ERR(ov8856->reset_gpio); > > -- > Kind regards, > > Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel