From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EEF4C433E6 for ; Fri, 5 Feb 2021 09:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1B8464FC7 for ; Fri, 5 Feb 2021 09:46:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229750AbhBEJqa (ORCPT ); Fri, 5 Feb 2021 04:46:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229669AbhBEJoG (ORCPT ); Fri, 5 Feb 2021 04:44:06 -0500 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8323C061793 for ; Fri, 5 Feb 2021 01:43:25 -0800 (PST) Received: by mail-pf1-x435.google.com with SMTP id i63so3961523pfg.7 for ; Fri, 05 Feb 2021 01:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DqJqQl1xSKavN+wug0hZ0iZc5i9bwB3JAakaDPcsm9k=; b=XC2yhAyepEIPdSWE2JxIt4ZGw87uQrdwLP8NeaGMO5mX/WpdJUWa6sD99Vrk6phbGS 3K459KZwzP0oMf4STCMaFC7U+M7tbH9p1YZLq9k79DyGkTKC8tj1mMvKi9t03tuD3MjS J5Rt4IjddHqU09Qu/stJrezWoMk68xnRPnKYi4FOtCV/NHO7ZOJM6eE8W9ly/dxahTQv I27QWH/L0CCsXWOq2802VE0wWECAUCbRZqV+tQ9oBEPEEDeILYKSGIfPdeJrV2dyHsmn LmUNqezFR3aqybKv4qExPnXb+J/zzoVZ0Z3BDcawpV4AsCZKKRmc8V89i8+997nzRnVO B4ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DqJqQl1xSKavN+wug0hZ0iZc5i9bwB3JAakaDPcsm9k=; b=aprLFICUvu7SSIuLRYv0J0+T3LBNs3susI9EA9Q1z4TLkTi4cFUyqubJlkWyXYcOqy LQ+9EXPwH4fC6UnQdtHXkhlrYVfqetc0s+4Y5oTM/yFFGp9FsOh+T+hKNcSlXPJ/tYej 3zZnkninOp3UJNFjzSne8D6jV6QLMClXRxBCevG6dfByjTibKxCyEhQbeVTIkJ5GeblO PZnoephggWezh9hrNMAxlWOaR64a/LEiZx2WFQTxl3mY0Ewfcm7eGzjsQ4LHDOztiXad /Qlnuv+62treAFqM0ObhLdTywTdm0+V6GL32r55KdihYqf41MhDSyRre7Nh663FX6PgQ 5oYA== X-Gm-Message-State: AOAM531dzb7Xl7kxhwzFdswgl+vLzfB5ch1feDnaTfz4UcHX8HN3gMZZ gwIKxHVntSe3WqKXuagyQpZKAyX/3ooKG2HO+Pwo0w== X-Google-Smtp-Source: ABdhPJyT4HMsF2dGuzPGOpl0Fmmj/5h+d6AATcrI1yEQ9m4uXBupaw+02kQjwB+emw72k0yf/4XBLFESW2s0tB5X0S0= X-Received: by 2002:a65:654e:: with SMTP id a14mr3609659pgw.265.1612518205362; Fri, 05 Feb 2021 01:43:25 -0800 (PST) MIME-Version: 1.0 References: <20210128111549.GA8174@zhaomy-pc> In-Reply-To: From: Robert Foss Date: Fri, 5 Feb 2021 10:43:14 +0100 Message-ID: Subject: Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP To: Nicolas Boichat Cc: Andrzej Hajda , devel@driverdev.osuosl.org, Nicolas Boichat , Jernej Skrabec , Sheng Pan , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel , dri-devel , Vasily Khoruzhick , Boris Brezillon , Torsten Duwe , Laurent Pinchart , Hsin-Yi Wang , Sam Ravnborg , Xin Ji , Dan Carpenter , Marek Szyprowski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat wrote: > > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > > >> Hi Xin, > > >> > > >> Thanks for the patch. > > >> > > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote: > > >>> Enable DSI EOTP feature for fixing some panel screen constance > > >>> shift issue. > > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. Does "constance shift" have a typo? Should it be "constant shift"? With that sorted out feel free to add my r-b. Reviewed-by: Robert Foss > > >> I don't think I quite understand how removing the > > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could > > >> you extrapolate on this in the commit message? > > > That confused me as well, but it turns out that's how the flag is defined: > > > ``` > > > /* disable EoT packets in HS mode */ > > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9) > > > ``` > > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129) > > > > > > I'm almost tempted to put together a mass patch to rename all of these flags... > > > > > > Yes that would be good, many of these flags were just copy pasted from > > some hw datasheet, without good analysis how to adapt them to the framework. > > I'll look into it (but that shouldn't block this patch). Thanks for clearing this up Nicolas & Andrzej! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E93C1C433DB for ; Fri, 5 Feb 2021 09:43:30 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E04F64FB7 for ; Fri, 5 Feb 2021 09:43:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E04F64FB7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 268C187124; Fri, 5 Feb 2021 09:43:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Xqxb1ts8Mmu; Fri, 5 Feb 2021 09:43:28 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 460C78712F; Fri, 5 Feb 2021 09:43:28 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 1895D1BF383 for ; Fri, 5 Feb 2021 09:43:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 111A586B08 for ; Fri, 5 Feb 2021 09:43:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JzV-kDaWFwn0 for ; Fri, 5 Feb 2021 09:43:25 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by fraxinus.osuosl.org (Postfix) with ESMTPS id B55E186AFD for ; Fri, 5 Feb 2021 09:43:25 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id g15so4144877pgu.9 for ; Fri, 05 Feb 2021 01:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DqJqQl1xSKavN+wug0hZ0iZc5i9bwB3JAakaDPcsm9k=; b=XC2yhAyepEIPdSWE2JxIt4ZGw87uQrdwLP8NeaGMO5mX/WpdJUWa6sD99Vrk6phbGS 3K459KZwzP0oMf4STCMaFC7U+M7tbH9p1YZLq9k79DyGkTKC8tj1mMvKi9t03tuD3MjS J5Rt4IjddHqU09Qu/stJrezWoMk68xnRPnKYi4FOtCV/NHO7ZOJM6eE8W9ly/dxahTQv I27QWH/L0CCsXWOq2802VE0wWECAUCbRZqV+tQ9oBEPEEDeILYKSGIfPdeJrV2dyHsmn LmUNqezFR3aqybKv4qExPnXb+J/zzoVZ0Z3BDcawpV4AsCZKKRmc8V89i8+997nzRnVO B4ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DqJqQl1xSKavN+wug0hZ0iZc5i9bwB3JAakaDPcsm9k=; b=a7xCCFMa9RlpapUAXhQmES1FIKDhCU1i4YIZ4/cIpMtz8gIwX+NSGxUnVAxNbnnm8m C7ctUu2PSy9ZqqQu8YhfRxIC8O0Vu2XdPLbSv37cqjG4/6xYZa4kJTOK6cS41RIOew3L 2yvoS5TlN9fNxpLxW2NmGDqDdfbn509El13eoo6J+fJ/hAk1iZX4I9fq1IzXEgqBsAWb iwlnxUgiVUMSr8rtawcARwaAgEUxY80cqWTvLd0LRr7fzA/EdzPTEtX6ruAOt8VM8WoO SDXnajJxe/sfSho1pvwk+HIzd6nwH+mhF7JcpzOkLk0pZnSkh54hyFvFEyLdbQ92aVaQ LdUg== X-Gm-Message-State: AOAM533FEPsbgg9XeD839QD6C+A6PNsrK0GlSKYqx7wTeVu2zIua1F1C wQ7y05Hc7o0zx8Qh8KGptTBf9HcngSD8Fhf2/K9B+w== X-Google-Smtp-Source: ABdhPJyT4HMsF2dGuzPGOpl0Fmmj/5h+d6AATcrI1yEQ9m4uXBupaw+02kQjwB+emw72k0yf/4XBLFESW2s0tB5X0S0= X-Received: by 2002:a65:654e:: with SMTP id a14mr3609659pgw.265.1612518205362; Fri, 05 Feb 2021 01:43:25 -0800 (PST) MIME-Version: 1.0 References: <20210128111549.GA8174@zhaomy-pc> In-Reply-To: From: Robert Foss Date: Fri, 5 Feb 2021 10:43:14 +0100 Message-ID: Subject: Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP To: Nicolas Boichat X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Nicolas Boichat , Jernej Skrabec , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel , dri-devel , Vasily Khoruzhick , Andrzej Hajda , Boris Brezillon , Torsten Duwe , Sheng Pan , Hsin-Yi Wang , Marek Szyprowski , Sam Ravnborg , Xin Ji , Dan Carpenter , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat wrote: > > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > > >> Hi Xin, > > >> > > >> Thanks for the patch. > > >> > > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote: > > >>> Enable DSI EOTP feature for fixing some panel screen constance > > >>> shift issue. > > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. Does "constance shift" have a typo? Should it be "constant shift"? With that sorted out feel free to add my r-b. Reviewed-by: Robert Foss > > >> I don't think I quite understand how removing the > > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could > > >> you extrapolate on this in the commit message? > > > That confused me as well, but it turns out that's how the flag is defined: > > > ``` > > > /* disable EoT packets in HS mode */ > > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9) > > > ``` > > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129) > > > > > > I'm almost tempted to put together a mass patch to rename all of these flags... > > > > > > Yes that would be good, many of these flags were just copy pasted from > > some hw datasheet, without good analysis how to adapt them to the framework. > > I'll look into it (but that shouldn't block this patch). Thanks for clearing this up Nicolas & Andrzej! _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEAC2C433E0 for ; Fri, 5 Feb 2021 09:43:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EF2864FB7 for ; Fri, 5 Feb 2021 09:43:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EF2864FB7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD4466F382; Fri, 5 Feb 2021 09:43:26 +0000 (UTC) Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by gabe.freedesktop.org (Postfix) with ESMTPS id ACACA6F382 for ; Fri, 5 Feb 2021 09:43:25 +0000 (UTC) Received: by mail-pg1-x529.google.com with SMTP id o63so4155992pgo.6 for ; Fri, 05 Feb 2021 01:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DqJqQl1xSKavN+wug0hZ0iZc5i9bwB3JAakaDPcsm9k=; b=XC2yhAyepEIPdSWE2JxIt4ZGw87uQrdwLP8NeaGMO5mX/WpdJUWa6sD99Vrk6phbGS 3K459KZwzP0oMf4STCMaFC7U+M7tbH9p1YZLq9k79DyGkTKC8tj1mMvKi9t03tuD3MjS J5Rt4IjddHqU09Qu/stJrezWoMk68xnRPnKYi4FOtCV/NHO7ZOJM6eE8W9ly/dxahTQv I27QWH/L0CCsXWOq2802VE0wWECAUCbRZqV+tQ9oBEPEEDeILYKSGIfPdeJrV2dyHsmn LmUNqezFR3aqybKv4qExPnXb+J/zzoVZ0Z3BDcawpV4AsCZKKRmc8V89i8+997nzRnVO B4ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DqJqQl1xSKavN+wug0hZ0iZc5i9bwB3JAakaDPcsm9k=; b=j4gSfJrc1lFQntoXdkrqxaMr01mw2c8RWWUeAqhIAZrJ5qTi/2uMZW5qA3nHSEBeyk By2QQUTlL1y/JoidDIKHFWySQS5vyhT4ctAT3l/9XivjPzaA4Zlu1dmDXmuwlqnZ/2T5 PprnKNrYd7nURtMhAUUi/GuhoV0/cMmx/mY+g7I3P3R62NOgiyrfngad9WBGju87NIJ/ LxiX3xPg9hvk25Qmjn5dxw3Wb1Yc6M/u9aDtnL7JrksNSxb01ZmbT4TB1ujltZh+W8nQ GI5ovRclx5LrFZlgbW6Nf6BHGMAocBsn56f7llfOT2i3DCd1vL7PhZ59U975BhOSSTWH E/qg== X-Gm-Message-State: AOAM533adq+XfaWK3ks8BM9lDTV4bxpZlQBXz7BgrUzJ34mKNqbmASN/ WE1UcUWVeEmtSW9I70p9/VBTa9Rwjq4HmM3I6Wz0xA== X-Google-Smtp-Source: ABdhPJyT4HMsF2dGuzPGOpl0Fmmj/5h+d6AATcrI1yEQ9m4uXBupaw+02kQjwB+emw72k0yf/4XBLFESW2s0tB5X0S0= X-Received: by 2002:a65:654e:: with SMTP id a14mr3609659pgw.265.1612518205362; Fri, 05 Feb 2021 01:43:25 -0800 (PST) MIME-Version: 1.0 References: <20210128111549.GA8174@zhaomy-pc> In-Reply-To: From: Robert Foss Date: Fri, 5 Feb 2021 10:43:14 +0100 Message-ID: Subject: Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP To: Nicolas Boichat X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Nicolas Boichat , Jernej Skrabec , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel , dri-devel , Vasily Khoruzhick , Andrzej Hajda , Boris Brezillon , Torsten Duwe , Sheng Pan , Hsin-Yi Wang , Marek Szyprowski , Sam Ravnborg , Xin Ji , Dan Carpenter , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat wrote: > > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > > >> Hi Xin, > > >> > > >> Thanks for the patch. > > >> > > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote: > > >>> Enable DSI EOTP feature for fixing some panel screen constance > > >>> shift issue. > > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. Does "constance shift" have a typo? Should it be "constant shift"? With that sorted out feel free to add my r-b. Reviewed-by: Robert Foss > > >> I don't think I quite understand how removing the > > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could > > >> you extrapolate on this in the commit message? > > > That confused me as well, but it turns out that's how the flag is defined: > > > ``` > > > /* disable EoT packets in HS mode */ > > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9) > > > ``` > > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129) > > > > > > I'm almost tempted to put together a mass patch to rename all of these flags... > > > > > > Yes that would be good, many of these flags were just copy pasted from > > some hw datasheet, without good analysis how to adapt them to the framework. > > I'll look into it (but that shouldn't block this patch). Thanks for clearing this up Nicolas & Andrzej! _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel