From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76118C4338F for ; Thu, 5 Aug 2021 14:32:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5606660F70 for ; Thu, 5 Aug 2021 14:32:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241719AbhHEOcs (ORCPT ); Thu, 5 Aug 2021 10:32:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233183AbhHEOco (ORCPT ); Thu, 5 Aug 2021 10:32:44 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A71D7C0613D5 for ; Thu, 5 Aug 2021 07:32:29 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id j18-20020a17090aeb12b029017737e6c349so9111340pjz.0 for ; Thu, 05 Aug 2021 07:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hxir+KJT92ne4sjUq07glKFb4339EmPmh/a5GVlr1ko=; b=k3719/z8eUSedQ6lU1Ji4Phj9b5Y8l0i6R93Er8eQtkwn8oV31S9CxSR/eMF8GtlH1 xjWqTZwBxPmQfL0Fm2rHuHHJMLShvWbTxr8VBc2YiKbAHxEuCChtZvgmN3DTD0imxKK1 oS6rtUVkpsmk2kEb9R0U4Csl2IWbJRtZsVqSOL202172DyPqWAoK0xb58hAC+b2bk0e9 JPaySdp1odFbAvM3gJRsak/89lSYGKrBbDzA9kH+zTUYhV0ir3IlKnGeeARonQYLnqUJ mRH09CtOCUWg6lmFaIZdQKUR7lM5V4gSzK5N96JNSgwEQ48WmP5e+YtBxE/j4IRuEFNi xYxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hxir+KJT92ne4sjUq07glKFb4339EmPmh/a5GVlr1ko=; b=FmNO9t7vwh7SBStNrljSdwZmR+w1BRVmXGgiIID+GRZW5oAZyzFI8RxmRPZQJvc9KZ x4phPNDOFapUgQvc2iEPgxvTuC01Di5t0SkevsVtEYxHDMBqyw/zlUOGUcPAZhyMUfqz QVBbGg4WQOSe72t8cMlzcuvHzpJMQZTuJL3Ey32sCVajBqgKa/4Htzo5tC6h+zUHfKaE sKzLR1gARXNmfgEAXLFRC+N6O/1aB9zA6Yr8x9e5yB6Mwzh8817bsMvv8otOPYrJEePB 2dSXhL7YUSbKKjFC4MIp8ZsF8k5QFypHeW3YqLo4uhFt3GQ9DkEzAq1KPHHQQQU2Wtwe ZAGA== X-Gm-Message-State: AOAM533WKk5bwSmTZe3CQb4Rf4dOwt/I0NB3V3Pws4yXOdEWy6M2qNdO 0nV7CnVLw6IjFcYJE2UTlvgytPxNEQbqGeFItvzW7w== X-Google-Smtp-Source: ABdhPJzmKvsuXnbAiJTCr2Ie3c70evLDQtBHyeupRXjhU286jch5hsPG3GMDBTl8uNZmPk7w39U7rdBJi7Zo+CSGIZw= X-Received: by 2002:a17:90a:604b:: with SMTP id h11mr4973185pjm.220.1628173948924; Thu, 05 Aug 2021 07:32:28 -0700 (PDT) MIME-Version: 1.0 References: <15187eccabf39561de226acd8be40b93503cac49.1628172477.git.hns@goldelico.com> In-Reply-To: <15187eccabf39561de226acd8be40b93503cac49.1628172477.git.hns@goldelico.com> From: Robert Foss Date: Thu, 5 Aug 2021 16:32:17 +0200 Message-ID: Subject: Re: [PATCH v2 1/8] drm/bridge: synopsis: Add mode_fixup and bridge timings support To: "H. Nikolaus Schaller" Cc: Paul Cercueil , Rob Herring , Mark Rutland , Thomas Bogendoerfer , Geert Uytterhoeven , Kees Cook , "Eric W. Biederman" , Miquel Raynal , David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jernej Skrabec , Ezequiel Garcia , Harry Wentland , Sam Ravnborg , Maxime Ripard , Hans Verkuil , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-mips@vger.kernel.org, linux-kernel , letux-kernel@openphoenux.org, Paul Boddie , Jonas Karlman , dri-devel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Nikolaus, Thanks for submitting this series. On Thu, 5 Aug 2021 at 16:08, H. Nikolaus Schaller wrote: > > From: Paul Boddie > > The platform-specific configuration structure is augmented with > mode_fixup and timings members so that specialisations of the > Synopsys driver can introduce mode flags and bus flags. > > Signed-off-by: Paul Boddie > Signed-off-by: Ezequiel Garcia > Signed-off-by: H. Nikolaus Schaller > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 16 ++++++++++++++++ > include/drm/bridge/dw_hdmi.h | 5 +++++ > 2 files changed, 21 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index e7c7c9b9c646f..e8499eb11328c 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -2810,6 +2810,19 @@ dw_hdmi_bridge_mode_valid(struct drm_bridge *bridge, > return mode_status; > } > > +static bool > +dw_hdmi_bridge_mode_fixup(struct drm_bridge *bridge, > + const struct drm_display_mode *mode, > + struct drm_display_mode *adjusted_mode) > +{ > + struct dw_hdmi *hdmi = bridge->driver_private; > + > + if (hdmi->plat_data->mode_fixup) > + return hdmi->plat_data->mode_fixup(bridge, mode, adjusted_mode); > + > + return true; > +} > + > static void dw_hdmi_bridge_mode_set(struct drm_bridge *bridge, > const struct drm_display_mode *orig_mode, > const struct drm_display_mode *mode) > @@ -2883,6 +2896,7 @@ static const struct drm_bridge_funcs dw_hdmi_bridge_funcs = { > .atomic_disable = dw_hdmi_bridge_atomic_disable, > .mode_set = dw_hdmi_bridge_mode_set, > .mode_valid = dw_hdmi_bridge_mode_valid, > + .mode_fixup = dw_hdmi_bridge_mode_fixup, mode_fixup() has been deprecated[1] in favor of atomic_check(), care has to be taken when switching to atomic_check() as it has access to the full atomic commit. Looking at this driver, it's using mode_set as well, which should be fixed. [1] https://lore.kernel.org/dri-devel/20210722062246.2512666-8-sam@ravnborg.org/ > .detect = dw_hdmi_bridge_detect, > .get_edid = dw_hdmi_bridge_get_edid, > }; > @@ -3364,6 +3378,8 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev, > #ifdef CONFIG_OF > hdmi->bridge.of_node = pdev->dev.of_node; > #endif > + if (plat_data->timings) > + hdmi->bridge.timings = plat_data->timings; > > memset(&pdevinfo, 0, sizeof(pdevinfo)); > pdevinfo.parent = dev; > diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h > index 6a5716655619b..677137445d534 100644 > --- a/include/drm/bridge/dw_hdmi.h > +++ b/include/drm/bridge/dw_hdmi.h > @@ -8,6 +8,7 @@ > > #include > > +struct drm_bridge; > struct drm_display_info; > struct drm_display_mode; > struct drm_encoder; > @@ -140,6 +141,10 @@ struct dw_hdmi_plat_data { > enum drm_mode_status (*mode_valid)(struct dw_hdmi *hdmi, void *data, > const struct drm_display_info *info, > const struct drm_display_mode *mode); > + bool (*mode_fixup)(struct drm_bridge *bridge, > + const struct drm_display_mode *mode, > + struct drm_display_mode *adjusted_mode); > + const struct drm_bridge_timings *timings; > > /* Vendor PHY support */ > const struct dw_hdmi_phy_ops *phy_ops; > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 680C2C4320A for ; Thu, 5 Aug 2021 14:32:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3311561151 for ; Thu, 5 Aug 2021 14:32:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3311561151 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 77B646E82E; Thu, 5 Aug 2021 14:32:30 +0000 (UTC) Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 496686E82E for ; Thu, 5 Aug 2021 14:32:29 +0000 (UTC) Received: by mail-pj1-x102d.google.com with SMTP id b1-20020a17090a8001b029017700de3903so9062491pjn.1 for ; Thu, 05 Aug 2021 07:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hxir+KJT92ne4sjUq07glKFb4339EmPmh/a5GVlr1ko=; b=k3719/z8eUSedQ6lU1Ji4Phj9b5Y8l0i6R93Er8eQtkwn8oV31S9CxSR/eMF8GtlH1 xjWqTZwBxPmQfL0Fm2rHuHHJMLShvWbTxr8VBc2YiKbAHxEuCChtZvgmN3DTD0imxKK1 oS6rtUVkpsmk2kEb9R0U4Csl2IWbJRtZsVqSOL202172DyPqWAoK0xb58hAC+b2bk0e9 JPaySdp1odFbAvM3gJRsak/89lSYGKrBbDzA9kH+zTUYhV0ir3IlKnGeeARonQYLnqUJ mRH09CtOCUWg6lmFaIZdQKUR7lM5V4gSzK5N96JNSgwEQ48WmP5e+YtBxE/j4IRuEFNi xYxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hxir+KJT92ne4sjUq07glKFb4339EmPmh/a5GVlr1ko=; b=mlmm1zh4rs5uwRuWjGrZkMi9SK9e6vvcyBeLhSGda3EO443hr1XfOVXNH33+1l00n2 iRdQrIcRkl+1LpEGGoGZwDNDstSgBgxjULvu9pEAplWwHmlMfyM67sXZ3LT8iUioFOGP 8xVlC2tebOiCcHbmBK8RiRIpzOffj9FUmkIN/zjNVxqLUwv5Iv1nejnGle6J0K0hFtFP 0v0vqmvdbPCMFuadovl1NbjD6Rg88Rt0Xt0CWapH/qZ2hp8Gw0q/STpfCooyN8ueXq6+ XpzpL68yYjYC2OaPSqSN5uc98DOdOB4k3NE7ayWq++E0Vl/pTnNNJ1NelWHQ4G2KDhUr sl4Q== X-Gm-Message-State: AOAM5329XQQE5/smi1bLGfwx2IZGhKeLnVAHLmL9EtiGFuYe7z6UuUQZ 8z9LBr0UvIuNQghxg8bjobLQTlWF/60HD6r1I0go8Q== X-Google-Smtp-Source: ABdhPJzmKvsuXnbAiJTCr2Ie3c70evLDQtBHyeupRXjhU286jch5hsPG3GMDBTl8uNZmPk7w39U7rdBJi7Zo+CSGIZw= X-Received: by 2002:a17:90a:604b:: with SMTP id h11mr4973185pjm.220.1628173948924; Thu, 05 Aug 2021 07:32:28 -0700 (PDT) MIME-Version: 1.0 References: <15187eccabf39561de226acd8be40b93503cac49.1628172477.git.hns@goldelico.com> In-Reply-To: <15187eccabf39561de226acd8be40b93503cac49.1628172477.git.hns@goldelico.com> From: Robert Foss Date: Thu, 5 Aug 2021 16:32:17 +0200 Message-ID: Subject: Re: [PATCH v2 1/8] drm/bridge: synopsis: Add mode_fixup and bridge timings support To: "H. Nikolaus Schaller" Cc: Paul Cercueil , Rob Herring , Mark Rutland , Thomas Bogendoerfer , Geert Uytterhoeven , Kees Cook , "Eric W. Biederman" , Miquel Raynal , David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jernej Skrabec , Ezequiel Garcia , Harry Wentland , Sam Ravnborg , Maxime Ripard , Hans Verkuil , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-mips@vger.kernel.org, linux-kernel , letux-kernel@openphoenux.org, Paul Boddie , Jonas Karlman , dri-devel Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hey Nikolaus, Thanks for submitting this series. On Thu, 5 Aug 2021 at 16:08, H. Nikolaus Schaller wrote: > > From: Paul Boddie > > The platform-specific configuration structure is augmented with > mode_fixup and timings members so that specialisations of the > Synopsys driver can introduce mode flags and bus flags. > > Signed-off-by: Paul Boddie > Signed-off-by: Ezequiel Garcia > Signed-off-by: H. Nikolaus Schaller > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 16 ++++++++++++++++ > include/drm/bridge/dw_hdmi.h | 5 +++++ > 2 files changed, 21 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index e7c7c9b9c646f..e8499eb11328c 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -2810,6 +2810,19 @@ dw_hdmi_bridge_mode_valid(struct drm_bridge *bridge, > return mode_status; > } > > +static bool > +dw_hdmi_bridge_mode_fixup(struct drm_bridge *bridge, > + const struct drm_display_mode *mode, > + struct drm_display_mode *adjusted_mode) > +{ > + struct dw_hdmi *hdmi = bridge->driver_private; > + > + if (hdmi->plat_data->mode_fixup) > + return hdmi->plat_data->mode_fixup(bridge, mode, adjusted_mode); > + > + return true; > +} > + > static void dw_hdmi_bridge_mode_set(struct drm_bridge *bridge, > const struct drm_display_mode *orig_mode, > const struct drm_display_mode *mode) > @@ -2883,6 +2896,7 @@ static const struct drm_bridge_funcs dw_hdmi_bridge_funcs = { > .atomic_disable = dw_hdmi_bridge_atomic_disable, > .mode_set = dw_hdmi_bridge_mode_set, > .mode_valid = dw_hdmi_bridge_mode_valid, > + .mode_fixup = dw_hdmi_bridge_mode_fixup, mode_fixup() has been deprecated[1] in favor of atomic_check(), care has to be taken when switching to atomic_check() as it has access to the full atomic commit. Looking at this driver, it's using mode_set as well, which should be fixed. [1] https://lore.kernel.org/dri-devel/20210722062246.2512666-8-sam@ravnborg.org/ > .detect = dw_hdmi_bridge_detect, > .get_edid = dw_hdmi_bridge_get_edid, > }; > @@ -3364,6 +3378,8 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev, > #ifdef CONFIG_OF > hdmi->bridge.of_node = pdev->dev.of_node; > #endif > + if (plat_data->timings) > + hdmi->bridge.timings = plat_data->timings; > > memset(&pdevinfo, 0, sizeof(pdevinfo)); > pdevinfo.parent = dev; > diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h > index 6a5716655619b..677137445d534 100644 > --- a/include/drm/bridge/dw_hdmi.h > +++ b/include/drm/bridge/dw_hdmi.h > @@ -8,6 +8,7 @@ > > #include > > +struct drm_bridge; > struct drm_display_info; > struct drm_display_mode; > struct drm_encoder; > @@ -140,6 +141,10 @@ struct dw_hdmi_plat_data { > enum drm_mode_status (*mode_valid)(struct dw_hdmi *hdmi, void *data, > const struct drm_display_info *info, > const struct drm_display_mode *mode); > + bool (*mode_fixup)(struct drm_bridge *bridge, > + const struct drm_display_mode *mode, > + struct drm_display_mode *adjusted_mode); > + const struct drm_bridge_timings *timings; > > /* Vendor PHY support */ > const struct dw_hdmi_phy_ops *phy_ops; > -- > 2.31.1 >