From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E3DFC433B4 for ; Fri, 9 Apr 2021 09:06:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E829561186 for ; Fri, 9 Apr 2021 09:06:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231526AbhDIJGV (ORCPT ); Fri, 9 Apr 2021 05:06:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231599AbhDIJGS (ORCPT ); Fri, 9 Apr 2021 05:06:18 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE5E4C061760 for ; Fri, 9 Apr 2021 02:06:05 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id q5so3804738pfh.10 for ; Fri, 09 Apr 2021 02:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jBFt7hCrEED4DsJn/9ZDSGXx+J7qlQtOTDSK460XmiI=; b=qhVVkziSC7x1hcssW43FRmDyNiuqo7qvZ8oZqJw0yJAZPFQIuG9YngIGR+LUaqB6Ep gA0gy1rtKXR6pUe+/fTk+cRdVip2NDRJfYqPp4N7Nar3zdZAVXnNb0gqTgh9lrCKFh6S 87iGSlbqb92KPO4K/jLdHRgCSCmVYSxcOz55ychgqVAz+N8EYxu//WImHLTU2LXA803m KcAvG1kJ1zioKENp2TW5WlpVumZkM3qHnwtZWDc0P6zLrHsqQKTqCgypr7ay8QtV2k+S x8sIo+8i8SkHHAtQZp25m/v+3lJoRrbuTW8PGi9pJrKLQPpUkY48wUMyFX93oaC9ZQ5D Mo2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jBFt7hCrEED4DsJn/9ZDSGXx+J7qlQtOTDSK460XmiI=; b=m3evQg+xl33Pvp8AfKoS7q5F3MM7+or+7Ov703Z/O5nK5xz1Uj2/76q7ulXWMpFTQz KpqQveMqZ5yiR+g0wtUtfOnicVBLuSQIbcTwHGO+N9l67tjYWu+GGHakfE7cCErFQIOC jkR6TfOaxufqlwui47tAnJ+Tw0OWKKDnCbv5Mj2rTJKqZQOiYSI5Ag4rqUf1GGB2vlmR Eq3CGUs8loRooz45Y33OCAT8J/5lZq09mgY42s+56idwqQ+6+62dUWTB47GVKNbhkuHD mkzMB2DQLtlMhBIJ9m9wM7QviW/U2T3e3C8fRF5y86wk14uBu2mUjkuBkLMvm/TeBbn7 hrog== X-Gm-Message-State: AOAM532gCMr/o0jDy0V7Gf4GjD/I1GmqX4WH1K27ap73B6RMjnNmMV8W 7aPyO8e/K2YmLO5QPtxGS81Zew2eHoAW+zpJ2c6+GA== X-Google-Smtp-Source: ABdhPJw6b7uVfLhRrscIOQJPJ0QlL2htq5lncrLazsCVv7TsysUlRSUnImwq7MxuBdaWbKATQsStIfCBvkPZ76tCudc= X-Received: by 2002:a63:530d:: with SMTP id h13mr12113445pgb.120.1617959165470; Fri, 09 Apr 2021 02:06:05 -0700 (PDT) MIME-Version: 1.0 References: <18ec1a440eb71e4f91c0932cd0fadddd2e9a4c0f.1617937551.git.xji@analogixsemi.com> In-Reply-To: <18ec1a440eb71e4f91c0932cd0fadddd2e9a4c0f.1617937551.git.xji@analogixsemi.com> From: Robert Foss Date: Fri, 9 Apr 2021 11:05:54 +0200 Message-ID: Subject: Re: [PATCH 1/1] drm/bridge: anx7625: send DPCD command to downstream To: Xin Ji Cc: Nicolas Boichat , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Dan Carpenter , David Airlie , Daniel Vetter , Boris Brezillon , Sam Ravnborg , Hsin-Yi Wang , Torsten Duwe , Vasily Khoruzhick , Marek Szyprowski , Sheng Pan , Bernie Liang , Zhen Li , dri-devel , linux-kernel , devel@driverdev.osuosl.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Xin, On Fri, 9 Apr 2021 at 07:35, Xin Ji wrote: > > Send DPCD command to downstream before anx7625 power down, > tell downstream into standby mode. > > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 75 +++++++++++++++++++++++ > 1 file changed, 75 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 65cc05982f82..53d2f0d0ee30 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -124,6 +124,23 @@ static int anx7625_reg_write(struct anx7625_data *ctx, > return ret; > } > > +static int anx7625_reg_block_write(struct anx7625_data *ctx, > + struct i2c_client *client, > + u8 reg_addr, u8 len, u8 *buf) > +{ > + int ret; > + struct device *dev = &client->dev; > + > + i2c_access_workaround(ctx, client); > + > + ret = i2c_smbus_write_i2c_block_data(client, reg_addr, len, buf); > + if (ret < 0) > + DRM_DEV_ERROR(dev, "write i2c block failed id=%x\n:%x", > + client->addr, reg_addr); > + > + return ret; > +} > + > static int anx7625_write_or(struct anx7625_data *ctx, > struct i2c_client *client, > u8 offset, u8 mask) > @@ -195,6 +212,55 @@ static int wait_aux_op_finish(struct anx7625_data *ctx) > return val; > } > > +static int anx7625_aux_dpcd_write(struct anx7625_data *ctx, > + u8 addrh, u8 addrm, u8 addrl, > + u8 len, u8 *buf) > +{ > + struct device *dev = &ctx->client->dev; > + int ret; > + u8 cmd; > + > + if (len > MAX_DPCD_BUFFER_SIZE) { > + DRM_DEV_ERROR(dev, "exceed aux buffer len.\n"); > + return -EINVAL; > + } > + > + cmd = ((len - 1) << 4) | 0x08; > + > + /* Set command and length */ > + ret = anx7625_reg_write(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_COMMAND, cmd); > + > + /* Set aux access address */ > + ret |= anx7625_reg_write(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_ADDR_7_0, addrl); > + ret |= anx7625_reg_write(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_ADDR_15_8, addrm); > + ret |= anx7625_write_and(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_ADDR_19_16, addrh); > + > + /* Set write data */ > + ret |= anx7625_reg_block_write(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_BUFF_START, len, buf); > + /* Enable aux access */ > + ret |= anx7625_write_or(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_CTRL_STATUS, AP_AUX_CTRL_OP_EN); > + if (ret < 0) { > + DRM_DEV_ERROR(dev, "cannot access aux related register.\n"); > + return -EIO; > + } > + > + usleep_range(2000, 2100); > + > + ret = wait_aux_op_finish(ctx); > + if (ret) { > + DRM_DEV_ERROR(dev, "aux IO error: wait aux op finish.\n"); > + return ret; > + } > + > + return 0; > +} > + > static int anx7625_video_mute_control(struct anx7625_data *ctx, > u8 status) > { > @@ -617,6 +683,7 @@ static void anx7625_dp_stop(struct anx7625_data *ctx) > { > struct device *dev = &ctx->client->dev; > int ret; > + u8 data; > > DRM_DEV_DEBUG_DRIVER(dev, "stop dp output\n"); > > @@ -628,8 +695,16 @@ static void anx7625_dp_stop(struct anx7625_data *ctx) > ret |= anx7625_write_and(ctx, ctx->i2c.tx_p2_client, 0x08, 0x7f); > > ret |= anx7625_video_mute_control(ctx, 1); > + > + DRM_DEV_DEBUG_DRIVER(dev, "notify downstream enter into standby\n"); > + > + /* Downstream monitor enter into standby mode */ > + data = 2; > + ret |= anx7625_aux_dpcd_write(ctx, 0x00, 0x06, 0x00, 1, &data); > if (ret < 0) > DRM_DEV_ERROR(dev, "IO error : mute video fail\n"); > + > + return; > } Reviewed-by: Robert Foss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4358C43460 for ; Fri, 9 Apr 2021 09:06:10 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A94861026 for ; Fri, 9 Apr 2021 09:06:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A94861026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id DF5CD84B01; Fri, 9 Apr 2021 09:06:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G8oCfHA_mgkL; Fri, 9 Apr 2021 09:06:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 681C584A55; Fri, 9 Apr 2021 09:06:08 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 06CEB1BF2C7 for ; Fri, 9 Apr 2021 09:06:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E3CC840E99 for ; Fri, 9 Apr 2021 09:06:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linaro.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j1q55U3_Co3H for ; Fri, 9 Apr 2021 09:06:06 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by smtp2.osuosl.org (Postfix) with ESMTPS id 0CDC94010E for ; Fri, 9 Apr 2021 09:06:05 +0000 (UTC) Received: by mail-pf1-x42e.google.com with SMTP id i190so3797171pfc.12 for ; Fri, 09 Apr 2021 02:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jBFt7hCrEED4DsJn/9ZDSGXx+J7qlQtOTDSK460XmiI=; b=qhVVkziSC7x1hcssW43FRmDyNiuqo7qvZ8oZqJw0yJAZPFQIuG9YngIGR+LUaqB6Ep gA0gy1rtKXR6pUe+/fTk+cRdVip2NDRJfYqPp4N7Nar3zdZAVXnNb0gqTgh9lrCKFh6S 87iGSlbqb92KPO4K/jLdHRgCSCmVYSxcOz55ychgqVAz+N8EYxu//WImHLTU2LXA803m KcAvG1kJ1zioKENp2TW5WlpVumZkM3qHnwtZWDc0P6zLrHsqQKTqCgypr7ay8QtV2k+S x8sIo+8i8SkHHAtQZp25m/v+3lJoRrbuTW8PGi9pJrKLQPpUkY48wUMyFX93oaC9ZQ5D Mo2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jBFt7hCrEED4DsJn/9ZDSGXx+J7qlQtOTDSK460XmiI=; b=OI/khgle/mEqwKLmNfard7f8BZrD4tvjWqrV3EHn5jGNC0uncpvNJSZurU/sN+m7Q1 SU67uSteUULng1RAExAyEv//s2UdW7it46lBtgwyeQS7mi/8EHfMA+soRL1ozHgS4Fkk cMsFAMxhXcX4OdgzaVzmdG+zDBjulw0A3+B651tys6U0v6s79x9iRLrR+BXNK8an90Sd vJdcef9lp3hD8Iep7WgZEpv7M17IRo/afdBJ5LPN01RoGzYlmfBnrc5Qb3wkWTE+lqEL v6aLvByciBnDO324GAj9Hz0w1deEI8qlWYjo4b2h9kuWRPN7jFilLEsp03bzP2VO8iv+ b6iw== X-Gm-Message-State: AOAM531zQpn4Tvy0RH1I2XE7vsKnoSHBEnQShU3PdUsRFrJaHFmaNMhX zqT1jQdjliD7yXAPBisuCrHF69LanvS5Oj6zyBLDSA== X-Google-Smtp-Source: ABdhPJw6b7uVfLhRrscIOQJPJ0QlL2htq5lncrLazsCVv7TsysUlRSUnImwq7MxuBdaWbKATQsStIfCBvkPZ76tCudc= X-Received: by 2002:a63:530d:: with SMTP id h13mr12113445pgb.120.1617959165470; Fri, 09 Apr 2021 02:06:05 -0700 (PDT) MIME-Version: 1.0 References: <18ec1a440eb71e4f91c0932cd0fadddd2e9a4c0f.1617937551.git.xji@analogixsemi.com> In-Reply-To: <18ec1a440eb71e4f91c0932cd0fadddd2e9a4c0f.1617937551.git.xji@analogixsemi.com> From: Robert Foss Date: Fri, 9 Apr 2021 11:05:54 +0200 Message-ID: Subject: Re: [PATCH 1/1] drm/bridge: anx7625: send DPCD command to downstream To: Xin Ji X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Nicolas Boichat , Jernej Skrabec , Sheng Pan , Jonas Karlman , David Airlie , Bernie Liang , Neil Armstrong , Zhen Li , linux-kernel , dri-devel , Vasily Khoruzhick , Andrzej Hajda , Boris Brezillon , Torsten Duwe , Laurent Pinchart , Daniel Vetter , Hsin-Yi Wang , Sam Ravnborg , Dan Carpenter , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hey Xin, On Fri, 9 Apr 2021 at 07:35, Xin Ji wrote: > > Send DPCD command to downstream before anx7625 power down, > tell downstream into standby mode. > > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 75 +++++++++++++++++++++++ > 1 file changed, 75 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 65cc05982f82..53d2f0d0ee30 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -124,6 +124,23 @@ static int anx7625_reg_write(struct anx7625_data *ctx, > return ret; > } > > +static int anx7625_reg_block_write(struct anx7625_data *ctx, > + struct i2c_client *client, > + u8 reg_addr, u8 len, u8 *buf) > +{ > + int ret; > + struct device *dev = &client->dev; > + > + i2c_access_workaround(ctx, client); > + > + ret = i2c_smbus_write_i2c_block_data(client, reg_addr, len, buf); > + if (ret < 0) > + DRM_DEV_ERROR(dev, "write i2c block failed id=%x\n:%x", > + client->addr, reg_addr); > + > + return ret; > +} > + > static int anx7625_write_or(struct anx7625_data *ctx, > struct i2c_client *client, > u8 offset, u8 mask) > @@ -195,6 +212,55 @@ static int wait_aux_op_finish(struct anx7625_data *ctx) > return val; > } > > +static int anx7625_aux_dpcd_write(struct anx7625_data *ctx, > + u8 addrh, u8 addrm, u8 addrl, > + u8 len, u8 *buf) > +{ > + struct device *dev = &ctx->client->dev; > + int ret; > + u8 cmd; > + > + if (len > MAX_DPCD_BUFFER_SIZE) { > + DRM_DEV_ERROR(dev, "exceed aux buffer len.\n"); > + return -EINVAL; > + } > + > + cmd = ((len - 1) << 4) | 0x08; > + > + /* Set command and length */ > + ret = anx7625_reg_write(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_COMMAND, cmd); > + > + /* Set aux access address */ > + ret |= anx7625_reg_write(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_ADDR_7_0, addrl); > + ret |= anx7625_reg_write(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_ADDR_15_8, addrm); > + ret |= anx7625_write_and(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_ADDR_19_16, addrh); > + > + /* Set write data */ > + ret |= anx7625_reg_block_write(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_BUFF_START, len, buf); > + /* Enable aux access */ > + ret |= anx7625_write_or(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_CTRL_STATUS, AP_AUX_CTRL_OP_EN); > + if (ret < 0) { > + DRM_DEV_ERROR(dev, "cannot access aux related register.\n"); > + return -EIO; > + } > + > + usleep_range(2000, 2100); > + > + ret = wait_aux_op_finish(ctx); > + if (ret) { > + DRM_DEV_ERROR(dev, "aux IO error: wait aux op finish.\n"); > + return ret; > + } > + > + return 0; > +} > + > static int anx7625_video_mute_control(struct anx7625_data *ctx, > u8 status) > { > @@ -617,6 +683,7 @@ static void anx7625_dp_stop(struct anx7625_data *ctx) > { > struct device *dev = &ctx->client->dev; > int ret; > + u8 data; > > DRM_DEV_DEBUG_DRIVER(dev, "stop dp output\n"); > > @@ -628,8 +695,16 @@ static void anx7625_dp_stop(struct anx7625_data *ctx) > ret |= anx7625_write_and(ctx, ctx->i2c.tx_p2_client, 0x08, 0x7f); > > ret |= anx7625_video_mute_control(ctx, 1); > + > + DRM_DEV_DEBUG_DRIVER(dev, "notify downstream enter into standby\n"); > + > + /* Downstream monitor enter into standby mode */ > + data = 2; > + ret |= anx7625_aux_dpcd_write(ctx, 0x00, 0x06, 0x00, 1, &data); > if (ret < 0) > DRM_DEV_ERROR(dev, "IO error : mute video fail\n"); > + > + return; > } Reviewed-by: Robert Foss _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B52FC433B4 for ; Fri, 9 Apr 2021 09:06:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 530CF61104 for ; Fri, 9 Apr 2021 09:06:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 530CF61104 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 46CF96EBA2; Fri, 9 Apr 2021 09:06:07 +0000 (UTC) Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by gabe.freedesktop.org (Postfix) with ESMTPS id 231A36EBA2 for ; Fri, 9 Apr 2021 09:06:06 +0000 (UTC) Received: by mail-pf1-x432.google.com with SMTP id m11so3806552pfc.11 for ; Fri, 09 Apr 2021 02:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jBFt7hCrEED4DsJn/9ZDSGXx+J7qlQtOTDSK460XmiI=; b=qhVVkziSC7x1hcssW43FRmDyNiuqo7qvZ8oZqJw0yJAZPFQIuG9YngIGR+LUaqB6Ep gA0gy1rtKXR6pUe+/fTk+cRdVip2NDRJfYqPp4N7Nar3zdZAVXnNb0gqTgh9lrCKFh6S 87iGSlbqb92KPO4K/jLdHRgCSCmVYSxcOz55ychgqVAz+N8EYxu//WImHLTU2LXA803m KcAvG1kJ1zioKENp2TW5WlpVumZkM3qHnwtZWDc0P6zLrHsqQKTqCgypr7ay8QtV2k+S x8sIo+8i8SkHHAtQZp25m/v+3lJoRrbuTW8PGi9pJrKLQPpUkY48wUMyFX93oaC9ZQ5D Mo2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jBFt7hCrEED4DsJn/9ZDSGXx+J7qlQtOTDSK460XmiI=; b=JXMfpc39AvNz0j/Xi5+OCTCrL8M8EYAYK52ysmanjb/v5xyHPxTYwkdxemK9zu/wdT F4uxLlvy7Guef4vMH3R69VOn44Fez1/DrwUfhyazL+XRxHTM/lLgt8KCLN1e/YuBLRtd qtjtdfC2gdw6tvXU1OQ1mMMyL/lspr450tBTzbOt6QuyiUqmX83CO7kWmTUqC6tw7en8 M/noARwjM1OaZjBOP0KE/bXFXNhw8lu9DiNqzPLsBZj/ggiyxMNZPT4wHc4q6AfQOJMY dLkwBR7A3IhZjFA3ZcwYKxzlAmn2B6TmBloAul/dWR3S7yF4F1yci9LLbJMzu3AEUQlc JTEA== X-Gm-Message-State: AOAM530XBm28MfB1H6ecHjnUJF1sy7rqfzdEltBlab8zhlgKuROXSKTp VyH/n8vlAh6OMeTnklhdMTmG2kcwmlY0PfPsgmzSiA== X-Google-Smtp-Source: ABdhPJw6b7uVfLhRrscIOQJPJ0QlL2htq5lncrLazsCVv7TsysUlRSUnImwq7MxuBdaWbKATQsStIfCBvkPZ76tCudc= X-Received: by 2002:a63:530d:: with SMTP id h13mr12113445pgb.120.1617959165470; Fri, 09 Apr 2021 02:06:05 -0700 (PDT) MIME-Version: 1.0 References: <18ec1a440eb71e4f91c0932cd0fadddd2e9a4c0f.1617937551.git.xji@analogixsemi.com> In-Reply-To: <18ec1a440eb71e4f91c0932cd0fadddd2e9a4c0f.1617937551.git.xji@analogixsemi.com> From: Robert Foss Date: Fri, 9 Apr 2021 11:05:54 +0200 Message-ID: Subject: Re: [PATCH 1/1] drm/bridge: anx7625: send DPCD command to downstream To: Xin Ji X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Nicolas Boichat , Jernej Skrabec , Sheng Pan , Jonas Karlman , David Airlie , Bernie Liang , Neil Armstrong , Zhen Li , linux-kernel , dri-devel , Vasily Khoruzhick , Andrzej Hajda , Boris Brezillon , Torsten Duwe , Laurent Pinchart , Hsin-Yi Wang , Sam Ravnborg , Dan Carpenter , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hey Xin, On Fri, 9 Apr 2021 at 07:35, Xin Ji wrote: > > Send DPCD command to downstream before anx7625 power down, > tell downstream into standby mode. > > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 75 +++++++++++++++++++++++ > 1 file changed, 75 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 65cc05982f82..53d2f0d0ee30 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -124,6 +124,23 @@ static int anx7625_reg_write(struct anx7625_data *ctx, > return ret; > } > > +static int anx7625_reg_block_write(struct anx7625_data *ctx, > + struct i2c_client *client, > + u8 reg_addr, u8 len, u8 *buf) > +{ > + int ret; > + struct device *dev = &client->dev; > + > + i2c_access_workaround(ctx, client); > + > + ret = i2c_smbus_write_i2c_block_data(client, reg_addr, len, buf); > + if (ret < 0) > + DRM_DEV_ERROR(dev, "write i2c block failed id=%x\n:%x", > + client->addr, reg_addr); > + > + return ret; > +} > + > static int anx7625_write_or(struct anx7625_data *ctx, > struct i2c_client *client, > u8 offset, u8 mask) > @@ -195,6 +212,55 @@ static int wait_aux_op_finish(struct anx7625_data *ctx) > return val; > } > > +static int anx7625_aux_dpcd_write(struct anx7625_data *ctx, > + u8 addrh, u8 addrm, u8 addrl, > + u8 len, u8 *buf) > +{ > + struct device *dev = &ctx->client->dev; > + int ret; > + u8 cmd; > + > + if (len > MAX_DPCD_BUFFER_SIZE) { > + DRM_DEV_ERROR(dev, "exceed aux buffer len.\n"); > + return -EINVAL; > + } > + > + cmd = ((len - 1) << 4) | 0x08; > + > + /* Set command and length */ > + ret = anx7625_reg_write(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_COMMAND, cmd); > + > + /* Set aux access address */ > + ret |= anx7625_reg_write(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_ADDR_7_0, addrl); > + ret |= anx7625_reg_write(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_ADDR_15_8, addrm); > + ret |= anx7625_write_and(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_ADDR_19_16, addrh); > + > + /* Set write data */ > + ret |= anx7625_reg_block_write(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_BUFF_START, len, buf); > + /* Enable aux access */ > + ret |= anx7625_write_or(ctx, ctx->i2c.rx_p0_client, > + AP_AUX_CTRL_STATUS, AP_AUX_CTRL_OP_EN); > + if (ret < 0) { > + DRM_DEV_ERROR(dev, "cannot access aux related register.\n"); > + return -EIO; > + } > + > + usleep_range(2000, 2100); > + > + ret = wait_aux_op_finish(ctx); > + if (ret) { > + DRM_DEV_ERROR(dev, "aux IO error: wait aux op finish.\n"); > + return ret; > + } > + > + return 0; > +} > + > static int anx7625_video_mute_control(struct anx7625_data *ctx, > u8 status) > { > @@ -617,6 +683,7 @@ static void anx7625_dp_stop(struct anx7625_data *ctx) > { > struct device *dev = &ctx->client->dev; > int ret; > + u8 data; > > DRM_DEV_DEBUG_DRIVER(dev, "stop dp output\n"); > > @@ -628,8 +695,16 @@ static void anx7625_dp_stop(struct anx7625_data *ctx) > ret |= anx7625_write_and(ctx, ctx->i2c.tx_p2_client, 0x08, 0x7f); > > ret |= anx7625_video_mute_control(ctx, 1); > + > + DRM_DEV_DEBUG_DRIVER(dev, "notify downstream enter into standby\n"); > + > + /* Downstream monitor enter into standby mode */ > + data = 2; > + ret |= anx7625_aux_dpcd_write(ctx, 0x00, 0x06, 0x00, 1, &data); > if (ret < 0) > DRM_DEV_ERROR(dev, "IO error : mute video fail\n"); > + > + return; > } Reviewed-by: Robert Foss _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel