From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D403C63777 for ; Thu, 26 Nov 2020 10:01:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E2ED21741 for ; Thu, 26 Nov 2020 10:01:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m/RAn4j/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387539AbgKZKAc (ORCPT ); Thu, 26 Nov 2020 05:00:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726099AbgKZKAb (ORCPT ); Thu, 26 Nov 2020 05:00:31 -0500 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20D69C0613D4 for ; Thu, 26 Nov 2020 02:00:31 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id 81so1329904pgf.0 for ; Thu, 26 Nov 2020 02:00:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5XA0ApxkdYkNVzbIa+l8SCSGXdHgS+0zpLkv05NT+6E=; b=m/RAn4j/Di3wbxTiswv/NVX8FZj2MzWPsbTEE7oMx3mNtlF6JO/27T0BRHMKcqIx13 CapfIcx0h4gRcqnXfy+cI5SEK3zwX7s5+5p7S1/0E82mWg5yOUeF8bCu0ubwExUHV+bD al8kPtWGEzCEhvuz878g9apzGL2qKBZ8EbVwjtvYHcZFULVedxWzibmB8aza+tgg+uhd bni3r/77FyvJHj6UEuLeopgMSUVWpmQ/StuSk6nJQtsCotugBXB89qgpOQ9uUqAnNKp8 Ew8nmtAanqUzxGb90N7HyWpw95CEtrZZw3i4hH5DZVZPZNvZjr24dub5IcVyK9ukEaLO 0bHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5XA0ApxkdYkNVzbIa+l8SCSGXdHgS+0zpLkv05NT+6E=; b=Okz/UmbZVoaFNqdT9SSHqEITYd5KsLmFWSuSNvuDnE8z4cGxMottXB6yYblZAVHm7P gFx/xUZ6ozYVDMTNOJ/Qz6RWvVsc90Rt1UZ5hXf6PanpH+S+YQHAnyIBJ3x56MuIW/t5 FYybseh0iNy0Pb78LJhNDBOHTncfjfzArc8LdZkfTfDY0fvoo99INe5xcBA9jx5zpQPI OXCpbbSVXPIBlLPCj/V/VWVhHa+X0aHj438FoKXoJ18K+X67YR+Qn5RSXWFPkD+xzViC VnuKShG0vHEeCZ7Gf1/1qtkpgmT9Os8zOKNjG7jwJtmLpOTYYtasHVBrQfrY55hapUSi uZdQ== X-Gm-Message-State: AOAM530PbNgLPSpkW5jWGy8WLMT0nMha6BWmvme2AK9Gx6u5QvuBLSx6 K49q81SoXdH9WsQIlmaB1oulOmHP1sC5xa39mJf8IA== X-Google-Smtp-Source: ABdhPJy7ZZ7UL8kL3olk5JHgIK/nEWOE+28BBi6hBer2nnJ+GOvZcds4PdIwtYEbFYRVCRACPbg2VxWduqguu37vNOM= X-Received: by 2002:a63:a84f:: with SMTP id i15mr2035192pgp.120.1606384830699; Thu, 26 Nov 2020 02:00:30 -0800 (PST) MIME-Version: 1.0 References: <20201116155008.118124-1-robert.foss@linaro.org> In-Reply-To: From: Robert Foss Date: Thu, 26 Nov 2020 11:00:19 +0100 Message-ID: Subject: Re: [PATCH] media: ov8856: Remove 3280x2464 mode To: Tomasz Figa Cc: Bingbu Cao , Dongchun Zhu , Mauro Carvalho Chehab , linux-media , linux-kernel , Sakari Ailus , Ben Kao Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Nov 2020 at 08:32, Tomasz Figa wrote: > > Hi Bingbu, > > On Wed, Nov 25, 2020 at 1:15 PM Bingbu Cao wrote: > > > > > > > > On 11/24/20 6:20 PM, Robert Foss wrote: > > > On Tue, 24 Nov 2020 at 10:42, Bingbu Cao wrote: > > >> > > >> Hi, Robert > > >> > > >> I remember that the full size of ov8856 image sensor is 3296x2480 and we can get the 3280x2464 > > >> frames based on current settings. > > >> > > >> Do you have any issues with this mode? > > > > > > As far as I can tell using the 3280x2464 mode actually yields an > > > output resolution that is 3264x2448. > > > > > > What does your hardware setup look like? And which revision of the > > > sensor are you using? > > > > > > > Robert, the sensor revision I am using is v1.1. I just checked the actual output pixels on our > > hardware, the output resolution with 2464 mode is 3280x2464, no black pixels. > > > > As Tomasz said, some ISP has the requirement of extra pixel padding, From the ov8856 datasheet, > > the central 3264x2448 pixels are *suggested* to be output from the pixel array and the boundary > > pixels can be used for additional processing. In my understanding, the 32 dummy lines are not > > black lines. > > The datasheet says that only 3264x2448 are active pixels. What pixel > values are you seeing outside of that central area? In the datasheet, > those look like "optically black" pixels, which are not 100% black, > but rather as if the sensor cells didn't receive any light - noise can > be still there. > I've been developing support for some Qcom ISP functionality, and during the course of this I ran into the issue I was describing, where the 3280x2464 mode actually outputs 3264x2448. I can think of two reasons for this, either ISP driver bugs on my end or the fact that the sensor is being run outside of the specification and which could be resulting in differences between how the ov8856 sensors behave.