All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Foss <robert.foss@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: agross@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
	robh+dt@kernel.org, krzk+dt@kernel.org, jonathan@marek.ca,
	tdas@codeaurora.org, anischal@codeaurora.org,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Steev Klimaszewski <steev@kali.org>
Subject: Re: [PATCH v2 1/8] clk: qcom: rcg2: Cache rate changes for parked RCGs
Date: Tue, 3 May 2022 18:23:18 +0200	[thread overview]
Message-ID: <CAG3jFyvMFZbELm8eydGm4Fp+UYQq9SCSUnfF79Y6QvZe4guYDw@mail.gmail.com> (raw)
In-Reply-To: <YnFDwUvFCgrH12zY@builder.lan>

On Tue, 3 May 2022 at 17:01, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> On Tue 03 May 08:04 CDT 2022, Robert Foss wrote:
>
> > From: Bjorn Andersson <bjorn.andersson@linaro.org>
> >
> > As GDSCs are turned on and off some associated clocks are momentarily
> > enabled for house keeping purposes. Failure to enable these clocks seems
> > to have been silently ignored in the past, but starting in SM8350 this
> > failure will prevent the GDSC to turn on.
> >
> > At least on SM8350 this operation will enable the RCG per the
> > configuration in CFG_REG. This means that the current model where the
> > current configuration is written back to CF_REG immediately after
> > parking the RCG doesn't work.
> >
> > Instead, keep track of the currently requested rate of the clock and
> > upon enabling the clock reapply the configuration per the saved rate.
> >
> > Fixes: 7ef6f11887bd ("clk: qcom: Configure the RCGs to a safe source as needed")
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Reviewed-by: Vinod Koul <vkoul@kernel.org>
> > Tested-by: Steev Klimaszewski <steev@kali.org>
> > ---
>
> This patch has been iterated since and the latest incarnation can be
> found on below link. A reference to that in the cover letter would be
> sufficient.
>
> https://lore.kernel.org/linux-arm-msm/20220426212136.1543984-1-bjorn.andersson@linaro.org/
>

Will do, thanks!

      reply	other threads:[~2022-05-03 16:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03 13:04 [PATCH v2 1/8] clk: qcom: rcg2: Cache rate changes for parked RCGs Robert Foss
2022-05-03 13:04 ` [PATCH v2 2/8] clk: Introduce CLK_ASSUME_ENABLED_WHEN_UNUSED Robert Foss
2022-05-03 15:02   ` Bjorn Andersson
2022-05-03 16:23     ` Robert Foss
2022-05-03 13:04 ` [PATCH v2 3/8] clk: qcom: sm8250-dispcc: Flag shared RCGs as assumed enable Robert Foss
2022-05-03 13:04 ` [PATCH v2 4/8] clk: qcom: add support for SM8350 GPUCC Robert Foss
2022-05-03 17:21   ` Bjorn Andersson
2022-05-03 20:39     ` Jonathan Marek
2022-05-04 12:24     ` Robert Foss
2022-05-03 13:04 ` [PATCH v2 5/8] dt-bindings: clock: Add Qcom SM8350 GPUCC bindings Robert Foss
2022-05-03 17:24   ` Bjorn Andersson
2022-05-03 13:04 ` [PATCH v2 6/8] clk: qcom: add support for SM8350 DISPCC Robert Foss
2022-05-03 17:25   ` Bjorn Andersson
2022-05-03 17:47     ` Robert Foss
2022-05-03 13:04 ` [PATCH v2 7/8] dt-bindings: clock: Add Qcom SM8350 DISPCC bindings Robert Foss
2022-05-03 17:26   ` Bjorn Andersson
2022-05-03 17:47     ` Robert Foss
2022-05-03 13:04 ` [PATCH v2 8/8] arm64: dts: qcom: sm8350: Add DISPCC node Robert Foss
2022-05-03 17:27   ` Bjorn Andersson
2022-05-03 15:01 ` [PATCH v2 1/8] clk: qcom: rcg2: Cache rate changes for parked RCGs Bjorn Andersson
2022-05-03 16:23   ` Robert Foss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAG3jFyvMFZbELm8eydGm4Fp+UYQq9SCSUnfF79Y6QvZe4guYDw@mail.gmail.com \
    --to=robert.foss@linaro.org \
    --cc=agross@kernel.org \
    --cc=anischal@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jonathan@marek.ca \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=steev@kali.org \
    --cc=tdas@codeaurora.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.