From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B428C433ED for ; Wed, 28 Apr 2021 15:47:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A057E6105A for ; Wed, 28 Apr 2021 15:47:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A057E6105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DEF2688FDD; Wed, 28 Apr 2021 15:47:35 +0000 (UTC) Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B03D6E111 for ; Wed, 28 Apr 2021 15:47:08 +0000 (UTC) Received: by mail-pj1-x1033.google.com with SMTP id l10-20020a17090a850ab0290155b06f6267so3145223pjn.5 for ; Wed, 28 Apr 2021 08:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FR4VebHJb51xCPyIYHwDlPXBLlPi9HnbG6Ct8peaY2k=; b=pa0Dt5H3GtN3dXiSJu/8K3iibwIyRBRb2PS8cC82+QX4EUK1GDjf/XSwzV+sstKU4A evlP8lqeosCXknvxdSbcJ7fMTBJAA+hLmegYAQV+WDcXkdb4L1HJ+bjfghlgmKbz5UtS IariBHzBCMzLkMuaxTjeNVAXjcul8KomK7/pBfdrP+ku1trJY33+R9n2fAzCgl4ZY5Nt NbaC+cuiMkQyRBOO3jtBuA0b6Jl5tvIzBl45RIRvPnhXE0qYi99C3dIbMsgvUPCCaXdL LFeuv0lem6DcNlWfgD/mTRtCPUZbb2kF4q5aUyV5CvREeELbldOtTkPzt56j8NZcmfrd phzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FR4VebHJb51xCPyIYHwDlPXBLlPi9HnbG6Ct8peaY2k=; b=pEuNPaTauiPJ3ox15eysilK+wQnE1xWTs/JD7kRREFQOOXw7UDIkFEEJpa+6NtxzZo J18nM0AbHV5XCAe+WL7MaWIOLCrkeKT96HU5gtnO53OCZkbMT0zImlK80UabxmLyKPVs DaizPOPSJ11vcIGFsaD9aPEmQbjm8SjoLZsJPJPdxb23aO/vLlZ+XM7RzrVhCi2odQcC j5w9Q6XsioJ5gExdwCsVXLZXnS4cjrjCh/sbrAdmkm5NuD/0BZLvazIakKS87L/k6dfy xbWIIgPdMifIzA3gLIl2Ofx1+GK8YaPUdRooj3/ICnL/Ivo576Viy4QETUtBgQAvfjIc 9YTw== X-Gm-Message-State: AOAM5328QywIOuYvR6O6ulhJwSmdmvFxqJ0HVTDzXOuBIcssa3/p/A4X C0zDcK7ipjNK/lQR/hYGcjd/rN/37WKx9H06E+O0cA== X-Google-Smtp-Source: ABdhPJye0QKIyaf0M7+v5Y7xHFw1H6cygyY4UoYiSfc3SapgV38stH2k8ZYtnt7r1sw1UQQ7rbOJ6iZ1k0CEPXn8JsQ= X-Received: by 2002:a17:90a:6687:: with SMTP id m7mr1966973pjj.75.1619624814266; Wed, 28 Apr 2021 08:46:54 -0700 (PDT) MIME-Version: 1.0 References: <20210428115116.931328-1-hsinyi@chromium.org> In-Reply-To: <20210428115116.931328-1-hsinyi@chromium.org> From: Robert Foss Date: Wed, 28 Apr 2021 17:46:43 +0200 Message-ID: Subject: Re: [PATCH v2] drm/bridge: anx7625: Fix power on delay To: Hsin-Yi Wang X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Neil Armstrong , David Airlie , Jonas Karlman , linux-kernel , dri-devel , Andrzej Hajda , Laurent Pinchart , Sam Ravnborg , Xin Ji Content-Type: multipart/mixed; boundary="===============0330717949==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0330717949== Content-Type: multipart/alternative; boundary="000000000000458c2a05c10a4ad1" --000000000000458c2a05c10a4ad1 Content-Type: text/plain; charset="UTF-8" Merged. https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1fcf24fb07e254ca69001ab14adc8cf567127c44 On Wed, 28 Apr 2021 at 13:51, Hsin-Yi Wang wrote: > From anx7625 spec, the delay between powering on power supplies and gpio > should be larger than 10ms. > > Fixes: 6c744983004e ("drm/bridge: anx7625: disable regulators when power > off") > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Neil Armstrong > --- > v1->v2: Extend sleep range a bit as the regulator on some device takes > more time to be powered on after regulator_enable() is called. > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c > b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 23283ba0c4f9..b4e349ca38fe 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -893,7 +893,7 @@ static void anx7625_power_on(struct anx7625_data *ctx) > usleep_range(2000, 2100); > } > > - usleep_range(4000, 4100); > + usleep_range(11000, 12000); > > /* Power on pin enable */ > gpiod_set_value(ctx->pdata.gpio_p_on, 1); > -- > 2.31.1.498.g6c1eba8ee3d-goog > > --000000000000458c2a05c10a4ad1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, 28 Apr 2021 at 13:51, Hsin-Yi Wang <hsinyi@chromium.org> wrote:
From anx7625 spec, the delay = between powering on power supplies and gpio
should be larger than 10ms.

Fixes: 6c744983004e ("drm/bridge: anx7625: disable regulators when pow= er off")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
v1->v2: Extend sleep range a bit as the regulator on some device takes more time to be powered on after regulator_enable() is called.
---
=C2=A0drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/br= idge/analogix/anx7625.c
index 23283ba0c4f9..b4e349ca38fe 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -893,7 +893,7 @@ static void anx7625_power_on(struct anx7625_data *ctx)<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 usleep_range(2000, = 2100);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }

-=C2=A0 =C2=A0 =C2=A0 =C2=A0usleep_range(4000, 4100);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0usleep_range(11000, 12000);

=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Power on pin enable */
=C2=A0 =C2=A0 =C2=A0 =C2=A0 gpiod_set_value(ctx->pdata.gpio_p_on, 1); --
2.31.1.498.g6c1eba8ee3d-goog

--000000000000458c2a05c10a4ad1-- --===============0330717949== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0330717949==--