From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92AD3C432BE for ; Thu, 29 Jul 2021 11:48:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 791D760EBD for ; Thu, 29 Jul 2021 11:48:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233832AbhG2Lsu (ORCPT ); Thu, 29 Jul 2021 07:48:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232122AbhG2Lst (ORCPT ); Thu, 29 Jul 2021 07:48:49 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8BFDC061765 for ; Thu, 29 Jul 2021 04:48:46 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id j1so9882267pjv.3 for ; Thu, 29 Jul 2021 04:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vxhHsDrYpm2kI+mPYAlWy7FpBAReDvQpjfpTvihE1ZE=; b=XQRdVrXr9ifqpbu6q9ewzE9YUmb4YMlVLGs9JHdGfMbmKe4kAYHSv4WY20+0qdxfGm 5BRybZX5w7SbfyvL9iAXSPOh+xRz8VcvSemDzrTqs4EYxxlH1Eyy7MYcKqSFAWUcrANW iCFxE6oY/wFgElEjL5ktNZGFCcUNqiWgxMdKfhmiVshMAGlHBWppJ0DsRjBLnNKMr0qi osBMKIoO2gsGMbqJSgLmJHcoHZnWU/xvWKoPelN7JheEAJoSsQG8hGpE3X5LyqjG0cgT n8MTJSIDHwUhsK7k+/z9x1Kx2RmeM+/xweoby9TWdXrHItl342LoXyD+wooRp4gOpf+1 MCKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vxhHsDrYpm2kI+mPYAlWy7FpBAReDvQpjfpTvihE1ZE=; b=UWFZdjxkC/csl7UyKRkBOv4PiQayNaNn/WssDqLeCqolER7Sj6Ntj2/GRA8SIwc9dY eMaOv7tuoZbc4euoK+y1yiMUBO6BWuvyHyjqtDhTFVIIrB06ByUx+62ENcCZ03D+O98G DTd/h/nBIlV2XRc5Do664Yju+TtSbRe/V2qtLGter4l3if+QgRn47BO3JH4KBYEitBlL 26V8oUw0KpTEPGCsQd+jc2zUhZMf3W3m6aPnf/9zT4HHVXhnqGF29MHXH9k7o4BQ+nun iukAF7yOFfZkJXXKT0CJxka2LzhC8aEbWgL456PTRRCyKJYY+EafITnJNAgyAo0yAeFF APRw== X-Gm-Message-State: AOAM531Nyvd+Gt0cFolvkJgmRnEovEEZbZHfUr67r4y1C9R4sRZ8ndDN jOTl6rSvVqO9bAZ3kduX3yKN230qUbI3cOMUybWsug== X-Google-Smtp-Source: ABdhPJzmjmbRLZHOYGw8ZKDBP8QSe9qxWf7f2rEWUiJPz48ENWI7qEJjpdwkxa7mxaox1V0XGFReV7579lL4tNxFtQs= X-Received: by 2002:a17:902:da8a:b029:12c:4261:a2d6 with SMTP id j10-20020a170902da8ab029012c4261a2d6mr4372829plx.50.1627559326287; Thu, 29 Jul 2021 04:48:46 -0700 (PDT) MIME-Version: 1.0 References: <20210728164557.1882787-1-dianders@chromium.org> <20210728094511.3.I842d483139531aa4651da8338512fdf0171ff23c@changeid> In-Reply-To: <20210728094511.3.I842d483139531aa4651da8338512fdf0171ff23c@changeid> From: Robert Foss Date: Thu, 29 Jul 2021 13:48:35 +0200 Message-ID: Subject: Re: [PATCH 3/6] drm/bridge: ti-sn65dsi86: Add some 100 us delays To: Douglas Anderson Cc: dri-devel , Thomas Zimmermann , MSM , Andrzej Hajda , Sam Ravnborg , David Airlie , Bjorn Andersson , Daniel Vetter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rodrigo Vivi , Jonas Karlman , Neil Armstrong , Laurent Pinchart , Jernej Skrabec , Maxime Ripard , Linus Walleij , Maarten Lankhorst , rajeevny@codeaurora.org, Lyude Paul , Thierry Reding , Steev Klimaszewski , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hey Doug, Thanks for submitting this. On Wed, 28 Jul 2021 at 18:46, Douglas Anderson wrote: > > The manual has always said that we need 100 us delays in a few > places. Though it hasn't seemed to be a big deal to skip these, let's > add them in case it makes something happier. > > NOTE: this fixes no known issues but it seems good to make it right. > > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 5e932070a1c3..cd0fccdd8dfd 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -307,6 +307,9 @@ static int __maybe_unused ti_sn65dsi86_resume(struct device *dev) > return ret; > } > > + /* td2: min 100 us after regulators before enabling the GPIO */ > + usleep_range(100, 110); > + > gpiod_set_value(pdata->enable_gpio, 1); > > /* > @@ -1096,6 +1099,9 @@ static void ti_sn_bridge_pre_enable(struct drm_bridge *bridge) > > if (!pdata->refclk) > ti_sn65dsi86_enable_comms(pdata); > + > + /* td7: min 100 us after enable before DSI data */ > + usleep_range(100, 110); > } > > static void ti_sn_bridge_post_disable(struct drm_bridge *bridge) > -- > 2.32.0.432.gabb21c7263-goog > Acked-by: Robert Foss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D37AEC4320E for ; Thu, 29 Jul 2021 11:48:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BB1060560 for ; Thu, 29 Jul 2021 11:48:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8BB1060560 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 20A686E25A; Thu, 29 Jul 2021 11:48:48 +0000 (UTC) Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by gabe.freedesktop.org (Postfix) with ESMTPS id C944D6E25A for ; Thu, 29 Jul 2021 11:48:46 +0000 (UTC) Received: by mail-pj1-x102a.google.com with SMTP id m10-20020a17090a34cab0290176b52c60ddso8807497pjf.4 for ; Thu, 29 Jul 2021 04:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vxhHsDrYpm2kI+mPYAlWy7FpBAReDvQpjfpTvihE1ZE=; b=XQRdVrXr9ifqpbu6q9ewzE9YUmb4YMlVLGs9JHdGfMbmKe4kAYHSv4WY20+0qdxfGm 5BRybZX5w7SbfyvL9iAXSPOh+xRz8VcvSemDzrTqs4EYxxlH1Eyy7MYcKqSFAWUcrANW iCFxE6oY/wFgElEjL5ktNZGFCcUNqiWgxMdKfhmiVshMAGlHBWppJ0DsRjBLnNKMr0qi osBMKIoO2gsGMbqJSgLmJHcoHZnWU/xvWKoPelN7JheEAJoSsQG8hGpE3X5LyqjG0cgT n8MTJSIDHwUhsK7k+/z9x1Kx2RmeM+/xweoby9TWdXrHItl342LoXyD+wooRp4gOpf+1 MCKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vxhHsDrYpm2kI+mPYAlWy7FpBAReDvQpjfpTvihE1ZE=; b=BgyWVkVC4ZVY7HHFcxt2Uea19SIuBqcJQoovZCEGoJL62/Yr9tmRkLwZ3sBtAg5tbZ eQI0uS13cURDyvCm14Q40h8/s9NSTkE+TrneeUtSorvsJrAx4jeKHxgf07vqNemQVgIJ QK67+bTLN4PJpNPiHAg730Q590ZLwhYbj311IHcmPgjE2fP1oxwjqrA5c59ObeUNWs7e utJCAWLxFVd1d9EQK6hvlowGIeHvYGLLzffzQXxQr1/TgaxRtriblH2G7bYQYBKgANkG XlJI5hS+BkzDgy1GvZ1fSMDZHn1bJ5uacCfadhwT01Aq6iq7VoxbWwid4KaGS4R/HwKl jckQ== X-Gm-Message-State: AOAM532h3qqWcLe26jg1Nqutx+/AWf1hBoxbZRKjD6eWWxg22CRV/A1O 0chE8YHqSYc8UM1O49tVdxTt13pcSgPKoWsEH+KLLQ== X-Google-Smtp-Source: ABdhPJzmjmbRLZHOYGw8ZKDBP8QSe9qxWf7f2rEWUiJPz48ENWI7qEJjpdwkxa7mxaox1V0XGFReV7579lL4tNxFtQs= X-Received: by 2002:a17:902:da8a:b029:12c:4261:a2d6 with SMTP id j10-20020a170902da8ab029012c4261a2d6mr4372829plx.50.1627559326287; Thu, 29 Jul 2021 04:48:46 -0700 (PDT) MIME-Version: 1.0 References: <20210728164557.1882787-1-dianders@chromium.org> <20210728094511.3.I842d483139531aa4651da8338512fdf0171ff23c@changeid> In-Reply-To: <20210728094511.3.I842d483139531aa4651da8338512fdf0171ff23c@changeid> From: Robert Foss Date: Thu, 29 Jul 2021 13:48:35 +0200 Message-ID: Subject: Re: [PATCH 3/6] drm/bridge: ti-sn65dsi86: Add some 100 us delays To: Douglas Anderson Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , dri-devel , Bjorn Andersson , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Sam Ravnborg , Jernej Skrabec , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Thomas Zimmermann , Jonas Karlman , MSM , Steev Klimaszewski , Rodrigo Vivi , rajeevny@codeaurora.org, linux-kernel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hey Doug, Thanks for submitting this. On Wed, 28 Jul 2021 at 18:46, Douglas Anderson wrote: > > The manual has always said that we need 100 us delays in a few > places. Though it hasn't seemed to be a big deal to skip these, let's > add them in case it makes something happier. > > NOTE: this fixes no known issues but it seems good to make it right. > > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 5e932070a1c3..cd0fccdd8dfd 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -307,6 +307,9 @@ static int __maybe_unused ti_sn65dsi86_resume(struct device *dev) > return ret; > } > > + /* td2: min 100 us after regulators before enabling the GPIO */ > + usleep_range(100, 110); > + > gpiod_set_value(pdata->enable_gpio, 1); > > /* > @@ -1096,6 +1099,9 @@ static void ti_sn_bridge_pre_enable(struct drm_bridge *bridge) > > if (!pdata->refclk) > ti_sn65dsi86_enable_comms(pdata); > + > + /* td7: min 100 us after enable before DSI data */ > + usleep_range(100, 110); > } > > static void ti_sn_bridge_post_disable(struct drm_bridge *bridge) > -- > 2.32.0.432.gabb21c7263-goog > Acked-by: Robert Foss