All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <roland@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Oliver Neukum <oliver@neukum.org>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: cdc_ncm kernel log spam with trendnet 2.5G USB adapter
Date: Tue, 22 Dec 2020 19:01:23 -0800	[thread overview]
Message-ID: <CAG4TOxM0BJ4TcVfcqx1E6r-ozgVGrLfFWzgxuqyGtTSiVvNpXQ@mail.gmail.com> (raw)
In-Reply-To: <20201222184926.35382198@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On Tue, Dec 22, 2020 at 6:49 PM Jakub Kicinski <kuba@kernel.org> wrote:

> I'm not sure what the story here is but if this change is expected to
> get into the networking tree we'll need a fresh posting. This sort of
> scissored reply does not get into patchwork.

OK, will resend.  Too bad about patchwork, "git am" drops everything
before scissors lines by default.

> It sounds like you're getting tens of those messages a second, we can
> remove the message but the device is still generating spurious events,
> wasting CPU cycles. Was blocking those events deemed unfeasible?

I certainly don't know enough about the USB CDC class to know why the
spurious messages are showing up or whether they could be suppressed
without a fix in the adapter firmware.  But even ~30 spurious messages
per second doesn't seem so bad for a multi-gig adapter that might be
handling 100,000 or more packets per second.

 - R.

  reply	other threads:[~2020-12-23  3:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16 17:23 cdc_ncm kernel log spam with trendnet 2.5G USB adapter Roland Dreier
2020-11-26 12:05 ` Oliver Neukum
     [not found] ` <3a9b2c8c275d56d9c7904cf9b5177047b196173d.camel@neukum.org>
2020-12-01 20:42   ` Roland Dreier
2020-12-19 22:21   ` Roland Dreier
2020-12-23  2:49     ` Jakub Kicinski
2020-12-23  3:01       ` Roland Dreier [this message]
2020-12-24  3:21       ` [PATCH] CDC-NCM: remove "connected" log message Roland Dreier
2020-12-24  7:53         ` Greg KH
2020-12-28 21:30           ` Jakub Kicinski
2020-12-29  7:56             ` Roland Dreier
2020-12-29 12:30               ` Oliver Neukum
     [not found]               ` <24c6faa2a4f91c721d9a7f14bb7b641b89ae987d.camel@neukum.org>
2020-12-29 19:50                 ` Roland Dreier
2020-12-30 11:03                   ` Oliver Neukum
2020-12-31 18:51                     ` Roland Dreier
2021-01-04 14:57                       ` Oliver Neukum
2021-01-04 19:13                         ` Roland Dreier
2021-01-05 14:04                           ` Oliver Neukum
2021-01-06  0:19                             ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAG4TOxM0BJ4TcVfcqx1E6r-ozgVGrLfFWzgxuqyGtTSiVvNpXQ@mail.gmail.com \
    --to=roland@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.