From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Leonard Subject: Re: [PATCH ARM v5 15/20] mini-os: enable test_xenbus again Date: Fri, 27 Jun 2014 13:48:35 +0100 Message-ID: References: <1403782117-15125-1-git-send-email-talex5@gmail.com> <1403782117-15125-16-git-send-email-talex5@gmail.com> <1403867148.25894.27.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X0Va2-0000ac-Sb for xen-devel@lists.xenproject.org; Fri, 27 Jun 2014 12:48:39 +0000 Received: by mail-ob0-f172.google.com with SMTP id uy5so5539635obc.17 for ; Fri, 27 Jun 2014 05:48:35 -0700 (PDT) In-Reply-To: <1403867148.25894.27.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , David Scott , Samuel Thibault , Anil Madhavapeddy List-Id: xen-devel@lists.xenproject.org On 27 June 2014 12:05, Ian Campbell wrote: > On Thu, 2014-06-26 at 12:28 +0100, Thomas Leonard wrote: >> The old code said "Xenbus tests disabled, because of a Xend bug". >> Since xend doesn't exist any longer, we can enable these again. > > Out of curiosity, do you know if they work now? (I don't think the > answer should block this patch either way). On ARM, with all the patches I sent applied, the output is: [...] Doing xenbus test. Periodic thread started. T(s=0 us=1253) Got a reply, type 16, id 1, len 7. Doing ls test. ls device... ls device[0] -> suspend ls device[1] -> vbd ls device[2] -> vif ls device/vif... ls device/vif[0] -> 0 ls device/vif/0... ls device/vif/0[0] -> backend ls device/vif/0[1] -> backend-id ls device/vif/0[2] -> state ls device/vif/0[3] -> handle ls device/vif/0[4] -> mac Doing read test. Read device/vif/0/mac... Read device/vif/0/mac -> 00:16:3e:7d:69:0d. Read device/vif/0/backend... Read device/vif/0/backend -> /local/domain/0/backend/vif/1/0. Doing write test. Write flobble to device/vif/0/flibble... Success. Read device/vif/0/flibble... Read device/vif/0/flibble -> flobble. Write widget to device/vif/0/flibble... Success. Read device/vif/0/flibble... Read device/vif/0/flibble -> widget. Doing rm test. rm device/vif/0/flibble... Success. Read device/vif/0/flibble... Error in xenbus read: ENOENT (Should have said ENOENT) Thread "xenbus_tester" exited. T(s=1 us=1543) [...] >> Signed-off-by: Thomas Leonard >> --- >> extras/mini-os/test.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/extras/mini-os/test.c b/extras/mini-os/test.c >> index bbfc613..20d372b 100644 >> --- a/extras/mini-os/test.c >> +++ b/extras/mini-os/test.c >> @@ -56,8 +56,7 @@ void test_xenbus(void); >> >> static void xenbus_tester(void *p) >> { >> - printk("Xenbus tests disabled, because of a Xend bug.\n"); >> - /* test_xenbus(); */ >> + test_xenbus(); >> } >> #endif >> > > -- Dr Thomas Leonard http://0install.net/ GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 GPG: DA98 25AE CAD0 8975 7CDA BD8E 0713 3F96 CA74 D8BA