From: Parav Pandit <pandit.parav@gmail.com>
To: Haggai Eran <haggaie@mellanox.com>
Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Tejun Heo <tj@kernel.org>,
lizefan@huawei.com, Johannes Weiner <hannes@cmpxchg.org>,
Doug Ledford <dledford@redhat.com>,
Liran Liss <liranl@mellanox.com>,
"Hefty, Sean" <sean.hefty@intel.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Jonathan Corbet <corbet@lwn.net>,
james.l.morris@oracle.com, serge@hallyn.com,
Or Gerlitz <ogerlitz@mellanox.com>,
Matan Barak <matanb@mellanox.com>,
raindel@mellanox.com, akpm@linux-foundation.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller
Date: Thu, 25 Feb 2016 19:56:01 +0530 [thread overview]
Message-ID: <CAG53R5WxXYZof4QzuJndakzvG1+t388pDRXL2O466eEDkYJ+bw@mail.gmail.com> (raw)
In-Reply-To: <CAG53R5UZb=9WR7zk2b5C_FuKmt+WdNkbcrVbW+g1-oAj6J=w_Q@mail.gmail.com>
> Can we call kfree() with spin_lock held? All these years I tend to
> avoid doing so.
Also it doesn't look correct to hold the lock while freeing the memory
which is totally unrelated to the lock.
With that I think current code appears ok with exception that its
duplicated at two place for code readability around lock.
What say?
next prev parent reply other threads:[~2016-02-25 14:26 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 11:00 [PATCHv6 0/3] rdmacg: IB/core: rdma controller support Parav Pandit
2016-02-20 11:00 ` Parav Pandit
2016-02-20 11:00 ` [PATCHv6 2/3] IB/core: added support to use rdma cgroup controller Parav Pandit
[not found] ` <1455966006-13774-3-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-24 13:43 ` Haggai Eran
2016-02-24 13:43 ` Haggai Eran
2016-02-24 16:05 ` Parav Pandit
[not found] ` <1455966006-13774-1-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-20 11:00 ` [PATCHv6 1/3] rdmacg: Added " Parav Pandit
2016-02-20 11:00 ` Parav Pandit
2016-02-21 7:43 ` Leon Romanovsky
2016-02-21 11:33 ` Parav Pandit
[not found] ` <CAG53R5XGJESb+_-FtjLsK+jHoEmbePLd==G2knBMOcrfdPm62Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-21 13:45 ` Leon Romanovsky
2016-02-21 13:45 ` Leon Romanovsky
[not found] ` <20160221134518.GM30450-2ukJVAZIZ/Y@public.gmane.org>
2016-02-21 14:11 ` Parav Pandit
2016-02-21 14:11 ` Parav Pandit
2016-02-21 15:09 ` Leon Romanovsky
2016-02-21 15:15 ` Parav Pandit
2016-02-24 13:13 ` Haggai Eran
2016-02-24 13:13 ` Haggai Eran
[not found] ` <56CDAC7A.6030206-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-02-24 16:16 ` Parav Pandit
2016-02-24 16:16 ` Parav Pandit
[not found] ` <CAG53R5Uof+Ve7CndWy=BrgtxxCisQpzP_Ls0kw=Q270DhoEsZw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-25 12:03 ` Haggai Eran
2016-02-25 12:03 ` Haggai Eran
[not found] ` <56CEED81.7010507-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-02-25 13:34 ` Parav Pandit
2016-02-25 13:34 ` Parav Pandit
2016-02-25 14:26 ` Parav Pandit [this message]
[not found] ` <CAG53R5WxXYZof4QzuJndakzvG1+t388pDRXL2O466eEDkYJ+bw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-25 14:42 ` Haggai Eran
2016-02-25 14:42 ` Haggai Eran
[not found] ` <CAG53R5UZb=9WR7zk2b5C_FuKmt+WdNkbcrVbW+g1-oAj6J=w_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-25 14:30 ` Haggai Eran
2016-02-25 14:30 ` Haggai Eran
2016-02-20 11:00 ` [PATCHv6 3/3] rdmacg: Added documentation for rdmacg Parav Pandit
2016-02-20 11:00 ` Parav Pandit
2016-02-20 11:00 ` Parav Pandit
[not found] ` <1455966006-13774-4-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-24 14:26 ` Haggai Eran
2016-02-24 14:26 ` Haggai Eran
2016-02-24 15:21 ` Parav Pandit
2016-02-28 8:55 ` Haggai Eran
2016-02-28 8:55 ` Haggai Eran
2016-02-28 9:02 ` Parav Pandit
2016-02-22 4:59 ` [PATCHv6 0/3] rdmacg: IB/core: rdma controller support Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG53R5WxXYZof4QzuJndakzvG1+t388pDRXL2O466eEDkYJ+bw@mail.gmail.com \
--to=pandit.parav@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dledford@redhat.com \
--cc=haggaie@mellanox.com \
--cc=hannes@cmpxchg.org \
--cc=james.l.morris@oracle.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=liranl@mellanox.com \
--cc=lizefan@huawei.com \
--cc=matanb@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=raindel@mellanox.com \
--cc=sean.hefty@intel.com \
--cc=serge@hallyn.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.