From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ig0-f172.google.com ([209.85.213.172]:33285 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932360AbbFCRkv convert rfc822-to-8bit (ORCPT ); Wed, 3 Jun 2015 13:40:51 -0400 Received: by igbpi8 with SMTP id pi8so117333703igb.0 for ; Wed, 03 Jun 2015 10:40:51 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1433187843-20698-1-git-send-email-cfliu.tw@gmail.com> From: "Liu CF/TW" Date: Wed, 3 Jun 2015 10:40:11 -0700 Message-ID: (sfid-20150603_194056_552242_37DD2643) Subject: Re: [PATCH 1/2] ath10k: add cryptmode param to support sw crypto and raw tx injection. To: Michal Kazior Cc: "ath10k@lists.infradead.org" , linux-wireless , Kalle Valo Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: >>>> diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h >>>> index 85cca29..37fd2f83 100644 >>>> --- a/drivers/net/wireless/ath/ath10k/hw.h >>>> +++ b/drivers/net/wireless/ath/ath10k/hw.h >>>> @@ -296,7 +296,7 @@ enum ath10k_hw_rate_cck { >>>> #define TARGET_10X_RX_SKIP_DEFRAG_TIMEOUT_DUP_DETECTION_CHECK 1 >>>> #define TARGET_10X_VOW_CONFIG 0 >>>> #define TARGET_10X_NUM_MSDU_DESC (1024 + 400) >>>> -#define TARGET_10X_MAX_FRAG_ENTRIES 0 >>>> +#define TARGET_10X_MAX_FRAG_ENTRIES 10 >>> >>> This is probably enough at "2" (ath10k doesn't send more than 2 tx >>> fragments now). I assume fw crashes with raw tx if this isn't fixed, >>> correct? >>> >>> Sidenote: I guess TARGET_MAX_FRAG_ENTRIES could be fixed as well. It >>> might make sense for QCA61X4 hw2.1 which still uses the old Rx >>> indication event and might be able to do raw txrx + swcrypto. But I'm >>> a bit reluctant to change this without any testing. >>> >> >> Sure. I change it to 10 because the document I got from QCA says so. >> Since this is a global setting, I will remove this and keep it =0 for >> now so it doesn't affect existing HW based datapath. > > Sure. I recall 10.x on QCA988X isn't really picky on this value. > QCA61X4 with wmi-tlv on the other hand needs an adequate value for > this configuration parameter or it'll crash horribly. > > >> Per QCA, the main issue not changing this would be SW crypto then >> won't be able to handle large Rx AMSDU. >> When HW is not doing Rx decryption, the whole AMSDU needs to be DMA to >> host for SW based decryption & AMSDU subframe deaggregation. > > Hmm.. From what I know this setting refers to the max number of Tx > fragments that can be submitted via HTT TX_FRM command eventually to > HW MAC, not Rx fragments. > Yeah you are right. I checked the QCA's PDF again and indeed it's for Tx not for Rx. David > > Michał From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ie0-x22e.google.com ([2607:f8b0:4001:c03::22e]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z0CfB-0004KU-FQ for ath10k@lists.infradead.org; Wed, 03 Jun 2015 17:41:14 +0000 Received: by iesa3 with SMTP id a3so18757367ies.2 for ; Wed, 03 Jun 2015 10:40:51 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1433187843-20698-1-git-send-email-cfliu.tw@gmail.com> From: "Liu CF/TW" Date: Wed, 3 Jun 2015 10:40:11 -0700 Message-ID: Subject: Re: [PATCH 1/2] ath10k: add cryptmode param to support sw crypto and raw tx injection. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior Cc: Kalle Valo , linux-wireless , "ath10k@lists.infradead.org" Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9ody5oIGIv ZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9ody5oCj4+Pj4gaW5kZXggODVjY2EyOS4u MzdmZDJmODMgMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEw ay9ody5oCj4+Pj4gKysrIGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9ody5oCj4+ Pj4gQEAgLTI5Niw3ICsyOTYsNyBAQCBlbnVtIGF0aDEwa19od19yYXRlX2NjayB7Cj4+Pj4gICNk ZWZpbmUgVEFSR0VUXzEwWF9SWF9TS0lQX0RFRlJBR19USU1FT1VUX0RVUF9ERVRFQ1RJT05fQ0hF Q0sgMQo+Pj4+ICAjZGVmaW5lIFRBUkdFVF8xMFhfVk9XX0NPTkZJRyAgICAgICAgICAgICAgICAg IDAKPj4+PiAgI2RlZmluZSBUQVJHRVRfMTBYX05VTV9NU0RVX0RFU0MgICAgICAgICAgICAgICAo MTAyNCArIDQwMCkKPj4+PiAtI2RlZmluZSBUQVJHRVRfMTBYX01BWF9GUkFHX0VOVFJJRVMgICAg ICAgICAgICAwCj4+Pj4gKyNkZWZpbmUgVEFSR0VUXzEwWF9NQVhfRlJBR19FTlRSSUVTICAgICAg ICAgICAgMTAKPj4+Cj4+PiBUaGlzIGlzIHByb2JhYmx5IGVub3VnaCBhdCAiMiIgKGF0aDEwayBk b2Vzbid0IHNlbmQgbW9yZSB0aGFuIDIgdHgKPj4+IGZyYWdtZW50cyBub3cpLiBJIGFzc3VtZSBm dyBjcmFzaGVzIHdpdGggcmF3IHR4IGlmIHRoaXMgaXNuJ3QgZml4ZWQsCj4+PiBjb3JyZWN0Pwo+ Pj4KPj4+IFNpZGVub3RlOiBJIGd1ZXNzIFRBUkdFVF9NQVhfRlJBR19FTlRSSUVTIGNvdWxkIGJl IGZpeGVkIGFzIHdlbGwuIEl0Cj4+PiBtaWdodCBtYWtlIHNlbnNlIGZvciBRQ0E2MVg0IGh3Mi4x IHdoaWNoIHN0aWxsIHVzZXMgdGhlIG9sZCBSeAo+Pj4gaW5kaWNhdGlvbiBldmVudCBhbmQgbWln aHQgYmUgYWJsZSB0byBkbyByYXcgdHhyeCArIHN3Y3J5cHRvLiBCdXQgSSdtCj4+PiBhIGJpdCBy ZWx1Y3RhbnQgdG8gY2hhbmdlIHRoaXMgd2l0aG91dCBhbnkgdGVzdGluZy4KPj4+Cj4+Cj4+IFN1 cmUuIEkgY2hhbmdlIGl0IHRvIDEwIGJlY2F1c2UgdGhlIGRvY3VtZW50IEkgZ290IGZyb20gUUNB IHNheXMgc28uCj4+IFNpbmNlIHRoaXMgaXMgYSBnbG9iYWwgc2V0dGluZywgSSB3aWxsIHJlbW92 ZSB0aGlzIGFuZCBrZWVwIGl0ID0wIGZvcgo+PiBub3cgc28gaXQgZG9lc24ndCBhZmZlY3QgZXhp c3RpbmcgSFcgYmFzZWQgZGF0YXBhdGguCj4KPiBTdXJlLiBJIHJlY2FsbCAxMC54IG9uIFFDQTk4 OFggaXNuJ3QgcmVhbGx5IHBpY2t5IG9uIHRoaXMgdmFsdWUuCj4gUUNBNjFYNCB3aXRoIHdtaS10 bHYgb24gdGhlIG90aGVyIGhhbmQgbmVlZHMgYW4gYWRlcXVhdGUgdmFsdWUgZm9yCj4gdGhpcyBj b25maWd1cmF0aW9uIHBhcmFtZXRlciBvciBpdCdsbCBjcmFzaCBob3JyaWJseS4KPgo+Cj4+IFBl ciBRQ0EsIHRoZSBtYWluIGlzc3VlIG5vdCBjaGFuZ2luZyB0aGlzIHdvdWxkIGJlIFNXIGNyeXB0 byB0aGVuCj4+IHdvbid0IGJlIGFibGUgdG8gaGFuZGxlIGxhcmdlIFJ4IEFNU0RVLgo+PiBXaGVu IEhXIGlzIG5vdCBkb2luZyBSeCBkZWNyeXB0aW9uLCB0aGUgd2hvbGUgQU1TRFUgbmVlZHMgdG8g YmUgRE1BIHRvCj4+IGhvc3QgZm9yIFNXIGJhc2VkIGRlY3J5cHRpb24gJiBBTVNEVSBzdWJmcmFt ZSBkZWFnZ3JlZ2F0aW9uLgo+Cj4gSG1tLi4gRnJvbSB3aGF0IEkga25vdyB0aGlzIHNldHRpbmcg cmVmZXJzIHRvIHRoZSBtYXggbnVtYmVyIG9mIFR4Cj4gZnJhZ21lbnRzIHRoYXQgY2FuIGJlIHN1 Ym1pdHRlZCB2aWEgSFRUIFRYX0ZSTSBjb21tYW5kIGV2ZW50dWFsbHkgdG8KPiBIVyBNQUMsIG5v dCBSeCBmcmFnbWVudHMuCj4KClllYWggeW91IGFyZSByaWdodC4gSSBjaGVja2VkIHRoZSBRQ0En cyBQREYgYWdhaW4gYW5kIGluZGVlZCBpdCdzIGZvcgpUeCBub3QgZm9yIFJ4LgoKRGF2aWQKPgo+ IE1pY2hhxYIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK