From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Northup Subject: Re: [RFC v5 86/86] 440fx: fix PAM, PCI holes Date: Mon, 25 Jul 2011 14:34:07 -0700 Message-ID: References: <1311180636-17012-1-git-send-email-avi@redhat.com> <1311180636-17012-87-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from smtp-out.google.com ([216.239.44.51]:44108 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751661Ab1GYVeK convert rfc822-to-8bit (ORCPT ); Mon, 25 Jul 2011 17:34:10 -0400 Received: from kpbe16.cbf.corp.google.com (kpbe16.cbf.corp.google.com [172.25.105.80]) by smtp-out.google.com with ESMTP id p6PLY99N012108 for ; Mon, 25 Jul 2011 14:34:09 -0700 Received: from gwm11 (gwm11.prod.google.com [10.200.13.11]) by kpbe16.cbf.corp.google.com with ESMTP id p6PLXYPs006700 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 25 Jul 2011 14:34:08 -0700 Received: by gwm11 with SMTP id 11so3480910gwm.2 for ; Mon, 25 Jul 2011 14:34:08 -0700 (PDT) In-Reply-To: <1311180636-17012-87-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jul 20, 2011 at 9:50 AM, Avi Kivity wrote: [...] > @@ -130,7 +137,13 @@ static void pc_init1(MemoryRegion *system_memory= , > > =A0 =A0 if (pci_enabled) { > =A0 =A0 =A0 =A0 pci_bus =3D i440fx_init(&i440fx_state, &piix3_devfn, = isa_irq, > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0system_m= emory, system_io, ram_size); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0system_m= emory, system_io, ram_size, > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A00xe00000= 00, 0x1fe00000, > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A00x100000= 000 + above_4g_mem_size, > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(sizeof(= target_phys_addr_t) =3D=3D 32 sizeof(target_phys_addr_t) =3D=3D 8 ? > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ? 0 > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 : ((uin= t64_t)1 << 63)), > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0pci_memo= ry, ram_memory); > =A0 =A0 } else { > =A0 =A0 =A0 =A0 pci_bus =3D NULL; > =A0 =A0 =A0 =A0 i440fx_state =3D NULL; From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlSmy-0004uy-Md for qemu-devel@nongnu.org; Mon, 25 Jul 2011 17:34:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlSmw-0004OP-QL for qemu-devel@nongnu.org; Mon, 25 Jul 2011 17:34:12 -0400 Received: from smtp-out.google.com ([216.239.44.51]:44104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlSmw-0004OL-Kw for qemu-devel@nongnu.org; Mon, 25 Jul 2011 17:34:10 -0400 Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101]) by smtp-out.google.com with ESMTP id p6PLY94a012106 for ; Mon, 25 Jul 2011 14:34:09 -0700 Received: from gwb1 (gwb1.prod.google.com [10.200.2.1]) by wpaz37.hot.corp.google.com with ESMTP id p6PLWnU8003777 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 25 Jul 2011 14:34:08 -0700 Received: by gwb1 with SMTP id 1so4990443gwb.8 for ; Mon, 25 Jul 2011 14:34:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1311180636-17012-87-git-send-email-avi@redhat.com> References: <1311180636-17012-1-git-send-email-avi@redhat.com> <1311180636-17012-87-git-send-email-avi@redhat.com> Date: Mon, 25 Jul 2011 14:34:07 -0700 Message-ID: From: Eric Northup Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On Wed, Jul 20, 2011 at 9:50 AM, Avi Kivity wrote: [...] > @@ -130,7 +137,13 @@ static void pc_init1(MemoryRegion *system_memory, > > =A0 =A0 if (pci_enabled) { > =A0 =A0 =A0 =A0 pci_bus =3D i440fx_init(&i440fx_state, &piix3_devfn, isa_= irq, > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0system_memor= y, system_io, ram_size); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0system_memor= y, system_io, ram_size, > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A00xe0000000, = 0x1fe00000, > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A00x100000000 = + above_4g_mem_size, > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(sizeof(targ= et_phys_addr_t) =3D=3D 32 sizeof(target_phys_addr_t) =3D=3D 8 ? > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ? 0 > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 : ((uint64_= t)1 << 63)), > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0pci_memory, = ram_memory); > =A0 =A0 } else { > =A0 =A0 =A0 =A0 pci_bus =3D NULL; > =A0 =A0 =A0 =A0 i440fx_state =3D NULL;