All of lore.kernel.org
 help / color / mirror / Atom feed
From: Moni Shoua <monis@mellanox.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Doug Ledford <dledford@redhat.com>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] IB/rxe: fix GFP_KERNEL in spinlock context
Date: Sun, 4 Sep 2016 13:01:29 +0300	[thread overview]
Message-ID: <CAG9sBKPQf=G0WpJXf0UAhDXdtaF9i5ZXBQ8rCv9nEORBKjp28g@mail.gmail.com> (raw)
In-Reply-To: <1472849213-27579-1-git-send-email-khoroshilov@ispras.ru>

On Fri, Sep 2, 2016 at 11:46 PM, Alexey Khoroshilov
<khoroshilov@ispras.ru> wrote:
> There is skb_clone(skb, GFP_KERNEL) in spinlock context
> in rxe_rcv_mcast_pkt().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
>  drivers/infiniband/sw/rxe/rxe_recv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/rxe/rxe_recv.c
> index 3d464c23e08b..144d2f129fcd 100644
> --- a/drivers/infiniband/sw/rxe/rxe_recv.c
> +++ b/drivers/infiniband/sw/rxe/rxe_recv.c
> @@ -312,7 +312,7 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
>                  * make a copy of the skb to post to the next qp
>                  */
>                 skb_copy = (mce->qp_list.next != &mcg->qp_list) ?
> -                               skb_clone(skb, GFP_KERNEL) : NULL;
> +                               skb_clone(skb, GFP_ATOMIC) : NULL;
>
>                 pkt->qp = qp;
>                 rxe_add_ref(qp);
> --
> 2.7.4
>
Acked-by: Moni Shoua <monis@mellanox.com>

  reply	other threads:[~2016-09-04 10:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 20:46 [PATCH] IB/rxe: fix GFP_KERNEL in spinlock context Alexey Khoroshilov
2016-09-02 20:46 ` Alexey Khoroshilov
2016-09-04 10:01 ` Moni Shoua [this message]
     [not found]   ` <CAG9sBKPQf=G0WpJXf0UAhDXdtaF9i5ZXBQ8rCv9nEORBKjp28g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-16 17:55     ` Doug Ledford
2016-09-16 17:55       ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAG9sBKPQf=G0WpJXf0UAhDXdtaF9i5ZXBQ8rCv9nEORBKjp28g@mail.gmail.com' \
    --to=monis@mellanox.com \
    --cc=dledford@redhat.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=khoroshilov@ispras.ru \
    --cc=ldv-project@linuxtesting.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sean.hefty@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.