All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: Goodix touchscreen works intermittently, fails reading config info.
@ 2016-09-12 17:32 Brad Baker
  2016-09-12 17:43 ` Brad Baker
  2016-09-13  3:04 ` Brad Baker
  0 siblings, 2 replies; 11+ messages in thread
From: Brad Baker @ 2016-09-12 17:32 UTC (permalink / raw)
  To: Tirdea, Irina; +Cc: bastien nocera, linux-input

Irina,
  The user just reported... "the TS is not working every time, here is
a log from when it is not working". The below logging appears to show
that setting the default trigger_type=0 when read_config fails does
not make a difference.  His statement that it's not working *every
time* is curious because he said before it was working like 9 out of
10 times he booted up.

http://pastebin.com/hpWbgpTe
[   10.922484] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
[   10.927791] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
x_max: 0, y_max: 0, touch_num: 0, trigger_type: 0
[   10.927797] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
[   10.927912] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
[   10.928112] input: Goodix Capacitive TouchScreen as
/devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6

source: https://github.com/blocksonic/gt9xx/blob/device-tree/goodix.c

I'm waiting for him to send the ACPI table data you requested.  I was
not sure exactly how to do this. I asked him to run this series of
commands which worked on my machine.  Is it OK?

mkdir ~/acpitables
cd /sys/firmware/acpi/tables/
for i in * ; do sudo cat $i > ~/acpitables/$i.dat; done
cd ~/acpitables
for i in * ; do iasl -d $i ; done
cat *.dsl >> chuwi_hi12_acpi.dsl

Also: following is an older log prior to my code changes where
read_config was succeeding but the user reported the touchscreen was
registering touch events in the wrong place.  This may have been some
fluke as he has not been reporting this type of problem happening
often or since.  Also appended to the end of this log is output from
dmidecode if it's  helpful:  http://pastebin.com/6QWF6JB8


On Sun, Sep 11, 2016 at 4:28 PM, Brad Baker <bbaker6212@gmail.com> wrote:
> Hi Irina,
>   I don't have the tablet. The user's last reply yesterday was this:
> "here is a log of the, TS working with your latest edits
> http://pastebin.com/mhMpa3Zj . it might be a couple days before i can
> do much more testing on it.  "
> So I'm still waiting to find out if my changing the default
> trigger_type=0 had any effect when read_config fails.
> That log of the working case shows things as expected.
>
> [   12.356637] goodix_backport: loading out-of-tree module taints kernel.
> [   12.356739] goodix_backport: module verification failed: signature
> and/or required key missing - tainting kernel
> [   12.364644] intel_sst_acpi 808622A8:00: No matching machine driver found
> [   12.365892] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
> [   12.373813] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
> x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
> [   12.373822] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
> x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
> [   12.373998] input: Goodix Capacitive TouchScreen as
> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
>
>
>
> On Sun, Sep 11, 2016 at 3:54 PM, Tirdea, Irina <irina.tirdea@intel.com> wrote:
>>
>>
>>> -----Original Message-----
>>> From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Brad Baker
>>> Sent: 11 September, 2016 0:21
>>> To: bastien nocera
>>> Cc: linux-input@vger.kernel.org
>>> Subject: Goodix touchscreen works intermittently, fails reading config info.
>>>
>>> Summary: Goodix touchscreen works intermittently, fails reading config info.
>>>  https://bugzilla.kernel.org/show_bug.cgi?id=156511
>>>
>>> Description:  Chuwi Hi12 tablet with Intel cherry-trail Atom Z8300,
>>> the touchscreen does work after bootup most of the time, but sometimes
>>> it does not work without running modprobe.  When it fails the dmesg
>>> log shows the error "Invalid config, using defaults" and when it works
>>> this error is not present.
>>>
>>> Module: goodix, goodix_backport
>>> Linux version 4.8.0-040800rc5-generic (kernel@tangerine) (gcc version
>>> 6.2.0 20160830 (Ubuntu 6.2.0-2ubuntu11) ) #201609041832 SMP Sun Sep 4
>>> 22:34:01 UTC 2016
>>>
>>> dmesg log when it's failing:
>>> [ 10.012314] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
>>> [ 10.017711] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
>>> [ 10.018021] input: Goodix Capacitive TouchScreen as
>>> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
>>>
>>> details given in bugzilla #156511
>>
>> Hi Brad,
>>
>> I had similar problems with some Goodix devices until I enabled the
>> reset sequence [1].
>>
>> Although the touch screen was initialized and I could read/write to/from
>> the device, I read only 0s from the configuration registers. The datasheet
>> recommends using the reset procedure at power on, so I could not find any
>> information on how to make the device work reliably without it. Resetting the
>> device at boot fixed the problem for me. For backwards compatibility, the
>> reset sequence is only available if the interrupt and reset gpio pins are
>> connected and configured through _DSD properties in the ACPI table or DT
>> properties.
>>
>> One reason for the touchscreen not working in this case is that the interrupts
>> are not properly configured. I noticed in the Bugzilla details that you already
>> tried changing the default value for trigger_type to the one read from the device.
>> Did that work?
>>
>> Regards,
>> Irina
>>
>> [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ec6e1b4082d9f5b0858ce33169a1c22a27a982f6

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Goodix touchscreen works intermittently, fails reading config info.
  2016-09-12 17:32 Goodix touchscreen works intermittently, fails reading config info Brad Baker
@ 2016-09-12 17:43 ` Brad Baker
  2016-09-13  3:04 ` Brad Baker
  1 sibling, 0 replies; 11+ messages in thread
From: Brad Baker @ 2016-09-12 17:43 UTC (permalink / raw)
  To: Tirdea, Irina; +Cc: bastien nocera, linux-input

Irina, here is the ACPI table data you requested for this device
(Chuwi Hi12 tablet) : http://pastebin.com/84cjD8kp

On Mon, Sep 12, 2016 at 2:32 PM, Brad Baker <bbaker6212@gmail.com> wrote:
> Irina,
>   The user just reported... "the TS is not working every time, here is
> a log from when it is not working". The below logging appears to show
> that setting the default trigger_type=0 when read_config fails does
> not make a difference.  His statement that it's not working *every
> time* is curious because he said before it was working like 9 out of
> 10 times he booted up.
>
> http://pastebin.com/hpWbgpTe
> [   10.922484] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
> [   10.927791] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
> x_max: 0, y_max: 0, touch_num: 0, trigger_type: 0
> [   10.927797] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
> [   10.927912] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
> x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
> [   10.928112] input: Goodix Capacitive TouchScreen as
> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
>
> source: https://github.com/blocksonic/gt9xx/blob/device-tree/goodix.c
>
> I'm waiting for him to send the ACPI table data you requested.  I was
> not sure exactly how to do this. I asked him to run this series of
> commands which worked on my machine.  Is it OK?
>
> mkdir ~/acpitables
> cd /sys/firmware/acpi/tables/
> for i in * ; do sudo cat $i > ~/acpitables/$i.dat; done
> cd ~/acpitables
> for i in * ; do iasl -d $i ; done
> cat *.dsl >> chuwi_hi12_acpi.dsl
>
> Also: following is an older log prior to my code changes where
> read_config was succeeding but the user reported the touchscreen was
> registering touch events in the wrong place.  This may have been some
> fluke as he has not been reporting this type of problem happening
> often or since.  Also appended to the end of this log is output from
> dmidecode if it's  helpful:  http://pastebin.com/6QWF6JB8
>
>
> On Sun, Sep 11, 2016 at 4:28 PM, Brad Baker <bbaker6212@gmail.com> wrote:
>> Hi Irina,
>>   I don't have the tablet. The user's last reply yesterday was this:
>> "here is a log of the, TS working with your latest edits
>> http://pastebin.com/mhMpa3Zj . it might be a couple days before i can
>> do much more testing on it.  "
>> So I'm still waiting to find out if my changing the default
>> trigger_type=0 had any effect when read_config fails.
>> That log of the working case shows things as expected.
>>
>> [   12.356637] goodix_backport: loading out-of-tree module taints kernel.
>> [   12.356739] goodix_backport: module verification failed: signature
>> and/or required key missing - tainting kernel
>> [   12.364644] intel_sst_acpi 808622A8:00: No matching machine driver found
>> [   12.365892] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
>> [   12.373813] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
>> x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
>> [   12.373822] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
>> x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
>> [   12.373998] input: Goodix Capacitive TouchScreen as
>> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
>>
>>
>>
>> On Sun, Sep 11, 2016 at 3:54 PM, Tirdea, Irina <irina.tirdea@intel.com> wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Brad Baker
>>>> Sent: 11 September, 2016 0:21
>>>> To: bastien nocera
>>>> Cc: linux-input@vger.kernel.org
>>>> Subject: Goodix touchscreen works intermittently, fails reading config info.
>>>>
>>>> Summary: Goodix touchscreen works intermittently, fails reading config info.
>>>>  https://bugzilla.kernel.org/show_bug.cgi?id=156511
>>>>
>>>> Description:  Chuwi Hi12 tablet with Intel cherry-trail Atom Z8300,
>>>> the touchscreen does work after bootup most of the time, but sometimes
>>>> it does not work without running modprobe.  When it fails the dmesg
>>>> log shows the error "Invalid config, using defaults" and when it works
>>>> this error is not present.
>>>>
>>>> Module: goodix, goodix_backport
>>>> Linux version 4.8.0-040800rc5-generic (kernel@tangerine) (gcc version
>>>> 6.2.0 20160830 (Ubuntu 6.2.0-2ubuntu11) ) #201609041832 SMP Sun Sep 4
>>>> 22:34:01 UTC 2016
>>>>
>>>> dmesg log when it's failing:
>>>> [ 10.012314] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
>>>> [ 10.017711] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
>>>> [ 10.018021] input: Goodix Capacitive TouchScreen as
>>>> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
>>>>
>>>> details given in bugzilla #156511
>>>
>>> Hi Brad,
>>>
>>> I had similar problems with some Goodix devices until I enabled the
>>> reset sequence [1].
>>>
>>> Although the touch screen was initialized and I could read/write to/from
>>> the device, I read only 0s from the configuration registers. The datasheet
>>> recommends using the reset procedure at power on, so I could not find any
>>> information on how to make the device work reliably without it. Resetting the
>>> device at boot fixed the problem for me. For backwards compatibility, the
>>> reset sequence is only available if the interrupt and reset gpio pins are
>>> connected and configured through _DSD properties in the ACPI table or DT
>>> properties.
>>>
>>> One reason for the touchscreen not working in this case is that the interrupts
>>> are not properly configured. I noticed in the Bugzilla details that you already
>>> tried changing the default value for trigger_type to the one read from the device.
>>> Did that work?
>>>
>>> Regards,
>>> Irina
>>>
>>> [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ec6e1b4082d9f5b0858ce33169a1c22a27a982f6

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Goodix touchscreen works intermittently, fails reading config info.
  2016-09-12 17:32 Goodix touchscreen works intermittently, fails reading config info Brad Baker
  2016-09-12 17:43 ` Brad Baker
@ 2016-09-13  3:04 ` Brad Baker
  2016-09-14  9:29   ` Tirdea, Irina
  1 sibling, 1 reply; 11+ messages in thread
From: Brad Baker @ 2016-09-13  3:04 UTC (permalink / raw)
  To: Tirdea, Irina; +Cc: bastien nocera, linux-input

Irina, a little more info on the symptoms. The user reports the
touchscreen works when restarting but fails when powering on.  He says
pretty much 100% of the time.  The log is the same...

http://pastebin.com/25haaPQd
[   10.246074] goodix_backport: loading out-of-tree module taints kernel.
[   10.246172] goodix_backport: module verification failed: signature
and/or required key missing - tainting kernel
[   10.263788] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
[   10.270135] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
x_max: 0, y_max: 0, touch_num: 0, trigger_type: 0
[   10.270141] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
[   10.270258] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
[   10.270608] input: Goodix Capacitive TouchScreen as
/devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6

On Mon, Sep 12, 2016 at 2:32 PM, Brad Baker <bbaker6212@gmail.com> wrote:
> Irina,
>   The user just reported... "the TS is not working every time, here is
> a log from when it is not working". The below logging appears to show
> that setting the default trigger_type=0 when read_config fails does
> not make a difference.  His statement that it's not working *every
> time* is curious because he said before it was working like 9 out of
> 10 times he booted up.
>
> http://pastebin.com/hpWbgpTe
> [   10.922484] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
> [   10.927791] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
> x_max: 0, y_max: 0, touch_num: 0, trigger_type: 0
> [   10.927797] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
> [   10.927912] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
> x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
> [   10.928112] input: Goodix Capacitive TouchScreen as
> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
>
> source: https://github.com/blocksonic/gt9xx/blob/device-tree/goodix.c
>
> I'm waiting for him to send the ACPI table data you requested.  I was
> not sure exactly how to do this. I asked him to run this series of
> commands which worked on my machine.  Is it OK?
>
> mkdir ~/acpitables
> cd /sys/firmware/acpi/tables/
> for i in * ; do sudo cat $i > ~/acpitables/$i.dat; done
> cd ~/acpitables
> for i in * ; do iasl -d $i ; done
> cat *.dsl >> chuwi_hi12_acpi.dsl
>
> Also: following is an older log prior to my code changes where
> read_config was succeeding but the user reported the touchscreen was
> registering touch events in the wrong place.  This may have been some
> fluke as he has not been reporting this type of problem happening
> often or since.  Also appended to the end of this log is output from
> dmidecode if it's  helpful:  http://pastebin.com/6QWF6JB8
>
>
> On Sun, Sep 11, 2016 at 4:28 PM, Brad Baker <bbaker6212@gmail.com> wrote:
>> Hi Irina,
>>   I don't have the tablet. The user's last reply yesterday was this:
>> "here is a log of the, TS working with your latest edits
>> http://pastebin.com/mhMpa3Zj . it might be a couple days before i can
>> do much more testing on it.  "
>> So I'm still waiting to find out if my changing the default
>> trigger_type=0 had any effect when read_config fails.
>> That log of the working case shows things as expected.
>>
>> [   12.356637] goodix_backport: loading out-of-tree module taints kernel.
>> [   12.356739] goodix_backport: module verification failed: signature
>> and/or required key missing - tainting kernel
>> [   12.364644] intel_sst_acpi 808622A8:00: No matching machine driver found
>> [   12.365892] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
>> [   12.373813] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
>> x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
>> [   12.373822] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
>> x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
>> [   12.373998] input: Goodix Capacitive TouchScreen as
>> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
>>
>>
>>
>> On Sun, Sep 11, 2016 at 3:54 PM, Tirdea, Irina <irina.tirdea@intel.com> wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Brad Baker
>>>> Sent: 11 September, 2016 0:21
>>>> To: bastien nocera
>>>> Cc: linux-input@vger.kernel.org
>>>> Subject: Goodix touchscreen works intermittently, fails reading config info.
>>>>
>>>> Summary: Goodix touchscreen works intermittently, fails reading config info.
>>>>  https://bugzilla.kernel.org/show_bug.cgi?id=156511
>>>>
>>>> Description:  Chuwi Hi12 tablet with Intel cherry-trail Atom Z8300,
>>>> the touchscreen does work after bootup most of the time, but sometimes
>>>> it does not work without running modprobe.  When it fails the dmesg
>>>> log shows the error "Invalid config, using defaults" and when it works
>>>> this error is not present.
>>>>
>>>> Module: goodix, goodix_backport
>>>> Linux version 4.8.0-040800rc5-generic (kernel@tangerine) (gcc version
>>>> 6.2.0 20160830 (Ubuntu 6.2.0-2ubuntu11) ) #201609041832 SMP Sun Sep 4
>>>> 22:34:01 UTC 2016
>>>>
>>>> dmesg log when it's failing:
>>>> [ 10.012314] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
>>>> [ 10.017711] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
>>>> [ 10.018021] input: Goodix Capacitive TouchScreen as
>>>> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
>>>>
>>>> details given in bugzilla #156511
>>>
>>> Hi Brad,
>>>
>>> I had similar problems with some Goodix devices until I enabled the
>>> reset sequence [1].
>>>
>>> Although the touch screen was initialized and I could read/write to/from
>>> the device, I read only 0s from the configuration registers. The datasheet
>>> recommends using the reset procedure at power on, so I could not find any
>>> information on how to make the device work reliably without it. Resetting the
>>> device at boot fixed the problem for me. For backwards compatibility, the
>>> reset sequence is only available if the interrupt and reset gpio pins are
>>> connected and configured through _DSD properties in the ACPI table or DT
>>> properties.
>>>
>>> One reason for the touchscreen not working in this case is that the interrupts
>>> are not properly configured. I noticed in the Bugzilla details that you already
>>> tried changing the default value for trigger_type to the one read from the device.
>>> Did that work?
>>>
>>> Regards,
>>> Irina
>>>
>>> [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ec6e1b4082d9f5b0858ce33169a1c22a27a982f6

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: Goodix touchscreen works intermittently, fails reading config info.
  2016-09-13  3:04 ` Brad Baker
@ 2016-09-14  9:29   ` Tirdea, Irina
  2016-10-12 19:48     ` sergk sergk2mail
  0 siblings, 1 reply; 11+ messages in thread
From: Tirdea, Irina @ 2016-09-14  9:29 UTC (permalink / raw)
  To: Brad Baker; +Cc: bastien nocera, linux-input



> -----Original Message-----
> From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Brad Baker
> Sent: 13 September, 2016 6:05
> To: Tirdea, Irina
> Cc: bastien nocera; linux-input@vger.kernel.org
> Subject: Re: Goodix touchscreen works intermittently, fails reading config info.
> 
> Irina, a little more info on the symptoms. The user reports the
> touchscreen works when restarting but fails when powering on.  He says
> pretty much 100% of the time.  The log is the same...
> 

Hi Brad,

Thanks for all the information you provided. I have already replied on the
Bugzilla thread with some patches that enable reset for the device.

Regards,
Irina


> http://pastebin.com/25haaPQd
> [   10.246074] goodix_backport: loading out-of-tree module taints kernel.
> [   10.246172] goodix_backport: module verification failed: signature
> and/or required key missing - tainting kernel
> [   10.263788] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
> [   10.270135] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
> x_max: 0, y_max: 0, touch_num: 0, trigger_type: 0
> [   10.270141] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
> [   10.270258] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
> x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
> [   10.270608] input: Goodix Capacitive TouchScreen as
> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
> 


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Goodix touchscreen works intermittently, fails reading config info.
  2016-09-14  9:29   ` Tirdea, Irina
@ 2016-10-12 19:48     ` sergk sergk2mail
  0 siblings, 0 replies; 11+ messages in thread
From: sergk sergk2mail @ 2016-10-12 19:48 UTC (permalink / raw)
  To: Tirdea, Irina; +Cc: Brad Baker, bastien nocera, linux-input

Hello from ;-) Chuwi tablets warrior.
Actually have done all requested, .cfg, bin, working module, etc are
located : https://gitlab.com/SergK/chuwi_hi12/tree/master.

Many thanks and regards,
                             Serge Kolotylo.


On Wed, Sep 14, 2016 at 9:29 AM, Tirdea, Irina <irina.tirdea@intel.com> wrote:
>
>
>> -----Original Message-----
>> From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Brad Baker
>> Sent: 13 September, 2016 6:05
>> To: Tirdea, Irina
>> Cc: bastien nocera; linux-input@vger.kernel.org
>> Subject: Re: Goodix touchscreen works intermittently, fails reading config info.
>>
>> Irina, a little more info on the symptoms. The user reports the
>> touchscreen works when restarting but fails when powering on.  He says
>> pretty much 100% of the time.  The log is the same...
>>
>
> Hi Brad,
>
> Thanks for all the information you provided. I have already replied on the
> Bugzilla thread with some patches that enable reset for the device.
>
> Regards,
> Irina
>
>
>> http://pastebin.com/25haaPQd
>> [   10.246074] goodix_backport: loading out-of-tree module taints kernel.
>> [   10.246172] goodix_backport: module verification failed: signature
>> and/or required key missing - tainting kernel
>> [   10.263788] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
>> [   10.270135] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
>> x_max: 0, y_max: 0, touch_num: 0, trigger_type: 0
>> [   10.270141] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
>> [   10.270258] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
>> x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
>> [   10.270608] input: Goodix Capacitive TouchScreen as
>> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
>>
>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: Goodix touchscreen works intermittently, fails reading config info.
  2016-10-12 20:37 Brad Baker
@ 2016-10-17 20:31 ` Tirdea, Irina
  0 siblings, 0 replies; 11+ messages in thread
From: Tirdea, Irina @ 2016-10-17 20:31 UTC (permalink / raw)
  To: Brad Baker, sergk sergk2mail; +Cc: bastien nocera, linux-input



> -----Original Message-----
> From: Brad Baker [mailto:bbaker6212@gmail.com]
> Sent: 12 October, 2016 23:37
> To: sergk sergk2mail
> Cc: Tirdea, Irina; bastien nocera; linux-input@vger.kernel.org
> Subject: Re: Goodix touchscreen works intermittently, fails reading config info.
> 

Hi Brad, Serge,

I already replied in the Bugzilla bug [1]. In order to not duplicate the discussion,
I will post all my replies there.

Regards,
Irina

[1] https://bugzilla.kernel.org/show_bug.cgi?id=156511

> Irina, I just saw this after updating the Bug 156511 with Serg's info.
> He says he just used the following single patch to generate the Chuwi
> Hi12 firmware file and get it working using
> ubuntu-16.10-beta2-desktop-amd64.iso:
> https://github.com/itirdea/linux/commit/13008b8535120c4a35f0bc8951895455cd706290.patch
> 
> On Wed, Oct 12, 2016 at 4:48 PM, sergk sergk2mail <sergk.admin@gmail.com> wrote:
> > Hello from ;-) Chuwi tablets warrior.
> > Actually have done all requested, .cfg, bin, working module, etc are
> > located : https://gitlab.com/SergK/chuwi_hi12/tree/master.
> >
> > Many thanks and regards,
> >                              Serge Kolotylo.
> >
> >


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Goodix touchscreen works intermittently, fails reading config info.
@ 2016-10-12 20:37 Brad Baker
  2016-10-17 20:31 ` Tirdea, Irina
  0 siblings, 1 reply; 11+ messages in thread
From: Brad Baker @ 2016-10-12 20:37 UTC (permalink / raw)
  To: sergk sergk2mail; +Cc: Tirdea, Irina, bastien nocera, linux-input

Irina, I just saw this after updating the Bug 156511 with Serg's info.
He says he just used the following single patch to generate the Chuwi
Hi12 firmware file and get it working using
ubuntu-16.10-beta2-desktop-amd64.iso:
https://github.com/itirdea/linux/commit/13008b8535120c4a35f0bc8951895455cd706290.patch

On Wed, Oct 12, 2016 at 4:48 PM, sergk sergk2mail <sergk.admin@gmail.com> wrote:
> Hello from ;-) Chuwi tablets warrior.
> Actually have done all requested, .cfg, bin, working module, etc are
> located : https://gitlab.com/SergK/chuwi_hi12/tree/master.
>
> Many thanks and regards,
>                              Serge Kolotylo.
>
>
> On Wed, Sep 14, 2016 at 9:29 AM, Tirdea, Irina <irina.tirdea@intel.com> wrote:
>>
>>
>>> -----Original Message-----
>>> From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Brad Baker
>>> Sent: 13 September, 2016 6:05
>>> To: Tirdea, Irina
>>> Cc: bastien nocera; linux-input@vger.kernel.org
>>> Subject: Re: Goodix touchscreen works intermittently, fails reading config info.
>>>
>>> Irina, a little more info on the symptoms. The user reports the
>>> touchscreen works when restarting but fails when powering on.  He says
>>> pretty much 100% of the time.  The log is the same...
>>>
>>
>> Hi Brad,
>>
>> Thanks for all the information you provided. I have already replied on the
>> Bugzilla thread with some patches that enable reset for the device.
>>
>> Regards,
>> Irina
>>
>>
>>> http://pastebin.com/25haaPQd
>>> [   10.246074] goodix_backport: loading out-of-tree module taints kernel.
>>> [   10.246172] goodix_backport: module verification failed: signature
>>> and/or required key missing - tainting kernel
>>> [   10.263788] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
>>> [   10.270135] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
>>> x_max: 0, y_max: 0, touch_num: 0, trigger_type: 0
>>> [   10.270141] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
>>> [   10.270258] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
>>> x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
>>> [   10.270608] input: Goodix Capacitive TouchScreen as
>>> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
>>>
>>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Goodix touchscreen works intermittently, fails reading config info.
@ 2016-10-03  0:53 Brad Baker
  0 siblings, 0 replies; 11+ messages in thread
From: Brad Baker @ 2016-10-03  0:53 UTC (permalink / raw)
  To: Tirdea, Irina; +Cc: bastien nocera, linux-input

On Wed, Sep 14, 2016 at 6:29 AM, Tirdea, Irina <irina.tirdea@intel.com> wrote:
>
>
>> -----Original Message-----
>> From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Brad Baker
>> Sent: 13 September, 2016 6:05
>> To: Tirdea, Irina
>> Cc: bastien nocera; linux-input@vger.kernel.org
>> Subject: Re: Goodix touchscreen works intermittently, fails reading config info.
>>
>> Irina, a little more info on the symptoms. The user reports the
>> touchscreen works when restarting but fails when powering on.  He says
>> pretty much 100% of the time.  The log is the same...
>>
>
> Hi Brad,
>
> Thanks for all the information you provided. I have already replied on the
> Bugzilla thread with some patches that enable reset for the device.
>
> Regards,
> Irina
>
>

Hi Irina, please see my updates to your Bugzilla comments.
In the directions for generating the firmware file I did not understand this:
"set Config_Fresh to 1 and generate the binary config firmware image"
Where is Config_Fresh set?  Do I set it to 1 at the top of the shell script?...
https://github.com/blocksonic/gt9xx/blob/device-tree/goodix-generate-fw.sh

Also, your comment was not clear to me...
"You might need to revert the patch that enables reset for the Chuwi tablet [3]"
Under what conditions do I need to move these changes?

The user is reporting the following dmesg output with your latest code...

[    8.635097] goodix_backport: loading out-of-tree module taints kernel.
[    8.635878] goodix_backport: module verification failed: signature
and/or required key missing - tainting kernel
[    8.644537] Goodix-TS i2c-GDIX1001:00: I2C Address: 0x14
[    8.644549] Goodix-TS i2c-GDIX1001:00: Applying gpios quirk
[    8.679120] EFI Variables Facility v0.08 2004-May-17
[    8.690345] pstore: using zlib compression
[    8.690382] pstore: Registered efi as persistent store backend
[    8.741171] Goodix-TS i2c-GDIX1001:00: i2c test failed attempt 1: -121
[    8.772461] Goodix-TS i2c-GDIX1001:00: i2c test failed attempt 2: -121
[    8.797575] Goodix-TS i2c-GDIX1001:00: I2C communication failure: -121
[    8.819003] SSE version of gcm_enc/dec engaged.
[    8.821731] Goodix-TS: probe of i2c-GDIX1001:00 failed with error -121

Please see my latest posts on Bugzilla.  Thanks, -Brad-

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Goodix touchscreen works intermittently, fails reading config info.
  2016-09-11 18:54 ` Tirdea, Irina
@ 2016-09-11 19:28   ` Brad Baker
  0 siblings, 0 replies; 11+ messages in thread
From: Brad Baker @ 2016-09-11 19:28 UTC (permalink / raw)
  To: Tirdea, Irina; +Cc: bastien nocera, linux-input

Hi Irina,
  I don't have the tablet. The user's last reply yesterday was this:
"here is a log of the, TS working with your latest edits
http://pastebin.com/mhMpa3Zj . it might be a couple days before i can
do much more testing on it.  "
So I'm still waiting to find out if my changing the default
trigger_type=0 had any effect when read_config fails.
That log of the working case shows things as expected.

[   12.356637] goodix_backport: loading out-of-tree module taints kernel.
[   12.356739] goodix_backport: module verification failed: signature
and/or required key missing - tainting kernel
[   12.364644] intel_sst_acpi 808622A8:00: No matching machine driver found
[   12.365892] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
[   12.373813] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
[   12.373822] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
[   12.373998] input: Goodix Capacitive TouchScreen as
/devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6

<====== Note: =====>
Please note my change of email address I will be moving to soon:
bradleybaker@protonmail.com
<================>


On Sun, Sep 11, 2016 at 3:54 PM, Tirdea, Irina <irina.tirdea@intel.com> wrote:
>
>
>> -----Original Message-----
>> From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Brad Baker
>> Sent: 11 September, 2016 0:21
>> To: bastien nocera
>> Cc: linux-input@vger.kernel.org
>> Subject: Goodix touchscreen works intermittently, fails reading config info.
>>
>> Summary: Goodix touchscreen works intermittently, fails reading config info.
>>  https://bugzilla.kernel.org/show_bug.cgi?id=156511
>>
>> Description:  Chuwi Hi12 tablet with Intel cherry-trail Atom Z8300,
>> the touchscreen does work after bootup most of the time, but sometimes
>> it does not work without running modprobe.  When it fails the dmesg
>> log shows the error "Invalid config, using defaults" and when it works
>> this error is not present.
>>
>> Module: goodix, goodix_backport
>> Linux version 4.8.0-040800rc5-generic (kernel@tangerine) (gcc version
>> 6.2.0 20160830 (Ubuntu 6.2.0-2ubuntu11) ) #201609041832 SMP Sun Sep 4
>> 22:34:01 UTC 2016
>>
>> dmesg log when it's failing:
>> [ 10.012314] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
>> [ 10.017711] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
>> [ 10.018021] input: Goodix Capacitive TouchScreen as
>> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
>>
>> details given in bugzilla #156511
>
> Hi Brad,
>
> I had similar problems with some Goodix devices until I enabled the
> reset sequence [1].
>
> Although the touch screen was initialized and I could read/write to/from
> the device, I read only 0s from the configuration registers. The datasheet
> recommends using the reset procedure at power on, so I could not find any
> information on how to make the device work reliably without it. Resetting the
> device at boot fixed the problem for me. For backwards compatibility, the
> reset sequence is only available if the interrupt and reset gpio pins are
> connected and configured through _DSD properties in the ACPI table or DT
> properties.
>
> One reason for the touchscreen not working in this case is that the interrupts
> are not properly configured. I noticed in the Bugzilla details that you already
> tried changing the default value for trigger_type to the one read from the device.
> Did that work?
>
> Regards,
> Irina
>
> [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ec6e1b4082d9f5b0858ce33169a1c22a27a982f6

^ permalink raw reply	[flat|nested] 11+ messages in thread

* RE: Goodix touchscreen works intermittently, fails reading config info.
  2016-09-10 21:21 Brad Baker
@ 2016-09-11 18:54 ` Tirdea, Irina
  2016-09-11 19:28   ` Brad Baker
  0 siblings, 1 reply; 11+ messages in thread
From: Tirdea, Irina @ 2016-09-11 18:54 UTC (permalink / raw)
  To: Brad Baker, bastien nocera; +Cc: linux-input



> -----Original Message-----
> From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Brad Baker
> Sent: 11 September, 2016 0:21
> To: bastien nocera
> Cc: linux-input@vger.kernel.org
> Subject: Goodix touchscreen works intermittently, fails reading config info.
> 
> Summary: Goodix touchscreen works intermittently, fails reading config info.
>  https://bugzilla.kernel.org/show_bug.cgi?id=156511
> 
> Description:  Chuwi Hi12 tablet with Intel cherry-trail Atom Z8300,
> the touchscreen does work after bootup most of the time, but sometimes
> it does not work without running modprobe.  When it fails the dmesg
> log shows the error "Invalid config, using defaults" and when it works
> this error is not present.
> 
> Module: goodix, goodix_backport
> Linux version 4.8.0-040800rc5-generic (kernel@tangerine) (gcc version
> 6.2.0 20160830 (Ubuntu 6.2.0-2ubuntu11) ) #201609041832 SMP Sun Sep 4
> 22:34:01 UTC 2016
> 
> dmesg log when it's failing:
> [ 10.012314] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
> [ 10.017711] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
> [ 10.018021] input: Goodix Capacitive TouchScreen as
> /devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6
> 
> details given in bugzilla #156511

Hi Brad,

I had similar problems with some Goodix devices until I enabled the
reset sequence [1].

Although the touch screen was initialized and I could read/write to/from
the device, I read only 0s from the configuration registers. The datasheet
recommends using the reset procedure at power on, so I could not find any
information on how to make the device work reliably without it. Resetting the
device at boot fixed the problem for me. For backwards compatibility, the
reset sequence is only available if the interrupt and reset gpio pins are
connected and configured through _DSD properties in the ACPI table or DT
properties.

One reason for the touchscreen not working in this case is that the interrupts
are not properly configured. I noticed in the Bugzilla details that you already
tried changing the default value for trigger_type to the one read from the device.
Did that work?

Regards,
Irina

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ec6e1b4082d9f5b0858ce33169a1c22a27a982f6

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Goodix touchscreen works intermittently, fails reading config info.
@ 2016-09-10 21:21 Brad Baker
  2016-09-11 18:54 ` Tirdea, Irina
  0 siblings, 1 reply; 11+ messages in thread
From: Brad Baker @ 2016-09-10 21:21 UTC (permalink / raw)
  To: bastien nocera; +Cc: linux-input

Summary: Goodix touchscreen works intermittently, fails reading config info.
 https://bugzilla.kernel.org/show_bug.cgi?id=156511

Description:  Chuwi Hi12 tablet with Intel cherry-trail Atom Z8300,
the touchscreen does work after bootup most of the time, but sometimes
it does not work without running modprobe.  When it fails the dmesg
log shows the error "Invalid config, using defaults" and when it works
this error is not present.

Module: goodix, goodix_backport
Linux version 4.8.0-040800rc5-generic (kernel@tangerine) (gcc version
6.2.0 20160830 (Ubuntu 6.2.0-2ubuntu11) ) #201609041832 SMP Sun Sep 4
22:34:01 UTC 2016

dmesg log when it's failing:
[ 10.012314] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
[ 10.017711] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
[ 10.018021] input: Goodix Capacitive TouchScreen as
/devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6

details given in bugzilla #156511

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2016-10-17 20:31 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 17:32 Goodix touchscreen works intermittently, fails reading config info Brad Baker
2016-09-12 17:43 ` Brad Baker
2016-09-13  3:04 ` Brad Baker
2016-09-14  9:29   ` Tirdea, Irina
2016-10-12 19:48     ` sergk sergk2mail
  -- strict thread matches above, loose matches on Subject: below --
2016-10-12 20:37 Brad Baker
2016-10-17 20:31 ` Tirdea, Irina
2016-10-03  0:53 Brad Baker
2016-09-10 21:21 Brad Baker
2016-09-11 18:54 ` Tirdea, Irina
2016-09-11 19:28   ` Brad Baker

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.