From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbeBHC7n (ORCPT ); Wed, 7 Feb 2018 21:59:43 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:53303 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751269AbeBHC7k (ORCPT ); Wed, 7 Feb 2018 21:59:40 -0500 X-Google-Smtp-Source: AH8x225Bab2cAS5fuvlaVArMkO1scNP6ibSX7O8Enl7arvxt8s4fftiHyAvYR+wd7Ijvegw89INZcoasDJmRris57eI= MIME-Version: 1.0 In-Reply-To: References: <20180207014117.62611-1-dbasehore@chromium.org> <20180207014117.62611-4-dbasehore@chromium.org> From: "dbasehore ." Date: Wed, 7 Feb 2018 18:59:38 -0800 X-Google-Sender-Auth: 6Om51yx-v9_sDsmXGdHKM1qQjak Message-ID: Subject: Re: [PATCH v5 3/4] DT/arm,gic-v3-its: add reset-on-suspend property To: Marc Zyngier Cc: linux-kernel , Soby Mathew , Sudeep Holla , devicetree@vger.kernel.org, robh+dt@kernel.org, Mark Rutland , Linux-pm mailing list , "Wysocki, Rafael J" , Thomas Gleixner , Brian Norris Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 7, 2018 at 1:21 AM, Marc Zyngier wrote: > On 07/02/18 01:41, Derek Basehore wrote: >> This adds documentation for the new reset-on-suspend property. This >> property enables saving and restoring the ITS for when it loses state >> in system suspend. >> >> Signed-off-by: Derek Basehore >> --- >> Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt >> index 0a57f2f4167d..a470147d4f14 100644 >> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt >> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt >> @@ -78,6 +78,9 @@ These nodes must have the following properties: >> Optional: >> - socionext,synquacer-pre-its: (u32, u32) tuple describing the untranslated >> address and size of the pre-ITS window. >> +- reset-on-suspend: Boolean property. Indicates that the ITS state is >> + reset on suspend. The state is then saved on suspend and restored on >> + resume. > > By whom? It is important to be clear about the respective > responsibilities, as this forms a binding contract between firmware and OS. > > Mark: Can you have a look at how to formulate this? I'm not sure we have > other instances of a non-architected behaviour involving FW > participation, aside from PSCI. I'll wait for Mark's reply to reword this. > >> >> The main GIC node must contain the appropriate #address-cells, >> #size-cells and ranges properties for the reg property of all ITS >> > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 From: "dbasehore ." Subject: Re: [PATCH v5 3/4] DT/arm,gic-v3-its: add reset-on-suspend property Date: Wed, 7 Feb 2018 18:59:38 -0800 Message-ID: References: <20180207014117.62611-1-dbasehore@chromium.org> <20180207014117.62611-4-dbasehore@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marc Zyngier Cc: linux-kernel , Soby Mathew , Sudeep Holla , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Mark Rutland , Linux-pm mailing list , "Wysocki, Rafael J" , Thomas Gleixner , Brian Norris List-Id: devicetree@vger.kernel.org On Wed, Feb 7, 2018 at 1:21 AM, Marc Zyngier wrote: > On 07/02/18 01:41, Derek Basehore wrote: >> This adds documentation for the new reset-on-suspend property. This >> property enables saving and restoring the ITS for when it loses state >> in system suspend. >> >> Signed-off-by: Derek Basehore >> --- >> Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt >> index 0a57f2f4167d..a470147d4f14 100644 >> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt >> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt >> @@ -78,6 +78,9 @@ These nodes must have the following properties: >> Optional: >> - socionext,synquacer-pre-its: (u32, u32) tuple describing the untranslated >> address and size of the pre-ITS window. >> +- reset-on-suspend: Boolean property. Indicates that the ITS state is >> + reset on suspend. The state is then saved on suspend and restored on >> + resume. > > By whom? It is important to be clear about the respective > responsibilities, as this forms a binding contract between firmware and OS. > > Mark: Can you have a look at how to formulate this? I'm not sure we have > other instances of a non-architected behaviour involving FW > participation, aside from PSCI. I'll wait for Mark's reply to reword this. > >> >> The main GIC node must contain the appropriate #address-cells, >> #size-cells and ranges properties for the reg property of all ITS >> > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html