From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3643BC433E0 for ; Fri, 7 Aug 2020 03:13:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2367522CAF for ; Fri, 7 Aug 2020 03:13:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RDovZW0c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbgHGDNf (ORCPT ); Thu, 6 Aug 2020 23:13:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbgHGDNe (ORCPT ); Thu, 6 Aug 2020 23:13:34 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC357C061575 for ; Thu, 6 Aug 2020 20:13:32 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id kr4so218285pjb.2 for ; Thu, 06 Aug 2020 20:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mntt/yV9g0WantW+MFUMl7qG7fGk/Oi5dRuY6kccsYw=; b=RDovZW0comW5k7a9qDBhi0AemfQotZc35NVP3B/JDirQCHkb3KxYzbiNVpmHOLFuwB 16VvF1+r+a5Uh0LqZm/NYiMCFqw5Kg84vRSFVEvGutQZxz14IrygV9VS6q8VcYGZw/h1 dHG0UzmQ0xHz10DDkThhfDS9paQ9LrKO/PoEGFXs24VQWqcyQVSzNeshbKpJnxZ1mG0d 5Zf92IcmPVcRjaHg0tRv1sCEKsHUa8AclgHXo1FnE9oTRiP5y2Izlfzg3fZJrgzl3sqd 07fpIFfQH3mur+x5UUTjPLI1b9JvJd346SZpuhDJVf+98Mu6vRZ5H5WCK+dJezuiL7kq YLBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mntt/yV9g0WantW+MFUMl7qG7fGk/Oi5dRuY6kccsYw=; b=etmI0yDp5CiKBGONQrS6gOR81T0AGYVENdUk5PZHIoP/fEWorN12y97Bcj9u3rLDC8 bLGwRw2HBS+XizUPLf/+krDrN3tqD6J4F3AB3K3d9AztDxjDCQCrgiuKxYQYB7tiBX1u 9fTLw9+VYnAnD/jDaRmZJw8maG3F8uHzfsSZ+Ou1Wbv4DRRhEfQuJrZSDMTkjWk+tLNQ +gaOuiB73Xb3sadDfP+0E3KI1GVI5Ytyf+t+a+F2M4UzP9nyQLZ/E3iw98g0xlTpq8G7 8RbFkBopwmue8TXj7Q3EZHLGsD8aTs9TdDXieeVNJ+sXvbIDkq/NbV5IWU5amfpE0pFO VgIQ== X-Gm-Message-State: AOAM533FkN5NmQrsbsfhhrpxBukM0DEiqnLjrLZOXbdr3sLEEszdYiI8 g+KisG2Lv1bCXiaoEpR+irPq4GfK1otstiIoBzH1Mg== X-Google-Smtp-Source: ABdhPJwHf/baXL/FshABJwVK72iC4bCenNX/IrhdV9ee/TdyaNNuV/RPDLg0FYY0/FnAyGhJKXhqedgsCLoHXEgA/TY= X-Received: by 2002:a17:90a:1546:: with SMTP id y6mr2707909pja.93.1596770011948; Thu, 06 Aug 2020 20:13:31 -0700 (PDT) MIME-Version: 1.0 References: <20200718000637.3632841-1-saravanak@google.com> <20200718000637.3632841-3-saravanak@google.com> <78ad0914-6173-f753-9eba-b7cbfbb51fd6@kali.org> <20200807004001.GF20825@builder.lan> <20200807013903.GG20825@builder.lan> In-Reply-To: From: Saravana Kannan Date: Thu, 6 Aug 2020 20:12:56 -0700 Message-ID: Subject: Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros To: John Stultz Cc: Bjorn Andersson , Steev Klimaszewski , Thomas Gleixner , Jason Cooper , Marc Zyngier , Matthias Brugger , Andy Gross , Android Kernel Team , lkml , linux-arm-kernel , "moderated list:ARM/Mediatek SoC support" , linux-arm-msm , Hanks Chen , CC Hwang , Loda Chou , Thierry Reding Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Aug 6, 2020 at 8:09 PM John Stultz wrote: > > On Thu, Aug 6, 2020 at 8:02 PM Saravana Kannan wrote: > > On Thu, Aug 6, 2020 at 7:49 PM John Stultz wrote: > > > On Thu, Aug 6, 2020 at 6:42 PM Bjorn Andersson > > > wrote: > > > > With all due respect, that's your downstream kernel, the upstream kernel > > > > should not rely on luck, out-of-tree patches or kernel parameters. > > > > > > I agree that would be preferred. But kernel parameters are often there > > > for these sorts of cases where we can't always do the right thing. As > > > for out-of-tree patches, broken things don't get fixed until > > > out-of-tree patches are developed and upstreamed, and I know Saravana > > > is doing exactly that, and I hope his fw_devlink work helps fix it so > > > the module loading is not just a matter of luck. > > > > Btw, the only downstream fw_devlink change is setting itto =on (vs > > =permissive in upstream). > > I thought there was the clk_sync_state stuff as well? That's not needed to solve the module load ordering issues and deferred probe issues. That's only needed to keep clocks on till some of the modules are loaded and it depends on fw_devlink, but not really a part of fw_devlink IMHO. And yes, that's on my list of things to upstream. > > > Also I think Thierry's comments in the other thread today are also > > > good ideas for ways to better handle the optional dt link handling > > > (rather than using a timeout). > > > > Could you please give me a lore link to this thread? Just curious. > > Sure: https://lore.kernel.org/lkml/20200806135251.GB3351349@ulmo/ Thanks. -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC91FC433DF for ; Fri, 7 Aug 2020 03:13:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83205221E2 for ; Fri, 7 Aug 2020 03:13:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LpsqvhXA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="RDovZW0c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83205221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TbhGW2luXOwfDHwB0SNKZIO4ukttdSKzwF+76FzKjrw=; b=LpsqvhXAcUPoDVmY/NFx3/z6t 37WIAGVpMBMMUIPAWY9WwHwfsyVSQqT6ur2nU6/tbGrZ3yeXzDLeu1BX/PiVqEn3aicpxtoWp+yje DRyDQn/n7LfRJONTCcbAGhB56ZvVM6dsLhBD+F9YFYTV+sO5yGIwpjlIyUWe+2m8/mVDqXjkp+rJe 8Ua8pSUglyyUKpqzPKC1vcJByJjJPxNuceCc+Xy7/Pm318duRa11bbupBvVslECqqD4HqlKVlxcoN PfknGBl8JqOei0FdkXE7EwmfG0i1zomAaVXpL3YdorVdRPhO8LBN5ux2Ekfgui17Vqts/UKHlaZC9 5NQAZ7Huw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3sp9-0004h6-5m; Fri, 07 Aug 2020 03:13:39 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3sp5-0004fs-7P for linux-mediatek@lists.infradead.org; Fri, 07 Aug 2020 03:13:36 +0000 Received: by mail-pj1-x1041.google.com with SMTP id 2so211747pjx.5 for ; Thu, 06 Aug 2020 20:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mntt/yV9g0WantW+MFUMl7qG7fGk/Oi5dRuY6kccsYw=; b=RDovZW0comW5k7a9qDBhi0AemfQotZc35NVP3B/JDirQCHkb3KxYzbiNVpmHOLFuwB 16VvF1+r+a5Uh0LqZm/NYiMCFqw5Kg84vRSFVEvGutQZxz14IrygV9VS6q8VcYGZw/h1 dHG0UzmQ0xHz10DDkThhfDS9paQ9LrKO/PoEGFXs24VQWqcyQVSzNeshbKpJnxZ1mG0d 5Zf92IcmPVcRjaHg0tRv1sCEKsHUa8AclgHXo1FnE9oTRiP5y2Izlfzg3fZJrgzl3sqd 07fpIFfQH3mur+x5UUTjPLI1b9JvJd346SZpuhDJVf+98Mu6vRZ5H5WCK+dJezuiL7kq YLBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mntt/yV9g0WantW+MFUMl7qG7fGk/Oi5dRuY6kccsYw=; b=YjpxI0LQgAAdnyR0QKDp+OvvEYOm4QsFNyNfUSjnK8b03d3Gg6aCOdri4mD90+ejCG ARJa3j6GNFYA661EG/6+K1rZ5d1xww4cQz57+vDfX8jFns1IH4LHAXTTFUvzDI/Tw6+3 8sTwIU5I7JiClR6+U8lRWx/yV1u3SbsnG3PNcft2ow/DgiXcjmAdkGCPdhV2FbkRiS2H xy4H7Ixm2f4JbTd/5ETQie1pm+wlF3fwwt8JsBpcI4u+LYpQWXreqCuuLSO2+FcVnu40 pdlUDdXVX2uVrSp4qdfUuZXSFR1HGE8bJuNRqL4Jvs1xZ8LH4B9AJU3WTaHM4O5KxxxS nAUA== X-Gm-Message-State: AOAM533BiQrAkJkQaJu39GDO01LTpogaHOD7sEhZV78o3NfMofGDAy17 jt4AdSJ1hGWOUM77FDxDGv5w+d3ejhWo1ooGvJiwHw== X-Google-Smtp-Source: ABdhPJwHf/baXL/FshABJwVK72iC4bCenNX/IrhdV9ee/TdyaNNuV/RPDLg0FYY0/FnAyGhJKXhqedgsCLoHXEgA/TY= X-Received: by 2002:a17:90a:1546:: with SMTP id y6mr2707909pja.93.1596770011948; Thu, 06 Aug 2020 20:13:31 -0700 (PDT) MIME-Version: 1.0 References: <20200718000637.3632841-1-saravanak@google.com> <20200718000637.3632841-3-saravanak@google.com> <78ad0914-6173-f753-9eba-b7cbfbb51fd6@kali.org> <20200807004001.GF20825@builder.lan> <20200807013903.GG20825@builder.lan> In-Reply-To: From: Saravana Kannan Date: Thu, 6 Aug 2020 20:12:56 -0700 Message-ID: Subject: Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros To: John Stultz X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200806_231335_333396_8BD12D7F X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: CC Hwang , Jason Cooper , Marc Zyngier , Hanks Chen , Loda Chou , lkml , Steev Klimaszewski , Bjorn Andersson , Andy Gross , "moderated list:ARM/Mediatek SoC support" , linux-arm-msm , Matthias Brugger , Thierry Reding , Thomas Gleixner , Android Kernel Team , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Aug 6, 2020 at 8:09 PM John Stultz wrote: > > On Thu, Aug 6, 2020 at 8:02 PM Saravana Kannan wrote: > > On Thu, Aug 6, 2020 at 7:49 PM John Stultz wrote: > > > On Thu, Aug 6, 2020 at 6:42 PM Bjorn Andersson > > > wrote: > > > > With all due respect, that's your downstream kernel, the upstream kernel > > > > should not rely on luck, out-of-tree patches or kernel parameters. > > > > > > I agree that would be preferred. But kernel parameters are often there > > > for these sorts of cases where we can't always do the right thing. As > > > for out-of-tree patches, broken things don't get fixed until > > > out-of-tree patches are developed and upstreamed, and I know Saravana > > > is doing exactly that, and I hope his fw_devlink work helps fix it so > > > the module loading is not just a matter of luck. > > > > Btw, the only downstream fw_devlink change is setting itto =on (vs > > =permissive in upstream). > > I thought there was the clk_sync_state stuff as well? That's not needed to solve the module load ordering issues and deferred probe issues. That's only needed to keep clocks on till some of the modules are loaded and it depends on fw_devlink, but not really a part of fw_devlink IMHO. And yes, that's on my list of things to upstream. > > > Also I think Thierry's comments in the other thread today are also > > > good ideas for ways to better handle the optional dt link handling > > > (rather than using a timeout). > > > > Could you please give me a lore link to this thread? Just curious. > > Sure: https://lore.kernel.org/lkml/20200806135251.GB3351349@ulmo/ Thanks. -Saravana _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4B4C433DF for ; Fri, 7 Aug 2020 03:14:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25134221E2 for ; Fri, 7 Aug 2020 03:14:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cgFE8+CP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="RDovZW0c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25134221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=boo6yqolWJqHmVuQGToBKRHTjGPbynJ2eo5RbQem4b4=; b=cgFE8+CPAFrpYUtPvZXEtWNna SIVfFf/J1+9a00mV2ac6g2Sv6JoYaQtHiufJKILW1LySPdIrGJzUzXONEkYnKdhg+RLrHxBBwzdW8 zthu/TZvQ/xjJ/IBHo132ze6yWepioHbHGh+/1U2CtNRjv2XytnMYB4yL9SaOBfpseBmOM6rHAxPt x2Bkemv94RMEnSnTFXXiyho0COdwci/TzNEGZmADgvdAkTqwoMNpap/Bgo2ne7HiWa8JwRQkHyQAL RVeRXlqjcCiVlbmF4Nt5m6plktZhdLEV+XeJ8KfsbUPIChYaF96WSu3nz2C9hcg2iQr4RbYO3z5AY AMznNwskg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3sp7-0004gl-Kt; Fri, 07 Aug 2020 03:13:37 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3sp5-0004fr-7Q for linux-arm-kernel@lists.infradead.org; Fri, 07 Aug 2020 03:13:36 +0000 Received: by mail-pj1-x1041.google.com with SMTP id mt12so214280pjb.4 for ; Thu, 06 Aug 2020 20:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mntt/yV9g0WantW+MFUMl7qG7fGk/Oi5dRuY6kccsYw=; b=RDovZW0comW5k7a9qDBhi0AemfQotZc35NVP3B/JDirQCHkb3KxYzbiNVpmHOLFuwB 16VvF1+r+a5Uh0LqZm/NYiMCFqw5Kg84vRSFVEvGutQZxz14IrygV9VS6q8VcYGZw/h1 dHG0UzmQ0xHz10DDkThhfDS9paQ9LrKO/PoEGFXs24VQWqcyQVSzNeshbKpJnxZ1mG0d 5Zf92IcmPVcRjaHg0tRv1sCEKsHUa8AclgHXo1FnE9oTRiP5y2Izlfzg3fZJrgzl3sqd 07fpIFfQH3mur+x5UUTjPLI1b9JvJd346SZpuhDJVf+98Mu6vRZ5H5WCK+dJezuiL7kq YLBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mntt/yV9g0WantW+MFUMl7qG7fGk/Oi5dRuY6kccsYw=; b=avqFmMxOaeaVywLs4QvP0LeFiFTvfz9DqJD0czXZE5x1xZcD7RilEqILuOeHg9/R80 9Q+tU5NiS+XSRl7MwnnXJMBT/gNuh5E1XC6tzjWjAJRhzQdoaqXiYSWoKoMa3vk2gVHn JBtL90dcEGZ1qYRb3ehcTNZDyoFCtMqjg6G5UuxsBZessVqCpQM53/yHEiL+wv13lARR 4ZiXWQ6+bQj9ZDngfFR7QXPlUB19733w0Cg6ZM4sr17TdgIOyp9tp5dR2m8LUT7urMsT zLm/hpm97spf61jdWF/E+3iAHifmP5kiMtZkYnymUFCcEXfPnmQ2aVvYdE/nPl7ebsDx jvhQ== X-Gm-Message-State: AOAM5326Q0zXFd+soMVwPpUnXJv0aHRRZc6hIsaagcrOdPdcMh7Bzm15 Wvrqh4yo44G/a8vg2axQ1sW+0pVoeivTkPsX1cK7NQ== X-Google-Smtp-Source: ABdhPJwHf/baXL/FshABJwVK72iC4bCenNX/IrhdV9ee/TdyaNNuV/RPDLg0FYY0/FnAyGhJKXhqedgsCLoHXEgA/TY= X-Received: by 2002:a17:90a:1546:: with SMTP id y6mr2707909pja.93.1596770011948; Thu, 06 Aug 2020 20:13:31 -0700 (PDT) MIME-Version: 1.0 References: <20200718000637.3632841-1-saravanak@google.com> <20200718000637.3632841-3-saravanak@google.com> <78ad0914-6173-f753-9eba-b7cbfbb51fd6@kali.org> <20200807004001.GF20825@builder.lan> <20200807013903.GG20825@builder.lan> In-Reply-To: From: Saravana Kannan Date: Thu, 6 Aug 2020 20:12:56 -0700 Message-ID: Subject: Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros To: John Stultz X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200806_231335_309481_D1320CB3 X-CRM114-Status: GOOD ( 22.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: CC Hwang , Jason Cooper , Marc Zyngier , Hanks Chen , Loda Chou , lkml , Steev Klimaszewski , Bjorn Andersson , Andy Gross , "moderated list:ARM/Mediatek SoC support" , linux-arm-msm , Matthias Brugger , Thierry Reding , Thomas Gleixner , Android Kernel Team , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 6, 2020 at 8:09 PM John Stultz wrote: > > On Thu, Aug 6, 2020 at 8:02 PM Saravana Kannan wrote: > > On Thu, Aug 6, 2020 at 7:49 PM John Stultz wrote: > > > On Thu, Aug 6, 2020 at 6:42 PM Bjorn Andersson > > > wrote: > > > > With all due respect, that's your downstream kernel, the upstream kernel > > > > should not rely on luck, out-of-tree patches or kernel parameters. > > > > > > I agree that would be preferred. But kernel parameters are often there > > > for these sorts of cases where we can't always do the right thing. As > > > for out-of-tree patches, broken things don't get fixed until > > > out-of-tree patches are developed and upstreamed, and I know Saravana > > > is doing exactly that, and I hope his fw_devlink work helps fix it so > > > the module loading is not just a matter of luck. > > > > Btw, the only downstream fw_devlink change is setting itto =on (vs > > =permissive in upstream). > > I thought there was the clk_sync_state stuff as well? That's not needed to solve the module load ordering issues and deferred probe issues. That's only needed to keep clocks on till some of the modules are loaded and it depends on fw_devlink, but not really a part of fw_devlink IMHO. And yes, that's on my list of things to upstream. > > > Also I think Thierry's comments in the other thread today are also > > > good ideas for ways to better handle the optional dt link handling > > > (rather than using a timeout). > > > > Could you please give me a lore link to this thread? Just curious. > > Sure: https://lore.kernel.org/lkml/20200806135251.GB3351349@ulmo/ Thanks. -Saravana _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel