From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C3FC4338F for ; Thu, 5 Aug 2021 21:52:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CE6A61102 for ; Thu, 5 Aug 2021 21:52:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229948AbhHEVwp (ORCPT ); Thu, 5 Aug 2021 17:52:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229987AbhHEVwo (ORCPT ); Thu, 5 Aug 2021 17:52:44 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23FD3C0613D5 for ; Thu, 5 Aug 2021 14:52:29 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id c137so11163921ybf.5 for ; Thu, 05 Aug 2021 14:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/UQ/XHaeIooFE6LdVCRHH8ogFbxbCCOS2tpf69zhkNE=; b=dwukpaJ0801S19b/iRaXaWXKAHkyOED36pnTpyc8AjYSHmgJMLD+aMktnliUWW6rEq PppEKZ3M+Dnqt2a39XTo24QWO38mo+zFGiBtzu/Ya/9iMFW9XCvTesRkEvPbt3/hx4sZ gm0lAKM/sF1MzN1zXeTZSCT5vU5JFyWeSom0wrUD/1pv12A8DvN4VZDtud9Ostr0i9aW CSx32++0/FvTz25+HsAFJfAmx7e7VwK+C+akrPRr/iwLbheFfOZToJWOkz32pVyXSbUA exM9/ZWaqnBhQJ9LegvH4umDa3j74KhKywouLmYMwAAdch1XWVl9aP+9NqSUZveFmqNR w9zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/UQ/XHaeIooFE6LdVCRHH8ogFbxbCCOS2tpf69zhkNE=; b=lt21e069P4G4jL/yO0vi9sHud5MnbYteB9ZISLQHbt9R0Tf7SakrdMIyYBFIBjRo7T mMVBUTKkBq6DjGEwK2t1wmmLM3Lxs6GmJwNawYOGOEgL75m5G9cfnQx11/izlxi+V0wd 57FvtVJ0jRhk7SsJhD1fIqQ3YzfmCvZzrXqwrkliSrd97NmV7S86RblEThURStf9u+Yt T9qtwRZtlyWn6J3ikHQwa8euCW2+A43zSa9U6Zq69i/6wY8PxtDAwsgG6sjIMNQPQnmW o7hmTlqb97dKrda+wbvQEzMSjO2/YQae2KcFhKuaWbcyZShkqr4h7CV9n0eNJ0B4WoEW sEpw== X-Gm-Message-State: AOAM530PklokU1cdFSkrQq7Gcxk1zmyHfSmtovCwZKRWthsS03ii0dl9 hWbZESfTL9vQdhzuXozYOmXCDvfaMBqjCyMrSMol4g== X-Google-Smtp-Source: ABdhPJw2QbmHUiI/GwToKTEaqQh0Zuz+Twwt1bbE9HNroKUywRwDzkiE+5/3vMcFtQ03MmF306AtYkLK232VndIfrlc= X-Received: by 2002:a25:8b91:: with SMTP id j17mr8337744ybl.228.1628200348144; Thu, 05 Aug 2021 14:52:28 -0700 (PDT) MIME-Version: 1.0 References: <162758560739.714452.5782743329332725952@swboyd.mtv.corp.google.com> <16392318.geO5KgaWL5@diego> In-Reply-To: <16392318.geO5KgaWL5@diego> From: Saravana Kannan Date: Thu, 5 Aug 2021 14:51:52 -0700 Message-ID: Subject: Re: [PATCH] clk: rk3308: make ddrphy4x clock critical To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Stephen Boyd , Yunhao Tian , t123yh.xyz@gmail.com, Michael Turquette , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Mon, Aug 2, 2021 at 12:26 PM Heiko St=C3=BCbner wrote: > > Hi Saravana, > > Am Montag, 2. August 2021, 20:24:56 CEST schrieb Saravana Kannan: > > On Thu, Jul 29, 2021 at 12:06 PM Stephen Boyd wrote: > > > > > > Quoting Heiko St=C3=BCbner (2021-07-28 02:53:54) > > > > Am Dienstag, 27. Juli 2021, 03:08:10 CEST schrieb Stephen Boyd: > > > > > Quoting Yunhao Tian (2021-07-21 05:48:16) > > > > > > Currently, no driver support for DDR memory controller (DMC) is= present, > > > > > > as a result, no driver is explicitly consuming the ddrphy clock= . This means > > > > > > that VPLL1 (parent of ddr clock) will be shutdown if we enable > > > > > > and then disable any child clock of VPLL1 (e.g. SCLK_I2S0_8CH_T= X). > > > > > > If VPLL1 is disabled, the whole system will freeze, because the= DDR > > > > > > controller will lose its clock. So, it's necessary to prevent V= PLL1 from > > > > > > shutting down, by marking the ddrphy4x CLK_IS_CRITICAL. > > > > > > > > > > > > This bug was discovered when I was porting rockchip_i2s_tdm dri= ver to > > > > > > mainline kernel from Rockchip 4.4 kernel. I guess that other Ro= ckchip > > > > > > SoCs without DMC driver may need the same patch. If this applie= s to > > > > > > other devices, please let us know. > > > > > > > > > > > > Signed-off-by: Yunhao Tian > > > > > > --- > > > > > > drivers/clk/rockchip/clk-rk3308.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/drivers/clk/rockchip/clk-rk3308.c b/drivers/clk/ro= ckchip/clk-rk3308.c > > > > > > index 2c3bd0c749f2..6be077166330 100644 > > > > > > --- a/drivers/clk/rockchip/clk-rk3308.c > > > > > > +++ b/drivers/clk/rockchip/clk-rk3308.c > > > > > > @@ -564,7 +564,7 @@ static struct rockchip_clk_branch rk3308_cl= k_branches[] __initdata =3D { > > > > > > COMPOSITE(SCLK_DDRCLK, "clk_ddrphy4x_src", mux_dpll_vpl= l0_vpll1_p, CLK_IGNORE_UNUSED, > > > > > > RK3308_CLKSEL_CON(1), 6, 2, MFLAGS, 0, = 3, DFLAGS, > > > > > > RK3308_CLKGATE_CON(0), 10, GFLAGS), > > > > > > - GATE(0, "clk_ddrphy4x", "clk_ddrphy4x_src", CLK_IGNORE_= UNUSED, > > > > > > + GATE(0, "clk_ddrphy4x", "clk_ddrphy4x_src", CLK_IGNORE_= UNUSED | CLK_IS_CRITICAL, > > > > > > > > > > Is it not enabled by default? > > > > > > > > All gates are enabled by default, but this gate shares a common par= ent > > > > tree down to a pll, so if another leaf-user is disabling their part= , this > > > > untracked clock would get disabled as well. > > > > > > Right, this problem is cropping up in different places for various > > > drivers. > > > > > > > > > > > On that note, I remember a sort of CLK_HANDOFF was planned way back > > > > in the past, meaning clock is critical until a driver picks it up, = after this the > > > > driver is responsible for it. Did that get any momentum? > > > > > > > > > > Last I saw Saravana sent a patch to sort of connect CLK_HANDOFF to > > > device driver sync_state() callback. I think we need to at least stas= h > > > away that a clk is enabled at boot and then figure out how to tie in > > > sync_state and/or something else. > > > > Yeah, my clk_sync_state() series should do that. I'll get back on that > > patch this week or next. > > > > Yunhao, > > > > Is there at least some DT device that consumes the DDR phy clock? Can > > you point me to the DT for this board (not the SoC) so I can take a > > look at it later? > > Not for the rk3308. If you're looking for live-examples of handoff clocks= , > I can provide another examples though: > > > rockchip/clk-rk3288.c - pclk_rkpwm (in the separate critical clock list) = ... with > arch/arm/boot/dts/rk3288.dtsi - clock is supplying pwm nodes. > > As the comment in the clock driver suggests (line 850), some boards use > pwm-regulators for central components. The pwm-regulators are configured > at boot already, so the clock shouldn't be disabled till the pwm-regulato= r takes > over. If you can reproduce the issue on your end if you remove the pclk_rkpwm clock from the critical clock list, then can you try this series? https://lore.kernel.org/lkml/20210407034456.516204-1-saravanak@google.com/ It should keep the pclk_rkpwm clock on till all the consumers of the clock have probed. And after that it'll actually allow the clock to be turned off instead of keeping it on forever. -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11D67C4338F for ; Thu, 5 Aug 2021 21:52:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE12760F38 for ; Thu, 5 Aug 2021 21:52:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BE12760F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GWmJ1x+El9taEk9oEgdnP4PUAMuJHPjzntWHtcKcbk8=; b=fjtkohHKIix5CJ F6nfA2bvnafLB+3riHbrQYfFc8/uM1V8t2vwly63z+PfjgiL9Sf1hcvOcz78ykqmfAxwf5e//Dd1K auDZMiR37YFrP5EDYXJ6na/91rVXkOX1+j8wwEJb8lNgg3T1PYJIa/jYWULvvrsBOimyU7PwTpBpi wzsu+k4gHoyg9S64J+iyLmI0dzmEG1V8m9j7/C8/GQHY5Ar73xd+PBQnu01OTGCIcKXnfPkVDJli0 47qxDkGaZ9/21LHH82OPVjqmxwYeBprZtU2Fk2RtU5zcW3qS6aiCNuWfOsi5N18Ph/+FZB5zQDqym qw9KV5sVjzftmzJ+jpMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBlI4-00Atl6-5f; Thu, 05 Aug 2021 21:52:36 +0000 Received: from mail-yb1-xb2b.google.com ([2607:f8b0:4864:20::b2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBlI0-00AtkF-IQ for linux-rockchip@lists.infradead.org; Thu, 05 Aug 2021 21:52:34 +0000 Received: by mail-yb1-xb2b.google.com with SMTP id z5so9759512ybj.2 for ; Thu, 05 Aug 2021 14:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/UQ/XHaeIooFE6LdVCRHH8ogFbxbCCOS2tpf69zhkNE=; b=dwukpaJ0801S19b/iRaXaWXKAHkyOED36pnTpyc8AjYSHmgJMLD+aMktnliUWW6rEq PppEKZ3M+Dnqt2a39XTo24QWO38mo+zFGiBtzu/Ya/9iMFW9XCvTesRkEvPbt3/hx4sZ gm0lAKM/sF1MzN1zXeTZSCT5vU5JFyWeSom0wrUD/1pv12A8DvN4VZDtud9Ostr0i9aW CSx32++0/FvTz25+HsAFJfAmx7e7VwK+C+akrPRr/iwLbheFfOZToJWOkz32pVyXSbUA exM9/ZWaqnBhQJ9LegvH4umDa3j74KhKywouLmYMwAAdch1XWVl9aP+9NqSUZveFmqNR w9zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/UQ/XHaeIooFE6LdVCRHH8ogFbxbCCOS2tpf69zhkNE=; b=tXLtXURuYnpBKaLxmbDbfvBeOCJPZxO/HlqIa1XjplWRvn/H9XaQd8UgBvwjqykGJt JhVyQSSDgtiSTmuFIZNG6KBkuRVnzA41GeIB7belsB5OvWSlzwxkGa+AxR9BMfnMMXZT RrHpUc2hgiY6EyPrBX0Fm1zm2/gk/xq9LNjrezVGsYUxjO7+0Vu4enAO4pPx7Idr7x+y dYDGjc3uHEc9HDi7VY9ASaMwKgemKiTMMk6/ChHba6gAdLawaUuHkIMxXIAZ3lzFewWp DUsX66nFGQI3NcUgabjIbqQkgPonJfBOAHeK2qqtlFhviY7DbwpJCd1cX9scq+PAUPjs XVKQ== X-Gm-Message-State: AOAM532LPxQvBihPx3ugnpC3ValroK1Ntfntv157j3DcjbKuvu6ExjUW rIYq4eRwEs6qfUk8ixMCpqwpelAG8vsBYx+cd/3g2w== X-Google-Smtp-Source: ABdhPJw2QbmHUiI/GwToKTEaqQh0Zuz+Twwt1bbE9HNroKUywRwDzkiE+5/3vMcFtQ03MmF306AtYkLK232VndIfrlc= X-Received: by 2002:a25:8b91:: with SMTP id j17mr8337744ybl.228.1628200348144; Thu, 05 Aug 2021 14:52:28 -0700 (PDT) MIME-Version: 1.0 References: <162758560739.714452.5782743329332725952@swboyd.mtv.corp.google.com> <16392318.geO5KgaWL5@diego> In-Reply-To: <16392318.geO5KgaWL5@diego> From: Saravana Kannan Date: Thu, 5 Aug 2021 14:51:52 -0700 Message-ID: Subject: Re: [PATCH] clk: rk3308: make ddrphy4x clock critical To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Stephen Boyd , Yunhao Tian , t123yh.xyz@gmail.com, Michael Turquette , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_145232_642535_B524332D X-CRM114-Status: GOOD ( 45.28 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMiwgMjAyMSBhdCAxMjoyNiBQTSBIZWlrbyBTdMO8Ym5lciA8aGVpa29Ac250 ZWNoLmRlPiB3cm90ZToKPgo+IEhpIFNhcmF2YW5hLAo+Cj4gQW0gTW9udGFnLCAyLiBBdWd1c3Qg MjAyMSwgMjA6MjQ6NTYgQ0VTVCBzY2hyaWViIFNhcmF2YW5hIEthbm5hbjoKPiA+IE9uIFRodSwg SnVsIDI5LCAyMDIxIGF0IDEyOjA2IFBNIFN0ZXBoZW4gQm95ZCA8c2JveWRAa2VybmVsLm9yZz4g d3JvdGU6Cj4gPiA+Cj4gPiA+IFF1b3RpbmcgSGVpa28gU3TDvGJuZXIgKDIwMjEtMDctMjggMDI6 NTM6NTQpCj4gPiA+ID4gQW0gRGllbnN0YWcsIDI3LiBKdWxpIDIwMjEsIDAzOjA4OjEwIENFU1Qg c2NocmllYiBTdGVwaGVuIEJveWQ6Cj4gPiA+ID4gPiBRdW90aW5nIFl1bmhhbyBUaWFuICgyMDIx LTA3LTIxIDA1OjQ4OjE2KQo+ID4gPiA+ID4gPiBDdXJyZW50bHksIG5vIGRyaXZlciBzdXBwb3J0 IGZvciBERFIgbWVtb3J5IGNvbnRyb2xsZXIgKERNQykgaXMgcHJlc2VudCwKPiA+ID4gPiA+ID4g YXMgYSByZXN1bHQsIG5vIGRyaXZlciBpcyBleHBsaWNpdGx5IGNvbnN1bWluZyB0aGUgZGRycGh5 IGNsb2NrLiBUaGlzIG1lYW5zCj4gPiA+ID4gPiA+IHRoYXQgVlBMTDEgKHBhcmVudCBvZiBkZHIg Y2xvY2spIHdpbGwgYmUgc2h1dGRvd24gaWYgd2UgZW5hYmxlCj4gPiA+ID4gPiA+IGFuZCB0aGVu IGRpc2FibGUgYW55IGNoaWxkIGNsb2NrIG9mIFZQTEwxIChlLmcuIFNDTEtfSTJTMF84Q0hfVFgp Lgo+ID4gPiA+ID4gPiBJZiBWUExMMSBpcyBkaXNhYmxlZCwgdGhlIHdob2xlIHN5c3RlbSB3aWxs IGZyZWV6ZSwgYmVjYXVzZSB0aGUgRERSCj4gPiA+ID4gPiA+IGNvbnRyb2xsZXIgd2lsbCBsb3Nl IGl0cyBjbG9jay4gU28sIGl0J3MgbmVjZXNzYXJ5IHRvIHByZXZlbnQgVlBMTDEgZnJvbQo+ID4g PiA+ID4gPiBzaHV0dGluZyBkb3duLCBieSBtYXJraW5nIHRoZSBkZHJwaHk0eCBDTEtfSVNfQ1JJ VElDQUwuCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFRoaXMgYnVnIHdhcyBkaXNjb3ZlcmVkIHdo ZW4gSSB3YXMgcG9ydGluZyByb2NrY2hpcF9pMnNfdGRtIGRyaXZlciB0bwo+ID4gPiA+ID4gPiBt YWlubGluZSBrZXJuZWwgZnJvbSBSb2NrY2hpcCA0LjQga2VybmVsLiBJIGd1ZXNzIHRoYXQgb3Ro ZXIgUm9ja2NoaXAKPiA+ID4gPiA+ID4gU29DcyB3aXRob3V0IERNQyBkcml2ZXIgbWF5IG5lZWQg dGhlIHNhbWUgcGF0Y2guIElmIHRoaXMgYXBwbGllcyB0bwo+ID4gPiA+ID4gPiBvdGhlciBkZXZp Y2VzLCBwbGVhc2UgbGV0IHVzIGtub3cuCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFNpZ25lZC1v ZmYtYnk6IFl1bmhhbyBUaWFuIDx0MTIzeWhAb3V0bG9vay5jb20+Cj4gPiA+ID4gPiA+IC0tLQo+ ID4gPiA+ID4gPiAgZHJpdmVycy9jbGsvcm9ja2NoaXAvY2xrLXJrMzMwOC5jIHwgMiArLQo+ID4g PiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4g PiA+ID4gPiA+Cj4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Nsay9yb2NrY2hpcC9j bGstcmszMzA4LmMgYi9kcml2ZXJzL2Nsay9yb2NrY2hpcC9jbGstcmszMzA4LmMKPiA+ID4gPiA+ ID4gaW5kZXggMmMzYmQwYzc0OWYyLi42YmUwNzcxNjYzMzAgMTAwNjQ0Cj4gPiA+ID4gPiA+IC0t LSBhL2RyaXZlcnMvY2xrL3JvY2tjaGlwL2Nsay1yazMzMDguYwo+ID4gPiA+ID4gPiArKysgYi9k cml2ZXJzL2Nsay9yb2NrY2hpcC9jbGstcmszMzA4LmMKPiA+ID4gPiA+ID4gQEAgLTU2NCw3ICs1 NjQsNyBAQCBzdGF0aWMgc3RydWN0IHJvY2tjaGlwX2Nsa19icmFuY2ggcmszMzA4X2Nsa19icmFu Y2hlc1tdIF9faW5pdGRhdGEgPSB7Cj4gPiA+ID4gPiA+ICAgICAgICAgQ09NUE9TSVRFKFNDTEtf RERSQ0xLLCAiY2xrX2RkcnBoeTR4X3NyYyIsIG11eF9kcGxsX3ZwbGwwX3ZwbGwxX3AsIENMS19J R05PUkVfVU5VU0VELAo+ID4gPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICBSSzMzMDhf Q0xLU0VMX0NPTigxKSwgNiwgMiwgTUZMQUdTLCAwLCAzLCBERkxBR1MsCj4gPiA+ID4gPiA+ICAg ICAgICAgICAgICAgICAgICAgICAgIFJLMzMwOF9DTEtHQVRFX0NPTigwKSwgMTAsIEdGTEFHUyks Cj4gPiA+ID4gPiA+IC0gICAgICAgR0FURSgwLCAiY2xrX2RkcnBoeTR4IiwgImNsa19kZHJwaHk0 eF9zcmMiLCBDTEtfSUdOT1JFX1VOVVNFRCwKPiA+ID4gPiA+ID4gKyAgICAgICBHQVRFKDAsICJj bGtfZGRycGh5NHgiLCAiY2xrX2RkcnBoeTR4X3NyYyIsIENMS19JR05PUkVfVU5VU0VEIHwgQ0xL X0lTX0NSSVRJQ0FMLAo+ID4gPiA+ID4KPiA+ID4gPiA+IElzIGl0IG5vdCBlbmFibGVkIGJ5IGRl ZmF1bHQ/Cj4gPiA+ID4KPiA+ID4gPiBBbGwgZ2F0ZXMgYXJlIGVuYWJsZWQgYnkgZGVmYXVsdCwg YnV0IHRoaXMgZ2F0ZSBzaGFyZXMgYSBjb21tb24gcGFyZW50Cj4gPiA+ID4gdHJlZSBkb3duIHRv IGEgcGxsLCBzbyBpZiBhbm90aGVyIGxlYWYtdXNlciBpcyBkaXNhYmxpbmcgdGhlaXIgcGFydCwg dGhpcwo+ID4gPiA+IHVudHJhY2tlZCBjbG9jayB3b3VsZCBnZXQgZGlzYWJsZWQgYXMgd2VsbC4K PiA+ID4KPiA+ID4gUmlnaHQsIHRoaXMgcHJvYmxlbSBpcyBjcm9wcGluZyB1cCBpbiBkaWZmZXJl bnQgcGxhY2VzIGZvciB2YXJpb3VzCj4gPiA+IGRyaXZlcnMuCj4gPiA+Cj4gPiA+ID4KPiA+ID4g PiBPbiB0aGF0IG5vdGUsIEkgcmVtZW1iZXIgYSBzb3J0IG9mIENMS19IQU5ET0ZGIHdhcyBwbGFu bmVkIHdheSBiYWNrCj4gPiA+ID4gaW4gdGhlIHBhc3QsIG1lYW5pbmcgY2xvY2sgaXMgY3JpdGlj YWwgdW50aWwgYSBkcml2ZXIgcGlja3MgaXQgdXAsIGFmdGVyIHRoaXMgdGhlCj4gPiA+ID4gZHJp dmVyIGlzIHJlc3BvbnNpYmxlIGZvciBpdC4gRGlkIHRoYXQgZ2V0IGFueSBtb21lbnR1bT8KPiA+ ID4gPgo+ID4gPgo+ID4gPiBMYXN0IEkgc2F3IFNhcmF2YW5hIHNlbnQgYSBwYXRjaCB0byBzb3J0 IG9mIGNvbm5lY3QgQ0xLX0hBTkRPRkYgdG8KPiA+ID4gZGV2aWNlIGRyaXZlciBzeW5jX3N0YXRl KCkgY2FsbGJhY2suIEkgdGhpbmsgd2UgbmVlZCB0byBhdCBsZWFzdCBzdGFzaAo+ID4gPiBhd2F5 IHRoYXQgYSBjbGsgaXMgZW5hYmxlZCBhdCBib290IGFuZCB0aGVuIGZpZ3VyZSBvdXQgaG93IHRv IHRpZSBpbgo+ID4gPiBzeW5jX3N0YXRlIGFuZC9vciBzb21ldGhpbmcgZWxzZS4KPiA+Cj4gPiBZ ZWFoLCBteSBjbGtfc3luY19zdGF0ZSgpIHNlcmllcyBzaG91bGQgZG8gdGhhdC4gSSdsbCBnZXQg YmFjayBvbiB0aGF0Cj4gPiBwYXRjaCB0aGlzIHdlZWsgb3IgbmV4dC4KPiA+Cj4gPiBZdW5oYW8s Cj4gPgo+ID4gSXMgdGhlcmUgYXQgbGVhc3Qgc29tZSBEVCBkZXZpY2UgdGhhdCBjb25zdW1lcyB0 aGUgRERSIHBoeSBjbG9jaz8gQ2FuCj4gPiB5b3UgcG9pbnQgbWUgdG8gdGhlIERUIGZvciB0aGlz IGJvYXJkIChub3QgdGhlIFNvQykgc28gSSBjYW4gdGFrZSBhCj4gPiBsb29rIGF0IGl0IGxhdGVy Pwo+Cj4gTm90IGZvciB0aGUgcmszMzA4LiBJZiB5b3UncmUgbG9va2luZyBmb3IgbGl2ZS1leGFt cGxlcyBvZiBoYW5kb2ZmIGNsb2NrcywKPiBJIGNhbiBwcm92aWRlIGFub3RoZXIgZXhhbXBsZXMg dGhvdWdoOgo+Cj4KPiByb2NrY2hpcC9jbGstcmszMjg4LmMgLSBwY2xrX3JrcHdtIChpbiB0aGUg c2VwYXJhdGUgY3JpdGljYWwgY2xvY2sgbGlzdCkgLi4uIHdpdGgKPiBhcmNoL2FybS9ib290L2R0 cy9yazMyODguZHRzaSAtIGNsb2NrIGlzIHN1cHBseWluZyBwd20gbm9kZXMuCj4KPiBBcyB0aGUg Y29tbWVudCBpbiB0aGUgY2xvY2sgZHJpdmVyIHN1Z2dlc3RzIChsaW5lIDg1MCksIHNvbWUgYm9h cmRzIHVzZQo+IHB3bS1yZWd1bGF0b3JzIGZvciBjZW50cmFsIGNvbXBvbmVudHMuIFRoZSBwd20t cmVndWxhdG9ycyBhcmUgY29uZmlndXJlZAo+IGF0IGJvb3QgYWxyZWFkeSwgc28gdGhlIGNsb2Nr IHNob3VsZG4ndCBiZSBkaXNhYmxlZCB0aWxsIHRoZSBwd20tcmVndWxhdG9yIHRha2VzCj4gb3Zl ci4KCklmIHlvdSBjYW4gcmVwcm9kdWNlIHRoZSBpc3N1ZSBvbiB5b3VyIGVuZCBpZiB5b3UgcmVt b3ZlIHRoZQpwY2xrX3JrcHdtIGNsb2NrIGZyb20gdGhlIGNyaXRpY2FsIGNsb2NrIGxpc3QsIHRo ZW4gY2FuIHlvdSB0cnkgdGhpcwpzZXJpZXM/Cmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwv MjAyMTA0MDcwMzQ0NTYuNTE2MjA0LTEtc2FyYXZhbmFrQGdvb2dsZS5jb20vCgpJdCBzaG91bGQg a2VlcCB0aGUgcGNsa19ya3B3bSBjbG9jayBvbiB0aWxsIGFsbCB0aGUgY29uc3VtZXJzIG9mIHRo ZQpjbG9jayBoYXZlIHByb2JlZC4gQW5kIGFmdGVyIHRoYXQgaXQnbGwgYWN0dWFsbHkgYWxsb3cg dGhlIGNsb2NrIHRvIGJlCnR1cm5lZCBvZmYgaW5zdGVhZCBvZiBrZWVwaW5nIGl0IG9uIGZvcmV2 ZXIuCgotU2FyYXZhbmEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94495C4338F for ; Thu, 5 Aug 2021 21:54:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51EF861078 for ; Thu, 5 Aug 2021 21:54:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 51EF861078 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bXMQnjopUZc3YKcSwM1DutFntlkZFvnqgc41yggokkA=; b=Kr9S5/szxwdwmL 6qAqh94Lui0SWHBef9apMr+cn9oxqb7KsmR0ahFusk0P/bNcbIFD00REBrxReCzgLrOUv6Q7nlKTo 7bDUN3s1lr0r9CbsrrylkSKa8f+XIs90cppRsIEpOPcwji90U/Uhw0R/Vt33jD8ytRA7V8tqjnxJ+ L72WX8yLR+YkRN0ENM1rSdQbnYClH9c5MeBOZl94iZtKAYiSX1sj/lJqa7MGGdVK2U+/8bcHmpfx1 pJQr6HUmQMlH2PxgDXTTkkh0Ks2SGuhZy7txbWRwerGgD+rWfJgUSm0NBUkZ52acv+qStplW7p8m0 Jt6hFAVyht5jOR4uaYQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBlI5-00AtlD-On; Thu, 05 Aug 2021 21:52:37 +0000 Received: from mail-yb1-xb2d.google.com ([2607:f8b0:4864:20::b2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBlI0-00AtkG-H2 for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 21:52:34 +0000 Received: by mail-yb1-xb2d.google.com with SMTP id x192so11610365ybe.0 for ; Thu, 05 Aug 2021 14:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/UQ/XHaeIooFE6LdVCRHH8ogFbxbCCOS2tpf69zhkNE=; b=dwukpaJ0801S19b/iRaXaWXKAHkyOED36pnTpyc8AjYSHmgJMLD+aMktnliUWW6rEq PppEKZ3M+Dnqt2a39XTo24QWO38mo+zFGiBtzu/Ya/9iMFW9XCvTesRkEvPbt3/hx4sZ gm0lAKM/sF1MzN1zXeTZSCT5vU5JFyWeSom0wrUD/1pv12A8DvN4VZDtud9Ostr0i9aW CSx32++0/FvTz25+HsAFJfAmx7e7VwK+C+akrPRr/iwLbheFfOZToJWOkz32pVyXSbUA exM9/ZWaqnBhQJ9LegvH4umDa3j74KhKywouLmYMwAAdch1XWVl9aP+9NqSUZveFmqNR w9zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/UQ/XHaeIooFE6LdVCRHH8ogFbxbCCOS2tpf69zhkNE=; b=V68gCnTN03bwMr0TYIS5mWb+uq2acvJNh7XQvXYN1KXtTOBYVT0NjSnEgZn1Q8kx7C 54n1p0dblxriTbMQQhJo8ndpNTWOnWdp6IUHlJkIuUhwUzkXQX3iiNB7anjOQqUiP2Nw TDsaKqp9f8YYmq6r7Eu90ta4ArLqAjNDru7uD2euZPxtQbBVgNIUgv2pMNCDR9nYTsMd egoQMYbtHgsWF7aIij9rRwOuWgH1WI7YwMND7cq7ZywFb0hDgR5sAEA1XVsqkocxFwWY WRgtdaQxnHxETe6BsL1E+hFdmcsECUvk6vPcVqnz7YOqNM5zFrfVufSuEv4OhY93Ag0Q 6eJw== X-Gm-Message-State: AOAM532mWdcMta5AKGazT9eI18lbIhiKVgoIhOkr/wX6pipkGP6dNMon PCBq+UPaFgPSvsYd1eEFmlfx3lyl8oF1cjRX5/y9Gw== X-Google-Smtp-Source: ABdhPJw2QbmHUiI/GwToKTEaqQh0Zuz+Twwt1bbE9HNroKUywRwDzkiE+5/3vMcFtQ03MmF306AtYkLK232VndIfrlc= X-Received: by 2002:a25:8b91:: with SMTP id j17mr8337744ybl.228.1628200348144; Thu, 05 Aug 2021 14:52:28 -0700 (PDT) MIME-Version: 1.0 References: <162758560739.714452.5782743329332725952@swboyd.mtv.corp.google.com> <16392318.geO5KgaWL5@diego> In-Reply-To: <16392318.geO5KgaWL5@diego> From: Saravana Kannan Date: Thu, 5 Aug 2021 14:51:52 -0700 Message-ID: Subject: Re: [PATCH] clk: rk3308: make ddrphy4x clock critical To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Stephen Boyd , Yunhao Tian , t123yh.xyz@gmail.com, Michael Turquette , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_145232_639205_41906A69 X-CRM114-Status: GOOD ( 46.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMiwgMjAyMSBhdCAxMjoyNiBQTSBIZWlrbyBTdMO8Ym5lciA8aGVpa29Ac250 ZWNoLmRlPiB3cm90ZToKPgo+IEhpIFNhcmF2YW5hLAo+Cj4gQW0gTW9udGFnLCAyLiBBdWd1c3Qg MjAyMSwgMjA6MjQ6NTYgQ0VTVCBzY2hyaWViIFNhcmF2YW5hIEthbm5hbjoKPiA+IE9uIFRodSwg SnVsIDI5LCAyMDIxIGF0IDEyOjA2IFBNIFN0ZXBoZW4gQm95ZCA8c2JveWRAa2VybmVsLm9yZz4g d3JvdGU6Cj4gPiA+Cj4gPiA+IFF1b3RpbmcgSGVpa28gU3TDvGJuZXIgKDIwMjEtMDctMjggMDI6 NTM6NTQpCj4gPiA+ID4gQW0gRGllbnN0YWcsIDI3LiBKdWxpIDIwMjEsIDAzOjA4OjEwIENFU1Qg c2NocmllYiBTdGVwaGVuIEJveWQ6Cj4gPiA+ID4gPiBRdW90aW5nIFl1bmhhbyBUaWFuICgyMDIx LTA3LTIxIDA1OjQ4OjE2KQo+ID4gPiA+ID4gPiBDdXJyZW50bHksIG5vIGRyaXZlciBzdXBwb3J0 IGZvciBERFIgbWVtb3J5IGNvbnRyb2xsZXIgKERNQykgaXMgcHJlc2VudCwKPiA+ID4gPiA+ID4g YXMgYSByZXN1bHQsIG5vIGRyaXZlciBpcyBleHBsaWNpdGx5IGNvbnN1bWluZyB0aGUgZGRycGh5 IGNsb2NrLiBUaGlzIG1lYW5zCj4gPiA+ID4gPiA+IHRoYXQgVlBMTDEgKHBhcmVudCBvZiBkZHIg Y2xvY2spIHdpbGwgYmUgc2h1dGRvd24gaWYgd2UgZW5hYmxlCj4gPiA+ID4gPiA+IGFuZCB0aGVu IGRpc2FibGUgYW55IGNoaWxkIGNsb2NrIG9mIFZQTEwxIChlLmcuIFNDTEtfSTJTMF84Q0hfVFgp Lgo+ID4gPiA+ID4gPiBJZiBWUExMMSBpcyBkaXNhYmxlZCwgdGhlIHdob2xlIHN5c3RlbSB3aWxs IGZyZWV6ZSwgYmVjYXVzZSB0aGUgRERSCj4gPiA+ID4gPiA+IGNvbnRyb2xsZXIgd2lsbCBsb3Nl IGl0cyBjbG9jay4gU28sIGl0J3MgbmVjZXNzYXJ5IHRvIHByZXZlbnQgVlBMTDEgZnJvbQo+ID4g PiA+ID4gPiBzaHV0dGluZyBkb3duLCBieSBtYXJraW5nIHRoZSBkZHJwaHk0eCBDTEtfSVNfQ1JJ VElDQUwuCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFRoaXMgYnVnIHdhcyBkaXNjb3ZlcmVkIHdo ZW4gSSB3YXMgcG9ydGluZyByb2NrY2hpcF9pMnNfdGRtIGRyaXZlciB0bwo+ID4gPiA+ID4gPiBt YWlubGluZSBrZXJuZWwgZnJvbSBSb2NrY2hpcCA0LjQga2VybmVsLiBJIGd1ZXNzIHRoYXQgb3Ro ZXIgUm9ja2NoaXAKPiA+ID4gPiA+ID4gU29DcyB3aXRob3V0IERNQyBkcml2ZXIgbWF5IG5lZWQg dGhlIHNhbWUgcGF0Y2guIElmIHRoaXMgYXBwbGllcyB0bwo+ID4gPiA+ID4gPiBvdGhlciBkZXZp Y2VzLCBwbGVhc2UgbGV0IHVzIGtub3cuCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFNpZ25lZC1v ZmYtYnk6IFl1bmhhbyBUaWFuIDx0MTIzeWhAb3V0bG9vay5jb20+Cj4gPiA+ID4gPiA+IC0tLQo+ ID4gPiA+ID4gPiAgZHJpdmVycy9jbGsvcm9ja2NoaXAvY2xrLXJrMzMwOC5jIHwgMiArLQo+ID4g PiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4g PiA+ID4gPiA+Cj4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Nsay9yb2NrY2hpcC9j bGstcmszMzA4LmMgYi9kcml2ZXJzL2Nsay9yb2NrY2hpcC9jbGstcmszMzA4LmMKPiA+ID4gPiA+ ID4gaW5kZXggMmMzYmQwYzc0OWYyLi42YmUwNzcxNjYzMzAgMTAwNjQ0Cj4gPiA+ID4gPiA+IC0t LSBhL2RyaXZlcnMvY2xrL3JvY2tjaGlwL2Nsay1yazMzMDguYwo+ID4gPiA+ID4gPiArKysgYi9k cml2ZXJzL2Nsay9yb2NrY2hpcC9jbGstcmszMzA4LmMKPiA+ID4gPiA+ID4gQEAgLTU2NCw3ICs1 NjQsNyBAQCBzdGF0aWMgc3RydWN0IHJvY2tjaGlwX2Nsa19icmFuY2ggcmszMzA4X2Nsa19icmFu Y2hlc1tdIF9faW5pdGRhdGEgPSB7Cj4gPiA+ID4gPiA+ICAgICAgICAgQ09NUE9TSVRFKFNDTEtf RERSQ0xLLCAiY2xrX2RkcnBoeTR4X3NyYyIsIG11eF9kcGxsX3ZwbGwwX3ZwbGwxX3AsIENMS19J R05PUkVfVU5VU0VELAo+ID4gPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICBSSzMzMDhf Q0xLU0VMX0NPTigxKSwgNiwgMiwgTUZMQUdTLCAwLCAzLCBERkxBR1MsCj4gPiA+ID4gPiA+ICAg ICAgICAgICAgICAgICAgICAgICAgIFJLMzMwOF9DTEtHQVRFX0NPTigwKSwgMTAsIEdGTEFHUyks Cj4gPiA+ID4gPiA+IC0gICAgICAgR0FURSgwLCAiY2xrX2RkcnBoeTR4IiwgImNsa19kZHJwaHk0 eF9zcmMiLCBDTEtfSUdOT1JFX1VOVVNFRCwKPiA+ID4gPiA+ID4gKyAgICAgICBHQVRFKDAsICJj bGtfZGRycGh5NHgiLCAiY2xrX2RkcnBoeTR4X3NyYyIsIENMS19JR05PUkVfVU5VU0VEIHwgQ0xL X0lTX0NSSVRJQ0FMLAo+ID4gPiA+ID4KPiA+ID4gPiA+IElzIGl0IG5vdCBlbmFibGVkIGJ5IGRl ZmF1bHQ/Cj4gPiA+ID4KPiA+ID4gPiBBbGwgZ2F0ZXMgYXJlIGVuYWJsZWQgYnkgZGVmYXVsdCwg YnV0IHRoaXMgZ2F0ZSBzaGFyZXMgYSBjb21tb24gcGFyZW50Cj4gPiA+ID4gdHJlZSBkb3duIHRv IGEgcGxsLCBzbyBpZiBhbm90aGVyIGxlYWYtdXNlciBpcyBkaXNhYmxpbmcgdGhlaXIgcGFydCwg dGhpcwo+ID4gPiA+IHVudHJhY2tlZCBjbG9jayB3b3VsZCBnZXQgZGlzYWJsZWQgYXMgd2VsbC4K PiA+ID4KPiA+ID4gUmlnaHQsIHRoaXMgcHJvYmxlbSBpcyBjcm9wcGluZyB1cCBpbiBkaWZmZXJl bnQgcGxhY2VzIGZvciB2YXJpb3VzCj4gPiA+IGRyaXZlcnMuCj4gPiA+Cj4gPiA+ID4KPiA+ID4g PiBPbiB0aGF0IG5vdGUsIEkgcmVtZW1iZXIgYSBzb3J0IG9mIENMS19IQU5ET0ZGIHdhcyBwbGFu bmVkIHdheSBiYWNrCj4gPiA+ID4gaW4gdGhlIHBhc3QsIG1lYW5pbmcgY2xvY2sgaXMgY3JpdGlj YWwgdW50aWwgYSBkcml2ZXIgcGlja3MgaXQgdXAsIGFmdGVyIHRoaXMgdGhlCj4gPiA+ID4gZHJp dmVyIGlzIHJlc3BvbnNpYmxlIGZvciBpdC4gRGlkIHRoYXQgZ2V0IGFueSBtb21lbnR1bT8KPiA+ ID4gPgo+ID4gPgo+ID4gPiBMYXN0IEkgc2F3IFNhcmF2YW5hIHNlbnQgYSBwYXRjaCB0byBzb3J0 IG9mIGNvbm5lY3QgQ0xLX0hBTkRPRkYgdG8KPiA+ID4gZGV2aWNlIGRyaXZlciBzeW5jX3N0YXRl KCkgY2FsbGJhY2suIEkgdGhpbmsgd2UgbmVlZCB0byBhdCBsZWFzdCBzdGFzaAo+ID4gPiBhd2F5 IHRoYXQgYSBjbGsgaXMgZW5hYmxlZCBhdCBib290IGFuZCB0aGVuIGZpZ3VyZSBvdXQgaG93IHRv IHRpZSBpbgo+ID4gPiBzeW5jX3N0YXRlIGFuZC9vciBzb21ldGhpbmcgZWxzZS4KPiA+Cj4gPiBZ ZWFoLCBteSBjbGtfc3luY19zdGF0ZSgpIHNlcmllcyBzaG91bGQgZG8gdGhhdC4gSSdsbCBnZXQg YmFjayBvbiB0aGF0Cj4gPiBwYXRjaCB0aGlzIHdlZWsgb3IgbmV4dC4KPiA+Cj4gPiBZdW5oYW8s Cj4gPgo+ID4gSXMgdGhlcmUgYXQgbGVhc3Qgc29tZSBEVCBkZXZpY2UgdGhhdCBjb25zdW1lcyB0 aGUgRERSIHBoeSBjbG9jaz8gQ2FuCj4gPiB5b3UgcG9pbnQgbWUgdG8gdGhlIERUIGZvciB0aGlz IGJvYXJkIChub3QgdGhlIFNvQykgc28gSSBjYW4gdGFrZSBhCj4gPiBsb29rIGF0IGl0IGxhdGVy Pwo+Cj4gTm90IGZvciB0aGUgcmszMzA4LiBJZiB5b3UncmUgbG9va2luZyBmb3IgbGl2ZS1leGFt cGxlcyBvZiBoYW5kb2ZmIGNsb2NrcywKPiBJIGNhbiBwcm92aWRlIGFub3RoZXIgZXhhbXBsZXMg dGhvdWdoOgo+Cj4KPiByb2NrY2hpcC9jbGstcmszMjg4LmMgLSBwY2xrX3JrcHdtIChpbiB0aGUg c2VwYXJhdGUgY3JpdGljYWwgY2xvY2sgbGlzdCkgLi4uIHdpdGgKPiBhcmNoL2FybS9ib290L2R0 cy9yazMyODguZHRzaSAtIGNsb2NrIGlzIHN1cHBseWluZyBwd20gbm9kZXMuCj4KPiBBcyB0aGUg Y29tbWVudCBpbiB0aGUgY2xvY2sgZHJpdmVyIHN1Z2dlc3RzIChsaW5lIDg1MCksIHNvbWUgYm9h cmRzIHVzZQo+IHB3bS1yZWd1bGF0b3JzIGZvciBjZW50cmFsIGNvbXBvbmVudHMuIFRoZSBwd20t cmVndWxhdG9ycyBhcmUgY29uZmlndXJlZAo+IGF0IGJvb3QgYWxyZWFkeSwgc28gdGhlIGNsb2Nr IHNob3VsZG4ndCBiZSBkaXNhYmxlZCB0aWxsIHRoZSBwd20tcmVndWxhdG9yIHRha2VzCj4gb3Zl ci4KCklmIHlvdSBjYW4gcmVwcm9kdWNlIHRoZSBpc3N1ZSBvbiB5b3VyIGVuZCBpZiB5b3UgcmVt b3ZlIHRoZQpwY2xrX3JrcHdtIGNsb2NrIGZyb20gdGhlIGNyaXRpY2FsIGNsb2NrIGxpc3QsIHRo ZW4gY2FuIHlvdSB0cnkgdGhpcwpzZXJpZXM/Cmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwv MjAyMTA0MDcwMzQ0NTYuNTE2MjA0LTEtc2FyYXZhbmFrQGdvb2dsZS5jb20vCgpJdCBzaG91bGQg a2VlcCB0aGUgcGNsa19ya3B3bSBjbG9jayBvbiB0aWxsIGFsbCB0aGUgY29uc3VtZXJzIG9mIHRo ZQpjbG9jayBoYXZlIHByb2JlZC4gQW5kIGFmdGVyIHRoYXQgaXQnbGwgYWN0dWFsbHkgYWxsb3cg dGhlIGNsb2NrIHRvIGJlCnR1cm5lZCBvZmYgaW5zdGVhZCBvZiBrZWVwaW5nIGl0IG9uIGZvcmV2 ZXIuCgotU2FyYXZhbmEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK