From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 916F8C433E6 for ; Tue, 26 Jan 2021 01:25:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6595723105 for ; Tue, 26 Jan 2021 01:25:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731806AbhAYThE (ORCPT ); Mon, 25 Jan 2021 14:37:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730891AbhAYTAB (ORCPT ); Mon, 25 Jan 2021 14:00:01 -0500 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCF04C0613D6 for ; Mon, 25 Jan 2021 10:59:20 -0800 (PST) Received: by mail-yb1-xb31.google.com with SMTP id b11so14330437ybj.9 for ; Mon, 25 Jan 2021 10:59:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MycbrezgsQZFT8oqiMufe2gK1ooAaS0SUCHVJFVQ9MQ=; b=D89ARNqQBSe6Gl9R5DO/KGq6f+XwI019KcTyn5HUgOjPlzNOoKDGLvzncEHAHxv7re lb0QJau2yo6HykmQLwhmFTcTH8Sq6QkyRikthUtPyKV308YBxPqBa17hLZ7vVdG82tdr 1ZYHEmIoWgXZXzZgGJavOcNzowg9rVJTESsTDHUrdAkVRtjVOXki39cVm64f90B/xnUN p++bUV3uNwbHulfuik0Rs79fbFZMM9ifY6BNJzC7/LyidIkjYH3n/Y3WfoT8VtT0C7bQ vqglJpySbxKD72RPbiNIaXSY6RlQxd1v9SjROcZsCNjlhR4Ys9ezoFcio6JbYI7EjanP cYLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MycbrezgsQZFT8oqiMufe2gK1ooAaS0SUCHVJFVQ9MQ=; b=tFWNGh6SzgJr/0qEW9urMZD7Xoq4G7TCD5dkwSr43ppquY+WMnPAPP3T1zzE1isWPv jV+oBDfiu0MVo+Lzycn+7mP6nE115Y98L1KnJvxLWmDX8nxry/Ou35LYwDEhPWZHSbx2 ezXHTkRdfd/2xLCzzGEFj3VoQibeyHwU1SJtpTddv5mbkbUdYZ0KzFrpV5nM0T596oLm 009vCs3KdS8fJWaK7OIYRAWzpCltGMvixRix2NB8/uQUrNkUMqB2Omq+NrvEyTeAOy6B g3lb1K4O73Og0MVkcef9ZPF5Aa0L2L/l+IDmHoNCZhBIJBtreMrrFXOXnZH1D/HPArGA UKLA== X-Gm-Message-State: AOAM5309leCo9r2rdU21rpbyJPbGYoNenNRvOG99o3lo34iv1fOC1BMW FBMJCnagm1S8vCRSU67iu/hV0PCWp4K8jbA2maBV7Q== X-Google-Smtp-Source: ABdhPJwgOyKDm0nJVp7CDR5p+pD9pfx6JsaeKrbh2AWLDPYbm1qy57jLH9fVrTDF4d9HZfHyOf/YQTtTZFeWAQ46qnY= X-Received: by 2002:a25:2f46:: with SMTP id v67mr3110432ybv.20.1611601159888; Mon, 25 Jan 2021 10:59:19 -0800 (PST) MIME-Version: 1.0 References: <20210120105246.23218-1-michael@walle.cc> <20210125165041.GA5979@e121166-lin.cambridge.arm.com> In-Reply-To: <20210125165041.GA5979@e121166-lin.cambridge.arm.com> From: Saravana Kannan Date: Mon, 25 Jan 2021 10:58:43 -0800 Message-ID: Subject: Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() To: Lorenzo Pieralisi Cc: Michael Walle , Rob Herring , linuxppc-dev , PCI , linux-arm-kernel , LKML , Minghuan Lian , Mingkai Hu , Roy Zang , Bjorn Helgaas , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 25, 2021 at 8:50 AM Lorenzo Pieralisi wrote: > > On Wed, Jan 20, 2021 at 08:28:36PM +0100, Michael Walle wrote: > > [RESEND, fat-fingered the buttons of my mail client and converted > > all CCs to BCCs :(] > > > > Am 2021-01-20 20:02, schrieb Saravana Kannan: > > > On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: > > > > > > > > On Wed, Jan 20, 2021 at 4:53 AM Michael Walle > > > > wrote: > > > > > > > > > > fw_devlink will defer the probe until all suppliers are ready. We can't > > > > > use builtin_platform_driver_probe() because it doesn't retry after probe > > > > > deferral. Convert it to builtin_platform_driver(). > > > > > > > > If builtin_platform_driver_probe() doesn't work with fw_devlink, then > > > > shouldn't it be fixed or removed? > > > > > > I was actually thinking about this too. The problem with fixing > > > builtin_platform_driver_probe() to behave like > > > builtin_platform_driver() is that these probe functions could be > > > marked with __init. But there are also only 20 instances of > > > builtin_platform_driver_probe() in the kernel: > > > $ git grep ^builtin_platform_driver_probe | wc -l > > > 20 > > > > > > So it might be easier to just fix them to not use > > > builtin_platform_driver_probe(). > > > > > > Michael, > > > > > > Any chance you'd be willing to help me by converting all these to > > > builtin_platform_driver() and delete builtin_platform_driver_probe()? > > > > If it just moving the probe function to the _driver struct and > > remove the __init annotations. I could look into that. > > Can I drop this patch then ? No, please pick it up. Michael and I were talking about doing similar changes for other drivers. -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77EDDC433E0 for ; Mon, 25 Jan 2021 19:01:40 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C24CC206E5 for ; Mon, 25 Jan 2021 19:01:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C24CC206E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DPfNc60BwzDqCY for ; Tue, 26 Jan 2021 06:01:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::b31; helo=mail-yb1-xb31.google.com; envelope-from=saravanak@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=D89ARNqQ; dkim-atps=neutral Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DPfL837DVzDqly for ; Tue, 26 Jan 2021 05:59:23 +1100 (AEDT) Received: by mail-yb1-xb31.google.com with SMTP id r32so14356835ybd.5 for ; Mon, 25 Jan 2021 10:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MycbrezgsQZFT8oqiMufe2gK1ooAaS0SUCHVJFVQ9MQ=; b=D89ARNqQBSe6Gl9R5DO/KGq6f+XwI019KcTyn5HUgOjPlzNOoKDGLvzncEHAHxv7re lb0QJau2yo6HykmQLwhmFTcTH8Sq6QkyRikthUtPyKV308YBxPqBa17hLZ7vVdG82tdr 1ZYHEmIoWgXZXzZgGJavOcNzowg9rVJTESsTDHUrdAkVRtjVOXki39cVm64f90B/xnUN p++bUV3uNwbHulfuik0Rs79fbFZMM9ifY6BNJzC7/LyidIkjYH3n/Y3WfoT8VtT0C7bQ vqglJpySbxKD72RPbiNIaXSY6RlQxd1v9SjROcZsCNjlhR4Ys9ezoFcio6JbYI7EjanP cYLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MycbrezgsQZFT8oqiMufe2gK1ooAaS0SUCHVJFVQ9MQ=; b=O7+YphLm2FV75kNkcUQCyfCzjIXRqXkSO9umZuTp1ve2+5gaCnsDAbvgRwts4Rqq12 WPTRf2+7s3yuawhWMO4H/DaCc0TjWFk3e/UCg4ZH8AJy/+tgBeWjR5mCPpDBeGSOQn0q VJontnaJRPl4YqjWhNc1lxkb/NlYuNJ1lz+8H3hSynrgm2RdMJj2JKYqt8EwY7Di6XLb ewG2sTNk/ttsGH+mz6OxbqJ2b4sWF4EBQTgSpYh/31i2snhKqMMv9X821yXbB1ZAFbQZ K3DvQqlxsJK0kVgOrSWryA5hBFk1ZYmUpXfy5HpccxfPr0DT1cUPGoubmlOWl20gv4Sz EXbQ== X-Gm-Message-State: AOAM533p7PgY59S0P1PB4pWe3F21PD8Hq/K2z1B7aujQDFhp92Cr3/2A 9Te28as9kLJVWsHfK/3MRB3KtNmSf8vBFenRKgpHnA== X-Google-Smtp-Source: ABdhPJwgOyKDm0nJVp7CDR5p+pD9pfx6JsaeKrbh2AWLDPYbm1qy57jLH9fVrTDF4d9HZfHyOf/YQTtTZFeWAQ46qnY= X-Received: by 2002:a25:2f46:: with SMTP id v67mr3110432ybv.20.1611601159888; Mon, 25 Jan 2021 10:59:19 -0800 (PST) MIME-Version: 1.0 References: <20210120105246.23218-1-michael@walle.cc> <20210125165041.GA5979@e121166-lin.cambridge.arm.com> In-Reply-To: <20210125165041.GA5979@e121166-lin.cambridge.arm.com> From: Saravana Kannan Date: Mon, 25 Jan 2021 10:58:43 -0800 Message-ID: Subject: Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() To: Lorenzo Pieralisi Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Roy Zang , PCI , LKML , Minghuan Lian , Michael Walle , Mingkai Hu , Greg Kroah-Hartman , Bjorn Helgaas , linuxppc-dev , linux-arm-kernel Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jan 25, 2021 at 8:50 AM Lorenzo Pieralisi wrote: > > On Wed, Jan 20, 2021 at 08:28:36PM +0100, Michael Walle wrote: > > [RESEND, fat-fingered the buttons of my mail client and converted > > all CCs to BCCs :(] > > > > Am 2021-01-20 20:02, schrieb Saravana Kannan: > > > On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: > > > > > > > > On Wed, Jan 20, 2021 at 4:53 AM Michael Walle > > > > wrote: > > > > > > > > > > fw_devlink will defer the probe until all suppliers are ready. We can't > > > > > use builtin_platform_driver_probe() because it doesn't retry after probe > > > > > deferral. Convert it to builtin_platform_driver(). > > > > > > > > If builtin_platform_driver_probe() doesn't work with fw_devlink, then > > > > shouldn't it be fixed or removed? > > > > > > I was actually thinking about this too. The problem with fixing > > > builtin_platform_driver_probe() to behave like > > > builtin_platform_driver() is that these probe functions could be > > > marked with __init. But there are also only 20 instances of > > > builtin_platform_driver_probe() in the kernel: > > > $ git grep ^builtin_platform_driver_probe | wc -l > > > 20 > > > > > > So it might be easier to just fix them to not use > > > builtin_platform_driver_probe(). > > > > > > Michael, > > > > > > Any chance you'd be willing to help me by converting all these to > > > builtin_platform_driver() and delete builtin_platform_driver_probe()? > > > > If it just moving the probe function to the _driver struct and > > remove the __init annotations. I could look into that. > > Can I drop this patch then ? No, please pick it up. Michael and I were talking about doing similar changes for other drivers. -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BCABC433DB for ; Mon, 25 Jan 2021 19:01:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C04E20758 for ; Mon, 25 Jan 2021 19:01:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C04E20758 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SdxXxdkxF0OUa8nVCOjsShXrpxmnLh96yzYGJ0lJqpc=; b=jIEcU91WKLpJDNAxvptXuPWhm YQTtzjsN46zF9kJFAXpwGfyqhPxBhBsYaHs0K9Ziipd7ORlS5SwXwASzaRfNxkeLdQ/a7UW8friJT ZCFd8UepES+0wD2mJH6CjUHWnFC39hPBk5cM7DsGbL72Hj0oTQe16+gbTPWxjs3txWJh3w0GKShZ5 jxke4VJZIlAdq0e5Xapi172WhG6cDL9981QJbSGOuxDEx+WcTsP0749FYrA5TrWuW6yCSpYqplBpQ esl9W7J+MpgyCslL0b8WzEUddze+r39q2Q0XOJuhIMWNTsM4O/88pev7GIiY34SL254PBDXBRyiYA 85UZtCN+g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l475C-0004aO-H1; Mon, 25 Jan 2021 18:59:26 +0000 Received: from mail-yb1-xb34.google.com ([2607:f8b0:4864:20::b34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l475A-0004a4-E1 for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2021 18:59:25 +0000 Received: by mail-yb1-xb34.google.com with SMTP id k132so14366073ybf.2 for ; Mon, 25 Jan 2021 10:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MycbrezgsQZFT8oqiMufe2gK1ooAaS0SUCHVJFVQ9MQ=; b=D89ARNqQBSe6Gl9R5DO/KGq6f+XwI019KcTyn5HUgOjPlzNOoKDGLvzncEHAHxv7re lb0QJau2yo6HykmQLwhmFTcTH8Sq6QkyRikthUtPyKV308YBxPqBa17hLZ7vVdG82tdr 1ZYHEmIoWgXZXzZgGJavOcNzowg9rVJTESsTDHUrdAkVRtjVOXki39cVm64f90B/xnUN p++bUV3uNwbHulfuik0Rs79fbFZMM9ifY6BNJzC7/LyidIkjYH3n/Y3WfoT8VtT0C7bQ vqglJpySbxKD72RPbiNIaXSY6RlQxd1v9SjROcZsCNjlhR4Ys9ezoFcio6JbYI7EjanP cYLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MycbrezgsQZFT8oqiMufe2gK1ooAaS0SUCHVJFVQ9MQ=; b=kw5Yg1QQMgDzk+te+WuQp/XRoPkTulTup1O0vIznrx2WIsmoQtdu9crwXr6G4E561Q uKNVz4NPWRAf8V+ZHHHY18rLaUpbPFobouao3Tz6dcsZGHiS7zP9hD8tUu2bj2jmh4S8 Lus9zNypXzEnDsqPKqFCb2/xLElYtxQ8tY/8VTun7rLz+xjd02fQiBNWPN/IBiz3CWtW SqxF/xwbb2mridusZ75T4AnoM26h84zGTZj3qyA0yWFwXmqmWZ4e6AkSe+1ggBa3rb9T o1cB9rbIcTc8Kb8/Cx+uvGMX8xN0NdGsNrHibKhWmCdja+SHixWoNGC2TztQHLQaj2Fe pp6Q== X-Gm-Message-State: AOAM531g7n9pteWSz8FyCqooN1duSMF3/sL3HKVkiLjrTWTYNJVDuqkp 5my+MGg9ywuqw9FjVgCLd2GzNy21JXMFJ2b2b4G+JA== X-Google-Smtp-Source: ABdhPJwgOyKDm0nJVp7CDR5p+pD9pfx6JsaeKrbh2AWLDPYbm1qy57jLH9fVrTDF4d9HZfHyOf/YQTtTZFeWAQ46qnY= X-Received: by 2002:a25:2f46:: with SMTP id v67mr3110432ybv.20.1611601159888; Mon, 25 Jan 2021 10:59:19 -0800 (PST) MIME-Version: 1.0 References: <20210120105246.23218-1-michael@walle.cc> <20210125165041.GA5979@e121166-lin.cambridge.arm.com> In-Reply-To: <20210125165041.GA5979@e121166-lin.cambridge.arm.com> From: Saravana Kannan Date: Mon, 25 Jan 2021 10:58:43 -0800 Message-ID: Subject: Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() To: Lorenzo Pieralisi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_135924_496166_5D7C5AA0 X-CRM114-Status: GOOD ( 23.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roy Zang , PCI , LKML , Minghuan Lian , Michael Walle , Mingkai Hu , Greg Kroah-Hartman , Bjorn Helgaas , linuxppc-dev , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 25, 2021 at 8:50 AM Lorenzo Pieralisi wrote: > > On Wed, Jan 20, 2021 at 08:28:36PM +0100, Michael Walle wrote: > > [RESEND, fat-fingered the buttons of my mail client and converted > > all CCs to BCCs :(] > > > > Am 2021-01-20 20:02, schrieb Saravana Kannan: > > > On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: > > > > > > > > On Wed, Jan 20, 2021 at 4:53 AM Michael Walle > > > > wrote: > > > > > > > > > > fw_devlink will defer the probe until all suppliers are ready. We can't > > > > > use builtin_platform_driver_probe() because it doesn't retry after probe > > > > > deferral. Convert it to builtin_platform_driver(). > > > > > > > > If builtin_platform_driver_probe() doesn't work with fw_devlink, then > > > > shouldn't it be fixed or removed? > > > > > > I was actually thinking about this too. The problem with fixing > > > builtin_platform_driver_probe() to behave like > > > builtin_platform_driver() is that these probe functions could be > > > marked with __init. But there are also only 20 instances of > > > builtin_platform_driver_probe() in the kernel: > > > $ git grep ^builtin_platform_driver_probe | wc -l > > > 20 > > > > > > So it might be easier to just fix them to not use > > > builtin_platform_driver_probe(). > > > > > > Michael, > > > > > > Any chance you'd be willing to help me by converting all these to > > > builtin_platform_driver() and delete builtin_platform_driver_probe()? > > > > If it just moving the probe function to the _driver struct and > > remove the __init annotations. I could look into that. > > Can I drop this patch then ? No, please pick it up. Michael and I were talking about doing similar changes for other drivers. -Saravana _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel