From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F83C636D4 for ; Mon, 30 Jan 2023 20:00:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236242AbjA3UAu (ORCPT ); Mon, 30 Jan 2023 15:00:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236321AbjA3UAt (ORCPT ); Mon, 30 Jan 2023 15:00:49 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3E9A45F6C for ; Mon, 30 Jan 2023 12:00:47 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id n20-20020a17090aab9400b00229ca6a4636so16722368pjq.0 for ; Mon, 30 Jan 2023 12:00:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oYPPhRQH7ubPQanie/vKOvvHKXQgtOiqcTGLviBDhmA=; b=VuIJDnbFxTUIxWa8L1VWYdb9MI+Uw4XrbLFKat84mMs9afmGaZW62Y8sKNZY5LBIF4 +Ul6XxbH/vm/jWs4c0ZPc3jWE3uAo28avKQqTO/OylcU85C+pB8xolsbJyGsGs/rL36V ZSGY0QiNRBwyMe6LPf8vVH/qahQuHtl7YMtCVevzTZ34CA2joFRibts3ttJxVgZaxcTx l/FqMCCgujpobwNcfJfN4c6OBuaJYFlasSYS1viKL0qQV/M1/KYatfFCLgEyymahIMwl 4hVV55hFljOlpo+yPWWpOYotAjaJ3htnES4ajEtyGZ/W45QNCPKfgFhg3OCpw5z0Gfbg 1ESw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oYPPhRQH7ubPQanie/vKOvvHKXQgtOiqcTGLviBDhmA=; b=lZfecl8XuRgjB5lWcTVl5+dYAplcTrP/kXKirgkc5Bmcnh6kLAI8as5LDYcqHLxABX 415DhcNFC+fKIkIb64nevfOeBOz5bOE+sD1x0Nk2/M4tfa2qwBFa0O3XtWmOMlVgeDZ1 0Ma2i3WjDth+XC7FJN1aBzEPZBUhYcB+ZG/QogFVsy4PBTA/mmpMt69pG7x9+UR2CbCP reaLHuQt6fu+p2C40ptB+nEGyUzqC+Q0aBoNvAeVoI6kDaPm6om0BV6B/ZntogrSIzw6 D9jxZC3V1zRXixgr3DtxHUNsPbUF09ZmlBBsP+c1RVUmOc+WAa4pQ2ijHGTnEwkGhE4v hnAw== X-Gm-Message-State: AO0yUKUlQoLIlqbFu3Hobq0SI4rx26/1zKHT3XoVgKRxJ3TvT8sTkXzJ nn1pHEGiEOavRtA/YF4v1QqQ5sCnXbU5UknGJ91P3g== X-Google-Smtp-Source: AK7set+H0YyjCWkJd7M+yIj4eRkqAmXNub+KUOd2n+yHCGliVqKml+ieu+Re/d5tqMId+oQWqascMv0yHsacweeoFCU= X-Received: by 2002:a17:902:d64d:b0:196:7c6e:eb8d with SMTP id y13-20020a170902d64d00b001967c6eeb8dmr912246plh.12.1675108846782; Mon, 30 Jan 2023 12:00:46 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Mon, 30 Jan 2023 12:00:10 -0800 Message-ID: Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Jan 30, 2023 at 12:43 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Sat, Jan 28, 2023 at 8:19 AM Saravana Kannan wrote: > > On Fri, Jan 27, 2023 at 12:11 AM Geert Uytterhoeven > > wrote: > > > On Fri, Jan 27, 2023 at 1:11 AM Saravana Kannan wrote: > > > > The OF_POPULATED flag was set to let fw_devlink know that the device > > > > tree node will not have a struct device created for it. This information > > > > is used by fw_devlink to avoid deferring the probe of consumers of this > > > > device tree node. > > > > > > > > Let's use fwnode_dev_initialized() instead because it achieves the same > > > > effect without using OF specific flags. This allows more generic code to > > > > be written in driver core. > > > > > > > > Signed-off-by: Saravana Kannan > > > > > > Thanks for your patch! > > > > > > > --- a/drivers/soc/renesas/rcar-sysc.c > > > > +++ b/drivers/soc/renesas/rcar-sysc.c > > > > @@ -437,7 +437,7 @@ static int __init rcar_sysc_pd_init(void) > > > > > > > > error = of_genpd_add_provider_onecell(np, &domains->onecell_data); > > > > if (!error) > > > > - of_node_set_flag(np, OF_POPULATED); > > > > + fwnode_dev_initialized(&np->fwnode, true); > > > > > > As drivers/soc/renesas/rmobile-sysc.c is already using this method, > > > it should work fine. > > > > > > Reviewed-by: Geert Uytterhoeven > > > i.e. will queue in renesas-devel for v6.4. I hope you meant queue it up for 6.3 and not 6.4? > > > > Thanks! Does that mean I should drop this from this series? If two > > maintainers pick the same patch up, will it cause problems? I'm > > eventually expecting this series to be picked up by Greg into > > driver-core-next. > > Indeed. Patches for drivers/soc/renesas/ are supposed to go upstream > through the renesas-devel and soc trees. This patch has no dependencies > on anything else in the series (or vice versa), so there is no reason > to deviate from that, and possibly cause conflicts later. This series is supposed to fix a bunch of issues and I vaguely think the series depends on this patch to work correctly on some Renesas systems. You are my main renesas person, so it's probably some issue you hit. Is you pick it up outside of this series I need to keep asking folks to pick up two different patch threads. I don't have a strong opinion, just a FYI. If you can take this patch soon, I don't have any concerns. > BTW, I will convert to of_node_to_fwnode() while applying. Sounds good. -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58071C54EAA for ; Mon, 30 Jan 2023 20:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+EeRtLcgLX/ThGzv6X5psyUGx8fe9V4AGhCejbc5YoY=; b=D1NsETYBEaxFqT tGkbtCoqoCE67ON0vVw4v2wsRHaB5ez7DZIByu8B0gM9tJg4mfLMbC22DAk47L9eRPqKXFkaphJxb 9XpIqq32/f3ek10rAFQ1R5LBEYJajsGCauCl3zE+UPtvN8EdCQwo+x0RgF3ZDBuAvvGfh/LjvmpBO PS13QmpzXKfpWTe6VhaXPVBwQLxY2Is1X+eofp1JEyS0yi3ERjxqWrZqCcuGr9W5k8fCMI91l3+45 hBI3ThFKjQlOBpTw6UxO5+JbiIjVW3+0gX8l0S53KoJ0SO7PfYnFga90Vj6i+nGVq15J2MqLmwUDO 4zLITNHqpawKHKOBhxUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMaKk-005H4u-Rc; Mon, 30 Jan 2023 20:00:55 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMaKg-005H0c-E3 for linux-arm-kernel@lists.infradead.org; Mon, 30 Jan 2023 20:00:53 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d3so12798271plr.10 for ; Mon, 30 Jan 2023 12:00:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oYPPhRQH7ubPQanie/vKOvvHKXQgtOiqcTGLviBDhmA=; b=VuIJDnbFxTUIxWa8L1VWYdb9MI+Uw4XrbLFKat84mMs9afmGaZW62Y8sKNZY5LBIF4 +Ul6XxbH/vm/jWs4c0ZPc3jWE3uAo28avKQqTO/OylcU85C+pB8xolsbJyGsGs/rL36V ZSGY0QiNRBwyMe6LPf8vVH/qahQuHtl7YMtCVevzTZ34CA2joFRibts3ttJxVgZaxcTx l/FqMCCgujpobwNcfJfN4c6OBuaJYFlasSYS1viKL0qQV/M1/KYatfFCLgEyymahIMwl 4hVV55hFljOlpo+yPWWpOYotAjaJ3htnES4ajEtyGZ/W45QNCPKfgFhg3OCpw5z0Gfbg 1ESw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oYPPhRQH7ubPQanie/vKOvvHKXQgtOiqcTGLviBDhmA=; b=QvlJppHCvmHglgZmP8V3Z0VP4OV+japZ2UTzTI2EFtkHGeMaQWYqzt/ubbI55jde3J BJpVTSljLCUgoe7Athoqq3jmfbFIo6JBcXmXilzF6J6eBzYyGroMKy6rudqqaiYbcBuf 7a/xZNzkZLGVLG9VuWcoyG2yEK474B4ajVMYOK8ag/F5FWo3qhtRRn/YETp+6rr4jAhM duzx8UD+sFoTMPAaric1gr/LTSkWoDfvh0d5BhykQGPx4ZY3uEwrwxp0p573IgWtWvyJ WkWmJ3kz8MEgNdbqABd+zvM836ZjS44cUoclcsnbRbPOzBRO2Hkd2+6RBBrknZyBzb6c MFOQ== X-Gm-Message-State: AO0yUKV/Il9HF3wH0kUz1l9hhsUvAP7y3ceM5tWp+YRXp/xtYs0fahGL rD0qkS6L+ZQYzYcPR++QfkLDvcxTMH0Kd3Gka9iRCQ== X-Google-Smtp-Source: AK7set+H0YyjCWkJd7M+yIj4eRkqAmXNub+KUOd2n+yHCGliVqKml+ieu+Re/d5tqMId+oQWqascMv0yHsacweeoFCU= X-Received: by 2002:a17:902:d64d:b0:196:7c6e:eb8d with SMTP id y13-20020a170902d64d00b001967c6eeb8dmr912246plh.12.1675108846782; Mon, 30 Jan 2023 12:00:46 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Mon, 30 Jan 2023 12:00:10 -0800 Message-ID: Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_120050_491568_E31BD46D X-CRM114-Status: GOOD ( 37.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 30, 2023 at 12:43 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Sat, Jan 28, 2023 at 8:19 AM Saravana Kannan wrote: > > On Fri, Jan 27, 2023 at 12:11 AM Geert Uytterhoeven > > wrote: > > > On Fri, Jan 27, 2023 at 1:11 AM Saravana Kannan wrote: > > > > The OF_POPULATED flag was set to let fw_devlink know that the device > > > > tree node will not have a struct device created for it. This information > > > > is used by fw_devlink to avoid deferring the probe of consumers of this > > > > device tree node. > > > > > > > > Let's use fwnode_dev_initialized() instead because it achieves the same > > > > effect without using OF specific flags. This allows more generic code to > > > > be written in driver core. > > > > > > > > Signed-off-by: Saravana Kannan > > > > > > Thanks for your patch! > > > > > > > --- a/drivers/soc/renesas/rcar-sysc.c > > > > +++ b/drivers/soc/renesas/rcar-sysc.c > > > > @@ -437,7 +437,7 @@ static int __init rcar_sysc_pd_init(void) > > > > > > > > error = of_genpd_add_provider_onecell(np, &domains->onecell_data); > > > > if (!error) > > > > - of_node_set_flag(np, OF_POPULATED); > > > > + fwnode_dev_initialized(&np->fwnode, true); > > > > > > As drivers/soc/renesas/rmobile-sysc.c is already using this method, > > > it should work fine. > > > > > > Reviewed-by: Geert Uytterhoeven > > > i.e. will queue in renesas-devel for v6.4. I hope you meant queue it up for 6.3 and not 6.4? > > > > Thanks! Does that mean I should drop this from this series? If two > > maintainers pick the same patch up, will it cause problems? I'm > > eventually expecting this series to be picked up by Greg into > > driver-core-next. > > Indeed. Patches for drivers/soc/renesas/ are supposed to go upstream > through the renesas-devel and soc trees. This patch has no dependencies > on anything else in the series (or vice versa), so there is no reason > to deviate from that, and possibly cause conflicts later. This series is supposed to fix a bunch of issues and I vaguely think the series depends on this patch to work correctly on some Renesas systems. You are my main renesas person, so it's probably some issue you hit. Is you pick it up outside of this series I need to keep asking folks to pick up two different patch threads. I don't have a strong opinion, just a FYI. If you can take this patch soon, I don't have any concerns. > BTW, I will convert to of_node_to_fwnode() while applying. Sounds good. -Saravana _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel