From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA0D5C7618F for ; Mon, 22 Jul 2019 23:44:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8856121955 for ; Mon, 22 Jul 2019 23:44:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lJkTgLF4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731594AbfGVXoP (ORCPT ); Mon, 22 Jul 2019 19:44:15 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:42010 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731524AbfGVXoO (ORCPT ); Mon, 22 Jul 2019 19:44:14 -0400 Received: by mail-oi1-f195.google.com with SMTP id s184so30929221oie.9 for ; Mon, 22 Jul 2019 16:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OWRSakQ5gBDzeVkobWkR8HSpZb9HZUgwqjhmh+8L31o=; b=lJkTgLF4pXuf6rTnAZ3wk0l3RK5IoCWMOwcdcSELyLPv/lhyX1oqMbV0qGLhqkbACU D46ggq5uoyOzb+MKw/wOAcS1q6kB4LgSGBSXQwNx9O5NeWyyD5+hbSHifWbRtMsVowy9 1Lb6JupMxU8M0FqVB5KHqPUvEQOa5u3yAH604UX9vZUT0sC7fGXEiN5+vNUi22Bb2Jp4 VPDem3IgvZIxBJMMHpxtihtHg/0Omj0pfiOjKYlaBtTKQZ9Me0R0sxT6orcLzYaA3Ciw eRPORJecZOd6QNPWWk1zRAXfria2MpTw8Li9qH2LukigK10EOVhAh/J9n2zqTjP4Bzj5 8HrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OWRSakQ5gBDzeVkobWkR8HSpZb9HZUgwqjhmh+8L31o=; b=OXjs+zDV3XbyEoNUvA5PRm+bg9eMTis8g6k2wmtMNTU6UKgOMOm3bacwtSkJWLZNR1 +lOx4tlUvx+c3QH59iQfABPxJZJdZDZHce5kxJcurzU4HiFnP0+kC+FAzzXzi9BrlcMu VB+jlovuJqnaXlZ0cITHpjD+xNddRyagPrL/kLmrbGWbrflx+xHTlV1CCrv8FMHsPTqP 8Tvvj4z76/m2pKNoKP1pvcn5mszFF3cNnF0lSOUaTA1hJ757afMNfhoYBzrrRUN6BXKM Z6vO1+14L2ARWwYpRTpolrBRCdmvhWEpmRWkKAvhUaWz/SPv52nCJMWhmZW+4+bxZln6 n2Rg== X-Gm-Message-State: APjAAAUv6+HlDzK1l1cmLUwqH8XKNLBx61jC+k/j+t13n8y/rMhf5KjC QbGq2ceaX89IMoosMQJbQeCC49G6cyiDrRB0tjPLIg== X-Google-Smtp-Source: APXvYqwoVIJPfpQXiC98z/h8FW7U3z9P5lhBYysrMf8a1285DsxdONOWkFBnZFRYhx+Acqhjh96hKewOCBbxlcHCm94= X-Received: by 2002:aca:6104:: with SMTP id v4mr36782532oib.172.1563839053869; Mon, 22 Jul 2019 16:44:13 -0700 (PDT) MIME-Version: 1.0 References: <20190703011020.151615-1-saravanak@google.com> <20190703011020.151615-6-saravanak@google.com> <20190722233927.GA1353@bogus> In-Reply-To: <20190722233927.GA1353@bogus> From: Saravana Kannan Date: Mon, 22 Jul 2019 16:43:38 -0700 Message-ID: Subject: Re: [PATCH v3 5/6] dt-bindings: interconnect: Add interconnect-opp-table property To: Rob Herring Cc: Georgi Djakov , Mark Rutland , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Vincent Guittot , "Sweeney, Sean" , daidavid1@codeaurora.org, Rajendra Nayak , Sibi Sankar , Bjorn Andersson , Evan Green , Android Kernel Team , Linux PM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 22, 2019 at 4:39 PM Rob Herring wrote: > > On Tue, Jul 02, 2019 at 06:10:19PM -0700, Saravana Kannan wrote: > > Add support for listing bandwidth OPP tables for each interconnect path > > listed using the interconnects property. > > > > Signed-off-by: Saravana Kannan > > --- > > .../devicetree/bindings/interconnect/interconnect.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/interconnect/interconnect.txt b/Documentation/devicetree/bindings/interconnect/interconnect.txt > > index 6f5d23a605b7..fc5b75b76a2c 100644 > > --- a/Documentation/devicetree/bindings/interconnect/interconnect.txt > > +++ b/Documentation/devicetree/bindings/interconnect/interconnect.txt > > @@ -55,10 +55,18 @@ interconnect-names : List of interconnect path name strings sorted in the same > > * dma-mem: Path from the device to the main memory of > > the system > > > > +interconnect-opp-table: List of phandles to OPP tables (bandwidth OPP tables) > > + that specify the OPPs for the interconnect paths listed > > + in the interconnects property. This property can only > > + point to OPP tables that belong to the device and are > > + listed in the device's operating-points-v2 property. > > + > > IMO, there's no need for this property. Which OPP is which should be > defined already as part of the device's binding. That's enough for the > driver to know which OPP applies to the interconnect. Sure, I don't mind dropping this. -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 From: Saravana Kannan Subject: Re: [PATCH v3 5/6] dt-bindings: interconnect: Add interconnect-opp-table property Date: Mon, 22 Jul 2019 16:43:38 -0700 Message-ID: References: <20190703011020.151615-1-saravanak@google.com> <20190703011020.151615-6-saravanak@google.com> <20190722233927.GA1353@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190722233927.GA1353@bogus> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Georgi Djakov , Mark Rutland , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Vincent Guittot , "Sweeney, Sean" , daidavid1@codeaurora.org, Rajendra Nayak , Sibi Sankar , Bjorn Andersson , Evan Green , Android Kernel Team , Linux PM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML List-Id: devicetree@vger.kernel.org On Mon, Jul 22, 2019 at 4:39 PM Rob Herring wrote: > > On Tue, Jul 02, 2019 at 06:10:19PM -0700, Saravana Kannan wrote: > > Add support for listing bandwidth OPP tables for each interconnect path > > listed using the interconnects property. > > > > Signed-off-by: Saravana Kannan > > --- > > .../devicetree/bindings/interconnect/interconnect.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/interconnect/interconnect.txt b/Documentation/devicetree/bindings/interconnect/interconnect.txt > > index 6f5d23a605b7..fc5b75b76a2c 100644 > > --- a/Documentation/devicetree/bindings/interconnect/interconnect.txt > > +++ b/Documentation/devicetree/bindings/interconnect/interconnect.txt > > @@ -55,10 +55,18 @@ interconnect-names : List of interconnect path name strings sorted in the same > > * dma-mem: Path from the device to the main memory of > > the system > > > > +interconnect-opp-table: List of phandles to OPP tables (bandwidth OPP tables) > > + that specify the OPPs for the interconnect paths listed > > + in the interconnects property. This property can only > > + point to OPP tables that belong to the device and are > > + listed in the device's operating-points-v2 property. > > + > > IMO, there's no need for this property. Which OPP is which should be > defined already as part of the device's binding. That's enough for the > driver to know which OPP applies to the interconnect. Sure, I don't mind dropping this. -Saravana