From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56464C43217 for ; Wed, 25 May 2022 19:49:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240503AbiEYTtl (ORCPT ); Wed, 25 May 2022 15:49:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344759AbiEYTtl (ORCPT ); Wed, 25 May 2022 15:49:41 -0400 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A54D966F81 for ; Wed, 25 May 2022 12:49:38 -0700 (PDT) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-300628e76f3so18822397b3.12 for ; Wed, 25 May 2022 12:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=lcsU1M3aHmWM93+N/Pq2k69CNkfyIQUCxczoLH0OLPk=; b=hGvqDCPINlCno6IGVx/RQ4/atSQ+dW08eMaP/4u4J2Rx0AU21Orr25m5AgNUJgVoBC 3FFOnaz5xSM9a3RRyGWmmLYgiZVdvKzEmj7vsHFg6Sh7EwGqNKrvH43xPCnlETqRbyTJ rUgPCSCAGnF+I3fcFxMltq5wx33LgoLK4ERO4IR4Sot/Uaxxldi6tkX+WdLxAvCCiEtI QP4xUPzpC2rlJZR8sd1n3W8vuHEHoaO4LC9YRcKisj9Uq+DszGcvpWkcK75IpZtbpf64 JIxJLJ+6BngIh5kjOcaFiUEdbJbMoovEHpIlAtRm4xeoQYYTe1wf9PGaYkAV8y48Abi0 +6Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lcsU1M3aHmWM93+N/Pq2k69CNkfyIQUCxczoLH0OLPk=; b=AiMSsrECxqh19xh2vVN4fWMgJjBDohOxcBMwDJdVuweAGZnXdwu80lcr4iaBhJioE/ l9xpcLD2LM6pcH7yPWybPQJOlPqbc9AD2XmRFffa7GVVb4liQV9D4jPspI8yg5PJXJaq EuXpICHEZxOGKbqGB01jvMrV58r2gnE+cHmdPs2hkLy8agMDSEvIX0X0+ePrA0AYi5xy 4+u8SwPWFUWjwrRCFcNaCR1edFRjMFETbvWIrUCr8XX01Szo3rQdcp7RVyOnngEKg0Wv 9CfjTKBow6+R5MO38kMjZdymhhouPgy4sXlLqT9/h6p+M3X+mKnTDcqKTeGWqi6E1+v2 2GaQ== X-Gm-Message-State: AOAM531Ew7KWKKCQsTG5hdFUtefaStGihRRJbZvesUVuFz1xXsOsCYVL w4scFtnz7mLEd5BFiW/IVZW4s7cUL8SVQqxG7eKX2w== X-Google-Smtp-Source: ABdhPJye/LYmXdbx2DRGvhYd77idEIGqJLpVK4M7sUVcSaytWZ/KajOi10nwmyuJy9EQw0Od4wYghiCxgCclb01GpVs= X-Received: by 2002:a81:72c5:0:b0:300:7d0:a642 with SMTP id n188-20020a8172c5000000b0030007d0a642mr14402533ywc.80.1653508177547; Wed, 25 May 2022 12:49:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Saravana Kannan Date: Wed, 25 May 2022 12:49:00 -0700 Message-ID: Subject: Re: [PATCH v1] driver core: Extend deferred probe timeout on driver registration To: Sebastian Andrzej Siewior Cc: Nathan Chancellor , Jonathan Corbet , Greg Kroah-Hartman , "Rafael J. Wysocki" , "Rafael J. Wysocki" , Rob Herring , Linus Walleij , Will Deacon , Ulf Hansson , Kevin Hilman , Thierry Reding , Mark Brown , Pavel Machek , Geert Uytterhoeven , Yoshihiro Shimoda , Paul Kocialkowski , linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux-foundation.org, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, John Stultz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, May 25, 2022 at 12:12 AM Sebastian Andrzej Siewior wrote: > > On 2022-05-24 10:46:49 [-0700], Saravana Kannan wrote: > > > Removing probe_timeout_waitqueue (as suggested) or setting the timeou= t > > > to 0 avoids the delay. > > > > In your case, I think it might be working as intended? Curious, what > > was the call stack in your case where it was blocked? > > Why is then there 10sec delay during boot? The backtrace is > |------------[ cut here ]------------ > |WARNING: CPU: 4 PID: 1 at drivers/base/dd.c:742 wait_for_device_probe+0x= 30/0x110 > |Modules linked in: > |CPU: 4 PID: 1 Comm: swapper/0 Not tainted 5.18.0-rc5+ #154 > |RIP: 0010:wait_for_device_probe+0x30/0x110 > |Call Trace: > | > | prepare_namespace+0x2b/0x160 > | kernel_init_freeable+0x2b3/0x2dd > | kernel_init+0x11/0x110 > | ret_from_fork+0x22/0x30 > | > > Looking closer, it can't access init. This in particular box boots > directly the kernel without an initramfs so the kernel later mounts > /dev/sda1 and everything is good. So that seems to be the reason=E2=80= =A6 Hmmm... that part shouldn't matter. As long as you are hitting the same code path. My guess is one of them has CONFIG_MODULES enabled and the other doesn't. In either case, I think the patch needs to be reverted (I'll send out one soon), but that'll also mean I need to revert part of my patch (sets the timeout back to 0) or I need to fix this case: https://lore.kernel.org/lkml/TYAPR01MB45443DF63B9EF29054F7C41FD8C60@TYAPR01= MB4544.jpnprd01.prod.outlook.com/ I'll try to do the latter if I can get something reasonable soon. Otherwise, I'll just do the revert + partial revert. -Saravana > My other machine with an initramfs does not show this problem. > > > -Saravana > > Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97AA8C433EF for ; Wed, 25 May 2022 19:49:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 4148B40176; Wed, 25 May 2022 19:49:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NT_fOMG_EJ0l; Wed, 25 May 2022 19:49:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 2E5DF40931; Wed, 25 May 2022 19:49:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D8AC4C0032; Wed, 25 May 2022 19:49:40 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 10C72C002D for ; Wed, 25 May 2022 19:49:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id DDFE140931 for ; Wed, 25 May 2022 19:49:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Sfg4c3DqvOqI for ; Wed, 25 May 2022 19:49:39 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by smtp2.osuosl.org (Postfix) with ESMTPS id 0A47440176 for ; Wed, 25 May 2022 19:49:38 +0000 (UTC) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-30026b1124bso68735587b3.1 for ; Wed, 25 May 2022 12:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=lcsU1M3aHmWM93+N/Pq2k69CNkfyIQUCxczoLH0OLPk=; b=hGvqDCPINlCno6IGVx/RQ4/atSQ+dW08eMaP/4u4J2Rx0AU21Orr25m5AgNUJgVoBC 3FFOnaz5xSM9a3RRyGWmmLYgiZVdvKzEmj7vsHFg6Sh7EwGqNKrvH43xPCnlETqRbyTJ rUgPCSCAGnF+I3fcFxMltq5wx33LgoLK4ERO4IR4Sot/Uaxxldi6tkX+WdLxAvCCiEtI QP4xUPzpC2rlJZR8sd1n3W8vuHEHoaO4LC9YRcKisj9Uq+DszGcvpWkcK75IpZtbpf64 JIxJLJ+6BngIh5kjOcaFiUEdbJbMoovEHpIlAtRm4xeoQYYTe1wf9PGaYkAV8y48Abi0 +6Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lcsU1M3aHmWM93+N/Pq2k69CNkfyIQUCxczoLH0OLPk=; b=HJrjOJ7C+QLFHlHszKCA5A2VKw3WypCk2W2pzhMPrRcbN9lnOA6h8ydS+fDKYbCQeU LU2v4h7V0GWIuJBBroixVy7G5F3F14qD2AB0L3tCoVBjIeTYZpLeFiB+WvTQTmSuP1A2 nQGgsCExxB/WZrgs53i8UsTo3MEBirATJsvhvxlYNfGJ4fIbiYxXGBwdYJZx8uSWaheI 5k7gD7+OG9zsTWbiSmfMq4PkWf9ywroiIv4vJfqBrUIieXHOOlLNePUGYZfxBcd1YlLd Jpgta+wnaI2aao7qApG6b5b3fDGIg7mqbgsKBjkjHXBfiMBzv7MEQ4xJRha/Z+LUkxcK nKmQ== X-Gm-Message-State: AOAM530bR2XxjQNW4ReICzl3NkRPoKBqVBd2bGuxRQ8W2HUaOnWFqy2M wMTOSsB/dlwfDtoMCsLllc9wbs8yJ6h90bHdp1yqMw== X-Google-Smtp-Source: ABdhPJye/LYmXdbx2DRGvhYd77idEIGqJLpVK4M7sUVcSaytWZ/KajOi10nwmyuJy9EQw0Od4wYghiCxgCclb01GpVs= X-Received: by 2002:a81:72c5:0:b0:300:7d0:a642 with SMTP id n188-20020a8172c5000000b0030007d0a642mr14402533ywc.80.1653508177547; Wed, 25 May 2022 12:49:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 25 May 2022 12:49:00 -0700 Message-ID: Subject: Re: [PATCH v1] driver core: Extend deferred probe timeout on driver registration To: Sebastian Andrzej Siewior Cc: Ulf Hansson , linux-doc@vger.kernel.org, Linus Walleij , John Stultz , Pavel Machek , linux-s390@vger.kernel.org, Will Deacon , Rob Herring , Jonathan Corbet , "Rafael J. Wysocki" , Geert Uytterhoeven , Thierry Reding , kernel-team@android.com, linux-pm@vger.kernel.org, Nathan Chancellor , linux-gpio@vger.kernel.org, Mark Brown , Greg Kroah-Hartman , Kevin Hilman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Paul Kocialkowski , iommu@lists.linux-foundation.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Saravana Kannan via iommu Reply-To: Saravana Kannan Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gV2VkLCBNYXkgMjUsIDIwMjIgYXQgMTI6MTIgQU0gU2ViYXN0aWFuIEFuZHJ6ZWogU2lld2lv cgo8YmlnZWFzeUBsaW51dHJvbml4LmRlPiB3cm90ZToKPgo+IE9uIDIwMjItMDUtMjQgMTA6NDY6 NDkgWy0wNzAwXSwgU2FyYXZhbmEgS2FubmFuIHdyb3RlOgo+ID4gPiBSZW1vdmluZyBwcm9iZV90 aW1lb3V0X3dhaXRxdWV1ZSAoYXMgc3VnZ2VzdGVkKSBvciBzZXR0aW5nIHRoZSB0aW1lb3V0Cj4g PiA+IHRvIDAgYXZvaWRzIHRoZSBkZWxheS4KPiA+Cj4gPiBJbiB5b3VyIGNhc2UsIEkgdGhpbmsg aXQgbWlnaHQgYmUgd29ya2luZyBhcyBpbnRlbmRlZD8gQ3VyaW91cywgd2hhdAo+ID4gd2FzIHRo ZSBjYWxsIHN0YWNrIGluIHlvdXIgY2FzZSB3aGVyZSBpdCB3YXMgYmxvY2tlZD8KPgo+IFdoeSBp cyB0aGVuIHRoZXJlIDEwc2VjIGRlbGF5IGR1cmluZyBib290PyBUaGUgYmFja3RyYWNlIGlzCj4g fC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQo+IHxXQVJOSU5HOiBDUFU6IDQg UElEOiAxIGF0IGRyaXZlcnMvYmFzZS9kZC5jOjc0MiB3YWl0X2Zvcl9kZXZpY2VfcHJvYmUrMHgz MC8weDExMAo+IHxNb2R1bGVzIGxpbmtlZCBpbjoKPiB8Q1BVOiA0IFBJRDogMSBDb21tOiBzd2Fw cGVyLzAgTm90IHRhaW50ZWQgNS4xOC4wLXJjNSsgIzE1NAo+IHxSSVA6IDAwMTA6d2FpdF9mb3Jf ZGV2aWNlX3Byb2JlKzB4MzAvMHgxMTAKPiB8Q2FsbCBUcmFjZToKPiB8IDxUQVNLPgo+IHwgcHJl cGFyZV9uYW1lc3BhY2UrMHgyYi8weDE2MAo+IHwga2VybmVsX2luaXRfZnJlZWFibGUrMHgyYjMv MHgyZGQKPiB8IGtlcm5lbF9pbml0KzB4MTEvMHgxMTAKPiB8IHJldF9mcm9tX2ZvcmsrMHgyMi8w eDMwCj4gfCA8L1RBU0s+Cj4KPiBMb29raW5nIGNsb3NlciwgaXQgY2FuJ3QgYWNjZXNzIGluaXQu IFRoaXMgaW4gcGFydGljdWxhciBib3ggYm9vdHMKPiBkaXJlY3RseSB0aGUga2VybmVsIHdpdGhv dXQgYW4gaW5pdHJhbWZzIHNvIHRoZSBrZXJuZWwgbGF0ZXIgbW91bnRzCj4gL2Rldi9zZGExIGFu ZCBldmVyeXRoaW5nIGlzIGdvb2QuICBTbyB0aGF0IHNlZW1zIHRvIGJlIHRoZSByZWFzb27igKYK CkhtbW0uLi4gdGhhdCBwYXJ0IHNob3VsZG4ndCBtYXR0ZXIuIEFzIGxvbmcgYXMgeW91IGFyZSBo aXR0aW5nIHRoZQpzYW1lIGNvZGUgcGF0aC4gTXkgZ3Vlc3MgaXMgb25lIG9mIHRoZW0gaGFzIENP TkZJR19NT0RVTEVTIGVuYWJsZWQgYW5kCnRoZSBvdGhlciBkb2Vzbid0LgoKSW4gZWl0aGVyIGNh c2UsIEkgdGhpbmsgdGhlIHBhdGNoIG5lZWRzIHRvIGJlIHJldmVydGVkIChJJ2xsIHNlbmQgb3V0 Cm9uZSBzb29uKSwgYnV0IHRoYXQnbGwgYWxzbyBtZWFuIEkgbmVlZCB0byByZXZlcnQgcGFydCBv ZiBteSBwYXRjaAooc2V0cyB0aGUgdGltZW91dCBiYWNrIHRvIDApIG9yIEkgbmVlZCB0byBmaXgg dGhpcyBjYXNlOgpodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sL1RZQVBSMDFNQjQ1NDQzREY2 M0I5RUYyOTA1NEY3QzQxRkQ4QzYwQFRZQVBSMDFNQjQ1NDQuanBucHJkMDEucHJvZC5vdXRsb29r LmNvbS8KCkknbGwgdHJ5IHRvIGRvIHRoZSBsYXR0ZXIgaWYgSSBjYW4gZ2V0IHNvbWV0aGluZyBy ZWFzb25hYmxlIHNvb24uCk90aGVyd2lzZSwgSSdsbCBqdXN0IGRvIHRoZSByZXZlcnQgKyBwYXJ0 aWFsIHJldmVydC4KCi1TYXJhdmFuYQoKCj4gTXkgb3RoZXIgbWFjaGluZSB3aXRoIGFuIGluaXRy YW1mcyBkb2VzIG5vdCBzaG93IHRoaXMgcHJvYmxlbS4KPgo+ID4gLVNhcmF2YW5hCj4KPiBTZWJh c3RpYW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaW9t bXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8v bGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11