From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02461ECAA25 for ; Thu, 25 Aug 2022 17:06:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237654AbiHYRGX (ORCPT ); Thu, 25 Aug 2022 13:06:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbiHYRGW (ORCPT ); Thu, 25 Aug 2022 13:06:22 -0400 Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DFD7AC24C for ; Thu, 25 Aug 2022 10:06:21 -0700 (PDT) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-3378303138bso517846997b3.9 for ; Thu, 25 Aug 2022 10:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=SOy68UEC0YgOxRxAM7LgXUvCsgIpZ6R1Pgijw93SqxM=; b=gx+Erd/icC6qh4IpZ0BSBdmpw72IdDomoBSPsFosYc0KoaDrWd1W9SM9staylbgCNc MPf88UCEPkXGCaLJenxA1lV92FL/7Tytze7zn18IyirkGA3f4FW7S2ZPVZiyQ87rhIlv BA+2ZCv+U6jBOexCd2weKguHWIl0L6x/13GKSEoKla7Y1FdiXagdokJBwVMPdIoeD3r4 7qF9JZnVZiG5e8VqAL4XtxEb6Gxyd/8KpR/4fJNHIb31YnikFRKxIbPpEMYl1Az5uF+L vQs1ogcJ4Qg65HcaDMHd9jxwXAcrqpEXuCx6xxi/57iFcFdsmp9DViLsYfC1N4HpflD3 dyIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=SOy68UEC0YgOxRxAM7LgXUvCsgIpZ6R1Pgijw93SqxM=; b=Ef5d2sKGLYZnx4qfTUnTyYHsTa4CgPXoveET3ZWYzbyw9AAMoIR5xrT5tElemVTOnW CzB14Q8n5hulROdhtyWHC8nOZwRnG1Qm5lwjb4SgQhXwUzS05HlhaeNiAs+kPujuetfq 0oiec+VDj6NejvCB0hHdck4BSuNdZPh0iipaW0fmhRTbAa8OMX2YJNdRFU/gV324UTBk 6l71Fv+DZVH5s2e2JrK2Jc35FmrC5YPpxyou+CWjRUEYsblJwbzn43fUr1DbvejL6wzW FCFsnvyH9IkYfyUxr2t7PPW9RzVd7Lkbv0jv4AYCJ7fbcZeao7pO/k2+nZ9a11ExoX2D Q1Ng== X-Gm-Message-State: ACgBeo2ACTuMX6JoAJYHsWulxLaVP/hbE5mrtBQVy/GJOGWRD7MBT5Dy TXGc1V11J/X2TpLAeTnd26//XU79e/a9TBPTlUAhVw== X-Google-Smtp-Source: AA6agR4amXEIKvXMXuUDe8G8QYLGEe0SPU95eszKZrRMSzAgG7u84pGBQ/1fQFxjQQcM+hKkbwNc/Si/sXNJBxpChlc= X-Received: by 2002:a81:7992:0:b0:336:8015:4889 with SMTP id u140-20020a817992000000b0033680154889mr5015363ywc.80.1661447180125; Thu, 25 Aug 2022 10:06:20 -0700 (PDT) MIME-Version: 1.0 References: <20220727013349.3056826-1-saravanak@google.com> <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> <13dde9ca-35de-bd8a-ec47-87fe1f844308@linaro.org> In-Reply-To: <13dde9ca-35de-bd8a-ec47-87fe1f844308@linaro.org> From: Saravana Kannan Date: Thu, 25 Aug 2022 10:05:43 -0700 Message-ID: Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them To: Krzysztof Kozlowski Cc: Linus Walleij , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Aug 25, 2022 at 5:11 AM Krzysztof Kozlowski wrote: > > On 25/08/2022 15:08, Linus Walleij wrote: > > On Thu, Jul 28, 2022 at 10:32 AM Krzysztof Kozlowski > > wrote: > >> On 27/07/2022 03:33, Saravana Kannan wrote: > > > >>> As soon as a gpio is registered, it should be usable by a consumer. So, > >>> do all the initialization before registering the gpios. Without this > >>> change, a consumer can request a GPIO IRQ and have the gpio to IRQ > >>> mapping fail. > >>> > >>> Signed-off-by: Saravana Kannan > >> > >> Looks good. > >> > >> Linus, > >> It's too late for me to pick it up, so make you could grab it directly? > >> > >> Reviewed-by: Krzysztof Kozlowski > >> > >> Otherwise it will wait for merge window to finish. > > > > I sadly missed this during the merge window, as the commit message didn't > > make it look like a fix or something urgent. (I don't know if it is?) > > Just send me the patch as fix or for -next, I let you decide. It wasn't anything urgent. I found this issue when I was refactoring fw_devlink, but that series hasn't landed yet. So it's okay if it's landing only in 6.0. -Saravana > > I understood, so I already picked it up after merge window. I'll send > you this in a pull. > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47CDEECAA24 for ; Thu, 25 Aug 2022 17:07:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u2doYh00eCcxWaOoblEKyTJqd2ZiXQcmfLCCXH/iY9U=; b=c8pbj99VZoCwGa DYReME6mJSAEcPo5JCYejCvmjxTMNSSJsCi54aAZLhkzdVILRGZ41N1UspTl/XCGKMMgNR5ICTfB6 mktxbHsbCZix1J2UTo8uuc324NZ6IEAudEkHKxRlKG6lt53V+eWe5BJmJrQvoqg/iMeq2I/yrWBIb l2z3MW2m+PdGcv6vIshVQR6sm0yQQRqr15Xd3dADO5N7R6FTx8pzvFPcN63GE4AUZSG/aolsSxxd7 3U8NMEtUIAoOqoCCMlq8gBCJo6xQ6x8PpbL2wt5wN60YWTLjLH/R56PRLxKUo5LbZLLbMoYUqmNvz ftGVNbcDLNXFrMXt/NKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRGJJ-00GfjE-IG; Thu, 25 Aug 2022 17:06:29 +0000 Received: from mail-yw1-x112f.google.com ([2607:f8b0:4864:20::112f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRGJG-00Gfco-R7 for linux-arm-kernel@lists.infradead.org; Thu, 25 Aug 2022 17:06:28 +0000 Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-33db4e5ab43so76053517b3.4 for ; Thu, 25 Aug 2022 10:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=SOy68UEC0YgOxRxAM7LgXUvCsgIpZ6R1Pgijw93SqxM=; b=gx+Erd/icC6qh4IpZ0BSBdmpw72IdDomoBSPsFosYc0KoaDrWd1W9SM9staylbgCNc MPf88UCEPkXGCaLJenxA1lV92FL/7Tytze7zn18IyirkGA3f4FW7S2ZPVZiyQ87rhIlv BA+2ZCv+U6jBOexCd2weKguHWIl0L6x/13GKSEoKla7Y1FdiXagdokJBwVMPdIoeD3r4 7qF9JZnVZiG5e8VqAL4XtxEb6Gxyd/8KpR/4fJNHIb31YnikFRKxIbPpEMYl1Az5uF+L vQs1ogcJ4Qg65HcaDMHd9jxwXAcrqpEXuCx6xxi/57iFcFdsmp9DViLsYfC1N4HpflD3 dyIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=SOy68UEC0YgOxRxAM7LgXUvCsgIpZ6R1Pgijw93SqxM=; b=xXoM7VzqpGTp5vTj/za//1eU06ovf6n0fWQ+sXGYrPj1s9WuhbuE2sAS4ueeIq7Wpu lOQbsyXtlS0eK+7/0Y7LMQfXD1RsFNscxTEUqZ1nc1QZbZWhw3AgLAPZaDZT3bR/nxBz qAYqIS17LoY3tyk4dyWY2atbdXpZGMg2R8Swt/8s8B9i3LRDBATy7CUaeR3Nvht+1VQK IvDi0aIc/v0+8wctIR52NvaJU6XtBklxy2Vm7gCEmCY3ZYF58wcDp+unQVUuxsyFfA2T 97uaC1TBCiK+aubDCFS9kduALc43nN08dqqnWUUgO7kYXAf7maSHQOXSqK/X6RUIOBmO 1mfg== X-Gm-Message-State: ACgBeo01GriGXbIo3aZD+YlsG42R02VvKHTcRLJt/7czUVXEPEuiBW2y jWJUYLNKV7vAo5eC69aWr+prc1R0oLIOlMmOf094pw== X-Google-Smtp-Source: AA6agR4amXEIKvXMXuUDe8G8QYLGEe0SPU95eszKZrRMSzAgG7u84pGBQ/1fQFxjQQcM+hKkbwNc/Si/sXNJBxpChlc= X-Received: by 2002:a81:7992:0:b0:336:8015:4889 with SMTP id u140-20020a817992000000b0033680154889mr5015363ywc.80.1661447180125; Thu, 25 Aug 2022 10:06:20 -0700 (PDT) MIME-Version: 1.0 References: <20220727013349.3056826-1-saravanak@google.com> <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> <13dde9ca-35de-bd8a-ec47-87fe1f844308@linaro.org> In-Reply-To: <13dde9ca-35de-bd8a-ec47-87fe1f844308@linaro.org> From: Saravana Kannan Date: Thu, 25 Aug 2022 10:05:43 -0700 Message-ID: Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them To: Krzysztof Kozlowski Cc: Linus Walleij , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_100626_893937_06566955 X-CRM114-Status: GOOD ( 21.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 25, 2022 at 5:11 AM Krzysztof Kozlowski wrote: > > On 25/08/2022 15:08, Linus Walleij wrote: > > On Thu, Jul 28, 2022 at 10:32 AM Krzysztof Kozlowski > > wrote: > >> On 27/07/2022 03:33, Saravana Kannan wrote: > > > >>> As soon as a gpio is registered, it should be usable by a consumer. So, > >>> do all the initialization before registering the gpios. Without this > >>> change, a consumer can request a GPIO IRQ and have the gpio to IRQ > >>> mapping fail. > >>> > >>> Signed-off-by: Saravana Kannan > >> > >> Looks good. > >> > >> Linus, > >> It's too late for me to pick it up, so make you could grab it directly? > >> > >> Reviewed-by: Krzysztof Kozlowski > >> > >> Otherwise it will wait for merge window to finish. > > > > I sadly missed this during the merge window, as the commit message didn't > > make it look like a fix or something urgent. (I don't know if it is?) > > Just send me the patch as fix or for -next, I let you decide. It wasn't anything urgent. I found this issue when I was refactoring fw_devlink, but that series hasn't landed yet. So it's okay if it's landing only in 6.0. -Saravana > > I understood, so I already picked it up after merge window. I'll send > you this in a pull. > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel