From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1BCCC3F6B0 for ; Wed, 27 Jul 2022 02:16:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233600AbiG0CQg (ORCPT ); Tue, 26 Jul 2022 22:16:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230245AbiG0CQf (ORCPT ); Tue, 26 Jul 2022 22:16:35 -0400 Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBB533C174 for ; Tue, 26 Jul 2022 19:16:33 -0700 (PDT) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-31e623a4ff4so161223377b3.4 for ; Tue, 26 Jul 2022 19:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dVN886NSrhQs8UWcwxaCPHANRVdx/m1bEPjAIN2GoxU=; b=GjkAHE5qR37LBJVes25IDRzw02yBl1adJiKjgbAj6FShHvOdjwfz78fltGk1xlzovC uwLhYx4fFuZp3QWHsGSvAXWaoq8EFp7PeFaXSMnvG7yxhZdKDDFlJereIUDZQns8h5I+ V58kR3heJaQqGz0rMaQQ/zKGX45W3r720h1gluPDtnn9qaAkxBni08RmBRPsB8w/CdEp QxIr787KZucoU6ES4FEW/8dt27JadkSsdISlSG1WodhxdWG6F1DQJvYxBcWabL5ysU1D pzmk7hhNkcyUIN3ATMp1FSYkXJias/sOiSvv7vKwpc4DkvA5MrRGJxjrzCgYkldrAFlt 8Dkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dVN886NSrhQs8UWcwxaCPHANRVdx/m1bEPjAIN2GoxU=; b=601i40askLStQmXBvMYuBrS4KxYLPgavPAJux8Rt9WVr9X0ZPmnnj1vjAGgaojen61 4e8Td0iSHRPAzGzBUb2FfxDVaEG4td+/IuYEpFFcQuMd2BVmxCz5Yt5lML32w/4HOejh sXsGLjCUk/fw0vf3Z4+lZfnleSFaeYlLwEPqw4J5Cl5rWrNK+lM44b0aMti58oUGeah9 LFhzavuTFXVLKGlJuLowTs+hKSOxZkWUzYP0N7mV4XgHPCqiT4Rctr1ciMg4hU57a8iZ vcpo8sRYAHpXNahUb9yi1IMZSg/ZORfU2a4GrsZ4TjmpvsieU0cE64cGkxCaQ7SgVdwW HLYQ== X-Gm-Message-State: AJIora+BvehaIta7OCsTAoqW3VnhVeAnGkDfPO5WomRGUKdA7LaVLvU3 0FQDZsYq1AvGWBL76Bnm2bEs78SCRudUowvWdIhEbA== X-Google-Smtp-Source: AGRyM1shFIftgpaxzZdS4kTpLlP5M16qJKmX4KJ/sZiobJ0XSiBFR7JGQsYQPUGcISQ9B3sW42W/eq2EFfD3Ddj/6ac= X-Received: by 2002:a81:4807:0:b0:31e:7002:46cc with SMTP id v7-20020a814807000000b0031e700246ccmr17615235ywa.83.1658888192913; Tue, 26 Jul 2022 19:16:32 -0700 (PDT) MIME-Version: 1.0 References: <20220727013349.3056826-1-saravanak@google.com> <000001d8a15c$da89d980$8f9d8c80$@samsung.com> In-Reply-To: <000001d8a15c$da89d980$8f9d8c80$@samsung.com> From: Saravana Kannan Date: Tue, 26 Jul 2022 19:15:56 -0700 Message-ID: Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them To: Chanho Park Cc: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Linus Walleij , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Jul 26, 2022 at 7:02 PM Chanho Park wrote: > > > Subject: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before > > registering them > > > > As soon as a gpio is registered, it should be usable by a consumer. So, do > > all the initialization before registering the gpios. Without this change, > > a consumer can request a GPIO IRQ and have the gpio to IRQ mapping fail. > > > > Signed-off-by: Saravana Kannan > > Make sense for me and I tested this on my Exynos Auto v9 SADK board. > > Reviewed-by: Chanho Park > Tested-by: Chanho Park Thank you! -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A53FBC19F28 for ; Wed, 27 Jul 2022 02:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wibYaspddh5EwWQIFJJrvbDJxYhf1WeOeGexRtHqsVQ=; b=ClJyCO/F3iVxjp DV4EqfnJYHxusA0Ap7f0n98FW/7h5cY1ajoWz6LdSxVSFKUwTcutEyCU1hsClRGGdnDl5bPUznnC7 9Q9DyYYDn9ZRb3xrQwFipA0IEf4w82ddCMn+ICW2Fkd+qO/0R7JKR7dXBOM3PYIt5JZRVMOHxHMTk nuvI6lFo2pXTgmrfhJr/hOJwVg30wPt5z97Ox80Jt7MSfG2qEcMTrQWUauo3gWLpjY7RqgpDPCdBU NZvGRhxyqcN3zQlqx8yRljtVSo2NRyCzOxRfX/Vq1UcphgGd0gnaCIN1hvItLmpZqKyDR8rn7yqpW Z04SpLh2Jg6qEdHp7v+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGWbK-007i4O-98; Wed, 27 Jul 2022 02:16:42 +0000 Received: from mail-yw1-x1130.google.com ([2607:f8b0:4864:20::1130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGWbH-007hzZ-4D for linux-arm-kernel@lists.infradead.org; Wed, 27 Jul 2022 02:16:40 +0000 Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-31f64093c21so2333657b3.6 for ; Tue, 26 Jul 2022 19:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dVN886NSrhQs8UWcwxaCPHANRVdx/m1bEPjAIN2GoxU=; b=GjkAHE5qR37LBJVes25IDRzw02yBl1adJiKjgbAj6FShHvOdjwfz78fltGk1xlzovC uwLhYx4fFuZp3QWHsGSvAXWaoq8EFp7PeFaXSMnvG7yxhZdKDDFlJereIUDZQns8h5I+ V58kR3heJaQqGz0rMaQQ/zKGX45W3r720h1gluPDtnn9qaAkxBni08RmBRPsB8w/CdEp QxIr787KZucoU6ES4FEW/8dt27JadkSsdISlSG1WodhxdWG6F1DQJvYxBcWabL5ysU1D pzmk7hhNkcyUIN3ATMp1FSYkXJias/sOiSvv7vKwpc4DkvA5MrRGJxjrzCgYkldrAFlt 8Dkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dVN886NSrhQs8UWcwxaCPHANRVdx/m1bEPjAIN2GoxU=; b=V3ysFv3cnACgv0TOhWj+LOJ3hR2xANxU0gbLVY+gZSIyKJvk/LbOqx2EXkGIqNDoph 73bcfe0nPoeSJxJkaDy8wzdVrmWHqjd7OMcThbwofkYnoprD31LZHVDvJ+tpIa2FiRat xs8qlu8+dz7ctn0/DB5FKsQR0FrgZCbhzUthWGIue4XkG6sOMwSQtmWO7mKHKYZk1CbG ZWKTqqsPplGwlI64bmAYNa/irFHFyGKISoYJWJU9h/exiCAbwUIhG4ge63qpzChMKP5D 7x9G9ukodIHwj/VJSxg5NOmbXpCkZ7jIjXap2iK+VinLtdRAI6liR2ArHPqH9/uJr+fT AL7w== X-Gm-Message-State: AJIora8+XMwKngaWpajgeik8Ta2Ccgg4fbdaedwloAwzDs2yWYgMNMqs nXujFWhjZdTl03fkYbT2P/5vbntKDraZCoa+2eMR4Q== X-Google-Smtp-Source: AGRyM1shFIftgpaxzZdS4kTpLlP5M16qJKmX4KJ/sZiobJ0XSiBFR7JGQsYQPUGcISQ9B3sW42W/eq2EFfD3Ddj/6ac= X-Received: by 2002:a81:4807:0:b0:31e:7002:46cc with SMTP id v7-20020a814807000000b0031e700246ccmr17615235ywa.83.1658888192913; Tue, 26 Jul 2022 19:16:32 -0700 (PDT) MIME-Version: 1.0 References: <20220727013349.3056826-1-saravanak@google.com> <000001d8a15c$da89d980$8f9d8c80$@samsung.com> In-Reply-To: <000001d8a15c$da89d980$8f9d8c80$@samsung.com> From: Saravana Kannan Date: Tue, 26 Jul 2022 19:15:56 -0700 Message-ID: Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them To: Chanho Park Cc: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Linus Walleij , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220726_191639_207909_A12C4CE3 X-CRM114-Status: GOOD ( 12.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 26, 2022 at 7:02 PM Chanho Park wrote: > > > Subject: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before > > registering them > > > > As soon as a gpio is registered, it should be usable by a consumer. So, do > > all the initialization before registering the gpios. Without this change, > > a consumer can request a GPIO IRQ and have the gpio to IRQ mapping fail. > > > > Signed-off-by: Saravana Kannan > > Make sense for me and I tested this on my Exynos Auto v9 SADK board. > > Reviewed-by: Chanho Park > Tested-by: Chanho Park Thank you! -Saravana _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel