From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F2DC38142 for ; Wed, 25 Jan 2023 02:13:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232680AbjAYCND (ORCPT ); Tue, 24 Jan 2023 21:13:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbjAYCM6 (ORCPT ); Tue, 24 Jan 2023 21:12:58 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E86727986 for ; Tue, 24 Jan 2023 18:12:53 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id nn18-20020a17090b38d200b0022bfb584987so584959pjb.2 for ; Tue, 24 Jan 2023 18:12:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wyo4ScdnKnOpNdEhwobdQ9WeYs+jQOexpJlhKGainQs=; b=WQyTcKY9Wn6wifrEjH06aIMPm5KuR8cVj90LyYYJz6t1gLRSgzj4DxVSOIXQrDTHeL 9zuk9jn2JQ1RAshLv1HMdYfn/ObWLARV+rYWZAYhvVg0ex573km+2YS9+iAxnzzFPWab xk3UswT1bRiKDvYUUrjYuisGK3SXVxzpr1oMSX5KjT2qJDBLIOulxdjgfeAMQccwgUNC m72LoKWAg5fYvJETfDRi+uSLf6VdRf0ewoX7PM5gLhfDyex8y4ln3R0dJFbdWLLF0w05 oTABPC3xvqhglWITFsiPtJPXWGmtTLJ6lfAY3IQ23XLwQ1j8xvdZOy65FOU+2aHNk8Tj dZ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wyo4ScdnKnOpNdEhwobdQ9WeYs+jQOexpJlhKGainQs=; b=TZ0VPMgDQd3oc8a1eFFgtuOodV2X6m2VcP5SxEkeJzhdi3FnFuBuPVJO3NlwNZTho/ x1tiyb+wnxBRxo0SB/mWLzbHRoiDAYLLPfVzLp5a/9F79uE928XyNq+irzE7yGhchOnh 011Vy4oTcF3yBHCT3KrFUVPmw7XkKG+H53Lx+wile0ayID7bbfePdfwP3xlq+PSSkFkS D6lelgHUeN4erk0jwuC1vymxyVkT/iQk56s9pMLTAvXb7A/XrlC4FoLPEBf87yo1o947 gJTUQlI9fz8zxbS+y7hW0f0COjYFB4I0K3rg6BcFar0Jz77hp0wK2WPDv7HX6Hz75TXY ylWA== X-Gm-Message-State: AFqh2kpC0WhQRafnQJaoXk8vl8wngpAjqiN3tWyK9MTagp5P0y0pVZ5d dZpLPesum5IZ7WJWYVpvrEDcWlXwkXWcyYViOhGAGg== X-Google-Smtp-Source: AMrXdXsVEndUelWqeTOq/yI0y1T7Go1AUXK7I4T+7m8PmMng+9RYf16DOxvQdM/cJ77ZduwDlA9DcaAtqzg9qyhk06g= X-Received: by 2002:a17:90a:e646:b0:229:ca6a:d742 with SMTP id ep6-20020a17090ae64600b00229ca6ad742mr3309663pjb.221.1674612772253; Tue, 24 Jan 2023 18:12:52 -0800 (PST) MIME-Version: 1.0 References: <20230118091122.2205452-1-dmitry.baryshkov@linaro.org> In-Reply-To: From: Saravana Kannan Date: Tue, 24 Jan 2023 18:12:15 -0800 Message-ID: Subject: Re: [RESEND PATCH] of: property: do not create clocks device link for clock controllers To: Rob Herring Cc: Dmitry Baryshkov , Frank Rowand , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bjorn Andersson , Stephen Boyd , Abel Vesa Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Jan 18, 2023 at 5:35 AM Rob Herring wrote: > > On Wed, Jan 18, 2023 at 3:11 AM Dmitry Baryshkov > wrote: > > > > Do not create device link for clock controllers. Some of the clocks > > provided to the device via OF can be the clocks that are just parents to > > the clocks provided by this clock controller. Clock subsystem already > > has support for handling missing clock parents correctly (clock > > orphans). Later when the parent clock is registered, clocks get > > populated properly. > > > > An example of the system where this matters is the SDM8450 MTP board > > (see arch/arm64/boot/dts/qcom/sdm845-mtp.dts). Here the dispcc uses > > clocks provided by dsi0_phy and dsi1_phy device tree nodes. However the > > dispcc itself provides clocks to both PHYs, to the PHY parent device, > > etc. With just dsi0_phy in place devlink is able to break the > > dependency, but with two PHYs, dispcc doesn't get probed at all, thus > > breaking display support. > > > > Cc: Bjorn Andersson > > Cc: Stephen Boyd > > Cc: Saravana Kannan > > Cc: Abel Vesa > > Signed-off-by: Dmitry Baryshkov > > --- > > > > This patch has been posted a year ago in January 2022 ([1]). Since that time > > Saravana failed to produce patches to assist in debugging the issue > > ([2]) or to fix the issue ([3]). The issue we observe has been described > > by Abel at ([4]). As we work on adding support for Dual DSI > > configurations, the issue becomes more and more important, since binding > > the whole display subsystem fails. I did send out a patch series[1] to try and fix this. Heck I even talked about this in LPC 2022. So I don't think it's accurate to say I didn't help debug this or fix this. There's some email thread in lore where Abel gave more details and I figured out the issue and we didn't need any more debugging. And then I sent out [1]. Sorry I missed you in the cc lise for [1] -- I try to keep track of everyone to cc but things slip through the cracks sometimes. But at the same time, it's easy to check for emails from me before saying I didn't help or didn't send out fixes :) If you do try to give [1] a shot, there are a bunch of bugs that people pointed out for which I gave fixes on top of [1] in the replies. I was supposed to work on v2 over the holidays, but that didn't happen because of stuff outside my control. > That's ample time to fix this, so I intend to apply this. But I'll > give it a few days for comments. Rob, I'd recommend not applying this because it'll fix it for Dmitry but break someone else's use case. That's the whole reason it takes me a while to send out patches -- it's easy to fix it for a subset of devices, but fixing something without breaking someone else is harder (I still believe it's doable) and it takes a while to test them on all the devices I want to test before sending them out. -Saravana [1] - https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@google.com/