From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC6D0C433FE for ; Fri, 3 Sep 2021 19:09:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE95760EC0 for ; Fri, 3 Sep 2021 19:09:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350964AbhICTKC (ORCPT ); Fri, 3 Sep 2021 15:10:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350597AbhICTKB (ORCPT ); Fri, 3 Sep 2021 15:10:01 -0400 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 648D1C061757 for ; Fri, 3 Sep 2021 12:09:00 -0700 (PDT) Received: by mail-yb1-xb36.google.com with SMTP id r4so365682ybp.4 for ; Fri, 03 Sep 2021 12:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m6kpIcQI2kaeiGN8nOW6gd72C2N5gwlYdeH/BXEk3Ws=; b=PvIxT7UYlvbGZmDSRi18bm+CxUU48AfcXm9EVQwqw8l0pfPFhqZV2NwLMWThnRNQif MO2cXjZ0xcgzs1LBL3ow0iJ5DfJt6Hmo+YYUCJRIK+z7X6DyaQq+UMQEF3EiLDBqlLh1 /rSntEhSdbFPMal5QBM4JBppsm4QaeDZtZ317wUdQYPmfC9c4ua58gXSCCV2mS2znkIi +AW8NFIST00oSt6Ur25EKWop+672adF/gMnqM8+35S0g7ffpbz90FrGSuVX20Qh/Yefy tDNwMV+r2BhlrUlwjXxUjuRYyEDaTxZK63MzR12bnURbIaR1CC3SPPhushnXtM/4npvj kkAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m6kpIcQI2kaeiGN8nOW6gd72C2N5gwlYdeH/BXEk3Ws=; b=Udian1c3Tq3TpO/eMW/7AlpVLwNSd9mZaXfO2PIjl++EMg0gJKwouBnefsehfCVwos q6Puhl1DAVm5oxYt398no7Y7GMlfDVjZmW+QqBtugLeksoOcquFoNb5s+yg2Zj2c/YsX jmMXwAkT4slgpDBvjRTmd43I4tNpe2sDU9+NWWmMMuttOU/t5E/0iua+UbLmqQNfmFrB /uYAWOK3ZyBqT5x89BnpH1D3VcwZpYxL3Iw48+dN37sX8/ZhQX4lx7xgZjJ7FgOLcl97 1bjrAYUOfBkQuqZFrOdEnCnW9c9/SAW/hXjh/ZN3HP4+s40eiEkjRUE4keeTTDiCunru 6X9g== X-Gm-Message-State: AOAM532mMWAW5rUldSZgQn0eE5FEXkEFhmYtTENPXiQhyttAPZUZ2y0u AlyebQsxwUmRxSH6RxyamhRyZbPY+N2pgnKL8RWWGw== X-Google-Smtp-Source: ABdhPJxVZXFvEDaU45VGsxRolnCRjbgaMa/2/abHvvKaPNlUXiJlihfRMjwfrHOKIXu70pEcFfzd668Yq6qeLZnvku0= X-Received: by 2002:a25:21c5:: with SMTP id h188mr697656ybh.23.1630696139325; Fri, 03 Sep 2021 12:08:59 -0700 (PDT) MIME-Version: 1.0 References: <20210902230442.1515531-1-saravanak@google.com> <20210902230442.1515531-2-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Fri, 3 Sep 2021 12:08:23 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] of: platform: Make sure bus only devices get probed To: Geert Uytterhoeven Cc: Ulf Hansson , Rob Herring , Frank Rowand , Android Kernel Team , Linux Kernel Mailing List , DTML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 3, 2021 at 12:06 PM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Fri, Sep 3, 2021 at 7:09 PM Saravana Kannan wrote: > > On Fri, Sep 3, 2021 at 7:29 AM Geert Uytterhoeven wrote: > > > On Fri, Sep 3, 2021 at 11:19 AM Ulf Hansson wrote: > > > > On Fri, 3 Sept 2021 at 01:04, Saravana Kannan wrote: > > > > > fw_devlink could end up creating device links for bus only devices. > > > > > However, bus only devices don't get probed and can block probe() or > > > > > sync_state() [1] call backs of other devices. To avoid this, set up > > > > > these devices to get probed by the simple-pm-bus. > > > > > > > > > > [1] - https://lore.kernel.org/lkml/CAPDyKFo9Bxremkb1dDrr4OcXSpE0keVze94Cm=zrkOVxHHxBmQ@mail.gmail.com/ > > > > > Signed-off-by: Saravana Kannan > > > > > Tested-by: Saravana Kannan > > > > > > > > Again, this looks like a nice solution to the problem. > > > > > > > > One question though. The Kconfig SIMPLE_PM_BUS, should probably be > > > > "default y" - or something along those lines to make sure fw_devlink > > > > works as expected. > > > > > > I would love for SIMPLE_PM_BUS to go away, and all of its functionality > > > to be usurped by the standard simple-bus handling. > > > > What if SIMPLE_PM_BUS *is* the standard simple-bus handling? > > Insert "I'm the captain now" meme. > > No objections from my side. In fact that's how I wanted it to be > from the beginning, but the DT people wanted a separate compatible > value (and a separate driver). The only difference is the presence > of pm_runtime_*() calls. > > > I think SIMPLE_PM_BUS config should just go away and we should compile > > the driver in if CONFIG_OF is selected. > > I think there would be no need for a separate driver, if the standard > simple-bus handling would take care of it. I'm not sure about the history there. For now, I'm just extending this driver to take care of simple-bus too. -Saravana