From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86293C433DB for ; Wed, 20 Jan 2021 19:50:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FD7F2343E for ; Wed, 20 Jan 2021 19:50:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392794AbhATTuU (ORCPT ); Wed, 20 Jan 2021 14:50:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392658AbhATTst (ORCPT ); Wed, 20 Jan 2021 14:48:49 -0500 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12370C061575 for ; Wed, 20 Jan 2021 11:48:09 -0800 (PST) Received: by mail-yb1-xb2d.google.com with SMTP id k132so13448580ybf.2 for ; Wed, 20 Jan 2021 11:48:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z+VKdic9vQLplZ5dRDPFBsqTAKEx7zvAEih/IIGE3o4=; b=gqXXWU/DUfCRlZqg6VB4WrIPdIGgIy2FpoB64Tw6CtQ1jL1wrLFZqp3MrEbrMBYGiZ N4/i+WbY5NkRoGQ0TOQ8gSx1H/xButR/QyThA+B2Gz/O5XBV3DuftVSBSZBLeyg1OLU+ UOnY3ZnpvA9fS2hSivgKSdxrfkTqrNLOncrFUlwoHemuKABuY67DntKltT3SJx0D9dWo /9pBl19rfoJS1N1WX6MM6xVcEDMYzyaqXAJ7Q6wXNhN/hh/u8nnQojbYlYlOdnqtABHz lhAfatORzVUNAHTBDkjRB1KD+A8zB99tvQ/Y4CW0lF2FN6Oz8vdPn1HEE/kgKprBbKFe sZcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z+VKdic9vQLplZ5dRDPFBsqTAKEx7zvAEih/IIGE3o4=; b=ApxUIAkiUqzJ6X2Px/BV7+D5mE8PF1+IcdmEYoU+uCODqszYaV41rHq7Uo1yZ9qFct 5E9Nhx8+wkohYoGvmmjiUs7VG9nh6goT2gT2lCtfgDHgpw++vSV3pjm7fFvfnnEYuC1s Gr+jyWfmJA9EpMjcjFHY52/F0ZLvHMvHS4MI69/CduMK629nuitlKwuWsswrVqPm3bTu pDFjF3zBDnzjPUMwTJt/FA5K+h7qhpOpKnYc3RdRwG6nghWVbNEb0yu8YZOf6UdzcvU/ hJoRm5IqHWi+9eORwrBnxIMn4komiIaW4HhjrKHe6ecbCI9L0s+7nrbzOjTNi3ZnLFCT Kw9w== X-Gm-Message-State: AOAM5335ks4k3ylowWTQlu/aUW6n8cueD6Pkam2IyoQYv6XplJS5XHok qukfV6TZOWlBIcCtAx5yWE6mGh8UTtDX7yvaq90Obg== X-Google-Smtp-Source: ABdhPJy6lnzImOgxZ62zFBVY/BNYqrbN/QRRos+AWvRoeObCVMQxkr4MeX9zWJIX5eWD7W+mqvC8d3XxTrbOt6hpwoA= X-Received: by 2002:a25:77d4:: with SMTP id s203mr17677961ybc.32.1611172088185; Wed, 20 Jan 2021 11:48:08 -0800 (PST) MIME-Version: 1.0 References: <20210120105246.23218-1-michael@walle.cc> In-Reply-To: From: Saravana Kannan Date: Wed, 20 Jan 2021 11:47:31 -0800 Message-ID: Subject: Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() To: Michael Walle Cc: Rob Herring , linuxppc-dev , PCI , linux-arm-kernel , LKML , Minghuan Lian , Mingkai Hu , Roy Zang , Lorenzo Pieralisi , Bjorn Helgaas , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 11:28 AM Michael Walle wrote: > > [RESEND, fat-fingered the buttons of my mail client and converted > all CCs to BCCs :(] > > Am 2021-01-20 20:02, schrieb Saravana Kannan: > > On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: > >> > >> On Wed, Jan 20, 2021 at 4:53 AM Michael Walle > >> wrote: > >> > > >> > fw_devlink will defer the probe until all suppliers are ready. We can't > >> > use builtin_platform_driver_probe() because it doesn't retry after probe > >> > deferral. Convert it to builtin_platform_driver(). > >> > >> If builtin_platform_driver_probe() doesn't work with fw_devlink, then > >> shouldn't it be fixed or removed? > > > > I was actually thinking about this too. The problem with fixing > > builtin_platform_driver_probe() to behave like > > builtin_platform_driver() is that these probe functions could be > > marked with __init. But there are also only 20 instances of > > builtin_platform_driver_probe() in the kernel: > > $ git grep ^builtin_platform_driver_probe | wc -l > > 20 > > > > So it might be easier to just fix them to not use > > builtin_platform_driver_probe(). > > > > Michael, > > > > Any chance you'd be willing to help me by converting all these to > > builtin_platform_driver() and delete builtin_platform_driver_probe()? > > If it just moving the probe function to the _driver struct and > remove the __init annotations. I could look into that. Yup. That's pretty much it AFAICT. builtin_platform_driver_probe() also makes sure the driver doesn't ask for async probe, etc. But I doubt anyone is actually setting async flags and still using builtin_platform_driver_probe(). -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5C6C433DB for ; Wed, 20 Jan 2021 20:59:59 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BC1D233FC for ; Wed, 20 Jan 2021 20:59:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BC1D233FC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DLdFT0L6nzDqtW for ; Thu, 21 Jan 2021 07:59:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::b2b; helo=mail-yb1-xb2b.google.com; envelope-from=saravanak@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=gqXXWU/D; dkim-atps=neutral Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DLbfk4RLYzDqTg for ; Thu, 21 Jan 2021 06:48:13 +1100 (AEDT) Received: by mail-yb1-xb2b.google.com with SMTP id y128so20569871ybf.10 for ; Wed, 20 Jan 2021 11:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z+VKdic9vQLplZ5dRDPFBsqTAKEx7zvAEih/IIGE3o4=; b=gqXXWU/DUfCRlZqg6VB4WrIPdIGgIy2FpoB64Tw6CtQ1jL1wrLFZqp3MrEbrMBYGiZ N4/i+WbY5NkRoGQ0TOQ8gSx1H/xButR/QyThA+B2Gz/O5XBV3DuftVSBSZBLeyg1OLU+ UOnY3ZnpvA9fS2hSivgKSdxrfkTqrNLOncrFUlwoHemuKABuY67DntKltT3SJx0D9dWo /9pBl19rfoJS1N1WX6MM6xVcEDMYzyaqXAJ7Q6wXNhN/hh/u8nnQojbYlYlOdnqtABHz lhAfatORzVUNAHTBDkjRB1KD+A8zB99tvQ/Y4CW0lF2FN6Oz8vdPn1HEE/kgKprBbKFe sZcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z+VKdic9vQLplZ5dRDPFBsqTAKEx7zvAEih/IIGE3o4=; b=ZbFyzhev4f0pBIIsu7FPMjl22VRuMNzWN+LNHoVSF5xgt7CEw1MMjNFJXE8q8Y+Vsm BHhnl5CNKjndsy4jI3Daw7iZs5dTB0G1NWDDmGsElUaH3ccg/J/s3fqH/T0Pk8cU69i2 ecXCjLIt04rYHqGF1f4UqrGskD9heFzHmkSquXbsUr2DCMZ39p4E79k65lhIU1wOWrGm t/wPN/FdZMUiebqcHfatm2FobjpQoWfsFD3cH+biwsuWgfqAwkHGJxGi1c1YW/JF4MW1 WTLxRB/1UxnjsR9zrilmcWkWA71n9WCCja9Soepcq00Isfkb/m4aSEgnSV8ShVv6k8ac 03FA== X-Gm-Message-State: AOAM530v58Lx1fw/RcNZRbEqv/vN0FlciMC4cUOfpma1AUmdZ/UJ0dJ5 m8/K5bZhZ0Wc2LCzUlro4zfUEH6wm90gJ5vTkmeNxA== X-Google-Smtp-Source: ABdhPJy6lnzImOgxZ62zFBVY/BNYqrbN/QRRos+AWvRoeObCVMQxkr4MeX9zWJIX5eWD7W+mqvC8d3XxTrbOt6hpwoA= X-Received: by 2002:a25:77d4:: with SMTP id s203mr17677961ybc.32.1611172088185; Wed, 20 Jan 2021 11:48:08 -0800 (PST) MIME-Version: 1.0 References: <20210120105246.23218-1-michael@walle.cc> In-Reply-To: From: Saravana Kannan Date: Wed, 20 Jan 2021 11:47:31 -0800 Message-ID: Subject: Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() To: Michael Walle Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Thu, 21 Jan 2021 07:49:58 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Lorenzo Pieralisi , Roy Zang , PCI , LKML , Minghuan Lian , Mingkai Hu , Greg Kroah-Hartman , Bjorn Helgaas , linuxppc-dev , linux-arm-kernel Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Jan 20, 2021 at 11:28 AM Michael Walle wrote: > > [RESEND, fat-fingered the buttons of my mail client and converted > all CCs to BCCs :(] > > Am 2021-01-20 20:02, schrieb Saravana Kannan: > > On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: > >> > >> On Wed, Jan 20, 2021 at 4:53 AM Michael Walle > >> wrote: > >> > > >> > fw_devlink will defer the probe until all suppliers are ready. We can't > >> > use builtin_platform_driver_probe() because it doesn't retry after probe > >> > deferral. Convert it to builtin_platform_driver(). > >> > >> If builtin_platform_driver_probe() doesn't work with fw_devlink, then > >> shouldn't it be fixed or removed? > > > > I was actually thinking about this too. The problem with fixing > > builtin_platform_driver_probe() to behave like > > builtin_platform_driver() is that these probe functions could be > > marked with __init. But there are also only 20 instances of > > builtin_platform_driver_probe() in the kernel: > > $ git grep ^builtin_platform_driver_probe | wc -l > > 20 > > > > So it might be easier to just fix them to not use > > builtin_platform_driver_probe(). > > > > Michael, > > > > Any chance you'd be willing to help me by converting all these to > > builtin_platform_driver() and delete builtin_platform_driver_probe()? > > If it just moving the probe function to the _driver struct and > remove the __init annotations. I could look into that. Yup. That's pretty much it AFAICT. builtin_platform_driver_probe() also makes sure the driver doesn't ask for async probe, etc. But I doubt anyone is actually setting async flags and still using builtin_platform_driver_probe(). -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7638C433E0 for ; Wed, 20 Jan 2021 19:49:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DEC02343E for ; Wed, 20 Jan 2021 19:49:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DEC02343E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FPgVFdabXLOQbWTHo34qYMvzaMqhpSPZGavhDW5omDU=; b=mLHWbD2UXEy4+gXgtziqtRxkb fLw4+sEFYrvZLCnS1KqEVzb2X/XA9BXFxEBuSJKKNhbGtmCP2AC5/pKu/EcFohGKWiDsPfLys/fGt xGIweXxVFmy/rKxxgIrzchQglirDLHmLw46Gys9+z2PfLY6SagoFJ51N/hGiciCHIyuspHJLyQneJ /cK8xuLbdU5Y5Hbdg1+KmHCSxmECY8Pwn7xCpr5v5EdLkHxIooZdAFFZQ0U3OSPfZYMgd0rt9cTkp /h0+mUx36ev3ACCZrGLYMfzO7l0WqGqpFH4p4xfU0MRmRfzKv93w5kqpmrXZ4l1ajqhidT4m30BFj bfDyFa0hg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2JSf-0000Z4-DD; Wed, 20 Jan 2021 19:48:13 +0000 Received: from mail-yb1-xb33.google.com ([2607:f8b0:4864:20::b33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2JSc-0000YW-Jm for linux-arm-kernel@lists.infradead.org; Wed, 20 Jan 2021 19:48:11 +0000 Received: by mail-yb1-xb33.google.com with SMTP id i141so13106170yba.0 for ; Wed, 20 Jan 2021 11:48:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z+VKdic9vQLplZ5dRDPFBsqTAKEx7zvAEih/IIGE3o4=; b=gqXXWU/DUfCRlZqg6VB4WrIPdIGgIy2FpoB64Tw6CtQ1jL1wrLFZqp3MrEbrMBYGiZ N4/i+WbY5NkRoGQ0TOQ8gSx1H/xButR/QyThA+B2Gz/O5XBV3DuftVSBSZBLeyg1OLU+ UOnY3ZnpvA9fS2hSivgKSdxrfkTqrNLOncrFUlwoHemuKABuY67DntKltT3SJx0D9dWo /9pBl19rfoJS1N1WX6MM6xVcEDMYzyaqXAJ7Q6wXNhN/hh/u8nnQojbYlYlOdnqtABHz lhAfatORzVUNAHTBDkjRB1KD+A8zB99tvQ/Y4CW0lF2FN6Oz8vdPn1HEE/kgKprBbKFe sZcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z+VKdic9vQLplZ5dRDPFBsqTAKEx7zvAEih/IIGE3o4=; b=ESjfdJsNopDOVnw7IXzBHyxdeFoH9cmmwsZPE166pLB3EfMatjd4iB/qthDpTltn/U 219MbpsCFciwbrtPDnyuUqZrN51fNR1O8v69xn2Y+UatGiHBQerx3QU65Y7bfaK6ol2I JQECKmYPaJnrkXYtDFeIZYiyFO4lW03FSOPstLBDoOT4L4brWPcmv+6gejmKeQrt2s9W zSZT7r3MIJMwa0sNerxAtCeE5pvSeW0gm9+QvTvWt332ZurqX0daeCze8mLUJSLive+d B98JvZ7ZfSWhgL025VDAHKJ5h5olqeT2wOTSO024zHnShPmazMkrATFzi3VnrWBHyjRo FLeg== X-Gm-Message-State: AOAM532OlVOFYkaVHi0ndrdsbHjOyMxrqDQnHZfcVFTYMlxOJOYxXnD3 mTPCj7h1b94FbgnjjLzR8DZn36h4C1g4Jj5E4OYfYw== X-Google-Smtp-Source: ABdhPJy6lnzImOgxZ62zFBVY/BNYqrbN/QRRos+AWvRoeObCVMQxkr4MeX9zWJIX5eWD7W+mqvC8d3XxTrbOt6hpwoA= X-Received: by 2002:a25:77d4:: with SMTP id s203mr17677961ybc.32.1611172088185; Wed, 20 Jan 2021 11:48:08 -0800 (PST) MIME-Version: 1.0 References: <20210120105246.23218-1-michael@walle.cc> In-Reply-To: From: Saravana Kannan Date: Wed, 20 Jan 2021 11:47:31 -0800 Message-ID: Subject: Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() To: Michael Walle X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_144811_050963_13C506F6 X-CRM114-Status: GOOD ( 22.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Roy Zang , PCI , LKML , Minghuan Lian , Mingkai Hu , Greg Kroah-Hartman , Bjorn Helgaas , linuxppc-dev , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 20, 2021 at 11:28 AM Michael Walle wrote: > > [RESEND, fat-fingered the buttons of my mail client and converted > all CCs to BCCs :(] > > Am 2021-01-20 20:02, schrieb Saravana Kannan: > > On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: > >> > >> On Wed, Jan 20, 2021 at 4:53 AM Michael Walle > >> wrote: > >> > > >> > fw_devlink will defer the probe until all suppliers are ready. We can't > >> > use builtin_platform_driver_probe() because it doesn't retry after probe > >> > deferral. Convert it to builtin_platform_driver(). > >> > >> If builtin_platform_driver_probe() doesn't work with fw_devlink, then > >> shouldn't it be fixed or removed? > > > > I was actually thinking about this too. The problem with fixing > > builtin_platform_driver_probe() to behave like > > builtin_platform_driver() is that these probe functions could be > > marked with __init. But there are also only 20 instances of > > builtin_platform_driver_probe() in the kernel: > > $ git grep ^builtin_platform_driver_probe | wc -l > > 20 > > > > So it might be easier to just fix them to not use > > builtin_platform_driver_probe(). > > > > Michael, > > > > Any chance you'd be willing to help me by converting all these to > > builtin_platform_driver() and delete builtin_platform_driver_probe()? > > If it just moving the probe function to the _driver struct and > remove the __init annotations. I could look into that. Yup. That's pretty much it AFAICT. builtin_platform_driver_probe() also makes sure the driver doesn't ask for async probe, etc. But I doubt anyone is actually setting async flags and still using builtin_platform_driver_probe(). -Saravana _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel