From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0433AC433E0 for ; Wed, 20 Jan 2021 17:17:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA6F723358 for ; Wed, 20 Jan 2021 17:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404157AbhATRR0 (ORCPT ); Wed, 20 Jan 2021 12:17:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404174AbhATRQ7 (ORCPT ); Wed, 20 Jan 2021 12:16:59 -0500 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08F6CC061757 for ; Wed, 20 Jan 2021 09:16:19 -0800 (PST) Received: by mail-yb1-xb2a.google.com with SMTP id x6so20178028ybr.1 for ; Wed, 20 Jan 2021 09:16:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b9wI5aOMK4QP7qEbl5k5jkAB+hpflm5UBU0G8oOa8LA=; b=bHQw89wbOV7Fyq9pJVIClifJ4R4XL+mAjZePqAM5wS6hckVNC8Gj1g5zDKKt2crNAb ZP0B5JPFtcowlxGooOulgculUU1EEoLo9TdPArv1F7VN9FD6sWiM4BBBc7NLN6MSUDIZ dPd8BuXJlNoZ7a3hIiXrfp2YY4gLoh/RMG4QlFl7HlenzNWXLFN4kQCMbglhkepu9i8Y GHZQ5He01i/kQQrbTRkI5/EBUWxeyEnsgs6r1vR6sgJlflH8Suj/FHuFnt2ZK7UTaJKo TdjskkEhZH83qZUxy1sCRbqhm7U+KL/fWL6LAtZs2bpJU/ViOyhmRQrwAfCF2kS86cWV /odg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b9wI5aOMK4QP7qEbl5k5jkAB+hpflm5UBU0G8oOa8LA=; b=q8tLe80QetOSE04hrvW0M63y0C7PclXgdUdcPgWL4asnSD9ktvSRSrcIa8ygCGeL3e 7Zm9vUTVHtgPKP5QwB6aPaensYaatd/U6k0RDOqXzCf15dY1E46m3K51Q2dnbDS8wMbh Mu72BEKXHXy6Jbv7baejerPwyvZPiOtQ2m4bir8WNuyTBlkwJgi5KE7bsQFsxGQINVRW cI0RX2FDpMEaLFaojpturgKLkQRRpfLA8e9jX8tvG66KUNQBjGrRo5fNjkbiUIM9V+p2 rtZ1tTIlSzBb+IXmuLSWSNHX/TTgK26AXKyCGEp4bvZa2S98kt99NNg8qp4qV3bv93Ew 65Dg== X-Gm-Message-State: AOAM5332A7SuD/Dy51zqE7SGU6od+dEljs5lRfm0wRzDALxSxh9zYFXF gVQUuS0im8CQb4iFn6j7N/VPYuN/xFHmxxsJBXq9HQ== X-Google-Smtp-Source: ABdhPJwi1CKgasHlPWQ/KwwGM6Bb7GEe0fwT8QqGkXr5UjjZ4xi0ClwNOMIzy1N4g0aOxnt8VzEuLM+Y07LqYB0YZRE= X-Received: by 2002:a25:288:: with SMTP id 130mr15326444ybc.412.1611162977999; Wed, 20 Jan 2021 09:16:17 -0800 (PST) MIME-Version: 1.0 References: <20201218210750.3455872-1-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Wed, 20 Jan 2021 09:15:42 -0800 Message-ID: Subject: Re: [PATCH] of: property: Add device link support for interrupts To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , Rob Herring , Frank Rowand , Marc Zyngier , Kevin Hilman , Android Kernel Team , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 6:28 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Wed, Jan 20, 2021 at 10:53 AM Geert Uytterhoeven > wrote: > > On Fri, Dec 18, 2020 at 10:11 PM Saravana Kannan wrote: > > > Add support for creating device links out of interrupts property. > > > > > > Cc: Marc Zyngier > > > Cc: Kevin Hilman > > > Signed-off-by: Saravana Kannan > > > > Thanks for your patch! > > > > This does not seem to add all links. I see links being created to the > > secondary interrupt controller (e61c0000 "renesas,irqc"), but not to > > the primary interrupt controller (GIC) > > > > Which is good, as the GIC driver is not a platform_driver, and thus > > creating links would break everything ;-) > > of_link_to_phandle() ignores device nodes where OF_POPULATED > is set, and of_irq_init() sets that flag. Hence the GIC is ignored. Geert, Yes, I know :) I wrote it that way for GIC and some of the early devices that can't use the driver core. And as Marc said in the other email, it looks like GIC is going to be stuck as a non-device for a while. But this patch and others that'll follow are all set up for allowing non-root interrupt controllers to be implemented as platform devices (or device). -Saravana