From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31041C83026 for ; Thu, 2 Sep 2021 17:01:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F26361041 for ; Thu, 2 Sep 2021 17:01:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346433AbhIBRCZ (ORCPT ); Thu, 2 Sep 2021 13:02:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346410AbhIBRCW (ORCPT ); Thu, 2 Sep 2021 13:02:22 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CA5AC061575 for ; Thu, 2 Sep 2021 10:01:21 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id v26so5128612ybd.9 for ; Thu, 02 Sep 2021 10:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PpysPmik57x5vnDmjTrZwtUlMx9bD37Da+iZfWbm5qg=; b=MjoPmyE65znm1D0n+HXu82MDj+gi8kUK0hXr1O6+Bjv/0XAG2S5ahgwzwBD+Cnu3oO mCweJVAtssAovQojoUmS6Ci++Uti7Ht6PYH1jWKKoI5eVjR67tdebUj2PCrXVlmfg8tM GyiQeXcN+v9qtEiprBzVjjzZ7yQjO3B3RB0RjTjVFZec+EtnhvmuxQV6HzPf1Ce4rVYk Gy9f0zlDrqqWd5K0smV29f3g4eEijuq462wK6TYG45R1D1Ize7UGrVUTJ2rR8JN5ILQ9 GYAjv/Mfjox9wtbxaEeHdHUz20MaTDkDSEcwV5fAbMdjTM64pRm6mNidTYDDG6UJo3t6 KbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PpysPmik57x5vnDmjTrZwtUlMx9bD37Da+iZfWbm5qg=; b=GCNaJHQfkpeR8OA5l03VknbEjK4Di3ziUxxEHWqFX87vCkhoPNR8rTTKhpDOJ4t5MI FXPWW0E3EE91xjGHGmRXrNvTiImYsrrQ0pXZALGTC+8pP+WCCC55mDYMmU8e3oS2g9fb ANAcC81DoYHJO6rjF7JZLk72t7Gt8Ca4sX1qcrUhV5Zmvl4/vDAB/C5MC5P2gS65qUO0 I0+IFnSCMUVLhlVsgPnCn12WkGSeRnGkDz6BaGGCu4CrWZ2gCTRGE+vuyVd5UXgF54Nl NNnf94OqyYnk2vw3Xes1NNZAIgqqVXEKwoy8JopIIDuuIg1MOWDrPLKbAnyOi01SAI// y9TA== X-Gm-Message-State: AOAM533LfXfd5Hvla/VQ+6yuP52PVyx4n9/ani9lRRAdfFdCsFj6W4Ao v2ESpdyqpTll+BNY3j4GbjG8/qKizCxZLo/tzE5Yfg== X-Google-Smtp-Source: ABdhPJyt8C3Ru+98FAhkc1VPkGvpkiogD6mUaNAdSCekNWLAzApbq4a2RvTAF9sHto1glvhd7SJ6dQ+62d8ugoff0lE= X-Received: by 2002:a25:6746:: with SMTP id b67mr6335807ybc.96.1630602080287; Thu, 02 Sep 2021 10:01:20 -0700 (PDT) MIME-Version: 1.0 References: <20210902134914.176986-1-narmstrong@baylibre.com> <20210902134914.176986-2-narmstrong@baylibre.com> In-Reply-To: <20210902134914.176986-2-narmstrong@baylibre.com> From: Saravana Kannan Date: Thu, 2 Sep 2021 10:00:44 -0700 Message-ID: Subject: Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module To: Neil Armstrong Cc: maz@kernel.org, tglx@linutronix.de, jbrunet@baylibre.com, khilman@baylibre.com, lee.jones@linaro.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 2, 2021 at 6:49 AM Neil Armstrong wrote: > > In order to reduce the kernel Image size on multi-platform distributions, > make it possible to build the Amlogic GPIO IRQ controller as a module > by switching it to a platform driver. > > Signed-off-by: Neil Armstrong > --- > drivers/irqchip/Kconfig | 5 +++-- > drivers/irqchip/irq-meson-gpio.c | 15 +++++++++------ > 2 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index 4d5924e9f766..2aba485025fd 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -400,8 +400,9 @@ config IRQ_UNIPHIER_AIDET > Support for the UniPhier AIDET (ARM Interrupt Detector). > > config MESON_IRQ_GPIO > - bool "Meson GPIO Interrupt Multiplexer" > - depends on ARCH_MESON > + tristate "Meson GPIO Interrupt Multiplexer" > + depends on ARCH_MESON || COMPILE_TEST > + default ARCH_MESON > select IRQ_DOMAIN_HIERARCHY > help > Support Meson SoC Family GPIO Interrupt Multiplexer > diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c > index e50676ce2ec8..d90ff0b92480 100644 > --- a/drivers/irqchip/irq-meson-gpio.c > +++ b/drivers/irqchip/irq-meson-gpio.c > @@ -436,8 +436,7 @@ static const struct irq_domain_ops meson_gpio_irq_domain_ops = { > .translate = meson_gpio_irq_domain_translate, > }; > > -static int __init meson_gpio_irq_parse_dt(struct device_node *node, > - struct meson_gpio_irq_controller *ctl) > +static int meson_gpio_irq_parse_dt(struct device_node *node, struct meson_gpio_irq_controller *ctl) > { > const struct of_device_id *match; > int ret; > @@ -463,8 +462,7 @@ static int __init meson_gpio_irq_parse_dt(struct device_node *node, > return 0; > } > > -static int __init meson_gpio_irq_of_init(struct device_node *node, > - struct device_node *parent) > +static int meson_gpio_irq_of_init(struct device_node *node, struct device_node *parent) > { > struct irq_domain *domain, *parent_domain; > struct meson_gpio_irq_controller *ctl; > @@ -521,5 +519,10 @@ static int __init meson_gpio_irq_of_init(struct device_node *node, > return ret; > } > > -IRQCHIP_DECLARE(meson_gpio_intc, "amlogic,meson-gpio-intc", > - meson_gpio_irq_of_init); > +IRQCHIP_PLATFORM_DRIVER_BEGIN(meson_gpio_intc) > +IRQCHIP_MATCH("amlogic,meson-gpio-intc", meson_gpio_irq_of_init) > +IRQCHIP_PLATFORM_DRIVER_END(meson_gpio_intc) > + > +MODULE_AUTHOR("Jerome Brunet "); > +MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("platform:meson-gpio-intc"); > -- Acked-by: Saravana Kannan Marc, my mdio-mux patches have landed. -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87352C83026 for ; Thu, 2 Sep 2021 17:01:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4889C61041 for ; Thu, 2 Sep 2021 17:01:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4889C61041 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eCM9VsWQP7FbdCjaYVxpa8LeoQojvEv8vN89V8AfG+Q=; b=MWY49VuzzC9xwO OunwHR3+CeQwTNM/WZMGxunhjUbb03t0eZvniOB16qAoNr2cXHrpcvMgRN40rU61Fq6jsnjlOaTP6 8L0Uec1PnghnfS/p9t0p5xm3VRQ7z1y8x91fegkp5QJasbjR/f7JrGwxteT8tdQGd7WFbY66Jjjy7 5/4O54lF/oR2coeZFR3/H8zs+EP2Xx8Vz7ugrMJrMR/v8qfbLUMXoxABRFXt4RqyoS/HcoUqg+/0c 4+bwa+2/XOa3uemmlx3fxozih64zTvYuTI3GyGbSsR1lgbCvy67d9g5mNLW7ErnwmdqjCCC2FH2+1 yGrhUmPCPXRgIBzulK4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLq5m-00A4eW-K3; Thu, 02 Sep 2021 17:01:34 +0000 Received: from mail-yb1-xb29.google.com ([2607:f8b0:4864:20::b29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLq5Z-00A4c8-Gh for linux-amlogic@lists.infradead.org; Thu, 02 Sep 2021 17:01:22 +0000 Received: by mail-yb1-xb29.google.com with SMTP id v26so5128607ybd.9 for ; Thu, 02 Sep 2021 10:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PpysPmik57x5vnDmjTrZwtUlMx9bD37Da+iZfWbm5qg=; b=MjoPmyE65znm1D0n+HXu82MDj+gi8kUK0hXr1O6+Bjv/0XAG2S5ahgwzwBD+Cnu3oO mCweJVAtssAovQojoUmS6Ci++Uti7Ht6PYH1jWKKoI5eVjR67tdebUj2PCrXVlmfg8tM GyiQeXcN+v9qtEiprBzVjjzZ7yQjO3B3RB0RjTjVFZec+EtnhvmuxQV6HzPf1Ce4rVYk Gy9f0zlDrqqWd5K0smV29f3g4eEijuq462wK6TYG45R1D1Ize7UGrVUTJ2rR8JN5ILQ9 GYAjv/Mfjox9wtbxaEeHdHUz20MaTDkDSEcwV5fAbMdjTM64pRm6mNidTYDDG6UJo3t6 KbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PpysPmik57x5vnDmjTrZwtUlMx9bD37Da+iZfWbm5qg=; b=NoeWtwLd+EmQ4KMod1wYjRly6BSeijHSQ3arBou3F/7f76my7YKgva85e+3SEfqxC1 zLR3IghaObSNB2fZDBqFTf+Z78FSw6/uWY+so/JsezTEJqwh5wXQBkSWQFY1OumoPND/ VyrfOVza4rYVW/3CusseJQg3+G8dG2JZ+F/g0zh8vdem2q6lDXQmiULfZXPQK69DDml0 SBSwzLgYsrguq8eTLo9tG3V9UyIZZ1p4zxih370JSJbLTo6GTuGVKFpoIC5uOs16OnM3 JBaGNDtT22KxJwLTNnRfAziVZX0GvdwcCO/LB86iCBZYBLNDJcZrqLGs07PsEgHaO+k4 //fA== X-Gm-Message-State: AOAM530K9aXfqrIbp3MP6wmfIOakOXRzJ/MQVhOREeJmLdaV2Aau/H9r hADG++AVPjVzOeJG3z/AtV+eDkc6hmB+fzE+m1Je3Q== X-Google-Smtp-Source: ABdhPJyt8C3Ru+98FAhkc1VPkGvpkiogD6mUaNAdSCekNWLAzApbq4a2RvTAF9sHto1glvhd7SJ6dQ+62d8ugoff0lE= X-Received: by 2002:a25:6746:: with SMTP id b67mr6335807ybc.96.1630602080287; Thu, 02 Sep 2021 10:01:20 -0700 (PDT) MIME-Version: 1.0 References: <20210902134914.176986-1-narmstrong@baylibre.com> <20210902134914.176986-2-narmstrong@baylibre.com> In-Reply-To: <20210902134914.176986-2-narmstrong@baylibre.com> From: Saravana Kannan Date: Thu, 2 Sep 2021 10:00:44 -0700 Message-ID: Subject: Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module To: Neil Armstrong Cc: maz@kernel.org, tglx@linutronix.de, jbrunet@baylibre.com, khilman@baylibre.com, lee.jones@linaro.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210902_100121_586056_02721C8E X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Thu, Sep 2, 2021 at 6:49 AM Neil Armstrong wrote: > > In order to reduce the kernel Image size on multi-platform distributions, > make it possible to build the Amlogic GPIO IRQ controller as a module > by switching it to a platform driver. > > Signed-off-by: Neil Armstrong > --- > drivers/irqchip/Kconfig | 5 +++-- > drivers/irqchip/irq-meson-gpio.c | 15 +++++++++------ > 2 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index 4d5924e9f766..2aba485025fd 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -400,8 +400,9 @@ config IRQ_UNIPHIER_AIDET > Support for the UniPhier AIDET (ARM Interrupt Detector). > > config MESON_IRQ_GPIO > - bool "Meson GPIO Interrupt Multiplexer" > - depends on ARCH_MESON > + tristate "Meson GPIO Interrupt Multiplexer" > + depends on ARCH_MESON || COMPILE_TEST > + default ARCH_MESON > select IRQ_DOMAIN_HIERARCHY > help > Support Meson SoC Family GPIO Interrupt Multiplexer > diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c > index e50676ce2ec8..d90ff0b92480 100644 > --- a/drivers/irqchip/irq-meson-gpio.c > +++ b/drivers/irqchip/irq-meson-gpio.c > @@ -436,8 +436,7 @@ static const struct irq_domain_ops meson_gpio_irq_domain_ops = { > .translate = meson_gpio_irq_domain_translate, > }; > > -static int __init meson_gpio_irq_parse_dt(struct device_node *node, > - struct meson_gpio_irq_controller *ctl) > +static int meson_gpio_irq_parse_dt(struct device_node *node, struct meson_gpio_irq_controller *ctl) > { > const struct of_device_id *match; > int ret; > @@ -463,8 +462,7 @@ static int __init meson_gpio_irq_parse_dt(struct device_node *node, > return 0; > } > > -static int __init meson_gpio_irq_of_init(struct device_node *node, > - struct device_node *parent) > +static int meson_gpio_irq_of_init(struct device_node *node, struct device_node *parent) > { > struct irq_domain *domain, *parent_domain; > struct meson_gpio_irq_controller *ctl; > @@ -521,5 +519,10 @@ static int __init meson_gpio_irq_of_init(struct device_node *node, > return ret; > } > > -IRQCHIP_DECLARE(meson_gpio_intc, "amlogic,meson-gpio-intc", > - meson_gpio_irq_of_init); > +IRQCHIP_PLATFORM_DRIVER_BEGIN(meson_gpio_intc) > +IRQCHIP_MATCH("amlogic,meson-gpio-intc", meson_gpio_irq_of_init) > +IRQCHIP_PLATFORM_DRIVER_END(meson_gpio_intc) > + > +MODULE_AUTHOR("Jerome Brunet "); > +MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("platform:meson-gpio-intc"); > -- Acked-by: Saravana Kannan Marc, my mdio-mux patches have landed. -Saravana _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C17C83028 for ; Thu, 2 Sep 2021 17:03:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97EDA61051 for ; Thu, 2 Sep 2021 17:03:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 97EDA61051 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u0dk3PGpojKSjiHdzU8v9zmxQ8Jg9+it4V1nFER+E7E=; b=ALJ1b85CvO5hn3 puHty7BRfSAa6v1tFkIzo2/DXMDS0rlD5YHn91k9hYphhgAjuLZVQ+M5O3ks1UtBNf8TQP6oNJUAM ECRyFxUidsOwZYLGBJk3O0yEXpSXTrFcb/VJEiHiTtZ3g8k5Dbf/QkpuC6OnAXTcQO6ocFKFQJWAC o0fP4NkOMFLwIDQs8emnVnu0HDYWYhp7f4xmrkulv5tVZD2oYcjaGHGilQBKXwpaY7N7jNSTO9ChL gfjxlIGqomV7JCBkx3JSCX29AN3AD8lzuiMdKrOKneQeHnYRBL4hxj9OO/DBMSIl8PVvL8YCujSMh PmA4kciJU4iJijvjC1cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLq5d-00A4dC-4X; Thu, 02 Sep 2021 17:01:25 +0000 Received: from mail-yb1-xb2b.google.com ([2607:f8b0:4864:20::b2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLq5Z-00A4c7-FD for linux-arm-kernel@lists.infradead.org; Thu, 02 Sep 2021 17:01:22 +0000 Received: by mail-yb1-xb2b.google.com with SMTP id z5so5175788ybj.2 for ; Thu, 02 Sep 2021 10:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PpysPmik57x5vnDmjTrZwtUlMx9bD37Da+iZfWbm5qg=; b=MjoPmyE65znm1D0n+HXu82MDj+gi8kUK0hXr1O6+Bjv/0XAG2S5ahgwzwBD+Cnu3oO mCweJVAtssAovQojoUmS6Ci++Uti7Ht6PYH1jWKKoI5eVjR67tdebUj2PCrXVlmfg8tM GyiQeXcN+v9qtEiprBzVjjzZ7yQjO3B3RB0RjTjVFZec+EtnhvmuxQV6HzPf1Ce4rVYk Gy9f0zlDrqqWd5K0smV29f3g4eEijuq462wK6TYG45R1D1Ize7UGrVUTJ2rR8JN5ILQ9 GYAjv/Mfjox9wtbxaEeHdHUz20MaTDkDSEcwV5fAbMdjTM64pRm6mNidTYDDG6UJo3t6 KbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PpysPmik57x5vnDmjTrZwtUlMx9bD37Da+iZfWbm5qg=; b=NuCJYUsPX82Ap32r0tjTR4aL8FdSZCilNg8LYSDFWpCCAAJ2U0G6cWWTB4M4+1naGF bYK2thGt0t2JcqbrmkVSnZl/pb6VpgytrBXUqDHiyX//1yYYRtpKN7vfhIV58DtQ5HeR I3812Gd0c+g7w5CjZtjtPR+eYcUaYlmfh4ByqwcqiCnSx0dgXDWkN/5sABRl5DRHbGQ3 PcqHCdK7FNt5ny8BFPYqOwEED5IM+Jn8sUtkeuMYU8RVIMNg0lhAdzvWvVIONghEwOvg sjU1oMerKofjWU6Giio0qMZeFPuXvCtXpn5B6U+p/tw/vASmux9YwgtYFE2VaQlCaDiI bRvg== X-Gm-Message-State: AOAM530ucDNvRyggtNneycpH0Npt3o2pv2Vq3Ewz8KlT2MsXm0509pgn o+VVy27iIQvXwrdplPTO8bjBNPbgBPd95W9MEGEH1Q== X-Google-Smtp-Source: ABdhPJyt8C3Ru+98FAhkc1VPkGvpkiogD6mUaNAdSCekNWLAzApbq4a2RvTAF9sHto1glvhd7SJ6dQ+62d8ugoff0lE= X-Received: by 2002:a25:6746:: with SMTP id b67mr6335807ybc.96.1630602080287; Thu, 02 Sep 2021 10:01:20 -0700 (PDT) MIME-Version: 1.0 References: <20210902134914.176986-1-narmstrong@baylibre.com> <20210902134914.176986-2-narmstrong@baylibre.com> In-Reply-To: <20210902134914.176986-2-narmstrong@baylibre.com> From: Saravana Kannan Date: Thu, 2 Sep 2021 10:00:44 -0700 Message-ID: Subject: Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module To: Neil Armstrong Cc: maz@kernel.org, tglx@linutronix.de, jbrunet@baylibre.com, khilman@baylibre.com, lee.jones@linaro.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210902_100121_573939_881CAB7C X-CRM114-Status: GOOD ( 21.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 2, 2021 at 6:49 AM Neil Armstrong wrote: > > In order to reduce the kernel Image size on multi-platform distributions, > make it possible to build the Amlogic GPIO IRQ controller as a module > by switching it to a platform driver. > > Signed-off-by: Neil Armstrong > --- > drivers/irqchip/Kconfig | 5 +++-- > drivers/irqchip/irq-meson-gpio.c | 15 +++++++++------ > 2 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index 4d5924e9f766..2aba485025fd 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -400,8 +400,9 @@ config IRQ_UNIPHIER_AIDET > Support for the UniPhier AIDET (ARM Interrupt Detector). > > config MESON_IRQ_GPIO > - bool "Meson GPIO Interrupt Multiplexer" > - depends on ARCH_MESON > + tristate "Meson GPIO Interrupt Multiplexer" > + depends on ARCH_MESON || COMPILE_TEST > + default ARCH_MESON > select IRQ_DOMAIN_HIERARCHY > help > Support Meson SoC Family GPIO Interrupt Multiplexer > diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c > index e50676ce2ec8..d90ff0b92480 100644 > --- a/drivers/irqchip/irq-meson-gpio.c > +++ b/drivers/irqchip/irq-meson-gpio.c > @@ -436,8 +436,7 @@ static const struct irq_domain_ops meson_gpio_irq_domain_ops = { > .translate = meson_gpio_irq_domain_translate, > }; > > -static int __init meson_gpio_irq_parse_dt(struct device_node *node, > - struct meson_gpio_irq_controller *ctl) > +static int meson_gpio_irq_parse_dt(struct device_node *node, struct meson_gpio_irq_controller *ctl) > { > const struct of_device_id *match; > int ret; > @@ -463,8 +462,7 @@ static int __init meson_gpio_irq_parse_dt(struct device_node *node, > return 0; > } > > -static int __init meson_gpio_irq_of_init(struct device_node *node, > - struct device_node *parent) > +static int meson_gpio_irq_of_init(struct device_node *node, struct device_node *parent) > { > struct irq_domain *domain, *parent_domain; > struct meson_gpio_irq_controller *ctl; > @@ -521,5 +519,10 @@ static int __init meson_gpio_irq_of_init(struct device_node *node, > return ret; > } > > -IRQCHIP_DECLARE(meson_gpio_intc, "amlogic,meson-gpio-intc", > - meson_gpio_irq_of_init); > +IRQCHIP_PLATFORM_DRIVER_BEGIN(meson_gpio_intc) > +IRQCHIP_MATCH("amlogic,meson-gpio-intc", meson_gpio_irq_of_init) > +IRQCHIP_PLATFORM_DRIVER_END(meson_gpio_intc) > + > +MODULE_AUTHOR("Jerome Brunet "); > +MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("platform:meson-gpio-intc"); > -- Acked-by: Saravana Kannan Marc, my mdio-mux patches have landed. -Saravana _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel